From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC6F8A04FD; Tue, 8 Nov 2022 07:37:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF7D4400D7; Tue, 8 Nov 2022 07:37:25 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 8AF694003C; Tue, 8 Nov 2022 07:37:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667889444; x=1699425444; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7o0RPzDfZR5c2tzTj12bpyFIOdshhjfoGZ2v0sLJ22E=; b=ehf3DK5MyRq6dg0Db2X+pOecKrTt+EfESU3MBbSQwePIxvd2SuPIZNOa Zxr2Ls/R6ksMXTtS8tTpS7kJ9LFYVrslkcHL94eCWIr8u/jR79nY9RejJ to4vucoW/5aAGmKdh7ytM/W3+7TmOraMvluRcrhsoQCPV/IL36dUEN78r Gmx+/r33Do81jBF4ca5IJGHS/QXIAvBi61mRnelHk+ZPCzCSSSJ7dLd9t Vd5Hl3DH1QV8Qp1/oS8x9Ptd4jTUSWd7J0MqYqYpXJ3iqNSu+c99QxUS2 LN4K9PdHwrqeBHl6Y/l6O8/5Oqrgns8WWYhqE3/MnjSxWugX8UReI7lBC A==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="290338753" X-IronPort-AV: E=Sophos;i="5.96,147,1665471600"; d="scan'208";a="290338753" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 22:37:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="636221688" X-IronPort-AV: E=Sophos;i="5.96,147,1665471600"; d="scan'208";a="636221688" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 07 Nov 2022 22:37:23 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 22:37:22 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 7 Nov 2022 22:37:22 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 7 Nov 2022 22:37:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IFoYs0i5Zq9IoSOiqD3dC0phxe3wCR5YBBD/iwPZvMKklFKABMV2dJeRHTI5xKuzqEiamFm3e/wO94W5MQJ2ERpr1mlNFcR3IUtIOYSTgl6moNk0Gea1rGs2J45R+OrXKwXIm8GIjAZnfYOUvBguRYGRntVK2+CKazeCfmv4AwFQ0aFopYBIv6eptLBtyt01Ka/3JUzwVDkfZxl0yLdog9PKWh5/ov3LfvauCaiS5QsYc/CuhOwacaAeCoPxQXox/Rj48T8MWC3Y64GNK52Yy7iYrAZIRM/veq+WmTFIXq3fjLRMnMTK6kNUw7iWMluLprWzPRn0JsEBRMiy22+aig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ft1Le6VMPmP8YgWWzZK3i1sozwFxOimhNksqbd1Zm9E=; b=MM1LH1ew2nvZU7xiQJHTDablsuQZpYeXApeHLj+sG1HXRbVUoiU/1XPBQ67Zt6DXcvXQuWiuc2TqG7XEgjWyO+JmqmJenlpEX7umlbuB7Z1pbl9JWr/A+PPjNH9Vt9Z/AJVW7rKY6n6zSAD9Zzls2Wtrq0Zw1YkxLGb1gZYmIs2MZOAlotbEOyOv3vkvOLHv1uAq7b2eajsJxRPXFkSaCnRkrQPjWJlkgXB35zk1mZZjcPaWiziAV7obaxiMyEJYqW+j6cjbcuvo0wigVZJdxz9GDh7+88wunHB5a0PnuKWnPghTa+O8MzF371M04BgBZGlagvoeoF8KPOaVnGHrRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR1101MB2107.namprd11.prod.outlook.com (2603:10b6:4:5a::19) by CY8PR11MB6913.namprd11.prod.outlook.com (2603:10b6:930:5b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Tue, 8 Nov 2022 06:37:20 +0000 Received: from DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::b961:c069:9d46:cf45]) by DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::b961:c069:9d46:cf45%9]) with mapi id 15.20.5791.026; Tue, 8 Nov 2022 06:37:20 +0000 From: "Zhou, YidingX" To: "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" Subject: RE: [PATCH] net/ice/base: fix duplicate flow rules Thread-Topic: [PATCH] net/ice/base: fix duplicate flow rules Thread-Index: AQHY3suJz98KTXSHg0adh38n4KyJ+640uheg Date: Tue, 8 Nov 2022 06:37:20 +0000 Message-ID: References: <20220919060654.1092715-1-yidingx.zhou@intel.com> <20221013062113.96088-1-yidingx.zhou@intel.com> In-Reply-To: <20221013062113.96088-1-yidingx.zhou@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR1101MB2107:EE_|CY8PR11MB6913:EE_ x-ms-office365-filtering-correlation-id: b0015d65-aef6-4675-2884-08dac153b00b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KUbuvGftgsvhythxd0F7VxCmMvgAhnzG40LGxcLtaBhQvViil5Uf8JNpC+yw3P6c90g9Btgk/DmGSl9DKnLid7u9JI5KJr0T/xqQ0aUXYpfLb95T8evD904qXCQLA6A8mMrS2H/gX7Mm3tCbB28Ycf0pXUHvdTQinfGySVJtk/9xHxMbZshTNWmRCPOvxmQAcIVgAs9cC21i3T3LgPNWYEcPnD6/SeMTia/KkNzum0lyaIUFEe1ht4CZMz5B5TTIepoo2m1PLJcsVWWf+kEpn7yjIYf3P98IXXUcG8oDelHIdy6igMRAHbQcvGNCtnYiJOBL07YxVl6Lwt+UWC4fCrq7W6cK38Ej8GrT9ySkrWXVIA8H1hSdsaC05pjLUAT/yR1HnrfPvdBBELCIP4zq8ok57qiVkagSLv+Tsoth2BTfriAqjljx3G9sCSCPC92hvRjP2nt8onjA1snCbdqi65FJtZQmsZ25fg2UHLUIUc1ZEXJU2X7sk3/twrputCrP4V0rqQOmdxATozEkR/j14XuHlYz1BxtyL29IXR5QgDjWFrmm9c2YJZ65tGIw3UVeXiNBlQLbxpAn0Y0NOr/c+JpS4H7Lwu6pVu/9tTVpsR06PlpMdYJb4/HCypjQ9vIDFKUyRU3gTZIZMfIGbkuKd5rxaBim1BjCPZREiVFdyCyXSbXLWGCSNgiWVwVvsM1nHxgn+W8SRnnstv/ukcfXBVpdrcK85ItehHvp3xVMqYAegvoPxorGqoZ1g/kAnGxPdgbWfY2jOMIz7IWzHIRg6g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2107.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(396003)(136003)(346002)(366004)(376002)(451199015)(316002)(83380400001)(53546011)(7696005)(6506007)(8936002)(52536014)(33656002)(66446008)(186003)(5660300002)(2906002)(55016003)(66946007)(450100002)(9686003)(26005)(41300700001)(4326008)(8676002)(66476007)(76116006)(64756008)(38070700005)(66556008)(71200400001)(478600001)(82960400001)(110136005)(6636002)(38100700002)(86362001)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+nRvUqhR9iMaIiUD2fgrbllGxw0UOnFTU3JRrOq64V8IkwjCIu0pa2iRKGe/?= =?us-ascii?Q?Gcq4JLOZWYBySFIW0sNmsE2BuNxGyg83O01N8VzYuE7hBfnG3X4cMbt5/V5w?= =?us-ascii?Q?FbxE8yNEFav5/FoAhtGMvFBirMQC8kfPI9pmXnsJnxuDfohQ4s1aeusdI2hm?= =?us-ascii?Q?O6zSuF4J7o5at8pak/yieqK8DixGdiacmJZ0N77CiVm0ssVynbbUnzhWKiIz?= =?us-ascii?Q?Iwd9D15UyUwEE2eiySbFr0yi5mJtvwEjD0vh4ZEEhtZRj/Qb4lR67hezVoxS?= =?us-ascii?Q?17N7m0Ahmip5vc8vOFu5l4zWwN529zRBHy6cr0m8sEm/4gyBRwW/qve4VxIq?= =?us-ascii?Q?cutyQUb13zf1wLgu+Zx9RF1OcQvc0c4OZUapSv0j1lwTWzLMoIwVceE1FJj1?= =?us-ascii?Q?U9Cj2J0CpreStmfAzCVEeYS5VqdhBYgmj63iR+vS2WwpYv3DWv9ECz7lRcgA?= =?us-ascii?Q?MrGzGRwooSY0frM8SBZTl7v2BXvmE+wiPXBSqO2hQLp+Km/PawBGcHdfDbGz?= =?us-ascii?Q?Aprb1brAT+Koyd2x9+VHIOANt4ZuyykWevwW76h1QtM1YIQZcnlDih7rWfyY?= =?us-ascii?Q?2Wl3/Qj+BEV8DZI3k/4ml5JCZI7ssc1ehxNCqCjuNMEmUrKcULP0q8wWlUyc?= =?us-ascii?Q?H/UcQYoe0yg6J+Bz2r7HHrIegLjVTYLDH5xEl0SzC1f/7b+TLUawCNx/hr1T?= =?us-ascii?Q?0mNmESjpXTFQqbR6K0m1ybUX3uP0XIocH178CJOlsvH2Dcq5aWf3hoO3rRtt?= =?us-ascii?Q?IuorVp/Nh8jC9lwJa1Q14HkFyU8A68Z6d3OgRqmUG6hDken/CDtV65yUKeu8?= =?us-ascii?Q?+nFLbV28hO3mttlPc6HL3njF12a9EvHS7XfpAq5WDQdNrAxIpc65gyfBJYxy?= =?us-ascii?Q?3/Ddw7rvclH6Fp69K+ORmrL2nOv/VzekPSTjBRl5rdXEjs6zQitB0ck5KhpD?= =?us-ascii?Q?xbDWuF+Ee64MVWXYKuHK8BAzFcviurvNHVIKB5KKu0w7OEZQHKU6I5WtdJhZ?= =?us-ascii?Q?HCNHKB3WqusqpppOLN8bwXfek2MUxgEuRdU/CvKVW5eWOA2/Z1RTnHvccSnH?= =?us-ascii?Q?PvyeZT9e9DtKeW9zQF0JM8nVUwth0ep3GKN2WNGgdX2a1xwcW+nlKQZbMuBY?= =?us-ascii?Q?mmXEMMWz7N4qbHCXAj3zxsQp3mqGxETvXPclNmVaKroDT9ArV8yKmCn+6o8Y?= =?us-ascii?Q?omQ5tw5W3CAK2P8bP1DipQdT8+arQR/SFeaHcR277qiUVWSvi69NYubTYIwf?= =?us-ascii?Q?hcI2FZDDMy9bEi0y6/RybheA9N2PTrxWls/BrUPRt4W9ln00llhMpzel+6j9?= =?us-ascii?Q?Yp0K6hjwESoF9/c1OkJWWuZfCKbIIEoQoAq0tTc3FbBM/mORG7Y6NBisB+te?= =?us-ascii?Q?TbyUEZaLv4kPW8XPpz6SW/grucK4ycE5Hn5SmU5N2LS02/YKDQHrkxSnnISY?= =?us-ascii?Q?u2s6J24eWQYTgtoWZ8tfBGEwW7eeiLFYY7jR8fz77G8ZnyJH1XuzTh48r0Xf?= =?us-ascii?Q?7npTm9W2B2tJ0os6RSZTctjlvTw7Im2O9ytOGfWwfiWoQssgzsZb7zTlTquy?= =?us-ascii?Q?opj8SeLI+09VVEIBmtC2UknLXSZswtX03TWUWJeQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0015d65-aef6-4675-2884-08dac153b00b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 06:37:20.5689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fQU5vcrLdCQuclfAHkh0fR0H/P0mwmS783xROVfpx+dOMwZu+hRBcFWSgMx2ZFYuyoVtTHQNk7rapzDYnTZ57A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6913 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Qi This patch has been merged to kernel driver. Should it be merged to dpdk now?=20 > -----Original Message----- > From: Zhou, YidingX > Sent: Thursday, October 13, 2022 2:21 PM > To: dev@dpdk.org > Cc: Zhou, YidingX ; stable@dpdk.org > Subject: [PATCH] net/ice/base: fix duplicate flow rules >=20 > When a vsi that already exists in the created vsi_list subscribes to the = same > filter again, the return value ICE_SUCCESS results in duplicate flow rule= s to be > stored, which will cause 'flush' and 'destroy' errors. >=20 > Fixes: fed0c5ca5f19 ("net/ice/base: support programming a new switch reci= pe") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yiding Zhou > --- > drivers/net/ice/base/ice_switch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/base/ice_switch.c > b/drivers/net/ice/base/ice_switch.c > index 4b115ce660..a2581f404d 100644 > --- a/drivers/net/ice/base/ice_switch.c > +++ b/drivers/net/ice/base/ice_switch.c > @@ -8786,7 +8786,7 @@ ice_adv_add_update_vsi_list(struct ice_hw *hw, >=20 > /* A rule already exists with the new VSI being added */ > if (ice_is_bit_set(m_entry->vsi_list_info->vsi_map, vsi_handle)) > - return ICE_SUCCESS; > + return ICE_ERR_ALREADY_EXISTS; >=20 > /* Update the previously created VSI list set with > * the new VSI ID passed in > -- > 2.34.1