From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3A5DA0544; Mon, 10 Oct 2022 04:02:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FFFE400D5; Mon, 10 Oct 2022 04:02:39 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 672FC40042; Mon, 10 Oct 2022 04:02:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665367357; x=1696903357; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IWzRcPql3eRVeH3Rbnbp8cDtKoYK0NN0FK5V991R92s=; b=GZUTXNgAjbQniofuQGRu7nrn1F/dcrYb2QHO9s2PiB38VVKiSprnnlxJ tknn3bqGR5K99cLH9XSRGa0ZxXKgNQXXlyHhnd9a47DPUE4YX81RZOdEX NyWGD78jAaoFzGAfttXhDjPxQjH0NpHbZ1iMUmuVSf3p4tpPtUeKQUysP v2P+NAv4m0cLy4dJHjoBglqYJmd5RVOIA5camDmcdWSLcd4BSmHypChhv AmrQ+08Wq38su/pJwAZ+10gdNYH8iJUJP2eVfBF/B4+pDWhmibb+9b0Au OfdFYU8lIkkLq9KDaIO/M/LMRs7rbT88YIImxJzz+Ir3viOByARsk9fIJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="366084467" X-IronPort-AV: E=Sophos;i="5.95,172,1661842800"; d="scan'208";a="366084467" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2022 19:02:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="628115544" X-IronPort-AV: E=Sophos;i="5.95,172,1661842800"; d="scan'208";a="628115544" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 09 Oct 2022 19:02:34 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 9 Oct 2022 19:02:34 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 9 Oct 2022 19:02:34 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 9 Oct 2022 19:02:34 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 9 Oct 2022 19:02:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g4gLvjlIRXxMslBaAvfIEmOGk3ZZt89IxdbPb+GaaNUptJU/hpf3Mh7T+R9fpou37f8utiB61a4tNw8xudEqQj6hrsHyN3wstdTeJtQlndJ0LAvE17EGy4YgrkUPRB2raT59z3brWvoQFMIxNBPS9JK14z/WZs0W4/WVU5+oy8SXpjybchZ8nLOzDBmp9D/ZCGCti/kRdRHrhmVfIjgcGvwuTeLVOw2AF/z/5CvCDak0HtfMJeR44ia8744VZ0NuwvgTIEdtZYvskZJtGWG0TsvSrR7wzRtOfaNX/M1+6j7hFjl8enWkjuiFNTn4pCCX0+FpYUCWpXP4BQElnUTw9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xiqFJxuC2hOJmeFs8rGYFyDPAhFgttZVydR0UOMn63o=; b=UbmhUvhRJwMOEVmj1SiOhKDpQ9STFI+TNpBPg4N7oLfxPBGfxe30xY+jpwNdBLoI30mUUoJaOB5WWo127CeB+7NfvlO11GlCZNjdMcI0sbsweTaLPGI8PbIhj6wYa/AkV+NEBJITTNnX0+dfVt1UdW3Njv9hl6mVpuHcjj3xiiPMWF6ORjFAYMiJEjjTcO9SOVvcMMoY9sRpNbV7qZWRNfh377b0QotgORZTRlucq8a4z9iUFX3mLYrLcGkEFIuAuqKySEZ1slagZl2tNhQ8qO+uDHAY/QUx1Vv4Wq3Y4z1nx4yCGc5ipO0Dkyv+fQMjVsTM0Cbc+pOmdrCWC+KgIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR1101MB2107.namprd11.prod.outlook.com (2603:10b6:4:5a::19) by MN2PR11MB4726.namprd11.prod.outlook.com (2603:10b6:208:269::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct 2022 02:02:32 +0000 Received: from DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::d17c:b860:14e3:a27e]) by DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::d17c:b860:14e3:a27e%9]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 02:02:31 +0000 From: "Zhou, YidingX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" , "stable@dpdk.org" Subject: RE: [PATCH v3] net/iavf: fix error of virtchnl command Thread-Topic: [PATCH v3] net/iavf: fix error of virtchnl command Thread-Index: AQHY2vJwH+kq3R7ED0OAqATXDV2Yn64Fk9GAgAFMUAA= Date: Mon, 10 Oct 2022 02:02:31 +0000 Message-ID: References: <20220919060654.1092715-1-yidingx.zhou@intel.com> <20221008084852.397649-1-yidingx.zhou@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR1101MB2107:EE_|MN2PR11MB4726:EE_ x-ms-office365-filtering-correlation-id: 62a6c861-50a7-4ccc-fd8e-08daaa637dd6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ovG/RF3s3rRq4pYk+OezM99hV1N03RI68Qg5c4MK7amiqP61FMcG7gQPDIHkTKnxvIiaclvZs6lHuCL5jhAa8HJ2gpeH7isObTKBKMYoCjghJ6lz2T914aR4DKSz/6DTFcDTbNhzxELDhp8uYTNr2ly2KvmzNu6nrSUD662ABJbmHbc/CYS10pmsLqZqXFLUC+pu6qaT8o0aPsgm4vI4AsFXA0BYTh3qpL/NbQreVzgIWtTGCcJI/j3yLuZlTpHjdw3falBbnVtnE86qMJV6w6gDxuKjuEs97nVkeyxg2t7V/vy4TFKulxQaMmKA1E4+B5PT8e4CuIPU1/yZvyU814Ex1ip9iIUt+Aa4dGJEMfQ3S6L1b1ZSm1AM+QVMZv73RGqpKYw7721kvK/chsryD+v0eBbW0oE91qBrihfNf77O26QHQTbIVu95lzFHFr91PxUSB8pucXwrkfCK6Pfr8HZty6fWdUuM9BOEjqCMu6wCtseoiqpG9MQ4O93uzbRFWJd6thzV372WRhyTLIEbG971rro8N5MYDs4nbdx0PmduXQkEbVp5Hjk8iw6WLkMBDhhLdsBHpbcsVbMVInVMWE28+5gLzsOp/hWM2ssyHL9uvMooktvm1b3r6XoeEnERtT98RcfvsOY7IswyXfsmBQ4F3ksgbF6BDDZMzxpCkopzf+8Shy5tb8ubvbaP8mPV+SXfV7vRseFc6VSqPBaDa3Out7mBNY/lYOhDn4myZ7Lzwn3JunQfZtVFLfy6EIXvLuObOIAkG36HTqcrUCsplA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2107.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199015)(6506007)(55016003)(316002)(71200400001)(7696005)(38100700002)(478600001)(66556008)(66446008)(2906002)(66476007)(76116006)(4326008)(5660300002)(8676002)(450100002)(4744005)(66946007)(122000001)(86362001)(52536014)(64756008)(41300700001)(8936002)(82960400001)(38070700005)(33656002)(54906003)(110136005)(186003)(83380400001)(9686003)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G9TXrrU4E79ibbpuLePtFk3bviMrz6ChvR4Vr0WZYLh563cnlGG6TnAjeig+?= =?us-ascii?Q?OXUSDp93g8h5DYr+iaxCKYO2WOczvqgoUhge8EKNMe+JhM1/SYq1KjD7baGa?= =?us-ascii?Q?Z+Owv9BIjCOanFpgQGYQrnd16nlTouQc4HBjGozKmEUXO7loQECL15CfXfhv?= =?us-ascii?Q?NGGfWM93kXsJZcoOeHLgrs5zFhu/1gIXtc+E3QaqpyURBG4A2/wV3UnU3IGs?= =?us-ascii?Q?kaR8rb9ZDPFIWIMBMlvg4GQpZ5B83NBnlGQcuWV+UvfJoPVVjGfQZgbZfyUf?= =?us-ascii?Q?cfM+HCjWqKDAYtaGVIcpgq2G38gF9XZQpy8WknHsGKUtw5FrV54FMLJSpwVh?= =?us-ascii?Q?lUL42syscPBlkS7jGLoarQQfTASgWrEjUBxqbxV39BpeHEpKO9wgu1jR6DJG?= =?us-ascii?Q?qsDAIuwSzMBe30aRSLucN5T87WldmRR4EbAR3A5QX+db36EzkGP2T/I+aN7L?= =?us-ascii?Q?mwN+lIv0PEu2gvo25yBrni+C3DE4TAdjOXfymCvS1an1vLnF2G1fG4jZwEZV?= =?us-ascii?Q?PiE6kEEq9h/g9nPgY9MpvPz+osC7w/YYpNH7GVFumSw+JeU2qq9msC6+jcGw?= =?us-ascii?Q?qHp2EwM4BcXDjA51yvRx0DGGjSNHfeutZaY/hjZP5HBtxmeCt4DhGAFMJA18?= =?us-ascii?Q?pC739ewpy7jFmmMVglZ3sVlYzviYi63JiAvwCzBHg4zjunnINzCA1lxeXtSJ?= =?us-ascii?Q?k9vxFFN6nOjoGjxbGzjoDfT1rQOiWB0xEM0sqUjhuy5kCQjkUx90SSHP5tbs?= =?us-ascii?Q?korT/3K4X1jWs5hNnz5hGg7E61pMOFwD3gI9ORnIPHFFZtOz0OMoq6k+Qrdv?= =?us-ascii?Q?PoNbyGjAHpgmUZGIfTwTmEaNallSd3Ia/w3PJIpkSXWBt2/2tJAZU9j/vfAS?= =?us-ascii?Q?DNci/NAQ1PItGALcBVAVpO8O6Mb52mmUGEbx6zY5/hBkchWxSL6Uu17D1hLV?= =?us-ascii?Q?W3xq6Pp9R04GZ5dh36un0tvimTdHF9ZvI1SpUYGF46KFzWAIq5q/tDf2PDKi?= =?us-ascii?Q?fbx42w6lFvHCnhgElfUmoVHM5nLOqQe6Yh4sTSEJ9OGiLTB9iBGVCp7Z/PLJ?= =?us-ascii?Q?sENq8gCKUzSj0lXJtTc3HLSsjy2JZq5MYcJMWuoCG9zkP21VufkttVWWG+dR?= =?us-ascii?Q?VDdlgDyaoOzqPhoAbDEnoQ3cFbXauYWK2VRA8p8ZaG65PuH0rrjT65fRJBEr?= =?us-ascii?Q?Gp26sHf7ysm/a9RUc5qK/TBOT+mVjZEVYtI7/LjYRPdCZj9KHO7sFetKrPpg?= =?us-ascii?Q?40HtChZC8jSNCXYpNodhtUDUouYGM3Lh4yv2ntpw2Xh2aGffQCVpQgwvSzv3?= =?us-ascii?Q?c27HXuO0QIDbOk3GvSWq7wyl60TwwTSI+zTGtGcpZA6E8twDb2ZKhxTH4MeT?= =?us-ascii?Q?MUgI8N3wnb6FpTwiyTLT09l8wbZCNtaYMlFnOl60PfqdduFI0wM1XXPBjLX4?= =?us-ascii?Q?QFKOXw5XxacNqOLyKV4M6SfJiNAJVHkKKaC7ckqOxtqf8cFrWEf5mRTdSjez?= =?us-ascii?Q?ebnRH+LhhAh4SAZ8nfnnJks8mY5xQSu3z0a/XawM4ecTTvlgr+fbG1AXrGxc?= =?us-ascii?Q?i79LGHt3g5a9mdzITVJHvKgxVFKlX7xpIxe2m1dL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62a6c861-50a7-4ccc-fd8e-08daaa637dd6 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 02:02:31.5916 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2iWWxSdGjZxfg/bT3VHm67F1dHVNsnm+AfW79a2/m/wh6RBZvFmWD7h7QZWT8j2zFqPypt6+mRZESwsxfTUcZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4726 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > This commit starts a thread to handle all events to fix this issue. > > > > Fixes: 48de41ca11f0 ("net/avf: enable link status update") > > CC: stable@dpdk.org > > > > Signed-off-by: Yiding Zhou > > --- > > + > > static uint32_t > > iavf_convert_link_speed(enum virtchnl_link_speed virt_link_speed) { > > @@ - > > 293,7 +427,7 @@ iavf_handle_pf_event_msg(struct rte_eth_dev *dev, > > uint8_t *msg, > > vf->link_speed =3D iavf_convert_link_speed(speed); > > } > > iavf_dev_link_update(dev, 0); > > - rte_eth_dev_callback_process(dev, > > RTE_ETH_EVENT_INTR_LSC, NULL); > > + iavf_dev_event_post(dev, RTE_ETH_EVENT_INTR_LSC, NULL); >=20 > If we decide to raise an etherdev event from a separate thread, is it bet= ter to > do this for all events ? Since there are no bug reports for other events, I have not handle them in = event thread, I will follow your comments in v4. Thanks~