From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 682F9A0542; Tue, 6 Sep 2022 18:21:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03322400D6; Tue, 6 Sep 2022 18:21:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 0FCF940042; Tue, 6 Sep 2022 18:21:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662481316; x=1694017316; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FsZ7MgGZTm/4WP+NxF4G1qfU81znk2aLpA//C9jtfkI=; b=INRDNlkyHvczSwZ2mCz2rxvvXaaTuEQIwwSrnV3gWZndNt8k8X3ftJxt X+tbGRiIfHBXFMfmswgHvuuu3Dul6AVrnQcBcJ/olXW+TadkY6lGfgD03 serkIBIo07Hl07zNppEUXydI2fpU0IUxRm2C3bH7sQWUnyL+iehV1wCSV a+aJueIwfslnZjy8UmdCr5zaHY001w5Cb2LyG41U15w3eCqbHvkAAvQqe t4IXSXs3Q3KVgy3EwUABA+o1IsPuUL2kmh10zCTM1tVLQGi+iPBEePvkN GKIhdwCmd6XzCWrvYff9wWitng+MI8Dswrun1bp3vc24Xz30abzU0y715 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="382934493" X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208";a="382934493" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 09:21:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208";a="859311325" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 06 Sep 2022 09:21:47 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Sep 2022 09:21:46 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Sep 2022 09:21:46 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 6 Sep 2022 09:21:46 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 6 Sep 2022 09:21:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fZzavBy3q79uzqxt4FfuTUlFgFoTmG/90Tqw/1WnOqC5eKVJu4bvSTbcUx2TLRfVfpVocN+Wowayo2X+w306Dvg/xMLlyQU2lGAtOKCtG6mnZxolzv5E1PUuK8YXfgWuG4XJDnzpjoX07iqZiEtyaU6hRGk1S0OOWiAAQnZOvr7fHpy7AzivzzpkZ8aUe/um2crm7ViH/2bvNLx9Slty87qbUNaxoq2b4RWZiMyCssd3Oc6KAa2gy8t4KycHitlAYd9dghdy9byNwqwkVlH5BmsW7cj7KLlZD9ZUN9CAaPzeo44Z5wnszuit8BwOCCiSy2NGwu6+w0t5N63Onu4mOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cmc6wFO5qQU3coDxakhAapQUXk2oCUOcIS+KUafCYO8=; b=HG/Nj10t263J6zqve3fS9AXh0b/HPtvFnkeTX5y4sFWQOo4AdPN7IeQNXOgvy9/HhraW0RyakR/HEfrwdbIkQueM87O4bYCotWqI9XPJ6LaVddijS+pbeEsrVi2f6NNJdjscUnDYNBRFEi/zJM/Q67GAcvCqJeCMjiB+P8mawrpKTFXVsrRyHLh5pyqYaaNWhlMlIUURgNffAFG+3+fO6Agp+HckoIOANAWPzOX6KX2adluAIgmXPVMnBJMijAniWG2JRF+aKKbxXFnvGu7UlEYuLkEfA0OzzATpRGHeBkYeJnZdpsxsGXYoVjJp/QbPl/lYpqTQsVzSgQHD3FZGrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR1101MB2107.namprd11.prod.outlook.com (2603:10b6:4:5a::19) by SA2PR11MB4923.namprd11.prod.outlook.com (2603:10b6:806:fa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 16:21:44 +0000 Received: from DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::55cf:b131:b6c6:bea3]) by DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::55cf:b131:b6c6:bea3%6]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 16:21:44 +0000 From: "Zhou, YidingX" To: Stephen Hemminger CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Burakov, Anatoly" , "He, Xingguang" , "stable@dpdk.org" Subject: RE: [PATCH v2] net/pcap: fix timeout of stopping device Thread-Topic: [PATCH v2] net/pcap: fix timeout of stopping device Thread-Index: AQHYwcctL9bFJ76KRUKNwgs+pLJ9gK3SfnOAgAATE3A= Date: Tue, 6 Sep 2022 16:21:43 +0000 Message-ID: References: <20220825072041.10768-1-yidingx.zhou@intel.com> <20220906080511.46088-1-yidingx.zhou@intel.com> <20220906075737.2fb429a5@hermes.local> In-Reply-To: <20220906075737.2fb429a5@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38611599-ac18-441c-fdfe-08da9023e36f x-ms-traffictypediagnostic: SA2PR11MB4923:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cNlIURG5XLUGXtE+2hpUPPsHIU4Ljv7k36Wf0ENQQFfVbw1ayOWcwfoAPF095iNT+D94p8+pzjqU6+sF0GqxP4M4H8j6n2mAmyR8XoVnG2O3LNSvsiTYAM7QOo5cIyBRZQOmDAq6HHJp1DkheRJ6lxr0NSOeUy88u2HIwviqirDtMmc+Z5ktbAkwFA9yGYYa5sweBC9qvZ+ucI0EVuiswvjKt8RXYUgl7QaJ3Nwx0LJHohWbfC9XZM1N9B7AVLnPp/ASKJE8XEcnRvSwMtQaAQuIhEL9rAXZq/FWsKRn6kJOriAukfzXo7eQ7QqnOwvoAoxwNusc6078U8x6peDMLTAjrCBmHb7ZLLWgl0nuofv3+G+oXLGYdwfzCDhH1thc39qMHz8GZr4++C66NJ+xnVSbd7JQFLwObGBqWAdiyQ9I3p1WWbCUQzolSoIrG0SncHhEcoUWD5NaWnMHxPpS27Yd7SLqCNwpSZ9fSqr6D4naNDgWaooWBfcp477PW20PpEohW5/wPrwpPwGe66sNqxyvccOxCXFcAUrPBakdmu2naoM35I/poclMNrnUlPyCfX8AqtieKvhxIzXn7kOZmR6YQAlxAQU0rAJH3X+JEwGdZqThwUqL/GWFIYUjwy7xtHDuOVglngV/CnfO1uv4ya5qwXZTeWbaLSY6D7TTACqiKdPAK+ZtqCoFv+4RJcoQGaJ56qUEzSfFLWlxUbwBs9AdAYU34u1wU4r87XmkMYn5KVZcHrZDoLd7RVBzMFu6obtjQF+fQbu43qIfP7htlA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2107.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(396003)(136003)(366004)(39860400002)(66446008)(82960400001)(83380400001)(38070700005)(186003)(64756008)(66556008)(66476007)(4326008)(76116006)(54906003)(6916009)(8676002)(316002)(66946007)(9686003)(26005)(7696005)(6506007)(71200400001)(86362001)(41300700001)(52536014)(2906002)(5660300002)(33656002)(478600001)(4744005)(55016003)(122000001)(8936002)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TV897iku4qUNWa0nTxhKzcMYnbZ8gqNnZZAyEle1Qt7SLjagom6Cdas8D1cz?= =?us-ascii?Q?mI3xriTNgP6eZhrHIZCc9n37MO7SVCh62otvWkUiFEIL/GpoO01cF8RbVeHz?= =?us-ascii?Q?CYx5tgvXh+Kp3K8WXVV4P3DQS/XbaTQaBphL6BL2SDwNKHFuJZEzKF0NNG2h?= =?us-ascii?Q?qrM576dNrw4HRtmlfPukkVAXLI5WrAGV+xFZRYwfgSJzdw3XnHK0FD2lZQi6?= =?us-ascii?Q?gu3B5IJaLTQNxKcZjZdKAIFeN1aIxwoVfmS9e6rMazXHrLpkSXWmaJCATu7p?= =?us-ascii?Q?FYZGaXYn/IoKMfXYPlXnKtCzhXaMBZqXsqtkg4V1OWNW/THI/DKlQS3AikWs?= =?us-ascii?Q?7zMT+k8qLpyGe8zMH3KQ3k837J/oLPIlyANMwYPGmO1VLR41+cUlppcslM7p?= =?us-ascii?Q?iILFwS/nPjU2QpwfnTNR/KglwfQbpR2zul6ZRahH+1nOR89Cfpj8boBJiy+E?= =?us-ascii?Q?kQ/JfxO/DMLHGn9QxMGH/fiFBGVRMEuVeH49J73sGVqNZVUg0/tJm0NQL/9y?= =?us-ascii?Q?/yFTAejYNtfxJgf98yUxA7VgdvybO4Ee26KqPHULVvdXKVmtxQlxd/S7/jDh?= =?us-ascii?Q?SvP8XX4oA1YAMeZfAT4yfU6V0FE0tPG+rwk+X3UyJw54RYxpmQ/t+17u5aT1?= =?us-ascii?Q?r6y2gQIBExsCLRO4PCDJ3Qs+ixz4oUXIUjwPzFTTF3P6Q22bO7QJis3NLzBY?= =?us-ascii?Q?IzzNlXNTg+pXgsHci1U3TH/zuMcBtkBjTZkSY9gWGa3q+JTPRrD+hMuIgAOG?= =?us-ascii?Q?Fl0nH4HHx54hMeZo82oBIvOTVCfuk4jn7sLpr9JYklPZK31JQOxlCz48vqsl?= =?us-ascii?Q?Me7kVE3ULBVMQ81L7wAi8CvS9Cfew//zYE5UhxPF4M7B8ijGAtFBP/BMhAMX?= =?us-ascii?Q?ag5DrHniXWHXpuCio3mcR/zwGCn0EURNAO+zgQw64ThcQIA7gfJwp4q8KYC6?= =?us-ascii?Q?lVhcuC7KDfZF5wihNbnADeYsqNPFiCQ9MXNKkS0EcpW93jX1QMj1d7AvHMr8?= =?us-ascii?Q?7x+I7WdkJxC2Qe6xOKpT6Mdp7qTotiVPQOh1rZYZ4JSjmtBuVK4DLGBebQZk?= =?us-ascii?Q?vWgnO3Qu7bfQlkkyJU7Vyu9bSL8o0C/uJrGW3nS7TDvigugDQqdHcgoL3aBg?= =?us-ascii?Q?naKAWX3TMvZ2xgyy0S/KLGEuNI/ni15Ni8yfaljdOuO6XHG3hvWiXn9aOEaY?= =?us-ascii?Q?+G1mEvTDWeVrBH1G76C4U43zGhWIomHhhV1s/x4frpzIxkbTx093SwN6aqF4?= =?us-ascii?Q?Wzt1GWYoC78H60dJWmiCBWnpOfo1aPjTzEfwxNjv3Gt3AGfR1Bbkv1MYU54+?= =?us-ascii?Q?3F+khfhzMVlrpJahv0qCKsQjYU+7z2GW7Xrfe/mGhnjPilOGiJJiQN1dpIaK?= =?us-ascii?Q?iB7xtkxwuwFj1yXXbxuT3bbkFYj4GrJ69/jKtN/kITvLN5PB4O0XdusUx2BX?= =?us-ascii?Q?HZ+SwYK7GbIr5/hA33zSTUk/c5vcgXYIMo3YlIqznVNax9DOHjkkNpXtezmi?= =?us-ascii?Q?OgTCJ6Ygvshuy0H44g0sL8/N0yZN3UXYqqfyODu/+aDYYJjvOCb13X7OugT3?= =?us-ascii?Q?iXQORm3h9GDoVf02SUHCNrS0X4NjT15pV+hJ3+xq?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38611599-ac18-441c-fdfe-08da9023e36f X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2022 16:21:44.0056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4VOfKC7r7rff/uofGOZMK2bBN5/kVeSlCtfMYAmVmHWjDhDZlQRSdDajhI+8X47WOUjWv/arQQmIQ3DZX/pv9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4923 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 6 Sep 2022 16:05:11 +0800 Yiding Zhou wrote: > The pcap file will be synchronized to the disk when stopping the device. > It takes a long time if the file is large that would cause the 'detach=20 > sync request' timeout when the device is closed under multi-process=20 > scenario. >=20 > This commit fixes the issue by using alarm handler to release dumper. >=20 > Fixes: 0ecfb6c04d54 ("net/pcap: move handler to process private") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yiding Zhou I think you need to redesign the handshake if this the case. Forcing 30 second delay at the end of all uses of pcap is not acceptable. Thanks for your comments. According to my test, the time required to sync a 100G pcap file is about 2= 0s,=20 so I set a delay of 30s. I also tried to use AIO, but some issue in the mul= ti-process scenario. And I also consider io_uring, it is only supported in linux-5.x, we need t= o consider compatibility,.=20 Maybe better way is to do more work to redesign the handshake.