From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65652A04AD; Tue, 8 Feb 2022 06:35:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31FA54014E; Tue, 8 Feb 2022 06:35:23 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id EED4A40141 for ; Tue, 8 Feb 2022 06:35:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644298522; x=1675834522; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=K3GnvMywZHVTYeinDWwZAr/eJ/fLjxJJBT3ijUuK4Qo=; b=nCQaGfYo37VgAmuzXv7FSbrJEe+WV+Ya4HOEMQziPxGpEsQXfdAbnY9O gdqW/FaSCkLBjvEVKuY93uFhtpRghHYeWA0Rn2gh3iu5B3QMLs+YPYJMa kQ8vna3uEzWmspQpJNdhyx+DEcEam5NGgpdGuUqXMPikB1B5ec7F46Tcs dFEPCB8a6JZodGFlHZapEg7oEjVAO4o3cF/a38VFblL+NEyYEb/os3Hpe yHQp6X3elOJ3NqQIyg8tXHey+EkX5tRdJQ8PCMJJdvpap3trFZAvPWQz1 OqgWwLuvL+ZwdQB0Kpbh5bVv1AkYjDXwaIPp2k2Uqd3fpU0a+2OLG9rht Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="309620584" X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="309620584" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 21:35:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="484691686" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 07 Feb 2022 21:35:21 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 21:35:20 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 21:35:20 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 7 Feb 2022 21:35:20 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 7 Feb 2022 21:35:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mowejvi2CWcR1OfrzH3A95BFHa6SudCl4gqsiehP5l+fM9VlsyfkacWrfAVNyOoLNdr7EdyhE9RAlPZrUdywoQvPnF7FDAhWn+epUlTVzHkCQ7l1G96HaylSmJzj59ptbWFbHtZy+EqEqJcpyBgVv2ko9B4xZKK02eUdQDzYDRDUTiwQ5Ep8jCpBAIo6WXNGP7SULrR8qLsOISVoJvYI7dLbIUXMzWVG1Mm5aFIlN6OManRRZeBQLij4tJcLEnCrhZ5/v5SXVQDk82Rwrr2FU91swen5OcEJMs89oirjwNLYqEv+xTKWcwQe2SKfGs105fWtNSUPvaJceL7d/ZiMbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n/iEyMTv3RyhJTPYTuT4h9kt4kjLpcqpLV8Gr3XQQXQ=; b=nrA9rklEQtf/t/S/XTUJMEUb8Vxc1KI8wkR7FSkdfI/Bplcei0vTERpRj7TipLHt0O7cMnUaZBlPTkJXLSyMbM3Lb7UHVlZgGz6R7ipo629cGMhhMA3F+QgyaMILxVcTiVCM9F3fM8aBgVgFyhqHOv9AI1oawvZeYPKJ9l7qVyYjQM3ZQpqyL+9pmpYDLAtIqJd0py1RnQmABn7fYLjaoeVcaUjJHtdUPAhTHYhN7ENR3rG1ONZWU3CZcJ8kLzMHF9fiQnG+HNaK3vHoI9+PZP0JJErb8zUr01JOxLI5L9UF4k3H4+uOXMXvYKAbwV2YaMMndkxCQqCpSTJWAYh9qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM5PR1101MB2107.namprd11.prod.outlook.com (2603:10b6:4:5a::19) by DM6PR11MB3178.namprd11.prod.outlook.com (2603:10b6:5:56::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb 2022 05:35:16 +0000 Received: from DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::9d86:c1f5:e6c2:8b7]) by DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::9d86:c1f5:e6c2:8b7%4]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 05:35:16 +0000 From: "Zhou, YidingX" To: "Richardson, Bruce" , "Wang, Haiyue" CC: "Yang, Qiming" , "Zhang, Qi Z" , "dev@dpdk.org" Subject: RE: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC Thread-Topic: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC Thread-Index: AQHYG/71IugXGrWD/kCoqW9UsWelP6yIETsAgAAI5ICAAQZd0A== Date: Tue, 8 Feb 2022 05:35:15 +0000 Message-ID: References: <20220207164801.2768734-1-yidingx.zhou@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d10423d9-678e-4141-734e-08d9eac4c961 x-ms-traffictypediagnostic: DM6PR11MB3178:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w+ZHpIXrMB7XogyvbZ1mi+H4o4luovOWicMJ60v27uMO+tsDKe9j/jXudF+oZH1D2ouZb8m7KfwJGifCQLgNoQj5VY5wVlO701i60ajLzYvozvxH2iGQoiC2snvf4gGFYha9Qt+RWDVOBaGs+TV1XWMzy9BKSb0eXETUWxnF//HX0tM+fxm6VJjIuJ/3F60eWryuefeep0Xw5Zj2hlegD7vrnZVLM5ZADmgXzbbrB4rCD49//3z4HMgT5TXe8UGcGnO4A/oKKe2i0FFilWXj4yRXvvBxzy6rpjrpT8w9a1upo+zuZPI9r+yX17et3GWibVgTFqsKeWeuXqkwm9bj58GZTBrMrvKXNuSBqirAknlw9Ij3glvu6Ip5d77sQN+L+C7slnJcsKiOMwwFizSMoeqrvkrBXnbwYwMsiERZmAbQ0j5pQHG33Mwt81rbx9c2XmE9cvws4nh+m3Slig6//42uqGu+g9/tvdvupKoyEnnbxvOehsJEmoM6W1XemznKbrwEbJQz+jjyg8QntRT7kWhM8KiZJLYBHf8sVhO/yKGWmFr5+qw0EHtIuP2pF+Wx8zBWMziW1bKkb/Y1J9MuMUtJnUg4GSro50v2baw5PBSr1WSbRPQulzqQtC3M6nHcwVj4o9KOf9CchH9MQG7aLdp144lSNEcBBx5+UnIAXTAbALexpMX/7KL9w5ywZzgBJn+W36Ap+gK56z6PU0czkQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2107.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(52536014)(38070700005)(4326008)(66946007)(76116006)(8676002)(86362001)(8936002)(508600001)(64756008)(122000001)(5660300002)(66446008)(110136005)(66556008)(6636002)(316002)(54906003)(38100700002)(7696005)(82960400001)(33656002)(9686003)(6506007)(83380400001)(26005)(53546011)(186003)(55016003)(71200400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ucu2DffZmhkMMCsLnes9X1yYrJ5pSTOD3aJmD6R2352nfkfQOeyyOM62duQx?= =?us-ascii?Q?vo+bwu86w9b+97tuD0iTtjSFoorRquz17WaVRq/7tCdHMCfNZ8T6FYbsADba?= =?us-ascii?Q?jRnZwvFBllymlf5lsQt7fnp7KBEZFBDZQ4zgzsUK8xn4beveWddUIQeMSrYO?= =?us-ascii?Q?vr8ppPAQRd8Rla06tq0ctZsbHak8mdiSKwWKu9vMN0V041IJ1IV+Mjq9cw2g?= =?us-ascii?Q?1qlUw8qO+Zvi1BwwfPPJok06WzdjJe9S/IW8AJ0p9vDmHaJTRTvNFE7iqEme?= =?us-ascii?Q?zQOxMB4eaThcWZ40hD2TFxtlqtRrAVSHyqB/cgOqY9FF0en1CFU6VAWrxxBr?= =?us-ascii?Q?n9t/6Bu8PUqx4n3ddia74QTUufnZfRv7V3LDZ8E/qFOwRMXj5dhOaU9vNKvD?= =?us-ascii?Q?lMvX6dl/IQmajQ7j1RJhZugP8awy1lH3lm8Z3B3UkzjbwyfU5O8hVZK1qdD7?= =?us-ascii?Q?EbgnuDH0ZZRHdllxg9XyfWb9e/TpNskuHkeTviNB7HV+ptsrzGotaM6+jqvD?= =?us-ascii?Q?7QAprlguGMARQd9bTFrgzYxbkKp1a8v6qAiGxFN2ZS2OEAiHxpTelTAsNWUf?= =?us-ascii?Q?vMgeR1Y7C6U/02HvtgT4T5VxN1Ip62/qf0OnKY1BYpSV6VrlTuzuWlGKQUB5?= =?us-ascii?Q?Q9WS6d7zsoYTBPvIgnwCJc7YKwJ+ftRY46tS6g/5iNZGcOhWCIel+irOe0y5?= =?us-ascii?Q?BvqJYrsgmFmGzicOwNOAwb1DzoxQsseXC2dzKhCJ7oQSjjsQWOuFcBRr7cEk?= =?us-ascii?Q?MfL1yI8DlOT+jdkoy3Z17P2BHDHqAn3B4GEkt523yDJPuvv46G+lkJSQBLQ3?= =?us-ascii?Q?U8XYSpHDOrgoIQIQzMuco5E6BELe7hAcfi61lXZHFMzQZvW5ZE6oXDbRKf6E?= =?us-ascii?Q?a/ckeuSt74EKjhJKGObMpu43+linR+8smpxMop+38NaDqCwgSG3amF7lKSE5?= =?us-ascii?Q?qKvWoZKlwOtH2yoThWXnzsgrsQt2Onr2krECGktn8xa9SNwm4+8j6wEBXCoL?= =?us-ascii?Q?b67f1Wgle2eIJuIjjwcE9W5B8DVBINu2+08zg0hTILNivBPY8fR5IT7PwAPn?= =?us-ascii?Q?1Vz/SMsT/VCvBMBj2RFPCCvhTUD7JqUjjCj5ssa13IAexjJtIfo8qJczxhXY?= =?us-ascii?Q?LJPgQJPe74EZ57VQD3G8lmiP69DjELTFDTjzpWQnUfA6h/DLafWTZy8FOAbT?= =?us-ascii?Q?1JqGFjEvXBqj43r2ni7VaJVltP7dqMWpz3Kv1jbTePnBuL/r5u+R8LSbEKph?= =?us-ascii?Q?e0+x5wqTQtSlrlVQgUIL31CEu+Eepim3e7ftw0UQdkRbeBva1gr/GP+j8LDZ?= =?us-ascii?Q?B3CH9vGXMLkzp4a3A1APsF1+oE2L3NaYeCbTdjKTKDfqEnBYkVH8Yg7xFWX0?= =?us-ascii?Q?4IrznR38VXcBzRwIWpWigDvM+ZQtRdjgL6k80HN4KoaJkOVYG5e9fUarq69D?= =?us-ascii?Q?BRTebrMhkhWLaO1jEAR2GDTjuTywlPJUc44wE2ob8h7k/cYT1085Ugi3/EkO?= =?us-ascii?Q?zm5fPxmr1pu4GHy5W78OAbe8tsYHQkyPuH6le8qXEZcGTPiF2HgGHT6EHx80?= =?us-ascii?Q?EW/UGpJs92a9R4AlpRbNbn3bPEPpYocCgW6J2s76YiNrKz4vFnLYC5wGQdid?= =?us-ascii?Q?3A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d10423d9-678e-4141-734e-08d9eac4c961 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 05:35:15.7889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mDt0vf51cPssBkxy1l9qhVGL1UbADgsqU8rAm+x6t62kL6Kp71asnFjHQKu+s1uuUfNBpEfGOB0Wm+IobAwr/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3178 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Monday, February 7, 2022 9:46 PM > To: Wang, Haiyue > Cc: Zhou, YidingX ; Yang, Qiming > ; Zhang, Qi Z ; > dev@dpdk.org > Subject: Re: [PATCH] net/ice: fix gcc error with - > DRTE_LIBRTE_ICE_16BYTE_RX_DESC >=20 > On Mon, Feb 07, 2022 at 01:14:18PM +0000, Wang, Haiyue wrote: > > > -----Original Message----- > > > From: Yiding Zhou > > > Sent: Tuesday, February 8, 2022 00:48 > > > To: Yang, Qiming ; Zhang, Qi Z > > > > > > Cc: dev@dpdk.org > > > Subject: [PATCH] net/ice: fix gcc error with > > > -DRTE_LIBRTE_ICE_16BYTE_RX_DESC > > > > > > gcc will report error "unused parameter 'rxq'" when the macro > > > RTE_LIBRTE_ICE_16BYTE_RX_DESC is defined. use "(void)rxq" to avoid > > > it > > > > > > Fixes: 7a340b0b4e03 ("net/ice: refactor Rx FlexiMD handling") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Yiding Zhou > > > --- > > > drivers/net/ice/ice_rxtx.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c > > > index 58700f1b92..97572d5952 100644 > > > --- a/drivers/net/ice/ice_rxtx.c > > > +++ b/drivers/net/ice/ice_rxtx.c > > > @@ -163,6 +163,8 @@ ice_rxd_to_pkt_fields_by_comms_aux_v1(struct > ice_rx_queue *rxq, > > > *RTE_NET_ICE_DYNF_PROTO_XTR_METADATA(mb) > =3D metadata; > > > } > > > } > > > +#else > > > + (void)rxq; > > > #endif > > > } > > > > > > @@ -201,6 +203,8 @@ ice_rxd_to_pkt_fields_by_comms_aux_v2(struct > ice_rx_queue *rxq, > > > *RTE_NET_ICE_DYNF_PROTO_XTR_METADATA(mb) > =3D metadata; > > > } > > > } > > > +#else > > > + (void)rxq; > > > #endif > > > } > > > > > > > " __rte_unused struct ice_rx_queue *rxq" could make the fix clean. > > >=20 > +1 >=20 > Or alternatively put in "RTE_SET_USED" macro after the endif. It doesn't > generate any instructions so doesn't need a #else clause. >=20 Thanks for your advice. Using RTE_SET_USED macro is better. > /Bruce