From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81ED2A034C; Wed, 21 Sep 2022 09:14:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73DA740697; Wed, 21 Sep 2022 09:14:51 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 6A3414014F; Wed, 21 Sep 2022 09:14:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663744489; x=1695280489; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tAGJBwfCeCFOcf5YWby8jIaK1IuIKE8OIu2MiEMn5DM=; b=oEliWoOgfd8TjAdDf/jsbt37+8qP0nDTjyofF0MpBpJGBc4GuCU/ZbFk HMbI5AIX9ZOKvkCqkMb0PLEA7nE/jf9tzPof6dZ3ivBJYu9z1SGSIgdOr 5rofre7tqrTAk2GN08jVWgBFQlIm03OkToZ6zxq1xz0Vqdhsrsx+PYM/1 yXdBxr9BrB5aYY5jHv7g636SVq/q7eeMhEBfsIejmOA5ocPHzte8zPqGc CouN8aHJc47ORrIYVCAxQaT8+dNLruhoyFxBqqdeCyGQ4zo8DL/qA60nO zwHerZrgjUWcz9S0sc+weXI+E/RodAuSsOf4pdKOHQkWbq6mkPabX7MtK w==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="299911105" X-IronPort-AV: E=Sophos;i="5.93,332,1654585200"; d="scan'208";a="299911105" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2022 00:14:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,332,1654585200"; d="scan'208";a="761638319" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 21 Sep 2022 00:14:42 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 00:14:41 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 00:14:41 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 21 Sep 2022 00:14:41 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 21 Sep 2022 00:14:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSEPhxxbzvZgfDcd3KTIe8GsAuggTXKPrRbrKXWY+DhyLNVdUXkyfQYOUqMtPbTR5mQh6MrB4JDKSxkkMgmvzutCosfsyVR0Zty93pi5mMIXJNo40GWypxR6d4NpeDw2PxEHzppgSLWAYg4/A7YROtC49Qy0VyryEiA5teiN48QDJQ8om32HfrhG2kX/XELH9iuE+yBdJzVYUE0I1UyS0DhPCbm0PYgR9uRiHWnuXUT/J6VnC97brHPw7Xob1ql6hl6TJAcCeq25kUInwLQOdTHOXkQ0eicuZqiIzEDb4F7zu+CAUQcr03wz2QbP7aQkrO5xAECyEg2Tv3SSOF5lMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fr6svNSeWn1HpsaWYxHGKR6GbRAMS/PBwK7IbaIIzXM=; b=aFuX4dN5Pc6xPWp+GLCojpUJoCg39SIX0BDDi/bhd96Bv56FwHws8PWGUrodLrW/F+rUMUhYlSj7cUh74fTpmMz0oiTRJUN6NFFKAoejwzUfBO1mo5E9cnIlLVpU/DzcRCWIz87DQbADTc2z1C0X41HewYdNG3MyOZMC08a68rh8K/BizkpR+YWt5r/YoVQQt4mTKbJNHrg+0nCeMdpOSXOeajY7+r4UMgJr2nsRAZXyDNTSo0tzScRmHoSEl8oRxbaqgtD7hunoOcf9nMApkMYaVUwac4siyc3NftnyIlTjAeTvVBD431utp59KWra2W+YoL1Ihf9oHnXpUj19u3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR1101MB2107.namprd11.prod.outlook.com (2603:10b6:4:5a::19) by DM4PR11MB6144.namprd11.prod.outlook.com (2603:10b6:8:af::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.18; Wed, 21 Sep 2022 07:14:35 +0000 Received: from DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::55cf:b131:b6c6:bea3]) by DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::55cf:b131:b6c6:bea3%6]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 07:14:34 +0000 From: "Zhou, YidingX" To: Stephen Hemminger , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Burakov, Anatoly" , "He, Xingguang" , "stable@dpdk.org" Subject: RE: [PATCH v2] net/pcap: fix timeout of stopping device Thread-Topic: [PATCH v2] net/pcap: fix timeout of stopping device Thread-Index: AQHYwcctL9bFJ76KRUKNwgs+pLJ9gK3SfnOAgBcQh8A= Date: Wed, 21 Sep 2022 07:14:34 +0000 Message-ID: References: <20220825072041.10768-1-yidingx.zhou@intel.com> <20220906080511.46088-1-yidingx.zhou@intel.com> <20220906075737.2fb429a5@hermes.local> In-Reply-To: <20220906075737.2fb429a5@hermes.local> Accept-Language: en-US Content-Language: en-US X-Mentions: qi.z.zhang@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR1101MB2107:EE_|DM4PR11MB6144:EE_ x-ms-office365-filtering-correlation-id: 34549bf9-bbbf-45df-860d-08da9ba0efaa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mXte3nQ3DedOlJWcAGrHX8EmcwWQ+uMGYnCmCv+yiQ34qqc8GutO5WtC4hU++xS8c4rprToxAAZ9Uv1Gab332ZONhtytlAL9YrCKRkWK2wTukqAi09EHQk6TdfierCGSkPdr8e9QL2BQ/FUjqB6p04YKl0K7rhKC47f8RcNpTzNdQOPyJ4oesg1/pAwD2YQF3LMncANFzTEltX68rxz8zBwsC5nqkLJ/nFBovZqa6YYlzXsbVuidfNHPRxyv0bZ9vdB7Gfc8ND9/EGlWRvGUtXgytYyfd7mwjBHsexWXH7GqCpNtqLqWhlWcXKibke108sKngfJkgWz2paxbWL275fTZtDjGJU+bD9+LtNKyG7iY1eVWj2MxW0tlEShpEXQyifBZYskh9iSGBGpJVFt79PcpX3BF5GvSxA1MATsUgLUq7+7z7BysKXPoagEpErWGXxlQG+5NwWa6LdLpFwAkqfQ2ldCKc6va4b0NyTrO0G3/9q3A1w/P3J4aJ03TuDfLk/n7uKLcJlr/ar5qBEo29RrBmsVe+qbjPia1hW1JpJYhcSNvmzd4LmKrARY9RjkLlyssTMlpWWVbGVkgCImQ8Yuux00p20oxh0qIjrnUQwr5968y7PdkYg+7hadPmO9Kbu4JUkpzmKNtrED5UpHSRfXyMiHKLtVXeb7MMmgirINK+V50HF/YGjpFuZkj/sPzLTwzmStfFLGoHspIMdJrxb/LaEG/QWxxSA0PAJSTubdnib7LHESpJRDfxlHK/gNofjWsk76EYbjc4/ScEjQtGA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2107.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(366004)(136003)(376002)(39860400002)(346002)(451199015)(66476007)(52536014)(66556008)(6636002)(5660300002)(76116006)(66946007)(66446008)(2906002)(64756008)(4326008)(4744005)(316002)(8676002)(110136005)(54906003)(186003)(82960400001)(6506007)(41300700001)(38100700002)(33656002)(55016003)(26005)(86362001)(8936002)(7696005)(9686003)(71200400001)(478600001)(38070700005)(83380400001)(53546011)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rA4jPeClRA3oRDwXrNY2iJMd+OpM9zrWS3DWxHChjM3fK5VbeX24TMp/Cz/+?= =?us-ascii?Q?yv07sLdsKEEGHUwYMm+RxnHKToS/Ke8oj8JQp231u4lq/gF46RF/f+LoZUm4?= =?us-ascii?Q?D5Adtrpqy4VRSYk60V1r1cjpZ/dK5QesF+R7iIB1CJSUo34vRde5hxq32D+R?= =?us-ascii?Q?oNjw2A7DSO+F81GwlqjGl+JE/mWhSNBNeBfFMIYWfF++0pixpOSoCSj5Co8H?= =?us-ascii?Q?aDbi78337IbELWwq1qFIB1nFBQS2HGs7sbNy1m/DNodH8yfUmq2MfTNWG5Yk?= =?us-ascii?Q?K5WhqpJ7sPRpWt8c/iZdT+z94QaAzHm9tpE/hj8X6saJ8Iofiqf4WbuVYGHi?= =?us-ascii?Q?ElA5nZsshv5hTgagISL3P0tIm8Lv90f3lAtuKJpMW6rmDAQhQwDDktIetxcI?= =?us-ascii?Q?g7mgMsc1dcwb3CPy06Mi4DsKdZzNz4t4D1d3qYg6twkl03zkNc1mde/kiVUG?= =?us-ascii?Q?xq5nsO8yns36aewF/080yXedDjhsy+GT3becAmi7BwxGgO9D1fLMHMCb1yV7?= =?us-ascii?Q?LNq0IIiEpgD7rTKle4usnoBUMntQkpj2t2wQN/L98lWDRCB9z9J28Zx0FFGX?= =?us-ascii?Q?+A2Gv4cbyFyzbji4vUHfbKtN2tgh1GQdwMj95aasgkrk2z/U1csgeeEu/N6u?= =?us-ascii?Q?EnpkO1mv1F1w+bbZfL9WjJPwXrkRwQY2JoHAQEHk9UeZsszbtv6+l6iFPCNZ?= =?us-ascii?Q?XoRnp/KOnso79VCdYrWcKfJhYS8PyV8iEg66pIaiiZjSeoosmHPNe3ek8Yx1?= =?us-ascii?Q?/OAlgvXTIZt6XaZUjII9CWRbPjFEkM5eDYQNptUifVzoiyaq8zYZ4TqEcK08?= =?us-ascii?Q?5UNfTAFRQyhCl5kS012APHfac350nr/YKoD4vIFg7OnsE0RrZb+8ZJtgPR5d?= =?us-ascii?Q?a61jcFbU/6s66A2Nu8ZxzQ7dgWhB2xs5DScOM+9LehNNNgnDcgwrID9Wotjf?= =?us-ascii?Q?0DnweTbZ9667XO6QsdLoLU7F7T1I5jQwEGsGQefPigKPrJhyQuMZNqT/0iJc?= =?us-ascii?Q?3AyCEgHsh6v0EOclmg/jrS7/j1tRVpHxdEK0bjFYJlKwRaVoCF7FZrbksixv?= =?us-ascii?Q?OnGNehVIQ3qb1y4tgytA+/D8DUmuDwSNrfzef6eCIhQEZSLX/bwC+bE9wTiu?= =?us-ascii?Q?xVIHv/BKzxPkD8nYMW3g2VDRcQOJbBhqh6G5HbXrZHnRlDnruuBtGpnJFo+c?= =?us-ascii?Q?hnuVmvOpVBlemNIkBH4CXGIDbNmnorMuGcL29sDhl6iuNO7VR0RaFzBx/puR?= =?us-ascii?Q?aYeIxMI34JpSNuFP0h/s4lpCalrw4Thxj4aKrQ1aHxFTJBg96iglnACGM7L4?= =?us-ascii?Q?QbdaBvJ2VHwMWwbjH8i4HwimzxZkP1yoRvcUo0nAmvavKdIhOSWxDlGFvL7g?= =?us-ascii?Q?r7Jp3KQaKLCpVo7i+kgPaXBkml/cYNt32VLb6EKL2GEMoUXdtMeZqOpKbPjM?= =?us-ascii?Q?x838h7SBIwLUjtJ68tgJSn02tj5750SGkt0M5bi8safiDxb4yj7yLk5XrLYb?= =?us-ascii?Q?JsJAqsa2Tdh7VSUZRzfaylmFBoLkeeWerU/3pRqBdhhg0zSP76yY3Ki5NK89?= =?us-ascii?Q?Q5WqRLTQcb5Hb0YJuWI96t7sR/YfY/NwW2eWMn+7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34549bf9-bbbf-45df-860d-08da9ba0efaa X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 07:14:34.4192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cVyiC10+jew645qMue97GXOJ3+i024XQqPTQnsWS94PgCSXVc1kLXiiHK8bUBR5C2iVWjJYBmegy9PBj4+frCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6144 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, September 6, 2022 10:58 PM > To: Zhou, YidingX > Cc: dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly > ; He, Xingguang ; > stable@dpdk.org > Subject: Re: [PATCH v2] net/pcap: fix timeout of stopping device >=20 > On Tue, 6 Sep 2022 16:05:11 +0800 > Yiding Zhou wrote: >=20 > > The pcap file will be synchronized to the disk when stopping the device= . > > It takes a long time if the file is large that would cause the 'detach > > sync request' timeout when the device is closed under multi-process > > scenario. > > > > This commit fixes the issue by using alarm handler to release dumper. > > > > Fixes: 0ecfb6c04d54 ("net/pcap: move handler to process private") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yiding Zhou >=20 >=20 > I think you need to redesign the handshake if this the case. > Forcing 30 second delay at the end of all uses of pcap is not acceptable. @Zhang, Qi Z Do we need to redesign the handshake to fix this?