From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D87BA0527; Mon, 9 Nov 2020 17:20:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6912B72ED; Mon, 9 Nov 2020 17:20:36 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9D64F72E2 for ; Mon, 9 Nov 2020 17:20:33 +0100 (CET) IronPort-SDR: MpKDfVNOSxeos3ZGiZruTYob/XUK9J7xOB/UbkF/OXGG10QAsWchv9wYgZ5cC4Qqd8j1nsnAK5 oV4C1eFkICrQ== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="169043065" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="169043065" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 08:20:31 -0800 IronPort-SDR: e+jw9brJYK5s+hxNl1+IuCs/5lFYzWW/XWqDRAVqs4Pkn6xq7tHOyJr1KQR01NnJhuxqJK8CXx EXXGEJFPZgJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="308033388" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 09 Nov 2020 08:20:31 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 9 Nov 2020 08:20:31 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 9 Nov 2020 08:20:31 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 9 Nov 2020 08:20:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KuXlU3fKXUkdm1pT/ub/Oe4N2FC0ka3eBrjbkva7HJH7AMmMkDR54/W8x6VoapsCYiEAFP3CJMpTUmF9kQuPavdKa6NUOObhALGt4GBP9Q+oMqd/xI3+7Yu94AjojoUx92JqI2ONZypHzy6I434eiVOzdzbuIol9u3MHVX2OKYUVCZvDF0gdRZCaMZsdXeBDdd0SH4w3hTdWWK0CXvHqGgOJB0cMvA5mlOleI+OWl+W5lCOTn4g0m6t6jvgOhDSR0vZ6zLENxujVWh/TrUTGX9r5rd51DlA+8TxBFLEbSGUmNHlLd/BP5l60bNCOFmEcphD4ixEbvttIVVrqn0hFYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RowCK/OT2fzVu8faPoVtTOnZieiO2C1yfRxaLPpcLK0=; b=iAxRUoJMTf03vdtXJsVOTWmmtZp4WXyBF3/9Mws7R5D3LR1r65bKUN1Gpqp3YKL0dLRdZxmAGW+Hvumo8SMLh1d5Y8+CPZT9DHHOnU7h4vujHXOkcERzIc4Ti8fuviWoyhNJROe8U0fL5f8IPsfzeauaUqFnVzFA9qCiGv0tcGqyUM/4ZkjKZjgOblZ8TLWkuyKl1BeRBSfhI3hS7QHdk8dzLZapxSViwyaIiM7lVqkCWjouz+qtmNms2gYr0k6O02fZdq7sd2XE9rf28/BQQDbSFQZEmEPFfL7i0bGrcwz4YN3oHetA2VaZjRfCRCrbhaZfuOPn97qDfP7zz5C0ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RowCK/OT2fzVu8faPoVtTOnZieiO2C1yfRxaLPpcLK0=; b=Goc9va38TXoNu/DS4h04Yse5+a8Q61G3dfGLvy8PDa2wiIEgMKbDatwt6v9OuptH57Mos9p2ddH7DxEtxqm0FSQryLntS1PL+CmoKB7WCFD214sVwM5KRqTxmG5FgBmB6Yr5qfp6Bhc3vROMMPz0hQsSeqllzJph6ioowaQX2No= Received: from DM5PR1101MB2121.namprd11.prod.outlook.com (2603:10b6:4:50::19) by DM6PR11MB3961.namprd11.prod.outlook.com (2603:10b6:5:19a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.25; Mon, 9 Nov 2020 16:20:28 +0000 Received: from DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621]) by DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621%10]) with mapi id 15.20.3541.025; Mon, 9 Nov 2020 16:20:28 +0000 From: "Walsh, Conor" To: Honnappa Nagarahalli , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Chen, LingliX" , nd Thread-Topic: [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error Thread-Index: AQHWssx7UeSjSO8VKEW0ixDwHHuez6m4UHwAgAevGSA= Date: Mon, 9 Nov 2020 16:20:28 +0000 Message-ID: References: <20201104170306.1688771-1-conor.walsh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.110.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ebd88d8-d029-4bd7-8fe6-08d884cb5f30 x-ms-traffictypediagnostic: DM6PR11MB3961: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lAKLTOkLXkc6h1+rJ9AWhAaxzz7veLk1HjKN03e5st80MLQtVjJdrw93aYhL+Wg+tC76/m1UDN2ETtLPMjsvMpUbOTvP6DdO6QcPWu4+Fr8mXMZCBHUrJZUDwF037CskGwsUqr5mUKmxxlZHudQag/jhLB2H1GCwkn1rTJygtl81hXo2IXhSBBpcy7xdiHsKgaUQjolWopabDbqt6ksaXwOLr0add2iHzLozO1GJXLif6ReJvvZ5c9k7tVj7V3nqol+ZVat53v9nvyFkPHqL67qU1xh2Q5b24/UgZ4XEeP/kC1lhIcpqrzwEzvmvkjWX++Xm/htWLCy3QYorAAzGSQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2121.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(6506007)(33656002)(6636002)(53546011)(2906002)(316002)(8936002)(83380400001)(7696005)(8676002)(110136005)(4326008)(54906003)(86362001)(76116006)(66946007)(55016002)(478600001)(9686003)(26005)(64756008)(66556008)(66476007)(71200400001)(186003)(66446008)(5660300002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: tyoQ5sTc60lOj8OK1LYBvM+EEimnxVx4kRJrtcFgvWuhswR8uieudLj9IAG+f4IdvNdudfs6ll8b6ZeDz7YMnxLpzyBuPovFK6LdtY01Iulb+AezO9SS4sAt7O392ffcp+owZxPJXpS6aFsWkTOUYHOw6+aQ86ADep6q4D1LQWtzZ0cPHPaZYEIHRdSRRHbMxJob6ZqNG32CF7x41OXyYVoZHnMEdGnUg8ANkMjlvbyJydF/wn0UQwpFoQuuO4ZSw10KWcQm+SvZNP8Rdf9LY88eKS6ID8GLsJyCNSTs7M78MxJ0tkjMyHn4aTEIM305RmO408CUoysRJm/ZHHxzv2/9e3GIDywzCp4bSWLqNpBdY158eUfVVPuHf4MCJXwA3f5atXTtgasKfI23977x/RbmUgT7R15NCs8NqorZq608MF3jxfXfhFRLx2CEgiuHi5G8cdZPIBLkaVzdmTI/8bV7y86lJvOzRpVvnKANfhFet+gaEgS2sXpdjf/iO9CGMMjLbRfRKhyrt5J0WPLFJAYpLf7uxX2xwgSQ/qHJvIJSwcUnOtN9R28g4PFNAU06KdmilPDmnIgIwSlAV7kRD0d4DHSZmp5fhLQBYrbJPM8zy2CmISiaPfpmX2lRCeslAN+E/KEiXZ38rwhiEfuq3nX5luLVhDtrOOtsa+bwXT9RBRp07Kb6H0JbR5TBhlRKV9q8rW2Cp6wpMq3GE7kAni3A/H4dNd5f6gJvZPxGQuqlxeJxgqH9HKf+yWCzVNnnoVLdZpGFxFzQdyTdG2BXqEGMn9q4x/LHFRH8cUAiH/2WnatLHiTaMqZi3c2ujyQ2js7ibZZSazD1NdnmAo8MG/Z6lijaLrM2WgVJ32amuZsDAWR8DJDE3+OwVoqbVKQFRK7+xzZiIkWS6YX11uxU4w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2121.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ebd88d8-d029-4bd7-8fe6-08d884cb5f30 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2020 16:20:28.1601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FSIE5Huc+rDQFvbtxDKV5jgkaHCASngTVuDw6SkeT+WdvWAQzgt4vShZ0KheEbpiNuBxCozttgMmmPrcikWREA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3961 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Honnappa, Sorry about the delayed reply. The build error trace is below, the build command used was: CC=3Dgcc meson = --optimization=3D1 --werror build1; ninja -C build1 I am not sure how I could fix this issue without initialising zcd. [2339/2407] Compiling C object app/test/dpdk-test.p/test_ring_mt_peek_stres= s_zc.c.o FAILED: app/test/dpdk-test.p/test_ring_mt_peek_stress_zc.c.o gcc -Iapp/test/dpdk-test.p -Iapp/test -I../app/test -Ilib/librte_acl -I../l= ib/librte_acl -I. -I.. -Iconfig -I../config -Ilib/librte_eal/include -I../l= ib/librte_eal/include -Ilib/librte_eal/linux/include -I../lib/librte_eal/li= nux/include -Ilib/librte_eal/x86/include -I../lib/librte_eal/x86/include -I= lib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal -I../lib/= librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_metrics = -I../lib/librte_metrics -Ilib/librte_telemetry -I../lib/librte_telemetry -I= drivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/librt= e_pci -I../lib/librte_pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/li= brte_bitratestats -I../lib/librte_bitratestats -Ilib/librte_ethdev -I../lib= /librte_ethdev -Ilib/librte_net -I../lib/librte_net -Ilib/librte_mbuf -I../= lib/librte_mbuf -Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_r= ing -I../lib/librte_ring -Ilib/librte_meter -I../lib/librte_meter -Ilib/lib= rte_bpf -I../lib/librte_bpf -Ilib/librte_cfgfile -I../lib/librte_cfgfile -I= lib/librte_cmdline -I../lib/librte_cmdline -Ilib/librte_cryptodev -I../lib/= librte_cryptodev -Ilib/librte_distributor -I../lib/librte_distributor -Ilib= /librte_efd -I../lib/librte_efd -Ilib/librte_hash -I../lib/librte_hash -Ili= b/librte_rcu -I../lib/librte_rcu -Ilib/librte_eventdev -I../lib/librte_even= tdev -Ilib/librte_timer -I../lib/librte_timer -Ilib/librte_fib -I../lib/lib= rte_fib -Ilib/librte_rib -I../lib/librte_rib -Ilib/librte_flow_classify -I.= ./lib/librte_flow_classify -Ilib/librte_table -I../lib/librte_table -Ilib/l= ibrte_port -I../lib/librte_port -Ilib/librte_sched -I../lib/librte_sched -I= lib/librte_ip_frag -I../lib/librte_ip_frag -Ilib/librte_kni -I../lib/librte= _kni -Ilib/librte_lpm -I../lib/librte_lpm -Ilib/librte_graph -I../lib/librt= e_graph -Ilib/librte_ipsec -I../lib/librte_ipsec -Ilib/librte_security -I..= /lib/librte_security -Ilib/librte_latencystats -I../lib/librte_latencystats= -Ilib/librte_member -I../lib/librte_member -Ilib/librte_node -I../lib/libr= te_node -Ilib/librte_pipeline -I../lib/librte_pipeline -Ilib/librte_rawdev = -I../lib/librte_rawdev -Ilib/librte_reorder -I../lib/librte_reorder -Ilib/l= ibrte_stack -I../lib/librte_stack -Idrivers/mempool/ring -I../drivers/mempo= ol/ring -Idrivers/mempool/stack -I../drivers/mempool/stack -Idrivers/event/= skeleton -I../drivers/event/skeleton -Idrivers/net/bonding -I../drivers/net= /bonding -Idrivers/net/ring -I../drivers/net/ring -Ilib/librte_power -I../l= ib/librte_power -Ilib/librte_pdump -I../lib/librte_pdump -Idrivers/crypto/s= cheduler -I../drivers/crypto/scheduler -fdiagnostics-color=3Dalways -pipe -= D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O1 -include rte_config= .h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral -Wformat-security -= Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-def= inition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-= strings -Wno-packed-not-aligned -Wno-missing-field-initializers -march=3Dna= tive -mno-avx512f -DALLOW_EXPERIMENTAL_API -Wno-format-truncation -D_GNU_SO= URCE -fno-strict-aliasing -DALLOW_INTERNAL_API -MD -MQ app/test/dpdk-test.p= /test_ring_mt_peek_stress_zc.c.o -MF app/test/dpdk-test.p/test_ring_mt_peek= _stress_zc.c.o.d -o app/test/dpdk-test.p/test_ring_mt_peek_stress_zc.c.o -c= ../app/test/test_ring_mt_peek_stress_zc.c In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: ../app/test/test_ring_stress_impl.h: In function 'test_worker': ../app/test/test_ring.h:82:3: error: 'zcd.n1' may be used uninitialized in = this function [-Werror=3Dmaybe-uninitialized] test_ring_mem_copy(zcd->ptr2, src, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ esize, num - zcd->n1); ~~~~~~~~~~~~~~~~~~~~~ ../app/test/test_ring_mt_peek_stress_zc.c:32:26: note: 'zcd.n1' was declare= d here struct rte_ring_zc_data zcd; ^~~ In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: ../app/test/test_ring.h:67:2: error: '*((void *)&zcd+8)' may be used uninit= ialized in this function [-Werror=3Dmaybe-uninitialized] memcpy(dst, src, sz); ^~~~~~~~~~~~~~~~~~~~ ../app/test/test_ring_mt_peek_stress_zc.c:32:26: note: '*((void *)&zcd+8)' = was declared here struct rte_ring_zc_data zcd; ^~~ In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: ../app/test/test_ring.h:67:2: error: 'zcd' may be used uninitialized in thi= s function [-Werror=3Dmaybe-uninitialized] memcpy(dst, src, sz); ^~~~~~~~~~~~~~~~~~~~ ../app/test/test_ring_mt_peek_stress_zc.c:32:26: note: 'zcd' was declared h= ere struct rte_ring_zc_data zcd; ^~~ In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: ../app/test/test_ring.h:63:11: error: 'zcd.n1' may be used uninitialized in= this function [-Werror=3Dmaybe-uninitialized] sz =3D num * sizeof(void *); ~~~~^~~~~~~~~~~~~~~~ ../app/test/test_ring_mt_peek_stress_zc.c:14:26: note: 'zcd.n1' was declare= d here struct rte_ring_zc_data zcd; ^~~ In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: ../app/test/test_ring.h:67:2: error: '*((void *)&zcd+8)' may be used uninit= ialized in this function [-Werror=3Dmaybe-uninitialized] memcpy(dst, src, sz); ^~~~~~~~~~~~~~~~~~~~ ../app/test/test_ring_mt_peek_stress_zc.c:14:26: note: '*((void *)&zcd+8)' = was declared here struct rte_ring_zc_data zcd; ^~~ In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: ../app/test/test_ring.h:67:2: error: 'zcd' may be used uninitialized in thi= s function [-Werror=3Dmaybe-uninitialized] memcpy(dst, src, sz); ^~~~~~~~~~~~~~~~~~~~ ../app/test/test_ring_mt_peek_stress_zc.c:14:26: note: 'zcd' was declared h= ere struct rte_ring_zc_data zcd; ^~~ cc1: all warnings being treated as errors [2340/2407] Compiling C object drivers/libtmp_...ontx2.a.p/event_octeontx2_= otx2_worker_dual.c.o ninja: build stopped: subcommand failed. Thanks, Conor. > From: Honnappa Nagarahalli > Sent: Wednesday 4 November 2020 18:48 > To: Walsh, Conor ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Chen, LingliX ; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH v1] app/test: zcd needs to be initialised to fix gcc = compile > error >=20 > Hi Conor, > Thanks for the patch. >=20 > >=20 > > > > When DPDK is compiled with gcc < 9 with the optimization level set to 1= gcc > > sees zcd in test_ring.h as possibly being uninitialised. To correct thi= s error > zcd > > has been initialised to {0} in test_ring_mt_peek_stress_zc.c. > > > > Signed-off-by: Conor Walsh > > --- > > app/test/test_ring_mt_peek_stress_zc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/test_ring_mt_peek_stress_zc.c > > b/app/test/test_ring_mt_peek_stress_zc.c > > index 7e0bd511a7..ba0acf237c 100644 > > --- a/app/test/test_ring_mt_peek_stress_zc.c > > +++ b/app/test/test_ring_mt_peek_stress_zc.c > > @@ -11,7 +11,7 @@ _st_ring_dequeue_bulk(struct rte_ring *r, void **obj, > > uint32_t n, > > uint32_t *avail) > > { > > uint32_t m; > > - struct rte_ring_zc_data zcd; > > + struct rte_ring_zc_data zcd =3D {0}; > I faced similar problems when I created this test case. I refrained from = doing > this initialization as it might mask the problems in the library. Is it p= ossible to > identify which path in the library is actually resulting in this error? I= would > prefer to fix that instead. >=20 > > > > m =3D rte_ring_dequeue_zc_bulk_start(r, n, &zcd, avail); > > n =3D (m =3D=3D n) ? n : 0; > > @@ -29,7 +29,7 @@ _st_ring_enqueue_bulk(struct rte_ring *r, void * > const > > *obj, uint32_t n, > > uint32_t *free) > > { > > uint32_t m; > > - struct rte_ring_zc_data zcd; > > + struct rte_ring_zc_data zcd =3D {0}; > > > > m =3D rte_ring_enqueue_zc_bulk_start(r, n, &zcd, free); > > n =3D (m =3D=3D n) ? n : 0; > > -- > > 2.25.1