From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2473EA0526; Tue, 10 Nov 2020 11:04:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E3DCF64; Tue, 10 Nov 2020 11:04:57 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3CC6E2AB for ; Tue, 10 Nov 2020 11:04:52 +0100 (CET) IronPort-SDR: Mz+tG2BwY/WrlLNq/ZBof9b66aMnY6xqwKkhhhHBnbwWzrj6xQP6XwVi5pgmFBALcxIwyVK2bM WdekLSFvxlbQ== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="187912838" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="187912838" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 02:04:37 -0800 IronPort-SDR: dlOppyWyYU9J3TOiBllCB50+URL6JKrNAygzzIS2Hc5N4yRKG/etAFSGvdGf/qOHH+x3u2gekx 7KiutxdiTjGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="338671376" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 10 Nov 2020 02:04:33 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 10 Nov 2020 02:04:33 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 10 Nov 2020 02:04:33 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 10 Nov 2020 02:04:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QM8z3Ou0OluMWlEREtjC1460FY4A1EOli+M2kXceDPfOBW8THFYTWmuYngL/rUWxZWwVR6GesAJzxHj9mUnfl4+ETVDqEqqnafUDFqSNcxpdyLOxYLvKFZwV0vBQ1ovpjjFYaDrcZow7lPMJP3tt+ydrIpi4WHr+fyx0qZKuGmw2SlV2dnfy5ed20lVakrijpUkZxZTZvSW+JMo3drxU4uVIzyF1vG3t4AKRbKcGhtXtjFrV/ij7SgOKMe7Ot6s0lAs6p/k3CKgNuX9cA2vnswvSJXIPq9AHPFgOFzWxnG5GOEpfwYNIwwS5CfrcQm2N9FlbhewHFs+t40EjbGusHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iCGmiIkNMQilPN561ZXzBmZ6sY95cuDtLXH/5b+TfeE=; b=A5nizJBuF2DH7D5gb3xQOjk9hmJ9EZfym8QzxzjmoeqRPRY8NVatYqRNlSnpozzrU/utrOgg73ZnLgdxh1zcqcuASHdEe4SpHpsfb9+8IRtIUkEtpUttwJQZz00bF6iR3gYLgML6zFI0ru0vOWablbrfscjdpUjWqLg3DsImr3Y5Z6RmgVEl+8bI3Z5Gv9ay6RIWhFzbZdut3ZwdFAnQYHA0/KjLeW75Tu6KuJcppwpUALuhcvAkfZ2clA+rdjJiXXWRxx3CEki0uRifd81GTdGIM6thjG13w5KTzmK/GWlo1FFcx+tzQz4OZuZunpVFNNGOGqmRDSwYlXKN9Bd/mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iCGmiIkNMQilPN561ZXzBmZ6sY95cuDtLXH/5b+TfeE=; b=jgz8IWftPs9F0ZOXmUP+GU8+VhpbLMx6FrDrtTAMXGQBaxuc3sC/hEEYkleAVeZ2hj15C+9ikHnzAdZnFDLPi9CuY4m1IYPgyFKqe5U68xjqDQKXasNK325pYd3WAdHyPRuygX/BWSHgMFvMSFpLqszIwN7vyEQM/nwAiB4070Y= Received: from DM5PR1101MB2121.namprd11.prod.outlook.com (2603:10b6:4:50::19) by DM5PR11MB1356.namprd11.prod.outlook.com (2603:10b6:3:14::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Tue, 10 Nov 2020 10:04:28 +0000 Received: from DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621]) by DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621%10]) with mapi id 15.20.3541.025; Tue, 10 Nov 2020 10:04:28 +0000 From: "Walsh, Conor" To: Honnappa Nagarahalli , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Chen, LingliX" , nd , nd Thread-Topic: [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error Thread-Index: AQHWssx7UeSjSO8VKEW0ixDwHHuez6m4UHwAgAevGSCAAAodgIAABIJQgAAGhACAAAB6wIAAWMMAgAC9xnA= Date: Tue, 10 Nov 2020 10:04:28 +0000 Message-ID: References: <20201104170306.1688771-1-conor.walsh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.43.236] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 247e57c5-841b-4e83-3d05-08d885600322 x-ms-traffictypediagnostic: DM5PR11MB1356: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: srAwLvoMhBW5RfBnpLpEFAcgMCwCL+fUwM7OS/soj4I3rMB//Vwlv8XwydZVubya+HseJeJfYn4HxZzVF6zCJv19hTm/hZuFwvYa4D3zompuZgMTsxhrSlmUfkd2ytHkrEiQoTsgOCY3GJaiOViGiTeipeuD5GduZWTE16dAbrXqE5Rj/he5yng1+1YyjNcwQajNJ6gqvR6LcTJp0M5wBRD5ayKh+Yd5CZLq1Lr6IE5OrTTpXul8hTO14eaDTABC8ihcH9TAL7E/bcovnqblQLJxu7kH3NnSEFxqxZ2r+VxCtpJsWobgQvUrnTdXD8Xn x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2121.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(39860400002)(366004)(376002)(55016002)(9686003)(83380400001)(54906003)(316002)(110136005)(76116006)(186003)(33656002)(2906002)(52536014)(6636002)(66556008)(66476007)(66446008)(66946007)(64756008)(478600001)(71200400001)(5660300002)(4326008)(26005)(6506007)(7696005)(86362001)(8936002)(8676002)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: RIDdocCMGqbPSlQDWuLFRgYJxP9SnMg0xc3R/LXaVao6NGNBpjv9qYb2iNJoa+xrZg3nRwNaOh6trEnnwFEgHlDo4ycZbEMikFHE9DmGTktdpwlFHv6mcL28Ub+XjIT85uX7YaaEH0rljSLQr06oA9KT/gWnhBK3s130sTCmzW0JsBc226qbfwUQAVV/bOV0b5wVFqp8Zn7g+P1zgKsOMcg+ppUq5NDh4z+1FQxIMESKvZxVt2qKKsDOUOsFRsXGRjmz4b8rccGaC3jretxHCNvKwncYnnusaAojzd0USyNptOvwT0qdkUYHpZ95rhySkGVzVGyP+oYGMLjKiUiHCDoMxOMzHDOa8VPEFxa1GrFa2b7DsACq2+7r4Xll+tvC8Ve9SAHe8ReCsLjzB/68AuJcQLzzWx4fyRoCo2vdEvkWE2R0EQ/XJ3qYsLKWt+m49Hz6re8+2YGEJesa6OZZWOF9rMuob2qVORp7oR79QAKLZUVlkoA07vPJQNlfbH1GOnP/14ro7vxkcMQscznazrXlbmw8Cte09kgHBTfR1NMIiN2uCHHEsglYMWUda72RDQCPDQ25sLs8AB4JF1FIX7bRr7dTI7qxZmFk8HnXUnv9ZHVOt9FJAHGtuhXdqxrqJb+VP1HbwZTP3MhWHzbO3mopaJuMuSdN8mHfGcX2T/Id5wtELET2JSA4R5lRZrpEGsuE6357YFmQhbCPXxhxxGcTS3BDdLWCS2Pi56DS2y6bQE31bo9CUQtZV83BKzzhgFlWiBZ5Xg5jWF+iJ3t/dJipHYcRCBQvZLZ5NWQorYXs82JoeBCIyOB/2A8Ysbd/zq1YYrnvTanXcrocsOWFg+X/A0RF/2guCjs5sJ1azy+z3wy3o5wZva1YBWlhXfb/3w7m4b+voUIYMii+0km3mg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2121.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 247e57c5-841b-4e83-3d05-08d885600322 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2020 10:04:28.6276 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yieeyB7GfhOET2EI/gJFVX0zL0qin41DS6vpEgLZlj1tVjaxLL7VY6+SMiQnwk3LyVAY9zzlLAa6ipPerH0TRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1356 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Honnappa Nagarahalli > Sent: Monday 9 November 2020 22:44 > To: Walsh, Conor ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Chen, LingliX ; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH v1] app/test: zcd needs to be initialised to fix gcc = compile > error >=20 > >=20 > > > > > > > > > > > [2339/2407] Compiling C object app/test/dpdk- > > > > test.p/test_ring_mt_peek_stress_zc.c.o > > > > FAILED: app/test/dpdk-test.p/test_ring_mt_peek_stress_zc.c.o > > > > gcc -Iapp/test/dpdk-test.p -Iapp/test -I../app/test -Ilib/librte_ac= l > > > > - I../lib/librte_acl -I. -I.. -Iconfig -I../config > > > > -Ilib/librte_eal/include - I../lib/librte_eal/include > > > > -Ilib/librte_eal/linux/include - I../lib/librte_eal/linux/include > > > > -Ilib/librte_eal/x86/include - I../lib/librte_eal/x86/include > > > > -Ilib/librte_eal/common - I../lib/librte_eal/common -Ilib/librte_ea= l > > > > -I../lib/librte_eal - > > > Ilib/librte_kvargs - > > > > I../lib/librte_kvargs -Ilib/librte_metrics -I../lib/librte_metrics = - > > > > Ilib/librte_telemetry -I../lib/librte_telemetry -Idrivers/bus/pci - > > > > I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/librte_pci > > > > -I../lib/librte_pci > > > - > > > > Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/librte_bitratestats - > > > > I../lib/librte_bitratestats -Ilib/librte_ethdev > > > > -I../lib/librte_ethdev - Ilib/librte_net -I../lib/librte_net > > > > -Ilib/librte_mbuf -I../lib/librte_mbuf - Ilib/librte_mempool > > > > -I../lib/librte_mempool -Ilib/librte_ring - > > > I../lib/librte_ring > > > > -Ilib/librte_meter -I../lib/librte_meter -Ilib/librte_bpf > > > > -I../lib/librte_bpf - Ilib/librte_cfgfile -I../lib/librte_cfgfile > > > > -Ilib/librte_cmdline - > > > I../lib/librte_cmdline > > > > -Ilib/librte_cryptodev -I../lib/librte_cryptodev > > > > -Ilib/librte_distributor - I../lib/librte_distributor > > > > -Ilib/librte_efd -I../lib/librte_efd -Ilib/librte_hash - > > > > I../lib/librte_hash -Ilib/librte_rcu -I../lib/librte_rcu > > > > -Ilib/librte_eventdev - I../lib/librte_eventdev -Ilib/librte_timer > > > > -I../lib/librte_timer -Ilib/librte_fib - I../lib/librte_fib > > > > -Ilib/librte_rib -I../lib/librte_rib -Ilib/librte_flow_classify - > > > > I../lib/librte_flow_classify -Ilib/librte_table > > > > -I../lib/librte_table - > > > Ilib/librte_port > > > > -I../lib/librte_port -Ilib/librte_sched -I../lib/librte_sched > > > > -Ilib/librte_ip_frag > > > - > > > > I../lib/librte_ip_frag -Ilib/librte_kni -I../lib/librte_kni > > > > -Ilib/librte_lpm - I../lib/librte_lpm -Ilib/librte_graph > > > > -I../lib/librte_graph -Ilib/librte_ipsec - I../lib/librte_ipsec > > > > -Ilib/librte_security -I../lib/librte_security - > > > > Ilib/librte_latencystats -I../lib/librte_latencystats > > > > -Ilib/librte_member - I../lib/librte_member -Ilib/librte_node > > > > -I../lib/librte_node - > > > Ilib/librte_pipeline > > > > -I../lib/librte_pipeline -Ilib/librte_rawdev -I../lib/librte_rawdev > > > > - Ilib/librte_reorder -I../lib/librte_reorder -Ilib/librte_stack - > > > I../lib/librte_stack - > > > > Idrivers/mempool/ring -I../drivers/mempool/ring > > > > -Idrivers/mempool/stack > > > - > > > > I../drivers/mempool/stack -Idrivers/event/skeleton - > > > > I../drivers/event/skeleton -Idrivers/net/bonding > > > > -I../drivers/net/bonding - Idrivers/net/ring -I../drivers/net/ring > > > > -Ilib/librte_power - > > > I../lib/librte_power - > > > > Ilib/librte_pdump -I../lib/librte_pdump -Idrivers/crypto/scheduler = - > > > > I../drivers/crypto/scheduler -fdiagnostics-color=3Dalways -pipe - > > > > D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O1 -include > > > > rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral - > > > > Wformat-security -Wmissing-declarations -Wmissing-prototypes - > > > Wnested- > > > > externs -Wold-style-definition -Wpointer-arith -Wsign-compare > > > > -Wstrict- prototypes -Wundef -Wwrite-strings -Wno-packed-not- > aligned > > > > -Wno- > > > missing- > > > > field-initializers -march=3Dnative -mno-avx512f - > > > DALLOW_EXPERIMENTAL_API - > > > > Wno-format-truncation -D_GNU_SOURCE -fno-strict-aliasing - > > > > DALLOW_INTERNAL_API -MD -MQ app/test/dpdk- > > > > test.p/test_ring_mt_peek_stress_zc.c.o -MF app/test/dpdk- > > > > test.p/test_ring_mt_peek_stress_zc.c.o.d -o app/test/dpdk- > > > > test.p/test_ring_mt_peek_stress_zc.c.o -c > > > > ../app/test/test_ring_mt_peek_stress_zc.c > > > > ../app/test/test_ring_mt_peek_stress_zc.c: In function > > > > '_st_ring_dequeue_bulk': > > > > ../app/test/test_ring_mt_peek_stress_zc.c:13:11: error: variable 'm= ' > > > > set > > > but > > > > not used [-Werror=3Dunused-but-set-variable] > > > > uint32_t m; > > > > ^ > > > > ../app/test/test_ring_mt_peek_stress_zc.c: In function > > > > '_st_ring_enqueue_bulk': > > > > ../app/test/test_ring_mt_peek_stress_zc.c:31:11: error: variable 'm= ' > > > > set > > > but > > > > not used [-Werror=3Dunused-but-set-variable] > > > > uint32_t m; > > > > ^ > > > I am not sure why you are seeing the above error. > > > > m is being set but is only being used in the line that I commented out,= if > that > > line needs to be removed then m doesn't need to be set or declared. > > E.g. below. > > > > test_ring_mt_peek_stress_zc.c:9 > > static inline uint32_t > > _st_ring_dequeue_bulk(struct rte_ring *r, void **obj, uint32_t n, > > uint32_t *avail) > > { > > uint32_t m; > > struct rte_ring_zc_data zcd; > > > > m =3D rte_ring_dequeue_zc_bulk_start(r, n, &zcd, avail); > > //n =3D (m =3D=3D n) ? n : 0; > > if (n !=3D 0) { > Sorry, the above 'if' statement should be as follows: > if (m !=3D 0) { Thanks Honnappa, those two changes fix the issue for me. I will send a V2 of the patch with these changes. Thanks, Conor. >=20 > > /* Copy the data from the ring */ > > test_ring_copy_from(&zcd, obj, -1, n); > > rte_ring_dequeue_zc_finish(r, n); > > } > > > > return n; > > } > > > > Thanks for looking into this. > > > > > > > >