From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DC17A04DD; Tue, 20 Oct 2020 11:16:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 485A5BC9A; Tue, 20 Oct 2020 11:08:00 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7BD6CAD2B for ; Tue, 20 Oct 2020 11:07:57 +0200 (CEST) IronPort-SDR: EaHQf8DiCsoeDYtu4ONkA8+NgfNcSYOEVgA68VbK1kALaJoUL2naSi6IqbsHZdIzkCjnw9L0PS 5bOfp4fUmA4Q== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="163688849" X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="163688849" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 02:07:55 -0700 IronPort-SDR: UBXKxoWscE0n42HCct2R55Pgy51XzEWB5y5pUoq4xxOLWzimG9pzEIYNWBxq3T4qYqebX5UHY5 kXBmEnEBacAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="315965477" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 20 Oct 2020 02:07:55 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 02:07:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 20 Oct 2020 02:07:54 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 20 Oct 2020 02:07:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OT6TJia0HwRpgJe94fsRst2MWRZ1jEtZMaliEUikvnVwQt78sZ5kRUl6ZiMzQmSqNdiP0Urbt1ohqJqUJqE1t1QTLZ+3+UsWY+wFysT3q6NdDJWwfiFxdGPQjepbp8yeQBqqLDwkqA16T2VTriQcBwFfZy6aWeDf0MSqDhbZ0WSOePshHYmFNt/i7VKATvqwIU2thBTFeNbc542jSNyqsXBgeQkx/bZheKuNTDQZpKzWSqwTtx9S0gvEbLV3AGsb9QCz0j63KAdn7zTILTiKr093E8oNm8VIy8Jm6H2bYyQ0p0t36OHX+ZdCZcVfCzNn0bGlqIrdP6+CcAjHH6oetQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pm7hI0LY1L67FEIUYeikhUo/Nkwz5gP0UvYH7TV4uLE=; b=h7eYLDIzakWEd6XFmapM3YYsXFohCQaROHnMKQMUBamvUC/2CRNNjWBGVFl4xrq2FLtaIJsWz+tRkHi1bPywAUUqve2udF1PHFI37zae4cIzJVjKXHsPy2M5APXtHoW7zjvXv8HEzCOmhTQFRlGA40ghwPJHVwRYXBtof1AzQf3g5fQs9D+2A9mJnCb6lrcSIJEMAY4uQolGGfREEKzgSWEwBE0sueTytVs0dYXndh2rJ81tSVGow9LBBeUkvatlD8IqcT+0OgbIOh7uCo4hy21uLz0OEwrZhD1d2ZerJtnkhF5upCjnprgSUr2MvExxWcZx1xORTswHPpCKHJjy8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pm7hI0LY1L67FEIUYeikhUo/Nkwz5gP0UvYH7TV4uLE=; b=eXKgfBhteabh8BYxgmavbB5SyfaKOeCPBHnfkkkdB/9FzYOREw46uu70mAX37MSgqvXcC0nZqvN+KZAssBAkutOExcmk5yyBq8bWDvcaNj8e1DECWT+Gg/QWq0QvDDNDsmUPNMLtdun6R0DX0vem+URZkXPP9Q/MxXChpOuZKMI= Received: from DM5PR1101MB2121.namprd11.prod.outlook.com (2603:10b6:4:50::19) by DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.27; Tue, 20 Oct 2020 09:07:50 +0000 Received: from DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621]) by DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621%10]) with mapi id 15.20.3477.028; Tue, 20 Oct 2020 09:07:50 +0000 From: "Walsh, Conor" To: "Wang, Haiyue" , "Guo, Jia" , "Yigit, Ferruh" , "Awal, Mohammad Abdul" , "Doherty, Declan" CC: "dev@dpdk.org" Thread-Topic: [PATCH 1/2] net/ixgbe: fix unchecked return value Thread-Index: AQHWphMaEJlb37i08UmAXMdkRU5kcKmgK1YAgAAJIkA= Date: Tue, 20 Oct 2020 09:07:49 +0000 Message-ID: References: <20201019122620.749625-1-conor.walsh@intel.com> <20201019122620.749625-2-conor.walsh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.79.3.61] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 31bb934a-1e2d-4d4e-4b0a-08d874d79ead x-ms-traffictypediagnostic: DM6PR11MB4425: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Bjli1Divf0tVBj5Va4wccJDLmAZ2PwXeWzEJ47YH6QnZ0VfwHSQrJwCVeX2ovGDz3hlQALg2jf8RAKUnZ5fzQr3RtTS7MX5M3bFOBgLtcED775ypy++kaoLfEMUbHER2CqhKFWxjRLQKbF3KTWir4Fm/M9Ewqo9fvtrMIZtBLRet+sfQh8ja/Q1XWOBRtyfMZowT1JTVjiQ2SPDxhr9kEcpxaz7iM2dFDPLXBu7y1TU6fOgXLsHUDMdMeM5Su7YHLKFLvfHSp58ia35/pQDxKHtgQ3x9L/o68guELPZmKwXFoA/QTlr3JUG/V5k/oRMepLpkpx3ee7Z5pIUnWDwZ8Qk7/GAF6iOLYAK6mfy0zHjhbqb9+b5HhBoOQjfYmh30 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2121.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(39860400002)(346002)(376002)(66946007)(7696005)(6506007)(66446008)(76116006)(64756008)(66476007)(26005)(55016002)(6636002)(8936002)(186003)(4326008)(53546011)(66556008)(9686003)(478600001)(316002)(8676002)(86362001)(5660300002)(52536014)(71200400001)(2906002)(33656002)(83380400001)(110136005)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: j4wYgEaPKfAQ3gMXdfTpWL39JV67fobuF9ztyEfLjp0zCK1jRN7sBclJSrAmrs2XlYn1BHxSuge44VG8VeztlTNqbHu5z7Rt7fguPy4Mh7yr5PifxTlstpK7m1JuKgxa1+NHq2ozjZq7v91HWvwWC8pGfwED2GfNAuZVvstTM/QGQ/8eFdN5MIbYVoT2JiGMUtjCJCUBHZh8KPAMY9yoGTYdqxMjOzhlSfj1+1y3hzizVsegsw4ToNHFeJ8069zBuoraz+NcZU4GzEUI9eZ+rYRVzZYCIqY3Scmdz7d0FlbynHD7aMquZBmOSRNm4SvItq0RBiE5pG0fUaiEtJAOnaEAQ4LSLtrsQ69TkMhRTXIk+Sl8PsmZtYj3msRZhRircnf75McK/XGSVniTdxIitTLonehhFpL37TE6bYeh6MmpRId4WNONr5fl1LUYo1+0JnPisz1Bml1EaTG4gE3uxMLEWc5SyNyMUzEVupW9BJ2+8oHA2GYeoKnUAjf4gxX7EzVjZwBGb98xAcMGaFSgNYRk9n1D3+gVXUJ3LMZJOqjYIcfFkoyTPy7PdyXdfFPXAvychXSiV1ecy8Z9SJj8XgBVgBghrtRvv4GKj3ccia63PAh4+6yeUZWd2oXJCOXDX3AoaecsiaVvuRbYABwxsg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2121.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31bb934a-1e2d-4d4e-4b0a-08d874d79ead X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 09:07:50.0503 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vHvfmqEtZ222SgyPmmDj1kN5lC0EBX1Cr1JYYi3s4q6tCUjr1kVSeazCK/UjlKLoUuzFpgm2EtUd1ANVXAhalg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4425 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Haiyue, I will implement a v2, following your suggestions. /Conor. > -----Original Message----- > From: Wang, Haiyue > Sent: Tuesday 20 October 2020 09:34 > To: Walsh, Conor ; Guo, Jia ; > Yigit, Ferruh ; Awal, Mohammad Abdul > ; Doherty, Declan > > Cc: dev@dpdk.org > Subject: RE: [PATCH 1/2] net/ixgbe: fix unchecked return value >=20 > > -----Original Message----- > > From: Walsh, Conor > > Sent: Monday, October 19, 2020 20:26 > > To: Guo, Jia ; Wang, Haiyue > ; Yigit, Ferruh > > ; Awal, Mohammad Abdul > ; Doherty, Declan > > > > Cc: dev@dpdk.org; Walsh, Conor > > Subject: [PATCH 1/2] net/ixgbe: fix unchecked return value > > > > The return value of rte_eth_switch_domain_alloc() was not being checked > > within ixgbe_pf_host_init() which caused a coverity issue. If the call > > fails a warning is logged using PMD_INIT_LOG() and *vfinfo is free'd. > > ixgbe_pf_host_init() now has a return value which is checked in > > eth_ixgbe_dev_init() > > > > Coverity issue: 362795 > > Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") > > > > Signed-off-by: Conor Walsh > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++-- > > drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- > > drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- > > 3 files changed, 18 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 14a254ab74..49ff523ea8 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -1077,7 +1077,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev > *eth_dev, void *init_params __rte_unused) > > IXGBE_DEV_PRIVATE_TO_BW_CONF(eth_dev->data- > >dev_private); > > uint32_t ctrl_ext; > > uint16_t csum; > > - int diag, i; > > + int diag, i, ret; > > > > PMD_INIT_FUNC_TRACE(); > > > > @@ -1256,7 +1256,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev > *eth_dev, void *init_params __rte_unused) > > memset(hwstrip, 0, sizeof(*hwstrip)); > > > > /* initialize PF if max_vfs not zero */ > > - ixgbe_pf_host_init(eth_dev); > > + ret =3D ixgbe_pf_host_init(eth_dev); > > + if (ret) > > + return ret; > > >=20 > Seems that just return is not enough, the eth_dev->data->mac_addrs and > eth_dev->data->hash_mac_addrs > also needs to be freed, please refer to ' ice_dev_init': >=20 > static int > ice_dev_init(struct rte_eth_dev *dev) >=20 > rte_free(dev->data->mac_addrs); > dev->data->mac_addrs =3D NULL; >=20 >=20 > > -- > > 2.25.1