From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8173BA052A; Thu, 26 Nov 2020 14:56:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 034EDC93E; Thu, 26 Nov 2020 14:56:54 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4BC20C93A; Thu, 26 Nov 2020 14:56:51 +0100 (CET) IronPort-SDR: uO16p+qJFEiXc8qqsOklPPLqNxvxWBKOP1V/2YR3digLCsYrv4SGZa8rgx1qY3D3UMGhsfzk8n 0mQrz4la59SQ== X-IronPort-AV: E=McAfee;i="6000,8403,9816"; a="256995508" X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="256995508" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2020 05:56:50 -0800 IronPort-SDR: 8P/rI38CinnQzhZi/5I1/NpxcGVpLAt2feyDAkqlA/MZsNt8I8gNV7NBa54XYStPkm4xk8d5ro FfFXM+2qoXPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="365825940" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 26 Nov 2020 05:56:50 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 26 Nov 2020 05:56:50 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 26 Nov 2020 05:56:50 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 26 Nov 2020 05:56:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D4xO9qqBwaMewktaofY9kymD41JWOXqm/ZCDA0+YuLOvwf0qKgCQKZUME0GSo7HVlHXPX9I2R8orlujq/77ikGKS439bpMFncKN9rgfsC0R7MnNsZZ++iFEAAKjGFqsPOpLT5CR8zKhcKNsBd+y8E4oDlw1DKhDB13nfu0W/zWZIdxhiACtI/jeUWb6phiL3QjEMqj17oFvFonhRg3VMxzb1yj3IzomAqvbDcP/oH5/IxJ9EV9FrxbEPFvE2/1ANXwZ2oa6m+qylT+2/yw8GHSP4me38ptj21WvfRVNdkuhyK8kiKVl6jiqXhrhZb3SczohAlj+IFUzt/E3WLq7GPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/FRTSZekcFusidzBSjDoiBd+d24IUjVBos2tl5essvo=; b=V08p019vkoy1ETVftQOH2dQOTRMW0M+3yvHAl+9Y0ySPWiDQB/gO4uwYVszpPBG4X/Wuj8r8fWgWMDPRkJRyjKweZaaAuMNVq+fJgCo8tgYNSbxjTpq/uPFmopgPNl0nVpzu7PBriE7/8yNVkCSczjkCgAA7PFPUopv+uj3JE1RhHePKlJO4x/HjeonvWP/Mbf0hxecjKf4vjX4w2HvpYftLUUPAQGGFVGXfQCi9ygsV3swxpkvbZ70si5K0OVVTF1zICuv3roxNqXkTgRnM2ulUH9AZ+ZcxZQU+xOdIBQSyAgAnlRwOnfQPIBTgyFCz+qoFJme8aDxitfxFq0VzIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/FRTSZekcFusidzBSjDoiBd+d24IUjVBos2tl5essvo=; b=rMv9vEBdBepBriRYhJABiWJvN50MQ5l0t9Lfg+iGo+HfpGSdmKLmpKIe/fpwDH5gJykzsMVuzdxxgJZU6bk4sXuy/vyrY042AEzlJ7K7jphiLbFZvzowiPNc9weaa1F7yJyPsCgMjx91EN04UzvPD7uCP8znCJH/Es+uPeEz0WU= Received: from DM5PR1101MB2121.namprd11.prod.outlook.com (2603:10b6:4:50::19) by DM5PR1101MB2122.namprd11.prod.outlook.com (2603:10b6:4:54::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.20; Thu, 26 Nov 2020 13:56:47 +0000 Received: from DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621]) by DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621%10]) with mapi id 15.20.3611.022; Thu, 26 Nov 2020 13:56:47 +0000 From: "Walsh, Conor" To: "Yigit, Ferruh" , Thomas Monjalon CC: "Yigit, Ferruh" , "dev@dpdk.org" , "techboard@dpdk.org" , Stephen Hemminger , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 1/6] usertools/setup: remove make based build Thread-Index: AQHWw2AFdpG+WwxpwEyxkv8t84TEX6naaO/Q Date: Thu, 26 Nov 2020 13:56:46 +0000 Message-ID: References: <20201125191908.1867106-1-ferruh.yigit@intel.com> <20201125191908.1867106-2-ferruh.yigit@intel.com> In-Reply-To: <20201125191908.1867106-2-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.70.33] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bda61251-2853-489a-afce-08d892131d99 x-ms-traffictypediagnostic: DM5PR1101MB2122: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cKUB/BmlvhQT7Rc5vMNekPDL+UW7RQX8hsEt8aekTF6rU2USMzhPiZJ3VsqRnBc/husdZmZygVPg8AnRS6EDLTDnfRy/UAyk1I9isz2x2ihOyg1wraPgnDu8ZQYbkFbMlGdRLZh0KhA2awPaWbhM0xSbfphXo8wXXI56IPT5RTMJnBGtstbYCnBV4QFvhTQWDwF4pe9oqahwjGsqElMzT86YOKkYa+Lxs5VJAM7JvMCsvRn4g0/y7JhaO+1ozhfSdmwfr5zw7Ymsa0nltGlSHlCoe6DmzWjli0fLt2oW+tpI+5thzsnpdWYeBcY8Sp5/to2UvMroS5Qxr+qyzTItuA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2121.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(366004)(39860400002)(136003)(86362001)(5660300002)(7696005)(478600001)(53546011)(54906003)(6506007)(26005)(186003)(4326008)(110136005)(107886003)(52536014)(55016002)(316002)(71200400001)(8676002)(76116006)(9686003)(33656002)(83380400001)(66476007)(2906002)(66946007)(64756008)(66446008)(66556008)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?OzbekIiP189o7PzfZSz6OlB+PLeLPEpLu/p3yKsEh4wE2Ph5k+kLjDudbAYK?= =?us-ascii?Q?kAkKugD6IY7B5W+CqpI+suXMQ7cZezDdHxDQZq854jHFVqTgR04jlAjqeE1A?= =?us-ascii?Q?QSL8MgUBPfka/ip3IgXGZ5ayuYzP5QCzisIicJyAw4mMVUGIn5jgJyEYjUhe?= =?us-ascii?Q?6w8AqTR6Ec64aMgAPtiUDcxpWRX2Ih4tJVPPDEB/vXBVU5o0Tbhw0kcS68ir?= =?us-ascii?Q?oELi1y9jMIiaqh56LPOV3CL7PQ0LI8/X1SNxUlujAPnRvBPyp1/cpCM3vBOD?= =?us-ascii?Q?3q8kc1VNoXIVP/1ukDhDcnZh76pO/VtS5bPatiloVd8IJ51Lgm8sYptqKYoI?= =?us-ascii?Q?KBtN0/a1EYeDqTpWcE5aNvsUeeAYpnBDTQtGRHgmyA7YADorl7kRUjbvdHA1?= =?us-ascii?Q?O+kbiTuuX2tILKPF/XYW51K1dQ0ZYRlSF+jzym5AZWTwwdZvyhsyafqL9Lmc?= =?us-ascii?Q?WRbNn3dBlTrUfWJgrtHugpJQfxP0jAEH7A3vRb3xIpdzQV+LJB9Ptm+Z/wt4?= =?us-ascii?Q?v52jc/Kp4b5Sq2h0QCKnfucV41Grzs9Udj6YS1213eO7q/Nbz1/wGkVoaQGS?= =?us-ascii?Q?BAJET3YLtSHNn7c/IsiORipX0SeViMI3Jhl/Ti1i5NF7ahddibBGrzlQ+0Fs?= =?us-ascii?Q?3pnlgrkbvsPZCxR81oc0P+dI/J9D7wrSUJKGHYIQaEXi3pEQJDT05ws1ReTs?= =?us-ascii?Q?szIYa0+EAjRs8xjYa08aH0qMLf2Ufo6AzMfRumRDAEsCxyGDpuK1Mvr7YPY1?= =?us-ascii?Q?IsuhI5UMKwCBULC0eftusO43Dymkj4v1UstPvLkgbgH38mcUZbGIOKjVfrQ2?= =?us-ascii?Q?i9iKxbr+VS/YFrJMAEmngsCaucA9fuD9wFWxgQXn+Ijx8/Z4J4a9CmB0FHAt?= =?us-ascii?Q?gseQRgMwrt/elEqgDRZa5IuFt0pE4DIEjpfE3/Gz16T5nXIGgVvd+5A4ONiO?= =?us-ascii?Q?ZtYOem9EeFrhI6DiI4oR+DC3S/dCt27mxCNOtnMFBko=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2121.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bda61251-2853-489a-afce-08d892131d99 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2020 13:56:47.0460 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7AwFsHtmyGq8io0p3A4IJjfRbHOTCb9lIafAnZNL4kaYqhx9FOrA4VmluyoIjKLh4Q7pyh7nQv6LQz3HjkkbSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2122 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/6] usertools/setup: remove make based build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, Patch tested. Thanks, Conor. > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techboard@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH 1/6] usertools/setup: remove make based build >=20 > DPDK build system is switched to 'meson' based build, please check the > documentation for details: "doc/guides/linux_gsg/build_dpdk.rst" >=20 > Signed-off-by: Ferruh Yigit Tested-by: Conor Walsh > --- > usertools/dpdk-setup.sh | 74 +++-------------------------------------- > 1 file changed, 4 insertions(+), 70 deletions(-) >=20 > diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh > index 411bf2e07f5e..d1eb188692a6 100755 > --- a/usertools/dpdk-setup.sh > +++ b/usertools/dpdk-setup.sh > @@ -36,53 +36,6 @@ q() > quit > } >=20 > -# > -# Sets up environmental variables for ICC. > -# > -setup_icc() > -{ > - DEFAULT_PATH=3D/opt/intel/bin/iccvars.sh > - param=3D$1 > - shpath=3D`which iccvars.sh 2> /dev/null` > - if [ $? -eq 0 ] ; then > - echo "Loading iccvars.sh from $shpath for $param" > - source $shpath $param > - elif [ -f $DEFAULT_PATH ] ; then > - echo "Loading iccvars.sh from $DEFAULT_PATH for $param" > - source $DEFAULT_PATH $param > - else > - echo "## ERROR: cannot find 'iccvars.sh' script to set up ICC." > - echo "## To fix, please add the directory that contains" > - echo "## iccvars.sh to your 'PATH' environment variable." > - quit > - fi > -} > - > -# > -# Sets RTE_TARGET and does a "make install". > -# > -setup_target() > -{ > - option=3D$1 > - export RTE_TARGET=3D${TARGETS[option]} > - > - compiler=3D${RTE_TARGET##*-} > - if [ "$compiler" =3D=3D "icc" ] ; then > - platform=3D${RTE_TARGET%%-*} > - if [ "$platform" =3D=3D "x86_64" ] ; then > - setup_icc intel64 > - else > - setup_icc ia32 > - fi > - fi > - if [ "$QUIT" =3D=3D "0" ] ; then > - make install T=3D${RTE_TARGET} > - fi > - echo "-----------------------------------------------------------------= ----------- > --" > - echo " RTE_TARGET exported as $RTE_TARGET" > - echo "-----------------------------------------------------------------= ----------- > --" > -} > - > # > # Creates hugepage filesystem. > # > @@ -456,28 +409,10 @@ unbind_devices() > sudo ${RTE_SDK}/usertools/dpdk-devbind.py -b $DRV $PCI_PATH > && echo "OK" > } >=20 > -# > -# Options for building a target. Note that this step MUST be first as it= sets > -# up TARGETS[] starting from 1, and this is accessed in setup_target usi= ng > the > -# user entered option. > -# > -step1_func() > -{ > - TITLE=3D"Select the DPDK environment to build" > - CONFIG_NUM=3D1 > - for cfg in config/defconfig_* ; do > - cfg=3D${cfg/config\/defconfig_/} > - TEXT[$CONFIG_NUM]=3D"$cfg" > - TARGETS[$CONFIG_NUM]=3D$cfg > - FUNC[$CONFIG_NUM]=3D"setup_target" > - let "CONFIG_NUM+=3D1" > - done > -} > - > # > # Options for setting up environment. > # > -step2_func() > +step1_func() > { > TITLE=3D"Setup linux environment" >=20 > @@ -512,7 +447,7 @@ step2_func() > # > # Options for running applications. > # > -step3_func() > +step2_func() > { > TITLE=3D"Run test application for linux environment" >=20 > @@ -526,7 +461,7 @@ step3_func() > # > # Other options > # > -step4_func() > +step3_func() > { > TITLE=3D"Other tools" >=20 > @@ -538,7 +473,7 @@ step4_func() > # > # Options for cleaning up the system > # > -step5_func() > +step4_func() > { > TITLE=3D"Uninstall and system cleanup" >=20 > @@ -562,7 +497,6 @@ STEPS[1]=3D"step1_func" > STEPS[2]=3D"step2_func" > STEPS[3]=3D"step3_func" > STEPS[4]=3D"step4_func" > -STEPS[5]=3D"step5_func" >=20 > QUIT=3D0 >=20 > -- > 2.26.2