From: "Walsh, Conor" <conor.walsh@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Chen, LingliX" <linglix.chen@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] build: add Wformat to fix gcc compile error
Date: Fri, 13 Nov 2020 13:54:54 +0000 [thread overview]
Message-ID: <DM5PR1101MB2121EB257D2CF2E1F4F0E7E3FFE60@DM5PR1101MB2121.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3386665.RJkdAoTnaa@thomas>
Thanks for your reply Thomas, that's no problem.
I will expand the explanation for this patch when I push a v2,
v2 will hopefully also address the issues it caused with the icc build.
/Conor
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday 12 November 2020 18:47
> To: Walsh, Conor <conor.walsh@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Chen,
> LingliX <linglix.chen@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1] build: add Wformat to fix gcc compile
> error
>
> 12/11/2020 12:35, Conor Walsh:
> > On some systems Wformat-nonliteral and Wformat-security could not be
> > checked without Wformat also being specified. This patch adds Wformat
> > to config/meson.build
> >
> > Signed-off-by: Conor Walsh <conor.walsh@intel.com>
>
> Please could you provide (in a v2) more informations about the error
> and why the fix is needed?
>
>
next prev parent reply other threads:[~2020-11-13 13:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 11:35 Conor Walsh
2020-11-12 18:47 ` Thomas Monjalon
2020-11-13 13:54 ` Walsh, Conor [this message]
2020-11-13 3:39 ` Chen, LingliX
2020-11-18 18:11 ` [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes Conor Walsh
2020-11-18 18:11 ` [dpdk-dev] [PATCH v2 1/2] build: fix gcc compile warnings by adding wformat Conor Walsh
2020-11-18 18:11 ` [dpdk-dev] [PATCH v2 2/2] net/bnxt: fix format characters for unsigned values Conor Walsh
2020-11-18 18:37 ` [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes Luca Boccassi
2020-11-19 10:24 ` Walsh, Conor
2020-11-19 10:16 ` [dpdk-dev] [PATCH v3 " Conor Walsh
2020-11-19 10:16 ` [dpdk-dev] [PATCH v3 1/2] build: fix gcc compile warnings by adding wformat Conor Walsh
2020-11-20 7:23 ` Chen, LingliX
2020-11-19 10:17 ` [dpdk-dev] [PATCH v3 2/2] net/bnxt: fix format characters for unsigned values Conor Walsh
2020-11-19 23:12 ` Ajit Khaparde
2020-11-22 20:07 ` [dpdk-dev] [dpdk-stable] [PATCH v3 0/2] build: add Wformat to fix gcc compile warnings and format fixes Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR1101MB2121EB257D2CF2E1F4F0E7E3FFE60@DM5PR1101MB2121.namprd11.prod.outlook.com \
--to=conor.walsh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=linglix.chen@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).