From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 976D8A052B; Fri, 31 Jul 2020 13:41:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12A95276C; Fri, 31 Jul 2020 13:41:28 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D34FD2629 for ; Fri, 31 Jul 2020 13:41:25 +0200 (CEST) IronPort-SDR: 8iNrtcEPvuOeBPDltDWZabaGmG3oCu3Az4Nfo+AKSBn7OgKJN+P9UTaMCO9qcHJ6xBTSOgM4/9 CL6fBZIvKWbQ== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="149587925" X-IronPort-AV: E=Sophos;i="5.75,418,1589266800"; d="scan'208";a="149587925" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2020 04:41:21 -0700 IronPort-SDR: wZkEbiSjsLTW+9VHKJeKIxM9KE8vP3xxBwCkQtGiXpv7yyo7ND0CDU9OWwZzD4M8fD5GAexbnz bgxAYvhCtEgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,418,1589266800"; d="scan'208";a="331041690" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 31 Jul 2020 04:41:20 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 31 Jul 2020 04:41:20 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 31 Jul 2020 04:41:19 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 31 Jul 2020 04:41:19 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 31 Jul 2020 04:41:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XeVkwbet/7azLUV6Tq+nIjpoZD0HfAStErg6zko57GQUIr2oiOzFKtbDSLfqH7B5NmyUFrvTtF0HiJstoeYhGm3zGm3vxpq9gcSbIkHT1vhbgGdPe+QJQW6Jy3aAnRwv6Vvat6KtM5OyGSQy14OoDNVzwmZ01AfN7BtbuDg/y6P9Z/ThIXb0G1p4fy/n/QyoxDYpNdcKG+7wW49Ya7BxHDrk9W1nbmlHkVnvBl1Xb1MZnjDxrnsZCUcRvL5fCjsUZBZk0sZBlHewzjoX/uCiOl+9vb3nYjALM/o2PBey4LNAjfEC3x+Nx3N3kd9S1VC5FMXOKiTxuBPm9uHZTY2b9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uaY5JXJyrUwOITDQOWWw1ckT/OC/iJV3oL67PUG78cw=; b=bAFt3nAeqbnqkjmqssPIQQW68uSczTgGFsc+WA0kZV5wxwdlKKojXhwSWgppGOPAo6uo7V4lZveBdXea6WcvcUdh/PD8ajUOCdysdg8t22y+0mrj5gIeS8CJPtUJjlnPYFspfg9Qx/u8rx1lkVr5wyx474RKCZQj/g99CVzB5f7PVG1ypSUEZnC2o5WWa7bH/RfjY6Nqz3T/yP6kOhAq0T+bMF/ggfYLnBhS2pojJxcmxXbVzWjZP3znP2aToKJTei155qb8EVYhpubJ/G2zHXas8hs8Y6MMkpvO2LP1An45hkou70+OEIspmyWX+yWxX8Zrtb+TktSetw6ptKlaiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uaY5JXJyrUwOITDQOWWw1ckT/OC/iJV3oL67PUG78cw=; b=Efs8uzYdnUj5N40EW42020JDumJbkrRrvCgyqbytOEAAWtubj0uWU1lwQZ3lxDuiXnxAyvvQggF79nJitvIkezeTaEz6qWYOxY/8TrhPoAp6CkYzuePFRHfgNTTylkPsOfd+vVxgEM8jJaqo0yVEETOWhhVbFJeYTL7NuuK+6pY= Received: from DM5PR1101MB2169.namprd11.prod.outlook.com (2603:10b6:4:51::14) by DM5PR11MB1754.namprd11.prod.outlook.com (2603:10b6:3:10a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Fri, 31 Jul 2020 11:41:04 +0000 Received: from DM5PR1101MB2169.namprd11.prod.outlook.com ([fe80::d96a:61:33a9:9036]) by DM5PR1101MB2169.namprd11.prod.outlook.com ([fe80::d96a:61:33a9:9036%12]) with mapi id 15.20.3216.034; Fri, 31 Jul 2020 11:41:04 +0000 From: "Fu, Patrick" To: Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" , "maxime.coquelin@redhat.com" , "Richardson, Bruce" , "Wang, Zhihong" , "Wang, Liang-min" , "Ananyev, Konstantin" , "Miskell, Timothy" , "Liang, Cunming" , "arybchenko@solarflare.com" , Jiawei Wang , "orika@mellanox.com" Thread-Topic: [dpdk-dev] [RFC] lib: introduce traffic mirroring API Thread-Index: AQHWZiF3IJZ9qRZiv0KvK1buvU246Kkfqj0AgAFLa+CAAHjyAIAAA3zg Date: Fri, 31 Jul 2020 11:41:04 +0000 Message-ID: References: <20200730032332.3742259-1-patrick.fu@intel.com> <9050775.XvCxKblxuy@thomas> <3630698.8D1TQZSjJl@thomas> In-Reply-To: <3630698.8D1TQZSjJl@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.207] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b036fad-99d6-4c33-ab64-08d835469b9d x-ms-traffictypediagnostic: DM5PR11MB1754: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lrh036yBwhN70ubY5k2TqM6bfbHLEW1IfxwLpjyMjLDHYapo10sG/Vox+DdfMXgA9fT9eBuVEh2A1aFDVU4GJeGhr3WQf2mnruLVrG1br4nL9e69KzlY25CDdrL2QQXF5XJkJeN0oO2TWVB4zK2Qj97VqeHOXawltrVYc06Abh0WVzVqoqGFqMjEGhDk/ZP7AqvV15HSpYRtKcOgDkjZlMrXv0fMiMGm/XXrfTwAmMTOj3cNXsFiJkg9J6eecZv6DjTUuLHDuxW4Nx09VV1tDOfBmw5jACF8JJ6AtYfqoKTiYsaMyq5+rPuIGGuKVTiZh5rwzUxBnmzbv95fZ35SejPSuxXMuUOB1bD0WeiIq9DgX40njRwb6dtC/yIlSTuQAWcJe69j49IPbxlM0eaDjQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2169.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(366004)(396003)(136003)(376002)(39860400002)(6506007)(7696005)(26005)(53546011)(55016002)(83380400001)(9686003)(6916009)(316002)(2906002)(33656002)(186003)(71200400001)(54906003)(66556008)(64756008)(966005)(66946007)(5660300002)(478600001)(86362001)(52536014)(76116006)(66476007)(66446008)(8676002)(8936002)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: HQ4N5OrJyr00LrNA11HupE7vSOQ7WzLM8ZSwunW7G3ydeLHokBZj2es9MZ6nfRFYOFtVQOUugdA6nboRUXddN2ODxTjKY1rmBkf1Zm8jWHlQT3UcF4JuNM6WlM2DZSAWAN81Mrc8NeRrr7e577SJEwuX3tKipV8AkofICy4MUz+DLdO9vq6Q2wRf8OC+0gQhc6tszLseOFAzkL/ErvLWFtxp7e1nU99ZLEF8NNzJj6NwX/FNKMMhT3YQz7K60F/vY7Ekqpuh7BVW4ANcvOR2asJd2JIQzuBo1c+ZxclFR6MMi+EQ1Er8fZ9NRA7Zk7Bl9k9fF0mlwQXQQ9FgDvZxtWZJZT3bjmx3CqcvU1N5sXLijAmQcCdG7MMiwsG8aZDb+EQtAb5bXn/xTCaKz6MDvccv57bRoHlbZtPNik/3P7nhIwEQUuOpvli7Q+1IvJlG8l459gtayk3hRJVphEtc82nggjzXdnx4LdUSh0+ovjAzoTCzKozW/8Gm3nOqClhR Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2169.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b036fad-99d6-4c33-ab64-08d835469b9d X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2020 11:41:04.5240 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zt/tk3scYYoSx43R6UuJp3ERxuA2JR9PIp8IziZBZ9vxaXg9m7FYxodSOjGEJYMiJwDNhGWvOPRVd7dEQl29Hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1754 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, July 31, 2020 5:32 PM > To: Fu, Patrick > Cc: dev@dpdk.org; Yigit, Ferruh ; > maxime.coquelin@redhat.com; Richardson, Bruce > ; Wang, Zhihong ; > Wang, Liang-min ; Ananyev, Konstantin > ; Miskell, Timothy > ; Liang, Cunming ; > arybchenko@solarflare.com; Jiawei Wang ; > orika@mellanox.com > Subject: Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API >=20 > 31/07/2020 04:34, Fu, Patrick: > > Hi Thomas, > > > > From: Thomas Monjalon > > > > > > I assume you consider deprecating rte_eth_mirror_rule_set() > > > > http://doc.dpdk.org/api/rte__ethdev_8h.html#a1c88c5e86f0358981443600 > > > f > > > 05069091 > > > > > Not exactly. > > The rte_eth_mirror_rule_set() is vendor-dependent API which allows > admin to configure two components (traffic source and traffic destination= ) of > the same NIC so packets can be copied from traffic source to traffic > destination through hardware. The API allows vendor to implement this > function via hardware-dependent offloading capability. In contrast, this = RFC > is proposing two high-level APIs (vendor independent) to allow admin > configuring mirror traffic from device A to device B where device A and B= may > come from different vendors. In particular, our initial target is on soft= ware > virtual devices such as virtio/vhost where there is no mirror hw support. > > > > > Please consider reviewing this implementation in rte_flow: > > > https://patches.dpdk.org/patch/73279/ > > > > > For the same reason explained, this patch is also targeting at differen= t use > cases with our RFC. >=20 > We should not have different API depending on the device. > Please look how to unify in a single API. >=20 I believe the proposed APIs work on a different abstraction level than exis= ting APIs.=20 But we can look into the possibility if they could be unified. So in general, do you think it's a right direction that we add common frame= work in DPDK to support cross devices traffic and vdev devices traffic mirroring= ? Thanks, Patrick