From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B7A8A0093; Tue, 19 May 2020 09:03:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8DF21D446; Tue, 19 May 2020 09:03:18 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 17C291D427; Tue, 19 May 2020 09:03:16 +0200 (CEST) IronPort-SDR: s5j76LwQzLmliCCB6ywNW0HAhqqbDIKmGZycIhuV0KP2wQE5MXNnrbvMjZ97RjOp2fgkpzw3oz Pq/yruIw3CgQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 00:03:16 -0700 IronPort-SDR: S+JIdbnoKLGKMR4kPWbzAtL8Bhi6ds8INiqRNG9GjwZ+oqELZpLvg8mR4cENgHvjTmqau+ZP0m eVRh6EU2zNyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,409,1583222400"; d="scan'208";a="373638239" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 19 May 2020 00:03:16 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 00:03:16 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 May 2020 00:03:15 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 19 May 2020 00:03:15 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 00:03:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cFpFH+3/n3SdIfloVCfmrsK1uUBAOwuLxWIN2n28HzyiuSHVMYcbLSQfLM9IICFn/DlFjPbWonXXWgY2b+/kG0vHcI6xhinVrpEWkVpEv4HM/D8cb7CqB3PXsLWAaIbJJYjukapA2MpG+DBQzK0tFJz55xai6PLEtWO0AdbO4N+qgi2tAoWfcmIo7C1Li6PZU5TVW/WkpKKwYVMU/9NdS/3Fa6dFRZC365+vi9ff2wenuIrYlgxvyxmm4XL8NF4CQ67tjglwM7w0xl4uKov+NuVaVSWnG1i3yoW57F4PfLy/mjCw8Q0eOtokb6oUlIELB4NwbkfcLPP1pnhtWJj8jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5E0xkg3Ok5+bwC4iBlcS3OhjrGf6He9Zeblc7gE3gQw=; b=AFINjOBs7/lQbcrDcBm/WWoOQU/Qw3YmyvK2dcZqYXgD5PeWxe51BBwZXh4Xx0xFMUmrL4vy0xscHMgf0LRr5vjGBgHM2yrCYIf6HhWTSmQRvYeDS7Kwlg/Y3HypHHpXwHv4wM8CNnfS7w/Owue3umrVzWNabxunaTZTKba5PcBryiG02SgdhKRPbjnRnjv5k646HnobQlfmiCMDCLt7hfu7RUw3jBGvW8uXF3I6tkCDT1pA1PA0526tw71WCkoBHtRQSaBvjP6DH+lBoT8LyAMHIqnh6sLWJBYVNiZOef3jN6fzqqqUnYZRYonkJ3SOnMtprvZiHDoFBbrFN4RcGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5E0xkg3Ok5+bwC4iBlcS3OhjrGf6He9Zeblc7gE3gQw=; b=J1wBLib7kn3ZguulqEvI8WHNs+wlgIwAUfBJnWE/caekUiBn0/XK2pueuAWR+0up450xGRyCGJHEG76t3raKsGNkEpAqphctyDwURGrzZj0hS/DqX5nVPPMJhkJr9/a3ws6K+PiQQvvSFia28/GOdMzNeDUJrYXFhIsgu3ODJcA= Received: from DM5PR11MB1388.namprd11.prod.outlook.com (2603:10b6:3:12::12) by DM5PR11MB0074.namprd11.prod.outlook.com (2603:10b6:4:69::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Tue, 19 May 2020 07:03:09 +0000 Received: from DM5PR11MB1388.namprd11.prod.outlook.com ([fe80::f9c2:a5b5:322d:6385]) by DM5PR11MB1388.namprd11.prod.outlook.com ([fe80::f9c2:a5b5:322d:6385%9]) with mapi id 15.20.3000.034; Tue, 19 May 2020 07:03:09 +0000 From: "Wang, Yinan" To: "Ding, Xuan" , "maxime.coquelin@redhat.com" , "Wang, Zhihong" , "Ye, Xiaolong" CC: "dev@dpdk.org" , "Ding, Xuan" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled Thread-Index: AQHWKMxbA3v6qzSU4kCOywQg+ebpSqiu/sVw Date: Tue, 19 May 2020 07:03:09 +0000 Message-ID: References: <20200512095155.98708-1-xuan.ding@intel.com> <20200513021410.98031-1-xuan.ding@intel.com> In-Reply-To: <20200513021410.98031-1-xuan.ding@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f898467-691a-4fab-fc6c-08d7fbc2b013 x-ms-traffictypediagnostic: DM5PR11MB0074: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1850; x-forefront-prvs: 040866B734 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MmNx7H+tmVkbbEMrD3zLW9lQ6GoKLcVixqUSBr9MJpgES+VJcK5BRegVJrU3vpvc0HwybhxNaj50r2BojmEx06WFM2kX8i+zJjv/1czY54L48WGS54kOqly8hu/VlZo1//q/UOYkFUG/+YeqFeEDIxfL827V04JvCIQ6fo+MqgvPVTliZ2dGdoYVUylCim/KBx/W8aruU5HmcGKahzVkxnkA6zO6LnxuyDwifaDpY96JvzAl5A55JSKrmfQR1OEQE5OPHH9aSb5Ln2VvLXOe56Trvlu2c9hZNRw6Wmcwkh3j8tRNG91w3y3mc7JYHlJ4ArqwX1CcgvSuMt6rHMPMCv7RwifVqxBMl/FZoxNc1L89+DC8iZtPzsYVLVUVkrGHDqaDGB/psdUK9oSmv1Vudd4j4UqXxmj1C8tniUzNspAd83bf/OERkN674d/mwEwd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1388.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(366004)(376002)(346002)(136003)(39860400002)(26005)(86362001)(55016002)(7696005)(478600001)(54906003)(316002)(52536014)(186003)(110136005)(71200400001)(8936002)(5660300002)(53546011)(33656002)(6506007)(2906002)(9686003)(6636002)(8676002)(66946007)(4326008)(66446008)(76116006)(64756008)(66556008)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: VmEqzWJ8MWPAEUcVd3pcj0EjrB1C2yqQDEm18+fEuhOSsdEeay3rs9vM195ELlAEpXyg067U3Q5D/qvyxkBxbs5oScrfYhoYJkqinxLBReIwgzQurFNvLMxBDeSCoLlur1xZ/YPATINsn4efQOo5xdp5FYU4yFqBBVe9EEoBohEok0OSd0BbC8fQkRsCc7NEKpwljCRgCotHUwBVRGaigx8SpWHOKKps0tZ2eDMAXrjYFoTPNAkNLphUA1ePlcU3S5Lxp2Dge+TCFySa/Zu0fgKCOWa5HLqO0xZaUlXKL2e0RYIYM3L5cJYhpemzC8zIRoSOvo/2XhOKeHVJ0Jp1aMcFxuxtnUckBrJXSInbLuufAAPxAnoozOhjInduTE8n6GXimgoLVyO/FQIAZm3BrUoccpY8dyLiBq2UIAcYXUMKR+cSKZeac98/A3UiuIGYzoDatrRTZnnIIxB3jxVqLQsKW89p3qOIiY+o6IAgZ3XXrMCbg/AxXwE2oKSFqcHa Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2f898467-691a-4fab-fc6c-08d7fbc2b013 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2020 07:03:09.1352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AyMo58EL17zr95x3XfqfxCXCtViU8kNctLFm/NHMV86Gpk+ha3oa4cblZRPKP/qM6rDk1Zm4WALb7id82nZcfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0074 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Wang, Yinan > -----Original Message----- > From: dev On Behalf Of Xuan Ding > Sent: 2020=1B$BG/=1B(B5=1B$B7n=1B(B13=1B$BF|=1B(B 10:14 > To: maxime.coquelin@redhat.com; Wang, Zhihong ; > Ye, Xiaolong > Cc: dev@dpdk.org; Ding, Xuan ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled >=20 > This patch fixes the situation where vhost-user cannot start as server wi= th > dequeue_zero_copy enabled. >=20 > Using flag instead of vsocket->is_server to determine whether vhost-user = is in > client mode. Because vsocket->is_server is not ready at this time. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Xuan Ding > --- >=20 > v2: > * Added the description of problem solved in commit log. > --- > lib/librte_vhost/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index > bb8d0d780..0a66ef976 100644 > --- a/lib/librte_vhost/socket.c > +++ b/lib/librte_vhost/socket.c > @@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t > flags) > ret =3D -1; > goto out_mutex; > } > - if (!vsocket->is_server) { > + if ((flags & RTE_VHOST_USER_CLIENT) !=3D 0) { > VHOST_LOG_CONFIG(ERR, > "error: zero copy is incompatible with vhost client > mode\n"); > ret =3D -1; > -- > 2.17.1