From: "Wang, Yinan" <yinan.wang@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Liu, Yong" <yong.liu@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix crash when device reconnecting
Date: Fri, 8 May 2020 01:54:07 +0000 [thread overview]
Message-ID: <DM5PR11MB1388992815B67A8ADA172B978FA20@DM5PR11MB1388.namprd11.prod.outlook.com> (raw)
In-Reply-To: <7b0d02c5-f109-8143-824f-921ad6898a95@redhat.com>
Tested-by: Wang, Yinan <yinan.wang@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Maxime Coquelin
> Sent: 2020年5月7日 22:18
> To: Liu, Yong <yong.liu@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>;
> Wang, Zhihong <zhihong.wang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix crash when device
> reconnecting
>
>
>
> On 5/6/20 5:07 PM, Marvin Liu wrote:
> > When doing virtio device initialization, virtqueues will be reset in
> > server mode if ring type is packed. It will cause issue because queues
> > have been freed in the beginning of device initialization.
> >
> > Fix this issue by checking whether device has been initialized before
> > reset. If device hasn't been initialized, there's no need to reset
> > queues.
> >
> > Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
> >
> > Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
> Applied to dpdk-next-virtio/master
>
> Thanks,
> Maxime
prev parent reply other threads:[~2020-05-08 1:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 12:55 [dpdk-dev] [PATCH] " Marvin Liu
2020-04-15 1:06 ` Wang, Yinan
2020-04-15 7:24 ` Ye Xiaolong
2020-04-15 7:30 ` Liu, Yong
2020-04-17 15:17 ` Maxime Coquelin
2020-04-19 1:35 ` Liu, Yong
2020-04-19 3:08 ` Ye Xiaolong
2020-05-06 15:07 ` [dpdk-dev] [PATCH v2] " Marvin Liu
2020-05-07 10:53 ` Maxime Coquelin
2020-05-07 14:18 ` Maxime Coquelin
2020-05-08 1:54 ` Wang, Yinan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB1388992815B67A8ADA172B978FA20@DM5PR11MB1388.namprd11.prod.outlook.com \
--to=yinan.wang@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=xiaolong.ye@intel.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).