From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9B15A04FF; Tue, 24 May 2022 05:11:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C41F04067C; Tue, 24 May 2022 05:11:40 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C5203400D6 for ; Tue, 24 May 2022 05:11:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653361900; x=1684897900; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=n7psVhlj5rPL7AIaKLIons7ZqeopMjo3RnWOnc2U/qY=; b=Sc7A4f1cSBfFtQ2lHrE962baiCoXtR5S8G3ufrMjpTywCcqiAQiZxVCA spYbNHp9pC+H+jE8vbs9Q1bJZkzVCI3bqtxet0rChliqKNUyRuvP719bm krZcumzyB8967pXxwMNtLNd5Dd/T21lddzVz05ci/Z3NYKqk+/Kmr7d2K HZ6gWDHygVZUnCuLIEZjn46Ha5mspmnQl1Z/Y+9Eb8bEExTf8sbKBocry VbmEaBJ352X4igInQotNRF6lsRVvrEb6aSh3bGc+UTPfJTjsT4jI9VRpu C0SfMLLg7VFxWPDv1TKzeGMk0hPmAKADYh/uHX6uSW3/9VpJ1XfDoOE7K Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="273142875" X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="273142875" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 20:11:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="577706244" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 23 May 2022 20:11:38 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 20:11:37 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 20:11:37 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 20:11:37 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 23 May 2022 20:11:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M1xgrfp4zml/CkZ3nQFNS5Q55YAuZnSMAjV3jDOs/mM46S/MFH3jMikGNAYWwwHvnjNSa7jG4M2SsD4nbID+ACB1w8rMtPQxeyCUPXmsRxwAKSvHzsZN4NcapnnNMcgFuGSeVVXMjaDTzKlcjt4tSdro4+mj5q8wpNfxA9m1BziuLk/eXCbs0MQu6xZo+tXq9sVK/LWzm1ALDfERPVQtcbrOXQXrEMVtM0DeNodQ2Iaz8itcVPQ5iewDcqTIIEvFxn3rvcI8Id4c/r1puGktt2925bKW4yQB84Zu4ZyB1RFPZHLeJOMfjrUVLDRQOkQg38UX2+fu/wNpijgmG7cBYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gViGhQYHHROnAwhCLDMwAJvB8MHLGOsQYpcxcH1RnTg=; b=NltzxGwpDGuzepHoTjJczFXvBHMALNeO/Tiawxk9BleKkP81LHIX2BN2NrIum8QS9N2sMC4PoK+OcwjBD2DlVlK6HrnNVs/stMDL+yAnSirYOYJ5hxEJl2X4uXN3Piig7JwzRRaSJ+LpaQnoXN40fVQyPGXC0ONKUxDqKSbtT1XKlmCFXjPsRp0fR3jLP+RTyFhG78LeBW0vKfVTDHeH5OAcD/EiupfVaTavT+NMUnGnqaUcf6G92NCPUYGfVVFq9kgq71LBPijkqe9XepP6Em+PAgRxgKHBLZtwxYTDqw3c6yM7405vc+A8fEkCqAVQtL9r5NiCYfKUf+ET2YPOqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by DM6PR11MB4489.namprd11.prod.outlook.com (2603:10b6:5:203::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 03:11:36 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::8c3b:8a54:d186:b555]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::8c3b:8a54:d186:b555%11]) with mapi id 15.20.5273.023; Tue, 24 May 2022 03:11:36 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Cao, Gang" , "Liu, Changpeng" , "Xu, Rosen" , "Xiao, QimaiX" Subject: RE: [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk device Thread-Topic: [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk device Thread-Index: AQHYbo8ZfXE639WCy0yYggQP8L5jJ60tWkXAgAAAbGA= Date: Tue, 24 May 2022 03:11:36 +0000 Message-ID: References: <1643093258-47258-2-git-send-email-andy.pei@intel.com> <1653298524-232138-1-git-send-email-andy.pei@intel.com> <1653298524-232138-14-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 455052d1-d1c2-4c29-3827-08da3d331ce4 x-ms-traffictypediagnostic: DM6PR11MB4489:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 37p+ILPHdDUcfq1LafitVMyJY0IJtyD2sMWNASZ6FLRcifipHHQc4oO6EMGikAyIKHCrRH6H64V9cMx+s3WJjM6Bk8TwPJwNrDmF/LpC9EpAeojw/0d+ghFFXRO9dkafPYrfhzvWxMeWSI4N9qmAcI8ecfquTdkDx2zoPPRHE4tBlnHWgNo+T1zglgIxCGAjZtUwP8tVrFm+4pgSGXpO7yHvrdKssKtEK/gQrcICFwgfVN6RO1ldNdATY/MMMVmnriVwwpZNYkrzlL9tpj1TrJ+dX2cbHdfmIvRciaWMZy1mu1Q4ISs4E4d5mdPLWzc+bOxCeHCPMa4OJ0IBBJufsnMlta9u44l3HDYNIfcnZeVU+dNfVoDX2Xq2DfIJJ9gc2sAqUCrdPE9ny+3pVV96GFo1aw0wuXUMoEq5LnnfElXAx+MxQvisUYAyAbsPo5gFOpN1RE0nwvqCfs1vsLkXU2XsRE5YbWSpqdMZ+F8LEZzT6vwfnfVIEcCY/TKc3fPmSePmlFV0KMPF+blWwHjXdLn6X7gWlFwghRow+vWRgOiKYSRFaoSr7WCel63CDGsP17DofVTkE2c2Wa7Ccm/fUzlJQKdyKVolRGRKi344sdiNsUQNvIPlG3ZBkpvL0LyUmohFK8H1NhUFoikClfM/2A1ep/X71PRk8txOGTwJoOcKw7iI9UC5rkoKVx3zj/fYKRKIMEXi6sLcfpQx7o7yNw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(55016003)(107886003)(38070700005)(54906003)(316002)(6506007)(110136005)(2906002)(122000001)(38100700002)(53546011)(7696005)(82960400001)(33656002)(508600001)(52536014)(66946007)(64756008)(66556008)(66476007)(8676002)(83380400001)(86362001)(66446008)(4326008)(186003)(5660300002)(8936002)(71200400001)(76116006)(9686003)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dK1mYHCsFkCSVqoO16SMm9s5C1NwIoTtjQ6BOx1rS0BVM868jFElteZcu6ok?= =?us-ascii?Q?lpkfS1wGjzIjOLbZykpsZcjHsRU/6RUuvCXy410f8EUJyXGselzuDAsrIcaG?= =?us-ascii?Q?ZV1C2HRmLP3SjfC8mjEJkzaFkOywUXAa9qvHEkHHOy+woMwz2JyDvDq+dbPB?= =?us-ascii?Q?H8/UdmwA1hlMHcG4oLJs5vTWHnhNcjFi1IMvwB3QpGeUUAof2BiFHRr5HQ6Z?= =?us-ascii?Q?6pznF21xV3xoTRdrU1AWLMhbbBMzPWQEe76KDlLp4QC3B/ITqD9w1woZgUnW?= =?us-ascii?Q?1vP7phJrBEzgpeUPZoszp0bhGrOREYVUwU1evf52CvsB4vRj6KX7o217oFaJ?= =?us-ascii?Q?DzloI+Aru6GoFFNSQpXsHuYlHB39MsxxB124lt8ZMpRa1NGMGGuOpl2FX0zA?= =?us-ascii?Q?retoT0ztQ/nhutyXj6Rx9HzNa4nzK4+IF6twsNJDBLK1r7nIAyx18WY8EgEg?= =?us-ascii?Q?XbOFPPTN+5+0Q+kpDnDYflDxeQkDPRYjhHto0fcgxi9Uc4kbm9JXJHpfSmEw?= =?us-ascii?Q?HV6BgDA0luEg3IpUwK+vZs+0hnJOoJne/gpyFKNW2l6cmoCjon6Snw2tD95Y?= =?us-ascii?Q?Ud7Ljp42UjE5YoHFATB18HlPET1HnB951YKBL3JOMdufvnG/a3Acco+QOQHE?= =?us-ascii?Q?YeL/ofPoPUHgMYJOqzTRMCthONuBsCmmHptk8NojJH1pCeeEBd+o4W7OzRpf?= =?us-ascii?Q?SG14zwKaEQ9Pl5fT1F6JA8ycTKvMGsI4FbvsZLpxgRPBO0yTMAw3Z1ibygZC?= =?us-ascii?Q?SQ9Nv7tTmsS10vGfm+i1VUkeocoUFF2HHiLsGHWtLKbFFJu6RyN8t0bOBOg/?= =?us-ascii?Q?t1joH8o/NIoQhvFI5FyI1nMi//K2N4qsiEp7XOdQDDyORVJ3z4y3lvbgo1gM?= =?us-ascii?Q?BCyJOdIr7pKwdKl0DS/KaGBab9980dnB1e8onrztLscRAfYr31PUN/cKBC3N?= =?us-ascii?Q?Nalk7lOrYo1rlEjaj6MLQQbNDrpav05zPHhBjFSNJNAG9+jxonb2xIl/dMuz?= =?us-ascii?Q?0evPOcoD5js4OPI4t7iUF6Mzqcymyxy4HlIiqOUxSq2yL2OMcS9cayKXB6Yx?= =?us-ascii?Q?RCpVQIkoyZx1J9A5RZsBrK1dEFNuN+1syXM2uLDneuL3QrCwnf5GVoioKSmM?= =?us-ascii?Q?nzvIxpMuUNvyIQ/QuYnExzqUwgWWg18wnZ0uE85Bw2eDdppUy7CY3DXAV7Te?= =?us-ascii?Q?by16SDBt0JUqOIYVoYLNrT9UCEhiEQKSE+1o+/dWFB11Te8h9TFlmtRWzkOq?= =?us-ascii?Q?Ly+gefMzvHRNxusqcoIc9EjBfftDqq0LREqsMu4gBMmTx85guJc3o89fcUE2?= =?us-ascii?Q?96Jq/DFcZzjolFyppqZUSUH7RoHMJWDvXnenb6lOYwY9+f0177tXU3f5rwvi?= =?us-ascii?Q?g8NW1iSffrmId/ElNsRC6XmM7cVwrVq7eAvNsxI/8KXVK3q8tShbIsLqK138?= =?us-ascii?Q?G9wac054DPdGKee9kqSneLwlI41/ULadc7fNBjwWIXgn37yQHvflas92d3GA?= =?us-ascii?Q?FshGEcChb8J5qKrQMhJRabk8LxIda9fLA4N9xoHHg6Ep+aabBgo62vISiS5S?= =?us-ascii?Q?vFgluMWY2wPC/zi0swjxGGF3HIqD480Meuw0JCkA2gnf1tggBttnaBQxyWKX?= =?us-ascii?Q?RJfBkiYdkpX8j4ySHfoVhLxsQSJmn/F+nr9L7lyy2hoIUKvNONSQgKINOeTj?= =?us-ascii?Q?aYyYULzds6YDwEa221o7VXSSZct0wwGmcBCacUlz7aHXI8xX8yLoFn6SvaSZ?= =?us-ascii?Q?DnzQbDEzMg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 455052d1-d1c2-4c29-3827-08da3d331ce4 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 03:11:36.3379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hnIC2ALe6ejwrP22T4Xk1t5csqhfi6mW4taEgvH9kYhyMtPNAw80/oeIVrlMx944UqJlSeIkV9q+KncptAfaMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4489 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Sure. Thanks for your review. I will address in V10. > -----Original Message----- > From: Xia, Chenbo > Sent: Tuesday, May 24, 2022 11:10 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH v9 13/13] vdpa/ifc/base: access correct register for = blk > device >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Monday, May 23, 2022 5:35 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; maxime.coquelin@redhat.com; > > Cao, Gang ; Liu, Changpeng > > ; Xu, Rosen ; Xiao, > > QimaiX > > Subject: [PATCH v9 13/13] vdpa/ifc/base: access correct register for > > blk device > > > > Register address is different between net and blk device. > > We are re-useing most of the code, when register address is >=20 > re-using >=20 > With this fixed: >=20 > Reviewed-by: Chenbo Xia >=20 > > different, we have to check net and blk device go through different > > code. > > > > Signed-off-by: Andy Pei > > --- > > drivers/vdpa/ifc/base/ifcvf.c | 34 +++++++++++++++++++++++++++------- > > 1 file changed, 27 insertions(+), 7 deletions(-) > >