From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26022A0542; Fri, 9 Dec 2022 03:37:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0ACE40E03; Fri, 9 Dec 2022 03:37:19 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 3F0E9400D6; Fri, 9 Dec 2022 03:37:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670553438; x=1702089438; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=E0orPzfYTl91QY+OKXrX/rUT+Ut0o2xpVuLwAjNP0Yo=; b=hfmimWov7EdC2b5eugWgD2NWgZc/QDZSdo+rmuYKP+AEW5RznkZWY6Eg vO+rvjJ7K6aOKxcEeUHhO8Pvkgb7K9mzO2eK/fHeqJ7vPCkT5FzwAEacj 6h0gul89m3jwdO7iS9erLvW0qeOBW31KXqMMWo9RaENXkAJniNTEMVB8d wz/RnAQ/sGcafkpjJubfyzqZItaBH1EgAE8kuC/gWGKDF0OnVvr/N8Er9 TNL4nZdxtdFJxzvTfv1/kJLTYkAsNUhqMexErYiVSJEOHzvbhdIkc1/ng kVJx3FPOK1n3f3y9GQNklez8IOutlaDlfGKonPwiFDV2WcUAUJtithT+a Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="297715626" X-IronPort-AV: E=Sophos;i="5.96,228,1665471600"; d="scan'208";a="297715626" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 18:37:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="789569242" X-IronPort-AV: E=Sophos;i="5.96,228,1665471600"; d="scan'208";a="789569242" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 08 Dec 2022 18:37:17 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 8 Dec 2022 18:37:16 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 8 Dec 2022 18:37:16 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 8 Dec 2022 18:37:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EcrtO1CPqgnTYVvFSyHNTXyOLbhEPToLe9T619UGQv+eisAj1UxVOYPiEjXWZXmRjZ/tSj9BNrBVz0vwJaswdpXdfcnaZiqun58j5pqlflHmlwQ7HfNlJIQBLGdo+PBUX3r6xftdAHK5rkGBcmXTAbeB7KPmtmW2A97BT/ydo46nmNt32oUWdmNDimeWx/FHMn0b4CvNwfveiL6anuQOpNUxw15R2Ir4/XbYdjahKR1bLUXrA80xooxpQiWhr2Tus51LEZO8qgNQimbQbI6Fg5V7ULHE+EB0JSA6D1y3coM1q0G8jYahTmIRCRo4yN8e0SjtATcfql5uf5mzpB8A2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IeZmbCNxZvE5bmupcWONQh+2IkPu71D3SLxCrpmkJSU=; b=jgxc9HLFkpvGOXv2D7S+sroWJVzyiPDx5bVbo36hCabABsgMCiFrf6xl3RO/u1O6uivHVZkGJuqRPdtS4V/zkY18vESOWMxjX8K0tsN1kDb16gc4+w3M4u/5qBqiYLy22u4An6L5tM2CEvuaVwmHGh9h+HSoeU49GXsJBD9b9NKl7zI/PSBbDobzI2zl9p7hDdIhkz0nz/p5/DTb4w1O/wT0ubJyVGlEvf4q5zR2L7qMl/oAlcI8SGg95u0tJmLX1j3hf5fp+RsMVdy1JXkU7+AqNKU/OjuiCn+vL5Lg7dk/ybJs7shlkfy+UMdacy5x/ieajoZLD+5Ill2GiTNrWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by SJ0PR11MB6790.namprd11.prod.outlook.com (2603:10b6:a03:483::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Fri, 9 Dec 2022 02:37:14 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::d5aa:32ec:9c21:83cb]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::d5aa:32ec:9c21:83cb%2]) with mapi id 15.20.5880.014; Fri, 9 Dec 2022 02:37:14 +0000 From: "Pei, Andy" To: "Wang, Xiao W" , "Maheshwari, Abhishek" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Xia, Chenbo" , "Mandal, Purna Chandra" Subject: RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices Thread-Topic: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices Thread-Index: AQHZCXbF4C5B58+cCkGkb8+1PnaLAq5j9s4ggADjsbA= Date: Fri, 9 Dec 2022 02:37:14 +0000 Message-ID: References: <20221206125041.339275-1-abhishek.maheshwari@intel.com> <20221206125524.339468-1-abhishek.maheshwari@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|SJ0PR11MB6790:EE_ x-ms-office365-filtering-correlation-id: a9f2fadf-b1f5-4f94-481a-08dad98e47f1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EhCjZb6uKsly9lxUmlGSv15n2YQ0qFIA3kqbqbE+OCBdJngx6voAxR+ScBa7ObL1pAD1tUnjFprXZaRxmv/+sIqoJjbxfhNdDgVHEj7GdmMb1zEKOmalHVvGCNsqw+E5gNq0l9WcMZip8jGTgGgEhdWlCB4c+Wguf2uUh43uFSzQEu3OCuUa5/Odf8jV93isIJ/dkq1N7uXIaAXdfBmiXq/CbckWXbK124TXbOME/mZA5Nk2k9voxZj33K7cmq9ArJZxHWF9M/jxPLAK8UGO2tw7YaU0FYSRl7Ua/pB+nsGDDt61BeW+Nou6YWJyneni+0l+HLwJZtG56TwrDIi/kp93AzY1a7Co7A8Ew2QBw+2PpxQlsYQzElOx9GBo53srYyHASkasYy9xVCXn9KF+xhdcjwvgN6mJ0bqhYTSSWAqc9YGbUQ5/3cmKvT5SVccz6VjqSf1Zh9yPfpTvEKgBTDs1KKoVkqh/q/FRteIO8uxL/bzlhkqvaktFnjt3y+ZW+WUyW71vAFE/+/ue7iFekmNuq9kfoZ6mzSzcLQGLctGdKoifY9LfQD8GHbQI1BJGpRYaS5YHM+bHk25VRtzBO/Ev5IMXN/7UdJ8Nu+D9k6zdyiSbyxFdkn36tH8mK31IkfAO0+6XikbNrw6p8WvMwdxoBfABrNuJRWSwGZ7Ti0d6ePnVdK8Q+Fe42OhcSnCsH/3LVlDYaWXSYDW3uQ41WQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(366004)(136003)(376002)(396003)(39860400002)(451199015)(38100700002)(41300700001)(122000001)(38070700005)(8936002)(54906003)(33656002)(66476007)(64756008)(6506007)(53546011)(66556008)(86362001)(26005)(7696005)(450100002)(52536014)(107886003)(66946007)(76116006)(66446008)(5660300002)(9686003)(186003)(4326008)(83380400001)(316002)(478600001)(8676002)(6636002)(71200400001)(82960400001)(55016003)(110136005)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T0jkAtvBpQPhstWva6RCP7qBPX5OCpEyL28ZCfgW55aH7FaGmRox/HifazPZ?= =?us-ascii?Q?kJfz+7G8ME0uO7iEEeK9qdkc0AfW08Iirql4WztMf8qa46ZyZT9ms/kV/5V5?= =?us-ascii?Q?nj5wNYeXeVUbNJqeg4emc63lwIm0W/nWLygeVYsQf5rhxLUqvd2fQdhCm+R2?= =?us-ascii?Q?l1f3+FqAom/oZZLX7zfMdO3iKqnsvHl1mK9tB+x6YGBrDp4vwRJZDqwBjwJC?= =?us-ascii?Q?cv8HVD64EdEpMOs03a4B/gnpVugxfLP2uiMDkGFGBWG6dK6fZ7fGM3hkDdfQ?= =?us-ascii?Q?BpzD8Q7aeD8PG+s4LZHY8Dqmbg73AzsVMUUbMZPhNaB9grMhaAP/S/1m3H7o?= =?us-ascii?Q?TSju6ec1GPILjpQ37UdIh1Cd1n5LiO8rlO5QVqOkDVUxBOT0nzDZ9xzt/4Hb?= =?us-ascii?Q?48+Ex1ZKJUEQ2LP1bYd7GQECzEVHjC3yspc2ykrrYT30gqVYyMOV9X6XPPjl?= =?us-ascii?Q?dVXNqG2c3eHqXb7xTiQZJIRTPHopSw/3GufW7pD2EKXwDQpeJP9ehGurR5hu?= =?us-ascii?Q?ZZeezkx4LhEl3/hO9bPQEYrA1QIjNaA6/fQqmkTuglIsGZ0yCEg5pzZdb8ve?= =?us-ascii?Q?2roMiLxSAj/m8ru1HSjyQSLjvJ08S1zbzLDbQDTEtr0kjXol4i0askFo6DOW?= =?us-ascii?Q?/sgwA8Xdmkitdu85b5YjcbqlMy84HnzbvFf1cLASNyKE5Mon21TGuUwHUmau?= =?us-ascii?Q?taZ8vRlit/R+vHatu/3x4jIkaC1zxwu9yF3Hu0cvbLlQcdf64N/vlQZ9QvZc?= =?us-ascii?Q?bKnoLLgJhBV4GWoVBEK+d+MF5TIKRnAssqKes/v/bwerHBd5ycuQfaUTojqV?= =?us-ascii?Q?kBf8wCzvyL/x0ZtyFwz2pU2dMxvgt0a3zlZS/STmDd3pI4uTmXsTkIw4/afz?= =?us-ascii?Q?NoN+g5s8xyqLVsuSUgN6uN7/5qnwUlYjAWEmrZD0cVlE7YSPYbY6Pbubkk4x?= =?us-ascii?Q?43WJGzudaLj+Qh8SIklq0svRlgEnwiiryn7xqsLeJg5HzJSsU9cpH7c5XNzM?= =?us-ascii?Q?b+dijV+tg2FOvQM2mjd46cF/aZ4ffJ46cl2Kv+PKOYNqujWAUtyvWBUo0GYH?= =?us-ascii?Q?H+2+NX4027755m4sNA46vMST6+0t4wbsMM0MEFOtIGsCweiJvn9alatmeM2l?= =?us-ascii?Q?c6anyolUemu0Ih+YOvr0uuwRbv316KS8hCjhwCtylaK2sSu8rUfk/ElJQuj/?= =?us-ascii?Q?o2LRlf2acN59Gzeu92ZB2ZNWjVOisrr5z7xlttRt14RLJmV1PI9gDfKfkDFX?= =?us-ascii?Q?DQrXZzUf2d9PyTGn0wMOWzSKbM0At89gS/zhbnPKL4rSYHptKFwDsUoO1mPn?= =?us-ascii?Q?8AnXIEEYqYRPXUEfil/2n8vOzbsJrIiLu3J3Ajvc+gVCkfzAb0J2YSQsKgmv?= =?us-ascii?Q?Hrnm9omdMtGUr69p6r5TcKuRkOYLByf2PqdF9LWfReLMSaSYhMXlYmRdzq3I?= =?us-ascii?Q?W6teJ9esqg/vJ+kBZ5hySJMPv7cx5iXZ7ots1nom+DEcnBRMNS/6B28zu6r0?= =?us-ascii?Q?b+n38RRuhln4CrLE4cwOx6W8VDhOUukJ1EsB2vBtEnxaCc1D4uoWNZQ+JrB6?= =?us-ascii?Q?I+QCjJIAXRYS4fPaMFE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9f2fadf-b1f5-4f94-481a-08dad98e47f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2022 02:37:14.1456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TgPUStSLonlZwVzhTDukNHnDK5uu/i2jSFgiu/e4LmbEXrZzuh9XUA4nWAR814MXsXFOtZiEm0Mzkcn0FVQ3vQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6790 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Abhishek, I agree with Xiao. I think it will be better you just add subvendor and subdevice you want to = be take care of by this vdpa driver. > -----Original Message----- > From: Wang, Xiao W > Sent: Thursday, December 8, 2022 9:09 PM > To: Maheshwari, Abhishek > Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo ; > Mandal, Purna Chandra ; Pei, Andy > > Subject: RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virt= io > devices >=20 > Hi Abhishek, >=20 > Please see comments inline. >=20 > BRs, > Xiao >=20 > > -----Original Message----- > > From: Maheshwari, Abhishek > > Sent: Tuesday, December 6, 2022 8:55 PM > > To: Wang, Xiao W > > Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo ; > > Mandal, Purna Chandra ; Maheshwari, > > Abhishek > > Subject: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern > > virtio devices > > > > Fixing the match table for vdpa/ifcvf driver because as per the Virtio > > device specification, for modern virtio devices, drivers MAY match any > > PCI Subsystem Vendor ID and any PCI Subsystem Device ID value. >=20 > Here the "drivers" refers to virtio driver, not vdpa driver. > With below change, this vdpa/ifc driver would hit the standard virtio dev= ice > which can't 100% match this driver. >=20 > > > > Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device") > > Fixes: 5c806b94785 ("vdpa/ifc: add PCI ID for legacy network device") > > Cc: stable@dpdk.org > > > > Signed-off-by: Abhishek Maheshwari > > --- > > drivers/vdpa/ifc/ifcvf_vdpa.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 49d68ad1b1..214d6e1f60 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -1824,8 +1824,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[]= =3D { > > { .class_id =3D RTE_CLASS_ANY_ID, > > .vendor_id =3D IFCVF_VENDOR_ID, > > .device_id =3D IFCVF_NET_MODERN_DEVICE_ID, > > - .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > > - .subsystem_device_id =3D IFCVF_SUBSYS_DEVICE_ID, > > + .subsystem_vendor_id =3D RTE_PCI_ANY_ID, > > + .subsystem_device_id =3D RTE_PCI_ANY_ID, > > }, > > > > { .class_id =3D RTE_CLASS_ANY_ID, > > @@ -1845,8 +1845,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[]= =3D { > > { .class_id =3D RTE_CLASS_ANY_ID, > > .vendor_id =3D IFCVF_VENDOR_ID, > > .device_id =3D IFCVF_BLK_MODERN_DEVICE_ID, > > - .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > > - .subsystem_device_id =3D IFCVF_SUBSYS_BLK_DEVICE_ID, > > + .subsystem_vendor_id =3D RTE_PCI_ANY_ID, > > + .subsystem_device_id =3D RTE_PCI_ANY_ID, > > }, > > > > { .vendor_id =3D 0, /* sentinel */ > > -- > > 2.31.1