From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7185A0543; Fri, 16 Dec 2022 02:58:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95E9A40695; Fri, 16 Dec 2022 02:58:07 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 9FEC940685; Fri, 16 Dec 2022 02:58:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671155886; x=1702691886; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6J8gielLbb264XETX6blAKf0Nh463ULT1jp8JY7VTjQ=; b=ZsHN/RoMM4esRJc2b3isfB74QioZTGwjllp9OBImF4Dm5KkIYROKLpAb SC2a/tP2KdeTWd0RayinothaDhPfh1Eds+QUBnv1j+hrElk/SfJqp4clG tAsnenQyhD8Ltu7bF0IES3Sh8LtgZiP7E7ymfebs6I37F5ZDY7NaOFasf cqM/ypXOBAihZMKl8IUOTMI7d5aqC5rUjsoi4zTGYl2P8feUGGYSVm+Or TaB9wwfrxXIRH4Ontp0h9i+Y/F/YDkajj7gBzuKSgeAepEbsbrdf92KMy j1BHDpdFGY3eIlCr/+a+IwvejudGQvUuU+8ZiX5PxTemrDQ3hpGf8Jdid g==; X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="306528881" X-IronPort-AV: E=Sophos;i="5.96,248,1665471600"; d="scan'208";a="306528881" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2022 17:58:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="756576042" X-IronPort-AV: E=Sophos;i="5.96,248,1665471600"; d="scan'208";a="756576042" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 15 Dec 2022 17:58:04 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 15 Dec 2022 17:58:03 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 15 Dec 2022 17:58:03 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 15 Dec 2022 17:58:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OcmGR2RbiABEIV0hG777OA9RkZVb1dJ4PJt6meVLVriTfaKGZYTXnnUbr9g5q9Df1IX0YneDpwIVJJnNFJ6f9A3G0JmP08OgiyjBMajnXWYukBSKsuyPXWg96RtCe2dTuF2/hzaNcywrGsXtOHmBqGVGE51SaKitpvMaobU/qA20z1gANUz1KNEm0YHV2T11FFmf8F5rMgTHWuaysszx26rYzsov3ikf/zCXahhH9ZmPrCeKqdSsLpxXoiIuLzW4dPJAuscdzkaZB9NG2yUc/HnBHDE2LNGvYYVNcTfwPl/aU0xqNWLe2ADKxHzySJyOPKT5HB5zBlZHSL4C/m1Cnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/tPxGyNdF5qLImh8Yta7BWbkK4d3yPP2WPt/86/jT5M=; b=GX9S+1Xas2c3YdWdrDmwnlFAfKhJvMLcWtZpkqPuw7ofqKtoqxPuETbZvtmP3lQM/gk2HPU8JsOLFF3O9n1NxKBg2b6wEbafjYw5qOpWdusH6lpTcqB5tkaj7SiofHolomMaeDqLn+afZJCQ/nWPzWf+XGNjwtYkbCnvUYK8fWCXhCcCzd6qyPvwi/q93VQH7dlab04NMOq2lrcoOWEQWKQ0G/R4BWOMXZXfIfcfK0/gFr2mPo7Lsmv5T1ILSotVtfAvOUF/bVR5btVlzvYnUkNLe80U2RJw1S3AKyoRYMSPx2T/yb3qXez1loEZQ4efySA/RW8B4th3nGlyi6rj3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by BN9PR11MB5291.namprd11.prod.outlook.com (2603:10b6:408:118::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.12; Fri, 16 Dec 2022 01:58:01 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::d5aa:32ec:9c21:83cb]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::d5aa:32ec:9c21:83cb%2]) with mapi id 15.20.5924.011; Fri, 16 Dec 2022 01:58:01 +0000 From: "Pei, Andy" To: "Maheshwari, Abhishek" , "Wang, Xiao W" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Xia, Chenbo" , "Mandal, Purna Chandra" , "Maheshwari, Abhishek" Subject: RE: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices Thread-Topic: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices Thread-Index: AQHZED0DxyKiD0NdOEWOSxe4phcDZq5vwruQ Date: Fri, 16 Dec 2022 01:58:01 +0000 Message-ID: References: <20221215034207.2145419-1-abhishek.maheshwari@intel.com> <20221215034818.2145612-1-abhishek.maheshwari@intel.com> In-Reply-To: <20221215034818.2145612-1-abhishek.maheshwari@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|BN9PR11MB5291:EE_ x-ms-office365-filtering-correlation-id: 2fe7e8c0-9401-48ab-8bd6-08dadf08f698 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E2JYl3lNDbvifyGffgm2c+rKhNdCYjJRGsP6A3QM9Vgvt463XSnSN6rmUbx5myRiwO94S7tMyF+QDHajG8D5VIg2I3961q2AW7x92QkeDTBGA+2bWSEZbOjvVmOrE+u16IU60k/hhRJYeuUHEflz5tRspeM1Cobemrl9Q1HT/irp+fD7qAwT+K+7/j/vdGrhShgJaSR4sCDqV6LSKS0QogJviwDC9dQxNsdE9lKdT15Jwy53OMxxAxStlMXyjqNxgB+amODZEb98q5ppQDytWzDrrl4YR5z/LxaEey4/l8Ka3ofNTq/nxsRxOnsLkxBba5t19dfHn86fDk54yOFeA+5LcnVMUSV3CqWXf63DUoZPAsvYor5A7MyGi+WDjf2awluDLI7QUzNFPIcvPDwAYoXcHGlK135yj4nom3nIAKwruVvgKVNDreoZA7WMDqWoGg+Ubex5QUlNYmmqcX2v/WP+lCz5B5RDNO+XNgO8HwMYrZL3agZ1wKv2fQ69aC0sZkveLg0bYA7bh30sIGF9leExjC8tx3Q+nz/mnqSDBjx215vj9PHj4+7vLrLqjo0WZUqoSRFXn8J/1XQpDA+5xR2TFdh4wUZgFjLa8IBQNJqQneugSQzhb43/yZO2WL81cwNhYjFG7RMhB+hNu7uA6ct9tOxNRc6zfPYjFWrysQ+ISSIVikOvgg7W03s2Wl6yfcuWSLKbDD6S5bB8l0o5QQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(396003)(376002)(136003)(366004)(346002)(451199015)(82960400001)(33656002)(38070700005)(2906002)(52536014)(8936002)(55016003)(41300700001)(5660300002)(83380400001)(38100700002)(122000001)(86362001)(478600001)(54906003)(110136005)(71200400001)(6636002)(53546011)(107886003)(76116006)(4326008)(26005)(66446008)(450100002)(66476007)(66946007)(64756008)(66556008)(7696005)(6506007)(316002)(8676002)(186003)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W12V53oohdCXSu3UWTie1QTsXtJO9p5W0vieuZVz2ncIKAx8D033dy1d+/cV?= =?us-ascii?Q?Vh/8vLQ7tKYV6T1eKZdp3R7vUR5PSN/dhrVWlO6hfO6uarenroGI82tqyaT4?= =?us-ascii?Q?cSxHnNJq75VofKmODVWQId8mIvrA5aeCzw7yadPRWrHkpM0jN8uYqDXQ3fQZ?= =?us-ascii?Q?7o5fKBJhlZaP8Gl9DkpFAnyIjsQpb3kAsBBmcO6NwrOOTJRmOCzlirSnEjk7?= =?us-ascii?Q?hkLD1pCBOHnIJop1RXNCvWLoNky8oAlgmtwe6bUsQEoPvy/9UPqF9YrZon9e?= =?us-ascii?Q?ZucmOZ3ZQ/a9/ZAGmxiZZWKXl46dKbggTkoyyMtpZENMfelI2FsJudRlPmXO?= =?us-ascii?Q?s0o4RZJGw6MlqhMQp2srNWW3wNkNv7azuajvZVteQcRNoGjhfQYN6N+UEjQ2?= =?us-ascii?Q?C8slUZcHBHQFUaifcXFXV+/tGK7LLaWCb3M0XJLuL0kcRri6f4RyTK34JdF8?= =?us-ascii?Q?38ur6M+U/zRcz1SqJ3GvSYvXMIyJ2QtE/JYphvYtMaUfTzh4qsaxmY9uX1hf?= =?us-ascii?Q?IxSnEnsMbZaAH+yIaDUqQdIafFTNN1D7SrrGIvH//zfHAY4nPN9Qf2e4qW5r?= =?us-ascii?Q?pa3TssX6wqWJKv2G25+16Aqw0KjvfeFSzm24fqheDcemCBWbqim9IrAfH4mP?= =?us-ascii?Q?n68Quxp0TmQa8HLApusMVAwjxn5xBmHnqpIpdzDAKX7mjqkAdfTTyMRBl7jA?= =?us-ascii?Q?mk5/8halU5QD++6nntdmjSmAYiQkntp0p+R9LP/PXj9WC8bgeewtDIU1RaTH?= =?us-ascii?Q?yijqGc4H6wwR0Mq+nZO+YYNWnZy5SHoiz19Cc+VXiwoppeB2n7TvRXKxAJ3z?= =?us-ascii?Q?iHO3NAL83Yub2VIFG5ZVrP5N41OAsF9aOaWd2T+8tpbHp8oCkb7LNrPSff73?= =?us-ascii?Q?3i7wXbmgnxpkgvGhv+vUHARoDz1DhmuQVA5rnPGDK0c0BMNQ2jBCtmmqDKYD?= =?us-ascii?Q?UsxbdaVSFrLI1kcUQgZtc6oMEHBZP63fZFDFGWoX4pMEgkgVIzY38xE0B/sY?= =?us-ascii?Q?Akd4OKGVtaVg7PDEQ6+/5Hx5EawmsbexruRaELGq6RuFQ0p4B0rSzR33bAZk?= =?us-ascii?Q?gNbluuykp+qLjBUc0Xu5m0WjQyYXnQhH1wrmsQeIPSbCKJ+CpfWN1MPXfce6?= =?us-ascii?Q?RMb7J2FU041COdoLjU+L5qvnaRMKk6oVnovtjtH37GOypDnsO+PSA8aUFyc0?= =?us-ascii?Q?VSSEHpJEEPVMBpNYLepOQweBrJ5S4RMkrxWZEhRS9kOnUiCBnIn4310rgOGA?= =?us-ascii?Q?OUABYDBddVB9ABf7Yo90RYU9AOiqxiTmWNlTAhMmQbEQW529eoTrP5Umn1km?= =?us-ascii?Q?h6AK0CXjbPPTJ7vE6XBnNNJ2I/pOK0gnMXD7fQXCFx4dGiTT2wgg/anD0awi?= =?us-ascii?Q?kauOdefabUS9n/8klblWuNxVpiA14ohzB1R1Ayns/ylCUQi776hhjVrKKoMQ?= =?us-ascii?Q?KsNFFOOPg8XyqWgDjnld3iyKc1nPaRS3JFguzEIICz08MRJsCDpw7D3Q9TXr?= =?us-ascii?Q?rH577R8WzDWYEEFRl2rZC5EChrsVIP71nU+1VHl79zrttsCseOrEkwk4Trql?= =?us-ascii?Q?EXxD6Yj6hPO6ieszj6UN/2tAuEXg7FAJd8rNul+c?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fe7e8c0-9401-48ab-8bd6-08dadf08f698 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2022 01:58:01.6115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xPb+6nECzekkOwqYlgUm0RcUqrK1H+WOXiLZCVMC6tjWalm+TTpL15ycJZ0Ox7WRd6mepgDltnmqTQKIgIxqSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5291 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Code looks good to me. > -----Original Message----- > From: Abhishek Maheshwari > Sent: Thursday, December 15, 2022 11:48 AM > To: Wang, Xiao W > Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo ; > Mandal, Purna Chandra ; Maheshwari, > Abhishek > Subject: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virt= io- > blk devices >=20 > Amending the match table for vdpa/ifcvf driver to work with virtio-blk > devices that have default subsystem IDs. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Abhishek Maheshwari >=20 > --- > v3: > * Removing match with ANY_IDs > * Adding support for only default subsystem IDs >=20 > v2: > * commit message update > --- > drivers/vdpa/ifc/base/ifcvf.h | 1 + > drivers/vdpa/ifc/ifcvf_vdpa.c | 7 +++++++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.= h > index 3726da7a33..04c81c8196 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.h > +++ b/drivers/vdpa/ifc/base/ifcvf.h > @@ -20,6 +20,7 @@ > #define IFCVF_SUBSYS_DEVICE_ID 0x001A > #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001 > #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002 > +#define IFCVF_SUBSYS_DEFAULT_DEVICE_ID 0x0000 >=20 > #define IFCVF_MAX_QUEUES 32 >=20 > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index 49d68ad1b1..edc6db545d 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1849,6 +1849,13 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = =3D > { > .subsystem_device_id =3D IFCVF_SUBSYS_BLK_DEVICE_ID, > }, >=20 > + { .class_id =3D RTE_CLASS_ANY_ID, > + .vendor_id =3D IFCVF_VENDOR_ID, > + .device_id =3D IFCVF_BLK_MODERN_DEVICE_ID, > + .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > + .subsystem_device_id =3D IFCVF_SUBSYS_DEFAULT_DEVICE_ID, > + }, /* virtio-blk devices with default subsystem IDs */ > + > { .vendor_id =3D 0, /* sentinel */ > }, > }; > -- > 2.31.1 Acked-by: Andy Pei