From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8F9AA04FD; Mon, 23 May 2022 06:39:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBE8F40156; Mon, 23 May 2022 06:39:01 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 73B534014F for ; Mon, 23 May 2022 06:39:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653280740; x=1684816740; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jvNClnFniewAgwZNcQIrFrD1ZqdKUM4N76g8irzGHhc=; b=Q+Kgja77DqckPMTRXuLgJOA6QZNXeEofopXJ/dbdhvRCECRsgIr/qfoA TWAW++pWPmE7v6nxK9oOYhWl2P7qmX0bUvQtVnsSVjStfFWl7Z/3ZGu// 6abjqRssaX9XO/ReJoNrc6RiEUuxVpGdShLIcsJRB8HXYGXl4bVDywpTn JgT6+1L6ABMkFijLbYSK8muifQqpHRCWzrOSvS9KHv+KCHDWkb/FS1Z16 J2CZb9TlCCF5jzP4J0iGZjXDFMzgJxZg/gr8/F1pwRIhataZWmd0KLn5n SDn/JodjBsaZqgh1RCvmFWQn3ZWt9qTBuEGjMyHmZLwo5vqSeioZn9gE/ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10355"; a="333742628" X-IronPort-AV: E=Sophos;i="5.91,245,1647327600"; d="scan'208";a="333742628" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2022 21:38:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,245,1647327600"; d="scan'208";a="525736373" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga003.jf.intel.com with ESMTP; 22 May 2022 21:38:58 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 22 May 2022 21:38:58 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 22 May 2022 21:38:57 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 22 May 2022 21:38:57 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 22 May 2022 21:38:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IQZECv1wEOuQGDZ7c45J5RDTRJU3y3y4xR53tdp0yfSitgoQG0WmyT3BlfF0YUkkYigAbOrXG+t7of/BXg6RfT0LpjL//2AcFpNcSDA8huClz5Fy9dvPM1Lp1ennw7k8io2Zl/FNN4Qhnjd0/syCOjHWs9C0ypKTDafd+EGEXXz/EFhlJjBLKX3QfoplBUlO3sbtGlbTUIRtfOlorrITn0d/Pxrs9vJ7+YxmFdm0RNdpPUZtgcPpY+19aFMnA0QSjKiCGdc+Lf3YAwvfrCOSwkSEROXRUfsoYGs95d/A5oJvezQbY0wxvWkF4MMGvrGkVehMUNG5mzPcAHv3sk5HGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zl+JOBe0kz5L2RZ10mHjalLNciBReXfWTiCoZ+wfLPE=; b=RYNdNZhQWYT/9JNoTWsO54KFkLHf34yjxVPde2+KJklX9nzUzneq2wQvPgJc3avv15/Xejs0RRBvqy8Bg31tmQ2Z0L4B9r7kFMizXKUTEhHWCblIHvT24hu+OMqDlwZGVLVhfC6hhnir1slmOMqjwYkoMdMOSIwbxxXGUOyGVPp+pHbI56LH2iTu0lIBUkC1OyddCF+4xvnIEBbgrEPmINa8VodzTwye15G+D2FOVMTZ95c6I3mTiSZBlFJrBNGKMPVsQB7m399FkUUnMdj3s0Z1Dq5sAEKUL1QiAXCV/P454PU5c+ebNTKuF2YOpCgtun6XOBfu09VluXhtKpeHDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by DM5PR1101MB2283.namprd11.prod.outlook.com (2603:10b6:4:50::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Mon, 23 May 2022 04:38:51 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::8c3b:8a54:d186:b555]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::8c3b:8a54:d186:b555%11]) with mapi id 15.20.5273.022; Mon, 23 May 2022 04:38:50 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Cao, Gang" , "Liu, Changpeng" , "Xu, Rosen" , "Xiao, QimaiX" Subject: RE: [PATCH v8 02/13] vhost: add vDPA ops for blk device Thread-Topic: [PATCH v8 02/13] vhost: add vDPA ops for blk device Thread-Index: AQHYardRLu34CTPvw0Gg+Sow5IJOcK0r2V2wgAAO+wA= Date: Mon, 23 May 2022 04:38:50 +0000 Message-ID: References: <1643093258-47258-2-git-send-email-andy.pei@intel.com> <1652876035-70513-1-git-send-email-andy.pei@intel.com> <1652876035-70513-3-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23d06f89-2012-45fd-e3bd-08da3c762272 x-ms-traffictypediagnostic: DM5PR1101MB2283:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nJI7QndVJ9p+Dzx+BCCUz3pKQHFuibxWSwoBscwXqy/6uwGvHIrn9CFoPGKmwZhni8fyI68Xi2pf0oUmXCyAvQp9B/Li0dqiBJbPHwPtfuyjDjtXeYaEo0Po8thklIiKLXRT2nwgAV7gZjmq/Cce5O5odcl1Xtv+fnQRK44q+LcmxEtwOv3FR3cRVukBk59bxlPZ27HT/x2MoywltUo0DwQRyBeYUnRiuOQIa5Ap9Dj5BdQWPXrmGiF6obrchld/6kDkpOTqRDeKFB0eCB5unkdvgtfdyLr3/z8ilKnPMCGcgQEdqLtHNB/gxJinkyJnPQXU5LtuwG9qqo1wKxdQOzcOJDYirnnBPeiEskLBjYuK5EvzXBTdEe9K19L8/xtY0Uohv2iJlAx62gWsBTzlyTA/iIDmg50EFy71r09JFPowpD9pM63xoWCCCZkEul9rhAXz7cjqZ12iK3YvhChsPjKPKO9TDxnp0LR0LOqxdyKtuSE3KvIZYHrW5GvP8L9sddNmV2uR//91AZTQuqOoFon3e89tYDMWLDUZvgc+M65C6DS1ZSqH8JhKlGHYJJT7Ll0vfdEwiiebeCyKj2LYTLTTuzYajjlojdZv34Bz3qZOWBszLxhmIFBT8j2Wvaqm84htxak88IlqTD3jkuhm3J0r6nuDiMJqrqhpnnT35V4E9plyg1mZM1YlCT234RdqhT5Qi1xTrCaOp9kqJP2D9Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(122000001)(5660300002)(2906002)(316002)(26005)(38100700002)(508600001)(71200400001)(33656002)(86362001)(38070700005)(55016003)(6506007)(4326008)(110136005)(7696005)(52536014)(64756008)(66476007)(9686003)(53546011)(54906003)(66556008)(8676002)(66446008)(66946007)(76116006)(8936002)(82960400001)(107886003)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YyvwKrF5vgq4+ExMDVyi72KKOhNB7g5LLTwEbHkoGz8sddZQQVakOs/7lZKW?= =?us-ascii?Q?3ct7mZL7ULlklOQKVFChjuVVg8xdvpq2hcYK7/P8HQZHG+uAkzPIqDoqUR90?= =?us-ascii?Q?2SnHpllPzcrux1g/yFYzUcABFlyvbisttUnSvaIpNnu5zj46p8RvXjthJBtL?= =?us-ascii?Q?zYa2U6KWoYp2XpDGsuhf7sOdNfiPyGeLwPeBJEn6nydcTg2Lk6cxuzqzoIWc?= =?us-ascii?Q?BV+Ch9UhyuHtK43lGpIHE6PNtpDkKp3TWFTCEtLcYtutMaZVvuA2dLr7mO8T?= =?us-ascii?Q?qox20N0d9gyjwVGuEMlNRSpXxEml4XJdbWl1wZHg24REJO3SpXV9vWZbFtUZ?= =?us-ascii?Q?eLOab713f34DURkzwwl8zA33fZMfgU9jGoMooZX+WuIXJw9Mi3QFPzfe4tsL?= =?us-ascii?Q?YjKsOwR5s8adNnJ75jeOcRuUmH3cSVIpftRPIueDoKmbNZT5RTpnHIqYjZPs?= =?us-ascii?Q?WhGROebDqBngFDtDV6zpEMEWj8Y+CdYs22cdxA6qK3W2hEVVWiERcNsFzhNh?= =?us-ascii?Q?bhKKak0Z/dNh3/Els4O4n3HgRMVFxRwM/BW5sZkqInpdoyd7w631aM1HhhuH?= =?us-ascii?Q?Uk3c5jB5kx/Q04RBvSwseBf7l8XKjP4zJHpwOhN9CTH5FxlaFQ+jMbZ9PfuN?= =?us-ascii?Q?lbkF/djQwpzuiOeiBWPaElLcHqkWVSt7LvS4Iedn4hLFz/XQOJM3e8BHXjDE?= =?us-ascii?Q?fe0zhE7TBNvIkwtw5jT4IdzWY7v5woyh8FO7cL6TbeMCVKTRgZeZbAKWEljh?= =?us-ascii?Q?/9viNcY8dz0WQBWHb62kGSUMl2f7Alycf3TlfwljXAPmRZjDHWJ2+S7t8c34?= =?us-ascii?Q?mN1+nILzGEkenc3lzLHaxSu6wU8IcewZwtqm5mRFSUEr+7uLwVwhVpangHQs?= =?us-ascii?Q?J1QLw5pnyZrdDEU7ptlYEovthLAku2hzKeifBCB2oIANFLeiK3Asad6VafPO?= =?us-ascii?Q?HuQa88IlMn3+MiZaVfRcFasnyaemATv6rfIjm5lzIIzLH/7dnS8EpKCAm+XR?= =?us-ascii?Q?OXmEIuDR7xjZrcBag4iEQ2zPAa6ypA/9tb5uDzW4pwh9aL4v5jm5NFVZ897M?= =?us-ascii?Q?I0/+b76rFEmeD5FwNvGRpa7XmdmxqnN3b8vBBIe/EaGmU+T9REgH2jaiC6/Q?= =?us-ascii?Q?PLWYJoE0aT+ll0P/edmh96+B/lYYRyhpBSjVyOlr/lRq5NAEu7AsgFw8pYyu?= =?us-ascii?Q?VLy/AevFfdJuk8XvwxoMvfjCdZ7c/olz+qms0+AzNEgNAKrjYIZzSanP76Hq?= =?us-ascii?Q?dyFPj/bVj2nR8UiyIAHjIjj+t11w3CCizaYfqSzMEZvvI0Q9cVMLD9Rv6YWs?= =?us-ascii?Q?tlDkruVTlkSG9NOkQAmZ/RoUAhHOxu4679z0ABYq/TSMyO/ndvIsj1ir+Pk4?= =?us-ascii?Q?DZ+PO6hNZM4cveGUvcfkgKh370u3zXmav44btmp5xmSGoW6OlS0Vvovstko5?= =?us-ascii?Q?Rw99JIqz47ET/fWTM9rgIstrzKZq/WAgFbpyZS1tABS+fm2fsOJypcOxunI2?= =?us-ascii?Q?/N/1iimyiS95HUx2xKt9GTBRHcMDeK70lcOePeV9zeOhVVBUScP2lOE7I6DZ?= =?us-ascii?Q?Eisu/ud5GqFS88yL4VL07yrjQu+qXpN0ysQ6UNuhbA5W4jyjn6QuavOggbzL?= =?us-ascii?Q?jjNkBVviy7ORaywv67d+6ts29EB1faJQ3kh1l2LXldmSI+Tt6dTvTSqTtigU?= =?us-ascii?Q?C/9ywbIMUaRmoGzEN8pT7O/7US7dd63AeEqtRpT49RhrUkp2y/ftUPMdzZX6?= =?us-ascii?Q?Lza4bETbNA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23d06f89-2012-45fd-e3bd-08da3c762272 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 04:38:50.7796 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MlNsttKVY80olnSF3Nx68do+OSSujnMpSSLkLdJ3pxarREPfByGNTcafJhZvhLmJ9PwbewzGzaKr6iV8IslFbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2283 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your reply, I will send out a new version to address this. > -----Original Message----- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 11:46 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH v8 02/13] vhost: add vDPA ops for blk device >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Wednesday, May 18, 2022 8:14 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; maxime.coquelin@redhat.com; > > Cao, Gang ; Liu, Changpeng > > ; Xu, Rosen ; Xiao, > > QimaiX > > Subject: [PATCH v8 02/13] vhost: add vDPA ops for blk device > > > > Get_config and set_config are necessary ops for blk device. > > Add get_config and set_config ops to vDPA ops. > > > > Signed-off-by: Andy Pei > > Reviewed-by: Maxime Coquelin > > --- > > lib/vhost/vdpa_driver.h | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h index > > 88138be..e59a834 100644 > > --- a/lib/vhost/vdpa_driver.h > > +++ b/lib/vhost/vdpa_driver.h > > @@ -72,8 +72,12 @@ struct rte_vdpa_dev_ops { > > /** Reset statistics of the queue */ > > int (*reset_stats)(struct rte_vdpa_device *dev, int qid); > > > > - /** Reserved for future extension */ > > - void *reserved[2]; > > + /** Get the device configuration space */ > > + int (*get_config)(int vid, uint8_t *config, uint32_t len); >=20 > One suggestion is renaming 'len' to 'size' to make it aligned to set_conf= ig. >=20 > With above fixed: >=20 > Reviewed-by: Chenbo Xia >=20 > > + > > + /** Set the device configuration space */ > > + int (*set_config)(int vid, uint8_t *config, uint32_t offset, > > + uint32_t size, uint32_t flags); > > }; > > > > /** > > -- > > 1.8.3.1