From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C549041D8F; Mon, 27 Feb 2023 10:28:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3CEA41143; Mon, 27 Feb 2023 10:28:23 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id DD8CF41140 for ; Mon, 27 Feb 2023 10:28:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677490102; x=1709026102; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FkT9Pg757jiNMrXhXVQx7DHUCqNtk81kmRczchVf0fs=; b=gdA8/RT9eOaoYObjuiedudtEQ0ypg0vJEZxkTHqXfItGx3vzZmDzgWuu 9OM6k4dcRyEAQSa1j+xVWal50JsMvQsZ6SnJfgCyXsEtkvWJrRY9Q6Fwv /9a4EfFSwLNd1sBNQ1b7P/soX3Zd7ey20Bg16bK6GwriKq3990Vq9P0ay frEUgqgR6nEUozkgxFS17Pxgtm057vUkmIHmpwVq1VoKEHQdan9d6BWTU JjXLhlix6h6dFEw2x6vOdgHV77QBkM7XdVb9/MpTddg2rL7LFcITv2XXP DeIKq9zVAN6CP8UPj4PaEoXHlnZz2XR3pcnOOTXHKsiex94H5x0F/Rn4S g==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="398593062" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="398593062" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 01:28:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="651143724" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="651143724" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 27 Feb 2023 01:28:19 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 27 Feb 2023 01:28:15 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 27 Feb 2023 01:28:15 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 27 Feb 2023 01:28:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ogr0eJ2aFigSOuAEdZ9TUoCOiluMzeyQgzGkSqYbbig5kW2Jq4h/dCZeAhHaRLTCcO5eLjcFd9mTTeTEI9ldNJIfob/wl0CUrphyjEvHETKB5fRum3WPYtEDxQtneyXsd1itFPulqJGWKDtaO8XjaDgcS1NsHs68/CJJNVLKe7AQNReSBUy55yYH0wjWeQk/JbROLGlpRfd97p1KyJPX3anJ6IQe2iasVmcNYZLfVrQAbqXIjHg/3jcqcu+pj+NePO/o6pRdER/ViqROzx0yNFvqNOj/4JMd7wSVUC+LjAJB1gX2kfT7VjO3bBC5EuUnmG1Q9McSftxAsSxbgUDRnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=elqoYlnh1Kf/8BhEZcVQTVCaUJimnP7lpFsKYq5LEn4=; b=mHU5nl9ufBi0ZdnjFf9j0aCmYtEqd/okFam4/3GUoxTENklZsrwIBE7SZm45CSHP++JYfaX1/eRMFBA//R/zYctXijOqSIxjNCIMB+ukuFav6YywhuieTc/wXWakdipf4An2lF7F6yaD6uGocpKg7p3WU2ivFTfx7rug3f9/0SfJILDxFeM3PX78OW7YSdC37JbLSgK8Auy0qPfiffyKZib/oI1ubfe54miI2wrZBjhSRjqYk2mq+zukS8LYc4Qe+Z16XZdMTQuGL94Y47C67kWiKWASQg/3ySwAzuu8cmDsDZKJmjj9O+uN3/Ap99IhAyk1b6SwW24bBFdaXUfOkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1851.namprd11.prod.outlook.com (2603:10b6:3:114::18) by CH3PR11MB7273.namprd11.prod.outlook.com (2603:10b6:610:141::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.28; Mon, 27 Feb 2023 09:28:13 +0000 Received: from DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::3c23:7638:8d23:670f]) by DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::3c23:7638:8d23:670f%5]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 09:28:12 +0000 From: "Dooley, Brian" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: Anoob Joseph , "jerinj@marvell.com" , Akhil Goyal Subject: RE: [v1, 09/10] examples/fips_validation: fix AES XTS to read seq number Thread-Topic: [v1, 09/10] examples/fips_validation: fix AES XTS to read seq number Thread-Index: AQHZOjnavC7Ux9TNlUeRNrWIaW5Gx67ipxHA Date: Mon, 27 Feb 2023 09:28:12 +0000 Message-ID: References: <9a4bd9e1734efd66bdd4f064288db991e7dfe2e2.1675693844.git.gmuthukrishn@marvell.com> In-Reply-To: <9a4bd9e1734efd66bdd4f064288db991e7dfe2e2.1675693844.git.gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1851:EE_|CH3PR11MB7273:EE_ x-ms-office365-filtering-correlation-id: 76abbba3-bd5f-47b2-b2f1-08db18a4f2b6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mViD2cdGJoXTUM938XfoESCW34/LGWeMBNt3xGfHuJ5QqPpfwXi2bwyBEblrD4Qx8O2SrrcBBWFbOiZz0La0l/Nn9DA9FSgNSPVyUdn+HaD7G44371DiADj0+2q9KWc8TvnZ1bQbPDteNxgKU5g/kHskA51JO0V3gt3L1jbu0mOI/ueDeveMbDNZoLdDZluUb/Im2CygSDZzn/fo+v9XlOkYGpwkqX+lH+JiEBJfrInG9n6TO/MWOTNuq69UqGHVqESgjRRjQ+JC+2iRXImyYyDXUB+tEMBRzYGO5btaBbNY8aQlisTawwJ1AC2Gx5tKhY25uSJVA6gnt6dErN+O4+Box2FoST1UY21rKuezmQ74sotrw5l6yRTd/N/uAaXV4gBMI/LorqSHalRE2JMtlggjhl0gi9RikS1FdeOWCYWHwfEfJjTU0nnvsVoN8ad3CDrCsvhwPWYpCsfIEfQLIY3y2loagyBf+lGvjfn2acZxVgbUf6OHA8fOklBU0vElT60jsjNUIvBmq8vFcmEujTGn0j4HisWJIY0G4qyop9EhWPntUeFK/9MHhKu05GWCfecF1kYMFpo7LkYtaadC1YguDpXi4QTstHgy86tj5BHfLIs9S9hcU/bn67ADkUBgkZOPn0QpsDr4sFlNj/TedmzI9nw13VPip4tnouepnoju/bIjX5AzlVxDy5Vue3mbr2f2DDF1m8mEPJBI4ysYXA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1851.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(366004)(376002)(39860400002)(346002)(136003)(451199018)(52536014)(5660300002)(8936002)(6506007)(53546011)(38100700002)(82960400001)(122000001)(83380400001)(26005)(9686003)(186003)(110136005)(86362001)(316002)(55016003)(41300700001)(66946007)(76116006)(54906003)(66476007)(33656002)(66556008)(4326008)(8676002)(66446008)(64756008)(7696005)(71200400001)(478600001)(38070700005)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HOSiwbjNeyvZzMP6E5XM0UQIlPT+fDo1kwBh8FMWg5vDuJZgpuY+w52XpCVJ?= =?us-ascii?Q?PtAx1LnohDy3LP4ADTkDx6bDN1u/gc98bNR1dwftHHEdCsA4CE1OJ/5hg2No?= =?us-ascii?Q?syoU+ttiZpCsxKjsGVrI8nBW7VdPDAFweJ2I7GTq+38/RgJzSkTcUsJvc+GP?= =?us-ascii?Q?ZN9snhM+Ac82v+1trJRiFefupq6DgiPdu9WTp0gqyr5WpF9LUPWSF+2/xmxZ?= =?us-ascii?Q?5hoGI8jg2bhDz3ny1wUd2mBoA9ozGj596dPCRuXvwQCG+KEfKHGjyCOUUKch?= =?us-ascii?Q?5LdpkcPsTjdaq5bfRb5wL+odl4IqbLCKxcYDMfZGK97gogD4GvHBmzrCwtTT?= =?us-ascii?Q?6QbrefsAKw3zPoNw+TEOZAfx0pDVTzEUgRqtCyBIhj/xKLPuy25iT57phyvO?= =?us-ascii?Q?h01MKIsTAPrllXCbKfRLZxVw3oKGSyJqzI9JdfNHsMN55qPODTUqMtIsPrl1?= =?us-ascii?Q?yQeCZHexvp99+fvcodzQRFlfQMSbe4MzZMAhhr83ZyMOm83h98y4/+7ZPJcO?= =?us-ascii?Q?U42gs704xz5yIAhpoqrd9AEFbtRYnMj7rZ5NOiISvRmN8WWBUW5HGFDD6/27?= =?us-ascii?Q?3D73AoFyXXXSQLvqAIF33hByLrWpWiZHqO1vn7f3y0OVjSnw7Hbaq5CG3xeT?= =?us-ascii?Q?nE77Ww3nXCakjoQDJ0fppk9OvrNaVpcmx85N336AcvleqdlXVMnsUELQGky2?= =?us-ascii?Q?ge4HhmoOZkXa2kVXut8z+qsN/O5ETsDzsvpI6FF8S1Ges4cf1KFYm0+PnZNy?= =?us-ascii?Q?N0KARYbvRqUZt85F7YOSYLGoP8osE68QLDRw0NfT8oX/SmYjAEqbZ15NUKsV?= =?us-ascii?Q?kcmyNLp6V7dY5yrt7WEMwH6FOoxZPDyEaJyaJhIjxhR3WMyyy5CH1fNYmBeF?= =?us-ascii?Q?/Mjo2aedMS0KXGrvKLzwIpURPsrvpWtyOqDF8gqqeLNAT2pbPAdx5Ox7Vt9W?= =?us-ascii?Q?rlwvBQA3jFNPdMwUbqhW40UhU+QGz/QY/Ewb7HabhBdXI9/UVa4CPiSyczDJ?= =?us-ascii?Q?mhLqqjWZzt3lM+Cb6Yeq1Xg7578RXLn6pBcrQx2dxqrCVf01Y21zAcGZjJRV?= =?us-ascii?Q?MlAmt7HZGGacXPwtRq/n5B3ixCxg6AVOKn0yT6RO1wdPZdXhNUh0h+BlSLbj?= =?us-ascii?Q?k8prikNN5tSe81Y4hJbYaGTQl0Brn2RhENWAuURfCPBqbyYGyuJkGKuHIIV3?= =?us-ascii?Q?Fu9wyUF/J6VvYW4JViTvvSq7pGOtDLBgvJB5LgBKtSIYCwzis1DIi01il2yA?= =?us-ascii?Q?PdsTkzi813E1lu15s+xW/mZVppBuYw8Cq5Mq9zOhssB/lJfRCWOjhOEVR8dR?= =?us-ascii?Q?LYreV+WlyObBR2kqkCFVnTP451v9DurT8kl3UI1jcDA40gqKaQkkoj0aRALn?= =?us-ascii?Q?J0OHffyNZpq2tIlMgs6aZjCFR0L4Kpn5glmqqYmS84sux3Z8I0MzimEY3W37?= =?us-ascii?Q?FzmK9sy6YqN4rB6bKlwQku0n9IMUGhV774s9Ygyuae010FlUqYgTCM6wdnvp?= =?us-ascii?Q?rCCV2UQnf/JmzCImQAAjP2NhBiwcPve4wtmAlJiYAlweaTXpvocEE4gONcgL?= =?us-ascii?Q?i5kKgsk+twwfWhw2wv8mkD7yQqEXyMMzDJuQT0z5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1851.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76abbba3-bd5f-47b2-b2f1-08db18a4f2b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2023 09:28:12.8663 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cFCb/Fvbkld/8o9hEcQNjHlliwtMcRE/txm8THcGqGvTRhRO6yIbJ7tiBJhskpzTIFA2V+pvcydsGqcb3lzTaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7273 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jerinj@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 09/10] examples/fips_validation: fix AES XTS to read seq > number >=20 > Fix AES XTS test to read sequence number correctly. >=20 > Fixes: f8e431ed8f6 ("examples/fips_validation: add parsing for AES-XTS") >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > examples/fips_validation/fips_validation_xts.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git a/examples/fips_validation/fips_validation_xts.c > b/examples/fips_validation/fips_validation_xts.c > index 531e3c688e..530df78ab4 100644 > --- a/examples/fips_validation/fips_validation_xts.c > +++ b/examples/fips_validation/fips_validation_xts.c > @@ -34,6 +34,7 @@ > #define DATAUNITLEN_JSON_STR "dataUnitLen" > #define PAYLOADLEN_JSON_STR "payloadLen" > #define TWEAKVALUE_JSON_STR "tweakValue" > +#define SEQNUMBER_JSON_STR "sequenceNumber" > #define PT_JSON_STR "pt" > #define CT_JSON_STR "ct" >=20 > @@ -95,14 +96,17 @@ parser_xts_read_keylen(const char *key, char *src, > struct fips_val *val) static int parser_xts_read_tweakval(const char *k= ey, > char *src, struct fips_val *val) { > + char num_str[4] =3D {0}; > int ret; >=20 > - if (info.interim_info.xts_data.tweak_mode =3D=3D > XTS_TWEAK_MODE_HEX) > + if (info.interim_info.xts_data.tweak_mode =3D=3D > XTS_TWEAK_MODE_HEX) { > ret =3D parse_uint8_hex_str(key, src, val); > - else if (info.interim_info.xts_data.tweak_mode =3D=3D > XTS_TWEAK_MODE_NUMBER) > - ret =3D parser_read_uint32_bit_val(key, src, val); > - else > + } else if (info.interim_info.xts_data.tweak_mode =3D=3D > XTS_TWEAK_MODE_NUMBER) { > + snprintf(num_str, RTE_DIM(num_str), "%x", atoi(src)); > + ret =3D parse_uint8_hex_str(key, num_str, val); > + } else { > ret =3D -1; > + } >=20 > return ret; > } > @@ -122,6 +126,7 @@ struct fips_test_callback xts_interim_json_vectors[] = =3D > { struct fips_test_callback xts_enc_json_vectors[] =3D { > {KEY_JSON_STR, parse_uint8_known_len_hex_str, > &vec.cipher_auth.key}, > {TWEAKVALUE_JSON_STR, parser_xts_read_tweakval, > &vec.iv}, > + {SEQNUMBER_JSON_STR, parser_xts_read_tweakval, > &vec.iv}, > {PT_JSON_STR, parse_uint8_hex_str, &vec.pt}, > {NULL, NULL, NULL} /**< end pointer */ }; > -- > 2.25.1 Acked-by: Brian Dooley