From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7422641D8F; Mon, 27 Feb 2023 10:30:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 629F3427E9; Mon, 27 Feb 2023 10:30:37 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 9A81A410FB for ; Mon, 27 Feb 2023 10:30:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677490235; x=1709026235; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IFOyXvbtXF2nUXiAvVe8KAnmJukKFevmzy0Qbn0bBgw=; b=Fsyln1vmRy+zU1QvXYbyA7ntQSiW8twWJRSoltL/UkGwVfWCmyaP96aR uU3+CuSQfNX3IU/LhVV/e0FOa2q+FcNhDEG0/o8l/4DjqTTj85jBKXJhS Ccn2rfM272hinnyL95JsLKVvwEQ9XxaEHCAwdSSGwDdzzd2vknMgJzXOq 7EVXKbhNql/4cQ28BY1utfCFggz4KhSlXhAUOX1xLftQvqa7pKc3+SWd6 ln3E2a37djiRipASM/hfq+5rn4UBhx/HFMyPxWh4Y3DyyaV8vbfnip//Y TdYmo/xYTVZIQyjjwPzWWr8vpQorvM0KtfhvfhVc07fFsEDRJ809nkkUK w==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="317619088" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="317619088" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 01:30:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="797544341" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="797544341" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 27 Feb 2023 01:30:32 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 27 Feb 2023 01:30:32 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 27 Feb 2023 01:30:32 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 27 Feb 2023 01:30:31 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 27 Feb 2023 01:30:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UtvhniUnH55K7TrN/DCAeVJfdDRDQ7IAg4IiFLESGeKwYLPAMa0qiCtDhJ6zPJj4hK9KVECy1eASbaepukMLAE5g9cfOvVBJfG8JPV7qVrQ8fszQrWUZukanffydCOb77MVWLdQ/4eQOSrvOl+mgV9hjb9j20vZvWo4CIQ7mGLmlAznx4ExIdnpPTSNLD7EjMV8c/oEznbDH1eDcf/XUInZjh1dg4RgzU6hjbZMGagYRwHGsJDD+1fa17iaU9Qri9NGH3uYS6LquuOW6ptCOl8SSkHlwCqw13d6FS5SsRxHdY7j1kO9C4qCAb5ZbZBwg9RiVW8p2e60VPQrgc1KcLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AwDRGSgvsKZ8+wZ4sBcvO4mSk2uP92yJjybrFZNCTvw=; b=c80nNBuTwEQBGoTE8i5AFUz71jSfhtbAsUvTBOEoLSazhE4fcGQetdR5V/K4dLvV/JJej5izxvF0q0z7Xe7IldBpnRd+/zCH9HpZr7K9udtwWI+iPxkuUuhUfPMkXBqXUBIU7MeDTsipbP87lEA1yLU4XHsJR5rgNvkxlwPq7pRfxHVhvLmy1h1NCbdoERCvTeBnlnMrV/VIz8Y98U9Dk0HNkf2fMINFS9SiGHjXgW4hsLlDpGlWoYT820c6YEu9At5JfKMoG9kTJmj/F2LlXmBuLBHqYW+qYgRDp0cvJ/HITgp+MGu9qnAdt/A7ph6gcdER81b1Yg2HN1GR5WFzUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1851.namprd11.prod.outlook.com (2603:10b6:3:114::18) by SA1PR11MB6664.namprd11.prod.outlook.com (2603:10b6:806:258::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.28; Mon, 27 Feb 2023 09:30:30 +0000 Received: from DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::3c23:7638:8d23:670f]) by DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::3c23:7638:8d23:670f%5]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 09:30:30 +0000 From: "Dooley, Brian" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: Anoob Joseph , "jerinj@marvell.com" , Akhil Goyal Subject: RE: [v1, 03/10] examples/fips_validation: fix integer parse in test case Thread-Topic: [v1, 03/10] examples/fips_validation: fix integer parse in test case Thread-Index: AQHZOjng1BUAzIaTu0yYIXso6p/WR67ip8Ug Date: Mon, 27 Feb 2023 09:30:30 +0000 Message-ID: References: <1f5637764dc057ee58ad6354f13296acc3b46fa7.1675693844.git.gmuthukrishn@marvell.com> In-Reply-To: <1f5637764dc057ee58ad6354f13296acc3b46fa7.1675693844.git.gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1851:EE_|SA1PR11MB6664:EE_ x-ms-office365-filtering-correlation-id: d21b7ebb-265a-4eae-84c3-08db18a544a2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +5aQWA3v9goaOtvcMLo9O8QIjDJd2QWuqtIzcqThspUfPlqnSZ8IOTwj521pagS/xmGpyaDMVFbfMFwXpk6D39gcV9L1nm67KHG7Ryoc/jszj5Wv52kYln7mID+BU+tsJiTTpbVjvmkxhrtI+RCtbbJjhHio7n3nqk+8iacNkJfq6G2fhxECo9KTFV0jvvtmUHonKhCPlD4dUKry3Wk0M5kDD2xFHt1qvOlEYeQH/207cvX3nZHrnxsKw2fZAVD6wv4jf6LG1UcW049uNfH4/Pq8CIQRKD4YT8CFSh6BnEsUulbcMHnJ08LCSHaDGm4Dc+mqMeKztgQadn/xgkvj8h27qAsQg4G/d1KTlkpfQpjXKv35BJbyJJIlNb8RAlitN+6jxb33LWG0SvOtvhTrnJDCpdr2IkV57EU4VUbtYlTQQFkqFQWoibO3+h129OhrJ9zWwI3MvHcvGtaNYCYKemegiOuzVPRXDxl/Uuzdx3iKNBdc6A8HeNOXMJrsbqjLHWCfDW5b45FAya8yQvlTgIlggXiUIkQxnQWyaChe8Obyr4AfoqUIVM3S2GSA60XLS2/YG7GloJ0oy/ouCOuq07zzJxPkYsFDys9L76N/BzbgaP438yABEa5LLEpY8hi+ns9AoiMnb/yJ1fn1vchCRIvdoKixEJ+hNWWRN+qynxLsQSJz4HOX1KjEteg4EHNMh/MBhX0i3S/LOEyxoChWug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1851.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(346002)(366004)(376002)(396003)(39860400002)(451199018)(110136005)(54906003)(316002)(33656002)(86362001)(55016003)(38100700002)(122000001)(82960400001)(53546011)(6506007)(83380400001)(38070700005)(9686003)(26005)(186003)(5660300002)(71200400001)(2906002)(7696005)(8936002)(52536014)(478600001)(4326008)(41300700001)(8676002)(66476007)(66446008)(64756008)(66946007)(66556008)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rq1ybcd+JpxKzBCI65HbIS1ub5F3eSUjz9LiOBgF07kNIx+wpsMBirnARsdh?= =?us-ascii?Q?+y9kUArHaAGE9FnRs3k6AXz6EJ8H/tPDgiBn71KW8zjTG6MDBeG6hHXJptf8?= =?us-ascii?Q?ghXo6BoVRvBGuv9BoU05lr0/xIBmcH4dfLcujIh117qu7hmyMNGlyV1WYlFQ?= =?us-ascii?Q?M9qp6aNurJFbMAgOgD2LXK60rwZswa2uogi6BotMbHXC0Y8OyrhgttrqvT0S?= =?us-ascii?Q?0Ps5vm2S/mZlFkHBhAZvtTC2Qg1TYgZG/3Ds/sIbDDlbDpIOGByqq2Z0Z+XM?= =?us-ascii?Q?FWeTkIQgazGtwhBfAULjnczb79jxYeEuvaSA19An77nCMXYsn1P/u40LjegM?= =?us-ascii?Q?WqnwCXjYfcIA/TkDOFOjbm/EcW77MkXv0WADPA774ELi8TjnxiKQ7frPp9aD?= =?us-ascii?Q?MN/W2EzDYRp3GK0Cop0Dwqjq2ko77AXjeX0tGT4zXbp4HUvgb0EosA/42hBM?= =?us-ascii?Q?9R3ua3CKNqTaUNj4TgPla+emH9JlJJ4zb8xON6p/y5V9VBk/PacprGMlyVE+?= =?us-ascii?Q?hyF2bi34utq96Hc9b8m5tMCRv7VA3ned2LlbmgR2yPQjxSUiu/dVo6UX5muG?= =?us-ascii?Q?dVxmVKWn20bYxUtPPEjBBOD8m7hsbYz0pJbqtVi9dxHD90RgOtA00vMzoPr2?= =?us-ascii?Q?oep4DVFOKVeyXrksVathapqYCqtYGdiz+oY7/5Eb50W1IU3WWinUfVD8Xi7I?= =?us-ascii?Q?yemW7ZhLhJVU8w01vvpB8CY6/wJTpc2yW7xN/Pw+V7VVxe2UjV3PCCe2x/aN?= =?us-ascii?Q?rq0qaFRRPDTHQ4pI9EY+01QW/KRg9DTWxW/Kb5kT+vY8rX76+QSapwvT55Vd?= =?us-ascii?Q?PP5yPY8p4AwNfCCnapj/mOD7oXdzKRS3Ybuv+eYkEHJ2Yt2DFDH9w1GFeyFA?= =?us-ascii?Q?ba6X4wei6K74MVsBdAy8ocXgBdRDd4POmtwIIYzWKJvtp5S/P1JhSFI+BYG5?= =?us-ascii?Q?+Lo6GytJJV/IHXZbjmfgK7zeggNmoNbdXuVQ3U5LkuAMPhG5v9PtKF++qHW1?= =?us-ascii?Q?q7XwWLR0tM8yn9F+7WyCv5/pIIF+/RA6LUSPlCxVYNhYMBhOP8yVX1UMgmDC?= =?us-ascii?Q?RVLthkBPFBXal1axJAVSujMPg+ndvJIXe3e+n8YIAQYA3rXFETHGhDqj0dDr?= =?us-ascii?Q?stLJEkH9c4ZLVQT10chI1SSTnUroqslNcs3beZum1g2xOIib1+y2DdLNzjry?= =?us-ascii?Q?f4oJS6D+P4lPN0lQ5EpfHm5RVxCVs7FkT9aq2IT48XOSxXfNx3iBKR4fSEVb?= =?us-ascii?Q?9/QWpNdeWTKMf0xKmgCfcUfIR5+EES3NNI6mwlQ+kKwgGq6/P1eAue64YufI?= =?us-ascii?Q?E3yfoJ8L/t4xWYkD1Kf48OAqD7Rxn84qkhIKfDDgrwblhY/Ax4kJxcKwOL3V?= =?us-ascii?Q?maN39MPoPct8sm/4pm+y7i1o8nbrlmBuYfswNtgA5d3QXCYEAgBDfXM1SmKy?= =?us-ascii?Q?BIDMtPpPEv1tH6YhUIDVD/iH+UOLVQ2CNWbX7UzmSPSuvWWKJNNl2bdhv+zi?= =?us-ascii?Q?BzroN6Rvew98oR5uVBvgnOWXCmBt9iJB3ZWvW78E1lIt+jfYQnb/AlLcA45X?= =?us-ascii?Q?2lcH794YTwz8sUqbEb3DyrNORlngGogXs5e+klJ4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1851.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d21b7ebb-265a-4eae-84c3-08db18a544a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2023 09:30:30.2760 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oshnHl0xNBUmNa06ZXv/Ymrs7EZ/9bR3lcVXKlZwtoKkoEkZu5HGnD84u6sZ+C84p6R1KR/74HUYKs8BXQhyIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6664 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jerinj@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 03/10] examples/fips_validation: fix integer parse in test = case >=20 > Parsing integer value in test case vector does not store it because only = string > was expected. This patch adds handling for integer value as well. >=20 > Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > examples/fips_validation/fips_validation.c | 29 ++++++++++++++++------ > 1 file changed, 21 insertions(+), 8 deletions(-) >=20 > diff --git a/examples/fips_validation/fips_validation.c > b/examples/fips_validation/fips_validation.c > index f7a6d821ea..d3b6099d73 100644 > --- a/examples/fips_validation/fips_validation.c > +++ b/examples/fips_validation/fips_validation.c > @@ -543,15 +543,28 @@ fips_test_parse_one_json_case(void) >=20 > for (i =3D 0; info.callbacks[i].key !=3D NULL; i++) { > param =3D json_object_get(json_info.json_test_case, > info.callbacks[i].key); > - if (param) { > - strcpy(info.one_line_text, > json_string_value(param)); > - ret =3D info.callbacks[i].cb( > - info.callbacks[i].key, info.one_line_text, > - info.callbacks[i].val > - ); > - if (ret < 0) > - return ret; > + if (!param) > + continue; > + > + switch (json_typeof(param)) { > + case JSON_STRING: > + snprintf(info.one_line_text, MAX_LINE_CHAR, "%s", > + json_string_value(param)); > + break; > + > + case JSON_INTEGER: > + snprintf(info.one_line_text, MAX_LINE_CHAR, > "%"JSON_INTEGER_FORMAT, > + json_integer_value(param)); > + break; > + > + default: > + return -EINVAL; > } > + > + ret =3D info.callbacks[i].cb(info.callbacks[i].key, > info.one_line_text, > + info.callbacks[i].val); > + if (ret < 0) > + return ret; > } >=20 > return 0; > -- > 2.25.1 Acked-by: Brian Dooley