From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA2C4A00BE; Thu, 10 Feb 2022 17:12:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FE4C4117D; Thu, 10 Feb 2022 17:12:05 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2068.outbound.protection.outlook.com [40.107.96.68]) by mails.dpdk.org (Postfix) with ESMTP id BDBE441176 for ; Thu, 10 Feb 2022 17:12:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VaUXFgI4Ta5ZLlgI02+SuMy3RLGbsXd842H25KFFY2Cf+T5ZuAUswQOWpLdGEIRJaIF4xxl2IZYXKs9E93vi4Fj82Vwuc8u86Nht2q1+jQKmO/yfKUolA3eJVlsNvzntLvhwGy37JjALi1pJw8lil6abge5sIu1FXfn0gBh+fBFMetsCXC5JSVU8416l0I1kTvbZ9aS/zpz06t/UTahD1CrzFRxUs3/I8LM8kpvAQFwlYjtKas1JmNIXyD4o9U5jUYiqHaWPuNeYXqCmKY08K8+vVwKz9VObBNlJYVwxXOZ2xrjVt9KFTOD8L7IKtPGzsr65WLXCIBIcQ1O8BulkWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wcFVpr2Wb+aQN3PhrArBrCa3zg/n8mifJ93X3VJu3K0=; b=ekKdws1EBQZIO5+7IEw/Apc4tpR4uN5M4gYctRSCCnflvTAdG0mr4dAe5C51/uw2PZG3dJVrgJoVANPolCKfFD7tYDwQV+puNoP6Yqa4GheZVWv12GD5/2qA7rt2Ime7K1Z1hWuFVPAFqfTz5hII/dRfPsHLVIVbL8bQliMHz13HQX7Y1QbuEnp40Uu8r/F5285ATrqai8hsbgfCRV4xFgofO0/hWkPtUuCqXQMZ+VzaXSxLPXMv6g2TzCVhZgCqaNwhK5rdJo96ylI1LhbishKlG8MjmYR6mUGQWYJD4koiwKpPPp+dE4sEZCJyEuWEOPHiMO1VDrKgzniHf/IcsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wcFVpr2Wb+aQN3PhrArBrCa3zg/n8mifJ93X3VJu3K0=; b=CRRTvR8Rd0OQ7Cy0UpFk3/ihVtqu3J6t1ac1MfSPYBI8r8bMSRGuxs8IJbp1dOUUKPUUzNMbldauLXjYvtoIk54bmIFAgGjp0/+R+comdbDCMXJTWHprrwNsN06nNjvKN96hs8cHqh4glO5rVW+bTejiiRm0Swg+5XzQPn/hZcSTtJ0yd51/z3CAwIbVCMBXSKMTAQ+x4uKYJjQ0UnSIDjDUMP1GhQixfxQMVbA0PhAvLWYlIp2OeJYkATqfh2O8Tg93E7+Nin2m5DDu878ego5LhB9IQY2yZSjqHxxIgISKhx6Mle913igkCbAlQP6+/awCWlzm5YhTUSgbq/jdRw== Received: from MW5PR12MB5621.namprd12.prod.outlook.com (2603:10b6:303:193::12) by BL1PR12MB5223.namprd12.prod.outlook.com (2603:10b6:208:315::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 16:12:02 +0000 Received: from DM5PR1201MB2555.namprd12.prod.outlook.com (2603:10b6:3:ea::14) by MW5PR12MB5621.namprd12.prod.outlook.com (2603:10b6:303:193::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Thu, 10 Feb 2022 16:12:00 +0000 Received: from DM5PR1201MB2555.namprd12.prod.outlook.com ([fe80::e4c8:ad94:bd2f:3fdd]) by DM5PR1201MB2555.namprd12.prod.outlook.com ([fe80::e4c8:ad94:bd2f:3fdd%5]) with mapi id 15.20.4951.021; Thu, 10 Feb 2022 16:12:00 +0000 From: Asaf Penso To: Ferruh Yigit , Alexander Kozyrev , "dev@dpdk.org" , Suanming Mou CC: Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "ivan.malov@oktetlabs.ru" , "andrew.rybchenko@oktetlabs.ru" , "mohammad.abdul.awal@intel.com" , "qi.z.zhang@intel.com" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "bruce.richardson@intel.com" Subject: RE: [PATCH v4 00/10] ethdev: datapath-focused flow rules management Thread-Topic: [PATCH v4 00/10] ethdev: datapath-focused flow rules management Thread-Index: AQHYHf1pgLT7GIsisUSvlA2ZSAwn36yM8o0AgAADD/A= Date: Thu, 10 Feb 2022 16:12:00 +0000 Message-ID: References: <20220206032526.816079-1-akozyrev@nvidia.com > <20220209213809.1208269-1-akozyrev@nvidia.com> <245157e3-1948-f207-9cdd-88ce22cad453@intel.com> In-Reply-To: <245157e3-1948-f207-9cdd-88ce22cad453@intel.com> Accept-Language: en-US Content-Language: en-US X-Mentions: suanmingm@nvidia.com X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aee3c534-5b97-4a62-6927-08d9ecb011d0 x-ms-traffictypediagnostic: MW5PR12MB5621:EE_|BL1PR12MB5223:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wr23Ayv6L3wj5oJtXcFyIBpSae+RakE5ZAP8i75WoYuUinSL22zCJNfUSjovrtPFmOi1LHaJEL13gsgKz1xSav/lfFFfc2Onm2a+C+7gXBLhBENzVJzVXk9wFROOzyaqNjMLaKT7MHKrAiyZCaUWUmGTH9CavRXr/ESQ8iOczxejER72BN8FQdkBt63h+vJ6Fp7jZMDjaYCDRZfwD5l60wMfcchltiTOz5XqLRYcwmHsme6UkZNwJok6ZfuPAUsnYBSC7O+mopkUyzISCoUNlWbvc1DCIGkCREOrH/rdygFcW7+AS8qVArQD0IhgoUEM6Lp3/a9XV4uufHdUXq9JicotEPT4IVvivao5IRREJCnsL10yqALqqEL9OgCJkgPOk6kUyqbl0SLle4W+MlhhEQtF7Bh8pOv6hcSe0HII4mIyq326Su3wxGHRH4Ilh1r3Wk28uqaifQmbv6yndo4DNjZ31TBLWgmMlP4WpJ8yrOrKgiFAWgZ559JIRs7D6+YWo9NScrQkJp/4m5Ls+2ZPgxGvtXEGUpsWjClpyX8Q/4k+Y2g4NZBQmCkRFfSyqgrtaVR2KIzSEhD5K4AS1Ur+4Tx3mB2vBgT37vTiU7kmY5rv+QZkW1O3rCVZQmvWuFNBTFzOpYgOrhtwGjAykz3MWsD/OP62Q9eyZW/F28IFcR0mHFLeJ35YbjR8NdZ467KyUaEwLGghEifdjWvD2AfXiV7UWjuU1JNKETaBFTiLfypBbbgdwKuIorezB+vU0qYp076DPN5t8+/lzre0Bzr5PoQEMA4C/TX6KzmSiTmkdgg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR12MB5621.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(6636002)(508600001)(7416002)(38100700002)(54906003)(110136005)(2906002)(122000001)(9686003)(52536014)(966005)(6506007)(66946007)(38070700005)(71200400001)(64756008)(66446008)(8936002)(8676002)(7696005)(66556008)(4326008)(66476007)(55016003)(83380400001)(76116006)(86362001)(26005)(186003)(5660300002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wATtY/Znr165jCMal2NABAFGiQmErpjoJmB5s+zNNnTsvqPdWlMVRlj4RiN+?= =?us-ascii?Q?soBCU63YrQLyJ54DAnA7JJe01k/STYk+V5eXr+ELRVMlNxLOwtw/9+NX/clK?= =?us-ascii?Q?lfE2fE7VYHvREWpo2RZTc17+zxyhvfxaW5rSiqOsma4uTljvLrBJ4+vLanRB?= =?us-ascii?Q?ahmJze1zLHFP5ak/6g+dECuTeSQsJK5PelSKA5JzU10Wf6tU4Pu7L9HetnwF?= =?us-ascii?Q?Zu3NjuqIyGVvysCkjygnktKb75thS9bljw3AGgt+D5yeFFbZwZ8mUuRxpw8y?= =?us-ascii?Q?oRykFg/ZcnCxzTm1bFeGahpbXhrumW4j/6ShGZvsH2ojCBFOQyiK7ruPNfS3?= =?us-ascii?Q?fzt1m90uzR+4eROI7lQDOAfxihvbDbB6O259csqVca9yfXcfrmBf5GjXyGY8?= =?us-ascii?Q?WUASojng9Y32A7GlaLNcdxDAPNuE7auMrggDU/8ja6wHobiNu1N6AZ9NhSqu?= =?us-ascii?Q?nIKExIL4BZ7j/sN7C597bL9RwRpwcxCwjrdb+JiyyHwmlKT6q7FbBNG0QxkC?= =?us-ascii?Q?8MZYSD6aTWshf8pTDloJDdMcXasbBsiJtQm4ujfcxWC9GLBrrStFPtvSChZ7?= =?us-ascii?Q?RKo5s80FlBSHvFFjY80YQKUCtC85zhLpR2903C2XcpVb+khalMqK3LbM8fPI?= =?us-ascii?Q?SLsXmE6ziGqPZUP8lSZ5tuFIF5+bocw0Ah/KQ7TsrsjT8pBttKFYGzB3lpgf?= =?us-ascii?Q?txaNhkUl+RtpJ4DjlMi9TcCdhG0MYbjTYY5h/tsOF/AM38QQJoHWKiJ31BXT?= =?us-ascii?Q?ifFraVSErF8Tk6yo4rAvvzuhvRdHV7IZEQCOB/ydWtFRglv/HNwEJgvbwoik?= =?us-ascii?Q?3hNnsPzz0uFRgl2p+U0RJpQBYU0hPizUTRXJmD9NAy06K9NknJfzfeAYWVib?= =?us-ascii?Q?QStBA60ULpu1QnfiT764OMTV0zhgGjw/9aS5Qn5vpmihDYH0NWUM/6Jh1oEA?= =?us-ascii?Q?WMFFe4zmq/64y1cv7HW83gz2wZNNkjvtgNGQdwg8gYidjUWkyz17YnUB16pM?= =?us-ascii?Q?coIYL/Xoc3YER/1poM6AvCmJ/eyAM3e2WCFYlflxco6Ppa2hJ/ce6P8q/cej?= =?us-ascii?Q?+pQr/W6bPZMuvvbqUfX1CXHyXstZc3wLqOAA6XCoQ3GLjmQ6l3Qpx/3/1RKN?= =?us-ascii?Q?KUv5QzKzzawBK+4XeSfCzIc8yi8hMNzN6PEGOKRTP1JpWNC8nPfL2oenoz3u?= =?us-ascii?Q?zsanNlPh6ToTBcxmFW1bhgQ1nmOo6eMSuiFfhHXGdaSreWPzbgX2O7fqxWEy?= =?us-ascii?Q?oNd4AmC9O5NIZFkTMSc6A8w1RVikZT+d+pjbdaVGjOw655lBop3b0zmcGWNg?= =?us-ascii?Q?Ltp5VWzgzQULkwYg24KmIOrkzlw6/jaE0bemnNRYqHmyX/1HuRX/nmcya6zl?= =?us-ascii?Q?BsFOHJn0NG6XH4+ZIWpxsPc829O6xX1Y1bB3nsF6tNJqv/ZTHJKQhyriUgy1?= =?us-ascii?Q?o/+YZ6LInvfmJ8asYwbY/XX/v6QJPn5BCndW/sM4mcogcHvjnfze7RKwohRa?= =?us-ascii?Q?MmST48dTH3wn95a+SJ5gXFcX6SFnNit1Jfrr85qkSsmlw99H0FDMBCtX7ODd?= =?us-ascii?Q?JWyHR9d9TSvALWYor8d5qigv5WI4u9bTtGul42Y6qe/OZCCHJPBMf1410xvD?= =?us-ascii?Q?BbQD2DNsvH4jON7heYbV/F0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1201MB2555.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aee3c534-5b97-4a62-6927-08d9ecb011d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 16:12:00.5343 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XFo3zFracqqxg4KO1nniEGqNXg89So8dZHrqFkFpwBi6UYRDoO4IJvSpGF88CH35mOgoj9TXfQ67gsAZ52G4pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5223 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks, Ferruh. The pmd part is being updated according to the previous API comments. @Suanming Mou is working on it and will send it once ready, before the week= end. Regards, Asaf Penso >-----Original Message----- >From: Ferruh Yigit >Sent: Thursday, February 10, 2022 6:00 PM >To: Alexander Kozyrev ; dev@dpdk.org >Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) >; ivan.malov@oktetlabs.ru; >andrew.rybchenko@oktetlabs.ru; mohammad.abdul.awal@intel.com; >qi.z.zhang@intel.com; jerinj@marvell.com; ajit.khaparde@broadcom.com; >bruce.richardson@intel.com >Subject: Re: [PATCH v4 00/10] ethdev: datapath-focused flow rules >management > >On 2/9/2022 9:37 PM, Alexander Kozyrev wrote: >> Three major changes to a generic RTE Flow API were implemented in >> order to speed up flow rule insertion/destruction and adapt the API to >> the needs of a datapath-focused flow rules management applications: >> >> 1. Pre-configuration hints. >> Application may give us some hints on what type of resources are needed. >> Introduce the configuration routine to prepare all the needed >> resources inside a PMD/HW before any flow rules are created at the init >stage. >> >> 2. Flow grouping using templates. >> Use the knowledge about which flow rules are to be used in an >> application and prepare item and action templates for them in advance. >> Group flow rules with common patterns and actions together for better >resource management. >> >> 3. Queue-based flow management. >> Perform flow rule insertion/destruction asynchronously to spare the >> datapath from blocking on RTE Flow API and allow it to continue with pac= ket >processing. >> Enqueue flow rules operations and poll for the results later. >> >> testpmd examples are part of the patch series. PMD changes will follow. >> >> RFC: >> https://patchwork.dpdk.org/project/dpdk/cover/20211006044835.3936226- >1 >> -akozyrev@nvidia.com/ >> >> Signed-off-by: Alexander Kozyrev >> Acked-by: Ori Kam >> >> --- >> v4: >> - removed structures versioning >> - introduced new rte_flow_port_info structure for rte_flow_info_get >> API >> - renamed rte_flow_table_create to rte_flow_template_table_create >> >> v3: addressed review comments and updated documentation >> - added API to get info about pre-configurable resources >> - renamed rte_flow_item_template to rte_flow_pattern_template >> - renamed drain operation attribute to postpone >> - renamed rte_flow_q_drain to rte_flow_q_push >> - renamed rte_flow_q_dequeue to rte_flow_q_pull >> >> v2: fixed patch series thread >> >> Alexander Kozyrev (10): >> ethdev: introduce flow pre-configuration hints >> ethdev: add flow item/action templates >> ethdev: bring in async queue-based flow rules operations >> app/testpmd: implement rte flow configuration >> app/testpmd: implement rte flow template management >> app/testpmd: implement rte flow table management >> app/testpmd: implement rte flow queue flow operations >> app/testpmd: implement rte flow push operations >> app/testpmd: implement rte flow pull operations >> app/testpmd: implement rte flow queue indirect actions >> > >Hi Jerin, Ajit, Ivan, > >As far as I can see you did some reviews in the previous versions, but not= ack >the patch. >Is there any objection to last version of the patch, if not I will proceed= with it. > > >Hi Alex, > >As process we require at least one PMD implementation (it can be draft) to >justify the API design. > >If there is no objection from above reviewers and PMD implementation exist= s >before end of the week, I think we can get the set for -rc1. > >Thanks, >ferruh