From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DB5AA0524; Fri, 8 Jan 2021 17:15:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 201BB14101D; Fri, 8 Jan 2021 17:15:33 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mails.dpdk.org (Postfix) with ESMTP id 6709314100B for ; Fri, 8 Jan 2021 17:15:31 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 08 Jan 2021 08:15:30 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 8 Jan 2021 16:15:27 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 8 Jan 2021 16:15:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBX1CdU4ZV94tZcpXWeKTGkSMyoNzutO4eUl9i9vOb2lhjoq8KMHM9P6yS9mn8JVxAQKpanYs4rg5aNzhxgFVrmMNg1Bke2asH5e3gslLYJnV3dZYBcpzkCX+h8wlXX3XbdiUGRDHeaOa+sqCV7DcgJvUT0ZyjwaVv4T+/9H/4WyF2a5NxxOnwgJh1D/UkolPz3X97I3mNbD1o2zXeWZLLwcJmiSlTvj6i8kDjfS4UDmbhdmis1RXTsk1NaUwjEWOY4RRuRiV8ELdgFvXA2TS3octqWy0FyCT2Ahar8xTPbC9OgLktGMVPO0LJ2bJeSKpzoFlAnOTKs13lo2WMhbSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=abWD4ThMsVQ6VA/z+00Iz1ipQyWw8gZQGE0TMlPUmsM=; b=ntOvoawHYwJTezYyFb7JFrp51glyL9LLSK8bFT/FwlzGKi+KTtdLxo4GFe/Jxh0XKdCZV3ikYoNDaq9ZjG1KCtSIlFb52JwcXa924eD8H7eLmTCxSTlB/s/3hJEm1ZhGn7ZqqhrbQvKAHJFA/i2nMkdbn0ViCf1MDzhVYPgecyT99kNJsCYDWcwieISm6xdeJz1XViXKXfhYzuzrf3UnZ4Ml30BpVFvEvg9rwfQBpipECbg8VjvNpzXG/UoV+Ig3duJerMiPyVygq51nmdGcLYpR49ldCSee8xCyR/vxgYYBWDk2EtNH8j5Iu6aTshGEUhjXSxjqGRs9PHZih4ZX3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM5PR12MB1161.namprd12.prod.outlook.com (2603:10b6:3:73::16) by DM5PR12MB1450.namprd12.prod.outlook.com (2603:10b6:4:3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 8 Jan 2021 16:15:26 +0000 Received: from DM5PR12MB1161.namprd12.prod.outlook.com ([fe80::7473:5c35:8ac9:72a3]) by DM5PR12MB1161.namprd12.prod.outlook.com ([fe80::7473:5c35:8ac9:72a3%11]) with mapi id 15.20.3742.008; Fri, 8 Jan 2021 16:15:26 +0000 From: Ophir Munk To: NBU-Contact-Thomas Monjalon , Ferruh Yigit CC: Tal Shnaiderman , "dev@dpdk.org" , "Matan Azrad" , Raslan Darawsheh , Dekel Peled Thread-Topic: [dpdk-dev] [PATCH v2 24/35] net/mlx5/windows: introduce flow support Thread-Index: AQHW3RWwtCR5T1R0Z0C/lnLqNWw/Tqod3ZAAgAAEyICAABS0UA== Date: Fri, 8 Jan 2021 16:15:26 +0000 Message-ID: References: <20201217173037.11396-2-talshn@nvidia.com> <20201228123302.3608-25-talshn@nvidia.com> <2671191.3mBJzJ6San@thomas> In-Reply-To: <2671191.3mBJzJ6San@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [87.68.240.207] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4b23eeef-0563-40d3-5e34-08d8b3f09c18 x-ms-traffictypediagnostic: DM5PR12MB1450: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4FmYUWNfWKi335U4VtRY6vCdViUExVHgQ04PVvWZNYU18j+s0FTghDHwIS0G/UlyIZMe9VLBMCuuAYXdni0fx4hX5JUx13MEJYR5qy7ZzfuN1/97qsb760neSKm9DFJ4/Qx3A3qKdjgOkKnAihauNiLjbLSXALtv8gvbVxzOTCj0GpwpEIKM9nQdx46pGrmDNFFgkdh5EeZonDtN9lXNbhCmCXAA3am+CxV8PwGVAPxJsZsZezHaPQzWogrOL1dLfINQ9zJbI3qnYcBsGCl9R3aDH2pO3s1fbrjFpM9EtKi76eaOJMFNlz6LQuPas6OfeGfI3NQ+2mfiOYIcIwtD+PgbT6KyY8JqM1zYpHPZ2dWP82r04dRbP+eP0yPqAMCRlXhKUSbrdaQgsHKxTsAi1g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB1161.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(376002)(346002)(396003)(5660300002)(4326008)(9686003)(107886003)(52536014)(83380400001)(86362001)(8936002)(478600001)(66446008)(33656002)(7696005)(64756008)(66946007)(66556008)(66476007)(76116006)(2906002)(8676002)(26005)(53546011)(186003)(6506007)(316002)(110136005)(54906003)(71200400001)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?R7FRbe39OACc8R63MScR3wYk8jr9OMohBU9b16edbZT+jG8XgTPIIHy5/DhN?= =?us-ascii?Q?WkgoOWivy66YY1bFuvOcf6WN7EtlL53tqx15o3pBXIvATT6v+eIaGm+z9dKf?= =?us-ascii?Q?Kby1mU1w3utKA6Gwr/HNszvwLOFvFl2O+i+maEMDdPMESv42uhmre5EMhHVv?= =?us-ascii?Q?r/8ftLBl6lN5gomeO6aaGHVLZ/d49OpbUGDJZUVW5mevWjh9wuqr/lVAKFjn?= =?us-ascii?Q?Lc8v8zrwl6SfP2IJLlcmoh8qun2khP5DREO3cCP3yOQG3WdIfTmUAbe5Wrtd?= =?us-ascii?Q?Pvxc+DQbakpY540hCDCF/lUjuHPIJTPxHxv4Xt5uxOtmReEovlSYdHihyOud?= =?us-ascii?Q?ptxdwvIw3Z0p/SuGvBwosugQsuviixK7JLwD9Qc3n5qCLQhPSdzoCK3PuxmC?= =?us-ascii?Q?PjS1MPrI6BVokJT5pzBUK6Xge2ziqNUAOIGwR4AEcGsAfYZn/PbRkXJyhLLP?= =?us-ascii?Q?p6e5Qmf2wAizmluSNg/2EmWnhT/ivfVpI6Hdx1gi3AAnpFmmR2docfv+Sd7g?= =?us-ascii?Q?RfsmMn8kQEs2t0k37FzFmxujNs55K+hyC0gHNdjzJemORZCLan6XZ3lUMJF2?= =?us-ascii?Q?lrjxwmdCvTBWAgQhM9QtFa6ti/JcSlIgn8bjQkb8Jz0PQxOQZZH3Oz2PQeQZ?= =?us-ascii?Q?mlEMH+I6lefbcG1SX9g/nkL/aPksVORCIe9YtyL8xQavn48lmW6U2VY7lE6u?= =?us-ascii?Q?y/J//RscFccRNF9iKEaUxgETTH4B8kGE5ussFhaUqQcfgkJW/XKjGJDrBbGp?= =?us-ascii?Q?ppmMRxPaOnhkfYZ/U83T33S11wQBjub7uy/5a+UVPikorAmilCUP7xT2BPXd?= =?us-ascii?Q?9FzW59858HNUINEBExjHUv7hsQLDB+eCVniLVgnVFXqBEs1YAfBXrLLn+L9z?= =?us-ascii?Q?WGlDLd6B+TL/d1x45GwcoceZh6Zcoa6RtoauSOFGz9n99wmmpxuBTkjbQD57?= =?us-ascii?Q?YZDLEI0nrkK4bsxb2SWWXB/tmAxp3TxumIw7DHOcKwg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1161.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b23eeef-0563-40d3-5e34-08d8b3f09c18 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2021 16:15:26.3581 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lrKmRxQIe8tMuZFjy00HPt6WRnoPkIRlZyGCFxdwhvg9uHR1vKNvajM9FDMqmEIvE2hQolckRghpCVuwrMa6rQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1450 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1610122530; bh=abWD4ThMsVQ6VA/z+00Iz1ipQyWw8gZQGE0TMlPUmsM=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=rA6BCk83oS88PBHTYXIIHQxYXq/xr7DpsefmuapGJz5k5OHEYFMHe5Uookgu1BhQ3 bZw80eNbKlgGKpEqnIZ0Gz5hkS7Uqtrgal0X7ihxYA+G3Yf+9e2yaBJZ5MbhRt/u9S sgyOXn4rJ46/BTNhq55Qqz7UPUC3UI22NCR26BF+enx3qcjscXa5yQIz7s+HFI8DUQ OZNsLzkJcGgMfUs7vGSBZCF7TLv88hZUy5xuLPALDMKakxVYiiLOZ6P/obNrkUEYTn /v+gYvDIFkyqnupUc9E+munlvjPs5rU/ULznm0bQRGdcG52gMGy3CNAzkY4Qf8TCcn hYgj6c0OatEgA== Subject: Re: [dpdk-dev] [PATCH v2 24/35] net/mlx5/windows: introduce flow support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The following lines were originally removed from the commit message and sho= uld not have been sent (please consider it a typo mistake): * Alarm API: mlx5_os_alarm_cancel() and mlx5_os_alarm_set() are implemented in Windows to match their Linux counterpart, see [1]. Currently they return -ENOTSUP. [1] ("net/mlx5/linux: wrap rte alarm API with mlx5") > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, January 8, 2021 4:55 PM > To: Ferruh Yigit > Cc: Tal Shnaiderman ; dev@dpdk.org; Matan Azrad > ; Raslan Darawsheh ; Ophir > Munk ; Dekel Peled > Subject: Re: [dpdk-dev] [PATCH v2 24/35] net/mlx5/windows: introduce flow > support >=20 > 08/01/2021 15:38, Ferruh Yigit: > > On 12/28/2020 12:32 PM, Tal Shnaiderman wrote: > > > From: Ophir Munk > > > > > > This patch adds the initial flow framework under Windows OS. It > > > supports a subset of filters (ETH, IPV4, UDP) and a QUEUE action. > > > It is based on DevX mechanism to send commands to the NIC through > > > the kernel. It does not support steering rules (i.e. writing directly= to the > NIC memory). > > > The Windows framework uses the existing DV framework where file > > > mlx5_flow_dv.c remains intact. > > > > > > Steps involved in flow creation: > > > 1. Create a domain (RX, TX, FDB). Since domains are created by > > > steering rules and not with DevX, Windows does not require a domain > > > object (this means switch dev mode which requires an FDB domain is no= t > supported). > > > 2. Create a table object. Windows only supports table 0. The call to > > > mlx5_flow_os_create_flow_tbl() silently returns successfully. > > > 3. Create a matcher object. A matcher struct is created by calling > > > mlx5_flow_os_create_flow_matcher(). The matcher validation and > > > translation are part of the DV implementation. The matcher bits that > > > were created by DV in standard PRM format are copied into the > > > matcher struct. > > > 4. Create an action object. The call to > > > mlx5_flow_os_create_flow_action_dest_devx_tir() creates an action > > > struct with the TIR type and id. This struct will be a parameter > > > later in a call to flow creation. All other action calls (e.g. > > > packet reformat, header modification, jump to flow table, etc) > > > return with a non supported error. > > > 5. Create the flow. The call to mlx5_flow_os_create_flow() receives > > > the matcher struct, action struct, and copy them into Windows > > > specific fs_rule struct, then it calls glue API devx_fs_rule_add(). > > > > > > Details on additional APIs: > > > * mlx5_flow_os_get_type() is called during flow type selection. In > > > Windows it constantly returns MLX5_FLOW_TYPE_DV. > > > * mlx5_flow_os_item_supported() is called before starting DV items > > > validation or translation. It filters out the OS non supported items > > > in advance. > > > * mlx5_flow_os_action_supported() is called before starting DV > > > actions validation or translation. It filters out the OS non > > > supported actions in advance. > > > * mlx5_flow_adjust_priority() is an OS stub for flow priority > > > adjustment. Windows only supports flow priority 0. > > > * Alarm API: mlx5_os_alarm_cancel() and mlx5_os_alarm_set() are > > > implemented in Windows to match their Linux counterpart, see [1]. > > > Currently they return -ENOTSUP. > > > > > > [1] > > > ("net/mlx5/linux: wrap rte alarm API with mlx5") > > > > Can you please provide commit hash for this commit, I can amend it > > later in the next-net? >=20 > It looks to be garbage. > There is no alarm-related function in this patch. > Please remove these lines from the message. >=20