From: Bing Zhao <bingz@nvidia.com>
To: Rongwei Liu <rongweil@nvidia.com>, Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter policy validation
Date: Tue, 2 Nov 2021 08:25:30 +0000 [thread overview]
Message-ID: <DM5PR12MB175512FB6C721919B5F373A6D08B9@DM5PR12MB1755.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM6PR12MB552073B6927279D428D6FB61AB8B9@DM6PR12MB5520.namprd12.prod.outlook.com>
Hi Rongwei,
At least, 21.08 should have the same issue.
BR. Bing
> -----Original Message-----
> From: Rongwei Liu <rongweil@nvidia.com>
> Sent: Tuesday, November 2, 2021 4:24 PM
> To: Bing Zhao <bingz@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>;
> NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: RE: [PATCH v1] net/mlx5: fix meter policy validation
>
> Hi Bing:
> Need to backport to 20.11?
>
> BR
> Rongwei
>
> > -----Original Message-----
> > From: Bing Zhao <bingz@nvidia.com>
> > Sent: Tuesday, November 2, 2021 4:21 PM
> > To: Rongwei Liu <rongweil@nvidia.com>; Matan Azrad
> <matan@nvidia.com>;
> > Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam
> <orika@nvidia.com>;
> > NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
> > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> > Subject: RE: [PATCH v1] net/mlx5: fix meter policy validation
> >
> > Hi Rongwei,
> >
> > stable@dpdk.org should also be CCed.
> >
> > > -----Original Message-----
> > > From: Rongwei Liu <rongweil@nvidia.com>
> > > Sent: Tuesday, November 2, 2021 3:23 PM
> > > To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> > > <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-
> Contact-
> > > Thomas Monjalon <thomas@monjalon.net>; Bing Zhao
> <bingz@nvidia.com>
> > > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> > > Subject: [PATCH v1] net/mlx5: fix meter policy validation
> > >
> > > When a user specifies meter policy like "g_actions queue / end
> > > y_actions queue / r_action drop / end", validation logic missed
> to
> > > set meter policy mode and it took a random value from the stack.
> > >
> > > Define ALL policy modes for the mentioned cases.
> > >
> > > Fixes: 4b7bf3ffb473 ("net/mlx5: support yellow in meter policy
> > > validation")
> > > Cc: bingz@nvidia.com
> > > Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> > > Acked-by: Matan Azrad <matan@nvidia.com>
> > > ---
> > > drivers/net/mlx5/mlx5.h | 2 ++
> > > drivers/net/mlx5/mlx5_flow_dv.c | 2 ++
> > > 2 files changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> index
> > > 39c001aa1b..591ae2764a 100644
> > > --- a/drivers/net/mlx5/mlx5.h
> > > +++ b/drivers/net/mlx5/mlx5.h
> > > @@ -622,6 +622,8 @@ struct mlx5_dev_shared_port { #define
> > > MLX5_MTR_TABLE_ID_DROP 2
> > > /* Priority of the meter policy matcher. */ #define
> > > MLX5_MTR_POLICY_MATCHER_PRIO 0
> > > +/* Green & yellow color valid for now. */ #define
> > > +MLX5_MTR_POLICY_MODE_ALL 0
> > > /* Default policy. */
> > > #define MLX5_MTR_POLICY_MODE_DEF 1
> > > /* Only green color valid. */
> > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> > > b/drivers/net/mlx5/mlx5_flow_dv.c index 8962d26c75..e516c11d9a
> > > 100644
> > > --- a/drivers/net/mlx5/mlx5_flow_dv.c
> > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> > > @@ -17617,6 +17617,8 @@ flow_dv_validate_mtr_policy_acts(struct
> > > rte_eth_dev *dev,
> > > *policy_mode = MLX5_MTR_POLICY_MODE_OG;
> > > } else if (def_green && !def_yellow) {
> > > *policy_mode = MLX5_MTR_POLICY_MODE_OY;
> > > + } else {
> > > + *policy_mode = MLX5_MTR_POLICY_MODE_ALL;
> > > }
> > > /* Set to empty string in case of NULL pointer access by user.
> > > */
> > > flow_err.message = "";
> > > --
> > > 2.27.0
> >
> > Reviewed-by: Bing Zhao <bingz@nvidia.com>
> >
> > BR. Bing
next prev parent reply other threads:[~2021-11-02 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 7:22 Rongwei Liu
2021-11-02 8:20 ` Bing Zhao
2021-11-02 8:24 ` Rongwei Liu
2021-11-02 8:25 ` Bing Zhao [this message]
2021-11-09 13:38 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB175512FB6C721919B5F373A6D08B9@DM5PR12MB1755.namprd12.prod.outlook.com \
--to=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).