From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86AB3A0C4E; Tue, 2 Nov 2021 09:25:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 679C04069F; Tue, 2 Nov 2021 09:25:33 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2046.outbound.protection.outlook.com [40.107.212.46]) by mails.dpdk.org (Postfix) with ESMTP id 4FEE34068F for ; Tue, 2 Nov 2021 09:25:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fm1acnx10TuM8nF26I5xNZesm+QRjl/pxMC79Mv3mePg7n+tTJnh3WfXiBtcxHn4WpxX2okLsyDos00rKwnuwFa2hl/A6SOtXwLxK5pnFHDd7BZMsysxNPFFlWy0VqRFFv/fiHg0izlwMAnX3rOcm68iSlau0yn8P+gEdv+pZHXHLwqQUoe3QenanOHGKcZ75mKcyI1sNmOZ64VhFu6juWfxSfUESxfClA62qSLTsk9/Icsm9Ix8sgI9DVSPlkw49ci04z1P6SyHmL8K+iBlKO2a2KRSAhywd5zxpsAz/QICszrY8d9NioV4BFWhOGLOhXhBHnduhSye8e7eKsHiNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W70ZaZGsz7lATYy/9N8GY1QtJ+kkGh101BsxvNg9Cv0=; b=lkqT72aLyzaa5qRlkCkgkivBVXQJNcXrMKeMCjlp4JA2XCgrofC7jWLONAe5GgqQFlxy7MiP7m4lGTfLBR9huZPDrmVGZFCa0zGOfdc+GgwAtvXvbKw+nQ4dqvEdmJFdCJAdhcd7z8TmszYflbwvz4pHqB7Z2xPkLLTR7rXsZy/xdsCIMwOLXVbEWaCOvw+fnoD0iM+Jv9aAlOQwrmh9bN5BHN7CS5Ry6po4wXTd4EZvL63H3NLx48Tnvnj3PCjIC7vlF3E9RdVFBeUrQIW/PNfvSimwIVgyNfd38RKVkYxqB8vUbPZWNtoPT74CxRmewS8mzO2tum6x7jMppAZS8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W70ZaZGsz7lATYy/9N8GY1QtJ+kkGh101BsxvNg9Cv0=; b=jPcL5ktj+O2lahijVzKsBgyH5HWZCmEz9mwNJTLT2gmHBDV+j6AHBZdU1e1bvkEpjZqcT7RA03qy1mJnJJCY06pcIvobhHg9QGKsAQ6evVsDdpk6q3a96D6dylgR/4FkGKtU+mN70yw5hbqL3TfCLF0muUcKJ0WBD7xY0G60AGwTi2dY+FPvpx1XjG2TxjdiVaHVRoZZlEV5nqgj+3zPrkniN+NoEQJI8VZQOFMSWjxYPcp9p5eXe9bzM6Qk0UqZj5TRGhfp50CHBUcyR0EXfph9Fyo3G/+UtthzkEOBVY0o906wZZ/OdxuZNMzbf+upGK8vxQVnNoF90Vbmcf1OQw== Received: from DM5PR12MB1755.namprd12.prod.outlook.com (2603:10b6:3:107::9) by DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17; Tue, 2 Nov 2021 08:25:30 +0000 Received: from DM5PR12MB1755.namprd12.prod.outlook.com ([fe80::f0d0:7b3c:2e7f:cf1e]) by DM5PR12MB1755.namprd12.prod.outlook.com ([fe80::f0d0:7b3c:2e7f:cf1e%10]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 08:25:30 +0000 From: Bing Zhao To: Rongwei Liu , Matan Azrad , Slava Ovsiienko , Ori Kam , NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , Raslan Darawsheh Thread-Topic: [PATCH v1] net/mlx5: fix meter policy validation Thread-Index: AQHXz7p9SfNX+WwUb0q9pQJKIud+v6vv5XgAgAABHQCAAAAvEA== Date: Tue, 2 Nov 2021 08:25:30 +0000 Message-ID: References: <20211102072240.1073955-1-rongweil@nvidia.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 574f3e07-ae81-43c0-36b8-08d99dda5510 x-ms-traffictypediagnostic: DM6PR12MB2810: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7rbUJX8oUSzez1hoP5+BSn+FSnjQvSfXsyT4k8MGO/mFqJYnu94Afhe8T4our2vFxSH+XK4JssX9UBTfEvGBI/o+kBKN8tqB/FSWGQpIuOiM/tBXfv3PyZcC3yKAZESVVexSGKZfil4i0G/an5m1bHuSZa90UNuITCdWb7OS4erWMbHb9zN8nm/ktFBq8AsavETpVDsM8vCI8wDw+MGLKAIRCo4hGeNtKI+Y1+YZ9ctfcakThLWr+x0DHgBRBRsGVHAB7pjuJJVdGbqhARbVsV/iSW07WOAifBarKqPJhBkeXwHIVd8i4f8LggiOwT7Nqm6TH4sbhUSIZtYYMRQv3NSoF9em136q3xmaSDKkqJdvJwDKeMEnt/uXXOtZ+1ZXTNSK5KuG/UvqfCsjmHpmjPZCYP2b0cCeYQFS0rd15EIwMppFG7OD+EhMd7+yJnbgeVG5/cdIG7pSJAJQY0w8+Suu/PVPcx3sxu050vFnXBHJfTkS1O9v8PGf/oRDfYWEFBmdWvd3Eh8kGUZPE4pdDjbyDGLHNwJIe5wqa23PFCKnqZmt4XcroHUxxPxS1JWo5yoab2JOgsN5duzp4s/d/lXhzHM9rFTUuUXbdDXsV5924VIBeTWtq2PYpgh4PcYhXtF9fLJ4EJIyPZz70sQrZl2CE2KlXt20r+LMEeJsBBKBUpbuoSHVQdjYAVgQsSkkgQLRpcIf8oyAYWx6R18I6g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB1755.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(54906003)(66556008)(83380400001)(86362001)(38070700005)(66476007)(66946007)(6506007)(64756008)(66446008)(26005)(8936002)(55016002)(52536014)(316002)(76116006)(53546011)(2906002)(33656002)(8676002)(4326008)(110136005)(5660300002)(9686003)(122000001)(508600001)(71200400001)(107886003)(38100700002)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yQ7VFTXlyDgfmy3jfVVza+/JnmWE+4B8ftDo8q/7f2d/h0cdBRFE646KVJDW?= =?us-ascii?Q?WMHiD01sU6alOz1TZBafODGi5JWzwK1nffMUCRwVTHMijsP48G5gO7FIDlDZ?= =?us-ascii?Q?7t7sVmgg/1PGCiBQlNbsoVQ7rVCicpNTh7vo18qGmqKgmljeGY4spHswxXMY?= =?us-ascii?Q?mUlZdt7BZ1hnfsYDOG4Pkb+d2tmgHxyQP767T/mSsSX8ver0FVNA3FgtGV2f?= =?us-ascii?Q?gaCIauC+EDSK9mREfmmngFjULklOklcSgx0iJH3Yl1/dAapjzZYeuss16h6m?= =?us-ascii?Q?G0dTePrKfb6Q8k2BGm4hD88q7/fQaMQ6Twh2I6oJt3sITI4bmkZ6ZiFaX9Ym?= =?us-ascii?Q?T+Z23nuQSYcMj+hjfCPnDelLEIiG+JBVlFNVi4kVO0Dt1S9Zn8rs/Y33RGvB?= =?us-ascii?Q?KFUwgUUeFiSNEIMtJkpQ67xHLpgR9pv0X+/1BkM13h0B/wjQh6y/QeqTlFA+?= =?us-ascii?Q?Cp4XDJpjKlSYKRo7FGt4SErb3L6zVzq9h+fFf7Anj5YwXtdSTnig2NWosAyy?= =?us-ascii?Q?IKA09Ii4NJyUC3nlfJ2W1aiXnX27Er1t02kM3Sa0benpO9MwoIiu8KTcNXhX?= =?us-ascii?Q?bbOLi5qZztOaHKnrpQeU6wdQA4W1hSb/TMGicg7HxpbeMbdXH4m/yClMxiCm?= =?us-ascii?Q?wtg0r0zP37NnIWuTKiZGGzCrV/f1K/kaSfgGhq/w5Lq30glDRlwvGYSh96ml?= =?us-ascii?Q?XF0cZQZXOSWnIofwiZdFHnp7epGc0vualBKXHzWRyPzGIudmwOwvqtebb9OF?= =?us-ascii?Q?qamc1zt9VPzSHX8UiSYkNm7tkqusxgjMY851JA8P1a8ak3Clsw6GBX9w4jzt?= =?us-ascii?Q?CxlfkM3edOGOhvbqKohrKVU4aCxUFDDZjHnlh41ZHVMaEvzdDkI1qDmnfrhe?= =?us-ascii?Q?lqVEo7cro+mjeyRkVLXtO2TTgQPArryVvZd8N17QTvgbK+E6xQ32Uhn4taah?= =?us-ascii?Q?xcHYj7+KM4HQFB9QiQGh/WYPwUGQ1FgQXQJahCM0Tjak7QmUHYGz1uHgEoF+?= =?us-ascii?Q?DfbyX9csr/ov8pbVAj2KGSPbCJhMeck7bzgMpreRjcGSUh/ZdNJVZUpQ8KvN?= =?us-ascii?Q?s/blvwNVdnzOL5U4rB7kVorByxd+rYk+Nqjqz7XFXyRUQqYh8w+XZo39Fbe/?= =?us-ascii?Q?YlfsvreDbxaGHCt4eZABfDgo/uddmxNSty2PAIOVt2oMAycYDf27ijog8pAm?= =?us-ascii?Q?ASoHI/PB9B2iTMMTbsWnfofN4tTsSm/sSmAA4ucAwRJpp0d6ksmh+nCcQ7eG?= =?us-ascii?Q?RMJswL5eqyJ+wEGoCfiLXRETxqksOe+6WL3lnucusjafz6c/odRk/w0wGWYB?= =?us-ascii?Q?Kit1/IYKICzVc4jz/wf4y0/cktULNgt/p9qrvjvVg085pu6aCwTeLoYPJrko?= =?us-ascii?Q?LgMkwroze2+iQDHW/clQjDZJBQIVfxsY8+H2AUkE06SgJ3EwX9aPscvhsPD6?= =?us-ascii?Q?9VikUP+KjAoR4ptKjkbWLmto3sGtVNTxGh1abMRg2laGapfdICCCuQ3l+OWp?= =?us-ascii?Q?KhIdJ87goXArD29DKAETnsioCX8jIZwZwIxuNkVQx0xqJ1dbyZ+6BKOU+Gj8?= =?us-ascii?Q?DLWzJSi/4vovzJFChosyUQmnEAR/PsMaMXM31cJxogEJKQFbW/D9BWJjcKTf?= =?us-ascii?Q?aQMSCoH4MsoXVranIcvOizQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1755.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 574f3e07-ae81-43c0-36b8-08d99dda5510 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 08:25:30.3493 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t3u3qO3DXMyFZjGIRhpjiW/AZXMNnw0giLScmTGZTQZRGjT1TjiL6uLbI2rv67nsZZMeEsf1djzoK3PygLjlaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2810 Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter policy validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Rongwei, At least, 21.08 should have the same issue. BR. Bing > -----Original Message----- > From: Rongwei Liu > Sent: Tuesday, November 2, 2021 4:24 PM > To: Bing Zhao ; Matan Azrad ; > Slava Ovsiienko ; Ori Kam ; > NBU-Contact-Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH v1] net/mlx5: fix meter policy validation >=20 > Hi Bing: > Need to backport to 20.11? >=20 > BR > Rongwei >=20 > > -----Original Message----- > > From: Bing Zhao > > Sent: Tuesday, November 2, 2021 4:21 PM > > To: Rongwei Liu ; Matan Azrad > ; > > Slava Ovsiienko ; Ori Kam > ; > > NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Raslan Darawsheh > > Subject: RE: [PATCH v1] net/mlx5: fix meter policy validation > > > > Hi Rongwei, > > > > stable@dpdk.org should also be CCed. > > > > > -----Original Message----- > > > From: Rongwei Liu > > > Sent: Tuesday, November 2, 2021 3:23 PM > > > To: Matan Azrad ; Slava Ovsiienko > > > ; Ori Kam ; NBU- > Contact- > > > Thomas Monjalon ; Bing Zhao > > > > Cc: dev@dpdk.org; Raslan Darawsheh > > > Subject: [PATCH v1] net/mlx5: fix meter policy validation > > > > > > When a user specifies meter policy like "g_actions queue / end > > > y_actions queue / r_action drop / end", validation logic missed > to > > > set meter policy mode and it took a random value from the stack. > > > > > > Define ALL policy modes for the mentioned cases. > > > > > > Fixes: 4b7bf3ffb473 ("net/mlx5: support yellow in meter policy > > > validation") > > > Cc: bingz@nvidia.com > > > Signed-off-by: Rongwei Liu > > > Acked-by: Matan Azrad > > > --- > > > drivers/net/mlx5/mlx5.h | 2 ++ > > > drivers/net/mlx5/mlx5_flow_dv.c | 2 ++ > > > 2 files changed, 4 insertions(+) > > > > > > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index > > > 39c001aa1b..591ae2764a 100644 > > > --- a/drivers/net/mlx5/mlx5.h > > > +++ b/drivers/net/mlx5/mlx5.h > > > @@ -622,6 +622,8 @@ struct mlx5_dev_shared_port { #define > > > MLX5_MTR_TABLE_ID_DROP 2 > > > /* Priority of the meter policy matcher. */ #define > > > MLX5_MTR_POLICY_MATCHER_PRIO 0 > > > +/* Green & yellow color valid for now. */ #define > > > +MLX5_MTR_POLICY_MODE_ALL 0 > > > /* Default policy. */ > > > #define MLX5_MTR_POLICY_MODE_DEF 1 > > > /* Only green color valid. */ > > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > > b/drivers/net/mlx5/mlx5_flow_dv.c index 8962d26c75..e516c11d9a > > > 100644 > > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > > @@ -17617,6 +17617,8 @@ flow_dv_validate_mtr_policy_acts(struct > > > rte_eth_dev *dev, > > > *policy_mode =3D MLX5_MTR_POLICY_MODE_OG; > > > } else if (def_green && !def_yellow) { > > > *policy_mode =3D MLX5_MTR_POLICY_MODE_OY; > > > + } else { > > > + *policy_mode =3D MLX5_MTR_POLICY_MODE_ALL; > > > } > > > /* Set to empty string in case of NULL pointer access by user. > > > */ > > > flow_err.message =3D ""; > > > -- > > > 2.27.0 > > > > Reviewed-by: Bing Zhao > > > > BR. Bing