From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E761A0C4E; Sat, 23 Oct 2021 14:45:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F2064069D; Sat, 23 Oct 2021 14:45:11 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2058.outbound.protection.outlook.com [40.107.101.58]) by mails.dpdk.org (Postfix) with ESMTP id 7031140041 for ; Sat, 23 Oct 2021 14:45:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kpkk35ACo4MSfU+dLhjQ1fKU5x5eccnwQfuwxpfKo1PqvOU7Wd4ko+zCzng4fA8s9NOwl90sWciIZrPk/tZX2z9JUwg6Uv3eAaE1/s+Jrb12dTvtk9oQucq1GXUv5ASzJ4ysrylhpyyr0XZPaegoTkz1QFV+DCHJqDRjoQcxnbweZ3u36SgYniCpY38INer2ZZ4G0wnEiwK+JLspOt32pmDOczzuYvXkx/T/ihjr0qYPYpwQb1y6uCkzjbe2lM4hCswuC3nf+H5gyZ4GCM/6GVpq2KnYV0wrU9XSOS23IG1NJOVWXF9L/bTF6kbpSAltKWT0OXQ003gHe0J++wZUPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lobtf9eBsw9FEHsEGW/1xFfuNDBw/AOBf/gO0FG6vqU=; b=mr1cyvAtajzkmL5kODf8OdN+0lLGX1f527izmd7CfKPdmXYrfnSefw2hhYoMTeAZsHGNV/3rqcbSzPATxn37dB1ze656BoVgpCflLYr5bgQ47b4b1befbc9p3Ec3HwLM0unLmO5j6iH+aK6XLNIgyJhpNgxdg36wD3CUuiIzm+2CMhjwlDuYgl6HcxPH/T68rFbwQfxYMWBJxCKf5uoq5Q8UMQladF2PO0DE+CS69KlMnow/0R2ukS5K/HRqdrFwC4wK4OSIGewlVSYpXeO2T70W7+fvBHHR/UJEqLjyL0UqmS9GS4Z8diaBc5zFWosGGA+c999V4vvrHJvDr2a2KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lobtf9eBsw9FEHsEGW/1xFfuNDBw/AOBf/gO0FG6vqU=; b=ikVkHlQVfJUEl/z0qrtePN73x8t65VYU+CDkYL0CHpaaiu584+GYgnk/zxzFe+S6eyAoE4j7Q2pddmEkuZucZ3zJwgHV4cgYj753pwe/lGdH2cZ0Wuj2HgcnXG+g/8hspzSnYptq8WYzn1zYGBsVGtrolGMyzmbZ/YMhjDqLNFrSbsn7qWmIXPv6r36GNsX7Lz8AnA+Cm1GP9raCXZ1oowHAKhn4Utn5NDBTqaMnQI7Zvg5lrrFx8QZynGeCcPdvJH/mf5ViclrNPe42+24uZ6i+qjjE/imbbnsi5kg5iHE++nBGfKk9eF237tPHROA5f55KoSLwhbctR17Lzy9lFg== Received: from DM5PR12MB1755.namprd12.prod.outlook.com (2603:10b6:3:107::9) by DM6PR12MB4636.namprd12.prod.outlook.com (2603:10b6:5:161::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Sat, 23 Oct 2021 12:45:04 +0000 Received: from DM5PR12MB1755.namprd12.prod.outlook.com ([fe80::f0d0:7b3c:2e7f:cf1e]) by DM5PR12MB1755.namprd12.prod.outlook.com ([fe80::f0d0:7b3c:2e7f:cf1e%10]) with mapi id 15.20.4608.019; Sat, 23 Oct 2021 12:45:04 +0000 From: Bing Zhao To: "Ananyev, Konstantin" , NBU-Contact-Thomas Monjalon CC: "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "dev@dpdk.org" Thread-Topic: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions Thread-Index: AQHXx+iPelEGkpNElEGd0ZiUlJqLQ6vgd3wAgAAL7nA= Date: Sat, 23 Oct 2021 12:45:04 +0000 Message-ID: References: <20211022211407.315068-1-bingz@nvidia.com> <3239661.XpjLsnopmV@thomas> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6a54ec6c-88e2-4ca4-fac5-08d99622efcd x-ms-traffictypediagnostic: DM6PR12MB4636: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wlbcA+8shNZpmerZ3GLs2mkQNs1hjwkZ2Z7J/ELfUJILUV30uk2bdkNKshhWxYWQiXpA+fTMBlG+bk9URDeocnWjohmrECfQUa+riQ2d0K32J/2H14Kokjtu62fNB+vTHm5Jp8TCvjL+Qhk0eHDeDgT7sF3J23QcvCC8TEvfchodBlAeWkkHaLADI4ztt+xs9cH5XvMENKCmvXcDVJWy+8dgFuotO3EZoqLBTyBoMUe478sxLxIg4aSCPPaPRCrbaTced0QQ1qM2j2ShrujcUx4wm5bVkM6aPYZqKtyLBcxFnCsM4xk8kri7w7rUqSYns06hb7pGD3WAWcV6k3VSV4QqxVHqN8PrVKA+nAGAzKR+0J7+WRmXdKx3st7Fk0vR9s+B1KzVWiUu86ohpUouQNdd4DGR/OEZaZl2qu0Vo3sN54mf8oVfEvKyn5pxcFxOQ2cqa6ZVnwMKcgNIsOspba2tH7y4zNjIz7HkaQi9S0CK9qyLQwv8BctLWTiT3rIqCOQ3upmStlsXpmvWSZYY3CphvBDyFUfkv0pP/yNwEeGUbdTqLaeSgo91qY0OL0L7MHOy5A8iTQZr87LxWtZBUOokmTEtwBSERu3/KXalOQ2aMXg/DGYbcdy4CoJfKVwrJu3+IMS32N6NBG0jtZ3PDFM426Ew6rCh4P6Y/dnXJJ9/dSDWCEYFUF5gqsOeudiMrLmHJiiBmuXWzWSlqAkbTg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB1755.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(26005)(5660300002)(122000001)(186003)(55016002)(38100700002)(76116006)(64756008)(66946007)(66476007)(66446008)(33656002)(66556008)(9686003)(86362001)(54906003)(71200400001)(52536014)(4326008)(316002)(7696005)(6506007)(53546011)(8676002)(83380400001)(110136005)(8936002)(2906002)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ORmClVRdPvtoV6KNRvkUymEsL7tSxNSYg+kwqkikOxpE5Wm9BijXduqjjN7x?= =?us-ascii?Q?5BtiLMYZQNOS7INiEnzUBZ+/qBqpB0OBiOb4lqnGHdQ/+UXNXt3zmIbOQ5oR?= =?us-ascii?Q?NY4+2MpT0FWZWiphNr8KLwPALGg2GnW2x/9KlRO0s3qGT31VDnU9Vk1MbhkB?= =?us-ascii?Q?zxlNgIsOBDsN3DUxqc9P0GCBwCs7DFZ/MiaXw8zr0lHGdlSRIGuQbzsmnshj?= =?us-ascii?Q?4ruaIovI1lNlOIVTjthqpVutkOLANZfyDVPpH6Zq7XRWwZnLBP/0gCX5PP1y?= =?us-ascii?Q?8JQzEx6oBMlWo+EtEOX2Vqr3csz2obqp6aWOVLBY7x+FfNwN4CSzSaTQS80k?= =?us-ascii?Q?ogB1yEfDyS/aGtQHQQPpV/0p+wR4KuMXAiBGOMLjpKNpUYEIkJJXsXf+ph0v?= =?us-ascii?Q?YZOgRDoOlu2o93mYA6OZsJ/iPgvy7m5udGmQ8h6p9or7si7wZlqwJMi+Gvd8?= =?us-ascii?Q?1bC9beN9MwEOJR0HUlrnH0idWxFANWvNcTonUgC92XS4XzX1Hxrhdjo47lvA?= =?us-ascii?Q?hhKf6KamL3AhnLZaAhTZzNge1FfC6j3rBgjAZCeWCvpdGcH7KJSi4s2SIe5A?= =?us-ascii?Q?UncmnRT527J4vft9EOJ509k4MA+chPJ0TR0lpYjBi/WG3xjz9ppWYWucIrPw?= =?us-ascii?Q?deKIWPa76IO/Iko8k5/oiW01KC+2aSS4O/uKzhinqO45TidiugttRJOGqs77?= =?us-ascii?Q?QBFu2vTl78WQc5vE/xv9xitKqxYio9YoQ+se0vXRNbthSKFlkrxsl2C2w+yK?= =?us-ascii?Q?C6HNUZotBKoM8jpqhSx+m7+bV5MC06H6twJ7UW5rPvFa9c3yfz2crLlBoSWW?= =?us-ascii?Q?Qi6nUZvmKJaEWLfhUg9Pnn9rNxzpoXs5aFQvom3kfGCgDCrsdza5xt/OZfqZ?= =?us-ascii?Q?tJuzAVVX73rhyJBkr/XVZSxOjnaqdVpOJrcCGQtc0F65CO2R9jqgd6a7IDg3?= =?us-ascii?Q?UZ/wWMUISo+xgaxm5jRNrE0hgofLkw/Vptr/BskS4xj4qFe4N7yDLuNnqHRu?= =?us-ascii?Q?D3QqRrWJrKl9lt7e4leTQNOHs1cw4Y/IHowWcjemh0OfP7DtU09t9GzNaoz4?= =?us-ascii?Q?qf2NM1LvEChKY2W9gnA4RruGDNyrcgBYIBcGhyo8keyUWzqJscP0N+7PNzbz?= =?us-ascii?Q?FQSXMoRZz8wFuEjwO0RLpCluTI95drwmzGCxqF9MUr3ak8XQ8FyWzGATG95h?= =?us-ascii?Q?DFH3WaI3DNWH5yT+a6Ubdd+jUHOTWwsR/swoFfyRvvt/jf8W/yRN2jGh5DxT?= =?us-ascii?Q?VLuEiXV02+j/0mrRNkis3H/1ZOw/H22+O6RuED7WZPkzWOryAVqR449aUrrB?= =?us-ascii?Q?I0JALRJ1G0iMvWWzfO88LVMginxOW/gFsBIFC3qW/EWmQvTY5Ul29cU0Bvi5?= =?us-ascii?Q?FN3k5dMqoHoqNux74yf73eY3PPz2uh7HNQpaoXtgLPMf2Djn7GMQLXqWh6qb?= =?us-ascii?Q?ixh9FKfNzSjueo5GHD5M0k7lydyOFQZfeCAtshzCfLzyxwFwBf+ou8Zb5ett?= =?us-ascii?Q?6QaoRXilnyEZnOeUkpAxjU63C0ecnpIt0Zj03RSxvFTRGFyB5Ihy4wHKcuVX?= =?us-ascii?Q?XaSV6GqjTEFhBKxqnz8ypsOde672lNIzkb8Nts8Y6iMeJJSnymBaQuDSjuI+?= =?us-ascii?Q?5w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1755.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a54ec6c-88e2-4ca4-fac5-08d99622efcd X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2021 12:45:04.4904 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UuV/A5ZShi1dkNUXn5Pw88NsgfX/dfQx0JJ3IN2myEZT5Pd7PHBeyDCIepZacFbjpe0l9jQTXY0VFZ6TFYsQ2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4636 Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ananyev, > -----Original Message----- > From: Ananyev, Konstantin > Sent: Saturday, October 23, 2021 7:47 PM > To: NBU-Contact-Thomas Monjalon ; Bing Zhao > > Cc: Yigit, Ferruh ; > andrew.rybchenko@oktetlabs.ru; dev@dpdk.org > Subject: RE: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy > functions >=20 > External email: Use caution opening links or attachments >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Saturday, October 23, 2021 9:33 AM > > To: Bing Zhao > > Cc: Yigit, Ferruh ; > > andrew.rybchenko@oktetlabs.ru; dev@dpdk.org; Ananyev, Konstantin > > > > Subject: Re: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy > > functions > > > > 22/10/2021 23:14, Bing Zhao: > > > When stopping a port, the data path Tx and Rx burst functions > should > > > be stopped firstly conventionally. Then the dummy functions are > used > > > to replace the callback functions provided by the PMD. > > > > > > When the application stops a port without or before stopping the > > > data path handling. >=20 > If the application really does that, then it is a severe bug in the > application, then needs to be fixed ASAP. I agree, this should be some improper / wrong behavior in the application. >=20 > > The dummy functions may be invoked heavily and a lot > > > of logs in these dummy functions will result in a flood. > > > > Why does it happen? We should not use a stopped port. > > Is it a problem of core synchronization? > > > > > Debug level log should be enough instead of the error level. > > > > >=20 > Dummy function is supposed to be set only when device is not able to > do RX/TX properly (not attached, or attached but not configured, or > attached and configured, but not started). > Obviously if app calls rx/tx_burst for such port it is a major issue, > that should be flagged immediately. > So I believe having ERR level here makes a perfect sense here. I do not insist on this. Some notification to the application may be needed= . While to my understanding, the log flood should be prevented, or the logs= may slow down the application, the IO, and would also have impact on other= logs and some information may get lost (but that is the users' decision). Since the rx/tx burst are usually in the data path and invoked heavily, if = the log is needed, how about print it only once? WDYT? BR. Bing