From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F4213A0C4E; Tue, 2 Nov 2021 09:20:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C87F24069F; Tue, 2 Nov 2021 09:20:55 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by mails.dpdk.org (Postfix) with ESMTP id DA5724068F for ; Tue, 2 Nov 2021 09:20:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AgRa3PykxFUW20QtHIzFhggGhYcA3NY9TOTqz+wdcNDU+Tf8i/Szafzru0o+m+fSpnK4GgAQhN3XcUTVSUK1ruUyffTQDWCyMLgnF+t6cWMsyf+lwJYiHeYX/CYbIQqUVat9KUx1nk5j8w53QKuwVg79wvwZyztQ9zuty1abrUjgIVo8j8OPL1nIkOt9gOFuUdTAkvb1rO3cKms493Ikx7QL/iFHgd1GR3NkGzfAOu7EoEe+YRkFlh+5o5zYvTUCE0sCHbo9dq0MQsRgZ+vU4Ga/50P9FmmAMN5GT6UVsAKv+2U1DscfWMfbHEnE3/W3tOpEPdMR5E83tESYZlZswg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+PMHzhtrgGx4E/GfXYaKT9fJeViCtohwBRgJALJDdnw=; b=bBvaUrBaQNL/JebX/zo6Ps5T/gPzWP2JwxmpOBQ0FPuo0rLBUzFAHLukHRAedQwrLxEZvklWbdGRbn0Eyi2DxYlyV2g43KLX2NB0i2GcvJDU0RZacb+T/bXzVqlQR0tid+C5mlPIhEFHA/nkHkDxdcKEturU765DSgW2YHLB/CgJKCvTYB45/IVsLAVaqT5O8plbPNVwOur1K9w37+GJAFGl8OvPvC8wkO7pJdWWLJYeCAdjGpjPdwCWLwF9vni9MAHDWOQeuJyIRo/9Ez7oIA+pPgai4wWuXeDX432qdbteL5Q9256lOWfPIXqSk3yPaueROuiZtjJwPQzCUIGsRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+PMHzhtrgGx4E/GfXYaKT9fJeViCtohwBRgJALJDdnw=; b=mtXeVhsuRnMJD67yEb02oL6S/fXJsxmf/QF8NM04UG1l+BMBpfN8AqFkbnkYCtw30IuYy3eniDLp+YOb6ERY5/AYpzqfFfTuOULNgtBsi2GF4I4+HMsoVSWcH0nGAuDyZuZzXVSgHvPRc/Ra5+bJGb6052EyWNbQ5siEvTN2vQhpbT9HZIOuikukcgvqNr3hyYTkMXrTk3iX9wU8I3rZGal/1eEKKRcZvQnbtiraLz+EqowoLTneQg09Uhzw1YqHS4vpnOthwG1lC8nj3rQPb12naYHzjO2Wuh6Ui+3MwYjL3eukmFaUYE+9cB8ErWHVKSt8GaDa/bxXDZcmKN8PRA== Received: from DM5PR12MB1755.namprd12.prod.outlook.com (2603:10b6:3:107::9) by DM6PR12MB2938.namprd12.prod.outlook.com (2603:10b6:5:18a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 08:20:51 +0000 Received: from DM5PR12MB1755.namprd12.prod.outlook.com ([fe80::f0d0:7b3c:2e7f:cf1e]) by DM5PR12MB1755.namprd12.prod.outlook.com ([fe80::f0d0:7b3c:2e7f:cf1e%10]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 08:20:51 +0000 From: Bing Zhao To: Rongwei Liu , Matan Azrad , Slava Ovsiienko , Ori Kam , NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , Raslan Darawsheh Thread-Topic: [PATCH v1] net/mlx5: fix meter policy validation Thread-Index: AQHXz7p9SfNX+WwUb0q9pQJKIud+v6vv5XgA Date: Tue, 2 Nov 2021 08:20:50 +0000 Message-ID: References: <20211102072240.1073955-1-rongweil@nvidia.com> In-Reply-To: <20211102072240.1073955-1-rongweil@nvidia.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8d24fe45-2232-42d8-61fa-08d99dd9ae98 x-ms-traffictypediagnostic: DM6PR12MB2938: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3E64WbUM3yotEWMQCUkhjG3lVzo8chsauZ4IJPNTZNpMgAx01KTD1cFT8fwd8c7A7DV1ErmRqwIKnuELUHrNr3wd0X9ehePAeh+mRmvzJ4CpVkYU+tNrsTNY70L48zvVDhzcy6rqLbK0IJ8285+knV9YClhZurk9y0/Exv2eX+I2Kzt6xLQRZSs5fF+gXbyp8OoTxJgQ/7WeNfmC2WfKmiswifSiRyWeYKve+csRzRZd7QKwT6AsAuwCPX++lIsYm6iLgWjjnqzcHkzyHpjv0yzQgahVoCIvYIWMRFcwCg6PywcUYQmcciCk0e7yH1VdkhzQExH31+w+/PM3TquPWhXBJ9g8wrobdKGiBmuYi089V6Zr0NktqQHLB8mrokuvu/XvCV3fWPw2ThVZKx034kdY7NR1kp7Jv2j6hGZb9HmTqzoxBxl8P8BK8BQodtc80RKrczI2oIzIyxSXmvZxW42PPBBociZJLwCvujWZFJvFgQjf56REMDdkw5gIAxoSAix6oplUGl+AjOePfLeU3y9mDLkDFTgE94wTa+4lX1oEawPZaoxio535RIlChZj6qxfIcQhFqRmGtfSvf0GWKHi/bJfRv3gKGAOQuRyB+I7ocDrCsWuu2y1gGPArK/cnOLqoFMdAj1R/qe1kvQk6H6GGE2YeNgEDJbD+14trmcX1aLUeUup1QJ0X50n5Ej2ijqFefbvcb+MWz2/hrb8SlQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB1755.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(55016002)(66446008)(7696005)(64756008)(107886003)(52536014)(38100700002)(122000001)(186003)(9686003)(66946007)(66556008)(508600001)(76116006)(66476007)(83380400001)(53546011)(8936002)(6506007)(33656002)(8676002)(86362001)(4326008)(2906002)(71200400001)(54906003)(110136005)(5660300002)(316002)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YjT+xgK0n6wQbr7YcpRph9BPXGOB8kTNXG2BZBvVOkVh/qLrnke5Zs6xEQKg?= =?us-ascii?Q?iutg1mfDejVAgHj3u1tZs5BflI1+N3vCmKkcDOnemVlcy3Ld6+izdqJ4esca?= =?us-ascii?Q?PJ795nXeXcQSDYaW6FuE4y+IMufwslr42gjvliKLMAdCSVdKJQb9joXJ3foa?= =?us-ascii?Q?59L81Z4awtY0m59I/UrD1Bp17jMGnhYK2cAjvn6FKt1Yflbej5v3L/Y3Qkfp?= =?us-ascii?Q?Ooj4YzK4M08qteicx3ckaT/Pobl2J7d7TMNRWZul7GbRvSwENCN023RpW2BW?= =?us-ascii?Q?F/6xRGuWKB9WjuD8B+5Rqga6p+FOo8+HARmuMbQcS8A/cGi/5MnmFo0aTulr?= =?us-ascii?Q?wjbUCPLbd2BuFrqddkAVQyBIL7ZI4In7VQpg1sKW2/PZLLLhTGGh8Dy4Q65a?= =?us-ascii?Q?dnpdpNSdcocNvtq2FT94Ejjs6T10Mw97rq0lLqR9jjO9mA4Ui2ikSefbgPw8?= =?us-ascii?Q?Ul3IGysb3MBpHWkBwkiyMzfyzdJoRVTq6axcWw3L7M1YlpULNoCO1EbH2B23?= =?us-ascii?Q?WearJ+ySJRiMrz4iWYPks80qBqtzo2UkjaI9xPMEBWT7+M8vWukrSh1vBdAC?= =?us-ascii?Q?CFXgfN1YT/ycqBir+deePY7RW+q4pD2DdpKdVlghwhOaGZm5PcKHyCwvL2yo?= =?us-ascii?Q?w91cIWStciu0QCiDkoaaWhPLErCoVhina0jTbJsjyiwwntoR41dZpbgQ66k9?= =?us-ascii?Q?VXTYPa9IjvYvcxLUenMV6dzqqy7Db3SDYFyEb1zWU/j+oT0buul+EKjjG/c2?= =?us-ascii?Q?NWNKo3IeLC31wY6eREYWEQXHDlLWPnIUwOFMyKe/D3JtOqRVr/hUD10xmgpu?= =?us-ascii?Q?7vqQDvCBBkP6QFQH53cGRheU5k5k2UIsFVkxMzZdFS9p9wZjm654OLnecl3o?= =?us-ascii?Q?VW90bY+m4epEJbLSte74pltouGboPg4ARuWPW7yH+cSFmb/RY8mJK1QuDdxo?= =?us-ascii?Q?TtRpftVyjDqojznnJ/R4RJgId6ts4rQgveQPLMCUvJPBmcTyo0WxYj3NvtBQ?= =?us-ascii?Q?63ZBw1N1/uJWPL0w+5/OA6g9cUK4m485+Q4DIsNniLhYQTNzKi7yhLLXUWbC?= =?us-ascii?Q?5TUE8HJOfNMCZGqDJRTrPPz0BGSM7OIR1fS6T7kUn65LJEAB3PApaJWW5pJC?= =?us-ascii?Q?lXzJ51PSmqNRIZjflx2W0ZMsm0C5i8DJEU3qlQcO8D2d3RKItUg67i4MrYwH?= =?us-ascii?Q?g3k1anOp0sK0l48aHbS5GtQjeWYSJP0Y5fAoOURTFNNUrE1NtRncxqOp5c3j?= =?us-ascii?Q?ob2OKIZ4XAhm7xKckjhtwWlqz5SvN34dfE+oYN/WEDWP0vDQUTzvULH2CXDA?= =?us-ascii?Q?y98bxtNDz3YW9xZ1Rli+rMXVXPzx+fexxfrMNR1K5jC5kiQa3lDa9mp/Jr95?= =?us-ascii?Q?CEhlMfst3DLpOTrvYM6WeIRUUu534K7tFTTWt23HIbTPk/tKXc/2OEB68mPx?= =?us-ascii?Q?zzBtz++bFnSJS+KS2s8vIe6sO4+/i2KZpUHeOss4Ar/kRuE++OykN7Y4kQcV?= =?us-ascii?Q?Eup2tddItD/vDIfS8B5t9AvhMw5A7Xy7RXZE2jkg1CCQgEoJ1XNF7G/qDUhl?= =?us-ascii?Q?sqxNQ0L4XdNOhGgF2Sk4eMR6NLbtJc/XX7/gRFvOT5/pCKihyHn130qfbx35?= =?us-ascii?Q?DQL2VqqcH3CNkOfL+Ll59xA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1755.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d24fe45-2232-42d8-61fa-08d99dd9ae98 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 08:20:51.0292 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wYs4fu+olzOQCLn7E7j5zU/jZJpm8Bu62As2TXoZalxL2ugaX0a5BleG+rIXOK1LWMEDkr9zcPSbTwA5n4Knqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2938 Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter policy validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Rongwei, stable@dpdk.org should also be CCed. > -----Original Message----- > From: Rongwei Liu > Sent: Tuesday, November 2, 2021 3:23 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Bing Zhao > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1] net/mlx5: fix meter policy validation >=20 > When a user specifies meter policy like "g_actions queue / end > y_actions queue / r_action drop / end", validation logic missed to > set meter policy mode and it took a random value from the stack. >=20 > Define ALL policy modes for the mentioned cases. >=20 > Fixes: 4b7bf3ffb473 ("net/mlx5: support yellow in meter policy > validation") > Cc: bingz@nvidia.com > Signed-off-by: Rongwei Liu > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5.h | 2 ++ > drivers/net/mlx5/mlx5_flow_dv.c | 2 ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > 39c001aa1b..591ae2764a 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -622,6 +622,8 @@ struct mlx5_dev_shared_port { #define > MLX5_MTR_TABLE_ID_DROP 2 > /* Priority of the meter policy matcher. */ #define > MLX5_MTR_POLICY_MATCHER_PRIO 0 > +/* Green & yellow color valid for now. */ #define > +MLX5_MTR_POLICY_MODE_ALL 0 > /* Default policy. */ > #define MLX5_MTR_POLICY_MODE_DEF 1 > /* Only green color valid. */ > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 8962d26c75..e516c11d9a > 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -17617,6 +17617,8 @@ flow_dv_validate_mtr_policy_acts(struct > rte_eth_dev *dev, > *policy_mode =3D MLX5_MTR_POLICY_MODE_OG; > } else if (def_green && !def_yellow) { > *policy_mode =3D MLX5_MTR_POLICY_MODE_OY; > + } else { > + *policy_mode =3D MLX5_MTR_POLICY_MODE_ALL; > } > /* Set to empty string in case of NULL pointer access by user. > */ > flow_err.message =3D ""; > -- > 2.27.0 Reviewed-by: Bing Zhao BR. Bing