From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C276342EAA; Tue, 18 Jul 2023 15:27:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45029410D3; Tue, 18 Jul 2023 15:27:54 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2049.outbound.protection.outlook.com [40.107.92.49]) by mails.dpdk.org (Postfix) with ESMTP id D940D40A84; Tue, 18 Jul 2023 15:27:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FU8qCTdG1BNQfjX/dE8Dy2Q4O/C2GcOvNeIEIHuG6NyieFNp1JssvZDjU02mL8WXYu/jrsCphps8pkaW+gBacH4bNqixtNRYb9WtptauIZs5KevNY2elRUlDnOEB4mIdYs87AqZzKyj6yBY+jJ4TUSs/UPfY3+4c+dOAu7ILQ1v85Z3fs/CXli0xxsaoKy4P/a3D8ysh0DcTxqR78oZ9PZscNwc5ggAEJPS2W6fCBCxmPaefHQWtWPyn0ajx4Qt2pJfHftu5WR7dXfWSAnneuU3wPNKKpjTtlt2O5lNqLYi9BCJ58/26IgBjGJAO8cOomsw4wLLTbIQ1JcZpdQ97pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cl5RX06QcUh+8I0nu60MMzcs+9oRtVNJA9Dfyt8fIFM=; b=kdC+/YhpH/YqrDODn6I+l4T94qk1EgXpi+TIFFb19gUvs+rumY2zwPqZA1PewayskebB0pd1JcR8+vm83n2Pirx6XureEGJIn55u4l5mY+f6tkQJzJcaxzWkhB8toJWW+WAHU5B/qXZ8stguDRcNiTOtbLLnQuNs0W0dTDoocZnxJhpuMVPdBBxZBvHozvxVvgdbq+yJeiKnfX/wrDDIi2sMDFJzzip6aN58tZZP+pYmqba7XQTdzGMtFuI0VQuRW4POyrZT79Cp04NpP825VQ2k6P3PH5vFHtRbCjMh+QbONXIqgCrSxLd0un/sWtqQvxN3Rz/mkrD9VZn82BAtsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cl5RX06QcUh+8I0nu60MMzcs+9oRtVNJA9Dfyt8fIFM=; b=RU7/T4fagdklcoUiFbcVAgNvoMQs0cSnaEcpIh3W0VZhMNpgbwkTIkxFaZviM0/M+p/PR5Z63m+Awi6BSymNWGJGHo8XKA6jglNUh+v7O4TKphERcv7+3cJl+ZnP5I6GfmAM0IBcG+UayFKWa7ZQO46VJfd39g3Qg2GHcJutYBHy699VbjYf0dV3cNYU6D9+p2PZYWV7YpO873QBPu35cfjq/rZeSQjpY9dKgJLJ9kA+23fhRxO1F00cUmSHAdrbl0yqlUOANzDINLjl3ncJFPZwf8yEFfhaNBJ8j7rAuXePJDCepP6/wwpT1ZelqJdVI9ou/pmNWB664IV4rg8mkA== Received: from DM5PR12MB2405.namprd12.prod.outlook.com (2603:10b6:4:b2::20) by BL1PR12MB5364.namprd12.prod.outlook.com (2603:10b6:208:314::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32; Tue, 18 Jul 2023 13:27:50 +0000 Received: from DM5PR12MB2405.namprd12.prod.outlook.com ([fe80::594f:1734:b22e:4fb1]) by DM5PR12MB2405.namprd12.prod.outlook.com ([fe80::594f:1734:b22e:4fb1%5]) with mapi id 15.20.6588.031; Tue, 18 Jul 2023 13:27:50 +0000 From: Alexander Kozyrev To: Stephen Hemminger CC: "dev@dpdk.org" , "stable@dpdk.org" , Raslan Darawsheh , Slava Ovsiienko , Matan Azrad Subject: RE: [PATCH 3/3] app/testpmd: fix meter mark handle update Thread-Topic: [PATCH 3/3] app/testpmd: fix meter mark handle update Thread-Index: AQHZtAtjzohDLBIVrkyeKmuoeAWN5a+0vZcAgArRShA= Date: Tue, 18 Jul 2023 13:27:50 +0000 Message-ID: References: <20230711152044.3141138-1-akozyrev@nvidia.com> <20230711152044.3141138-3-akozyrev@nvidia.com> <20230711091500.4aa15bf7@hermes.local> In-Reply-To: <20230711091500.4aa15bf7@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR12MB2405:EE_|BL1PR12MB5364:EE_ x-ms-office365-filtering-correlation-id: 738a7b00-40a9-4ad5-6f97-08db8792c8a2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jI84JMWCVo/KDKgeBi75q6KEJbRnOxHTQQqBXy+E7g7zgDajYxSI0oGHVgqYV13OaFNIxCGNp5Rw6rUW/l1e2OTBKbuPl6lC/ok52cv2HA1Ov9bMOn10x6zZRNhcyGNKQ34M4DDhdGhAvry/p/7R44W/HjniBGe+hUyuKEiJBD6fFaap8oOVZr4dx8JYnYjkN1Xw8qnMvQXVVRxpaKofu0Za/91aw6Kr72S/I+0M0iV01dW481vEe6jizviGdIKng2S0p/V+C3hZsLQaGXBzBW4F2/9YWc3NGqcFFkSTutRExi9GR89USNDY3gviDcPy+dDCJG1txahRJeZNJiB7TQusMMrnYFPaYSnNWa2qdfUmBYByoeyRSJjCaQMC+JiAJvUVyvt7QYGUes1WKTcF5G1SLJuzka8OqEcZfD3WTa7qkIXvduEPfnHwmx9oye5uFCZ0V3d0cBir+9X2wV3JaoAbgr32Uc4l7wzATbFCTxJUnxtkUCI36C7ePSaATsUa+9C6ZCopt5ApEkQbEOaBTD3xvbvFh5EBXblx5DgZuJHTbUaOwaIf3yEb+O+aNcQpajONq6E3ZaCjXSpBdYFjvJZnBLLJqVxSoPk/+q98+nwC0KbQB4eFbaxmJe4yy5xV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB2405.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(346002)(366004)(39860400002)(136003)(376002)(451199021)(55016003)(54906003)(122000001)(71200400001)(38100700002)(7696005)(66446008)(41300700001)(8676002)(8936002)(52536014)(6916009)(76116006)(478600001)(316002)(66946007)(66476007)(5660300002)(66556008)(64756008)(4326008)(186003)(83380400001)(6506007)(26005)(107886003)(53546011)(9686003)(86362001)(33656002)(38070700005)(4744005)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4DO68KsdSbccv7kq/SflbO3GVD4Ksv8zv9sBX5gAEZNDJaugEvPzTY+rzZjm?= =?us-ascii?Q?nBp2BGmY03O2W19I+OQ7/TzoRPhgc4YvUL31sEeMkKYlG/EeMxEUcKpHFQgJ?= =?us-ascii?Q?9n5MhGVOU3e7EzK5xR3qkAI34qGihGO7ADQXypnBJrN6yxRRRZ6+M3NHCsL5?= =?us-ascii?Q?RXyXN3oDHOtc1TnFSx2ikrE3Z6A/4VwEZ+jcKekhaeiR/JsE/MgGLPa+4bCG?= =?us-ascii?Q?0Diza+IKN4wb0lMqpEZylcfDomQnlOviL3foN5ogfiZhWhhbpgF0j/m4Gw/T?= =?us-ascii?Q?GjUnftyecvkbvEgLNEsS5jZ4JTvUuCxFK5Y+qGZblybxfYagm0m8LfyF+WNa?= =?us-ascii?Q?Paay8VpAbVYGy7eDji1rE99UpBJ6BaqN8gLI/1YvGPrLeArfVsvBXjH3wWsA?= =?us-ascii?Q?XGbGopyVKarAJshFg6Ja05ZlMSoIcMyz1P9eER98lugdJeK3OTnruWGzxKkp?= =?us-ascii?Q?zka8TxQbr3dt3ZUrCvEvSQVBGbFu58kgPvHbACJKJyl8FtblTvTB8NWPK2hg?= =?us-ascii?Q?Zd5iavEasPTKOjuObhNbu/xOXpZdisw7Na9juV4TFo7CFz5kSfVCjbgqzGzd?= =?us-ascii?Q?p5tkN2W1dwguwwuZI5klQkELSDyYO2Cip/D+TLD1NvchD1dSEs2zgBTXGZjz?= =?us-ascii?Q?dV5L2/q9GRmxWig4ZdHmhW9tVBR/I+0KSWLA5tzjr+qInBdj/XHiqoll4uih?= =?us-ascii?Q?QBdqjPw4zZj7naLL1ObGhChAJtEKgAKjVKrF+l1gclOG6jyZMgvZ5r4GhRhS?= =?us-ascii?Q?bu9IyxQO2hupEnuJgUH09hpkjtOzK5euBjpDMP4jw0zO1JH6YueNHhmxdi2j?= =?us-ascii?Q?4U4qLTkSt3puQfxc/80m+jf48g5fUcORhUeWqT/2pCh0k/0+znVlo++3IeMJ?= =?us-ascii?Q?r5WKFdxzYhfRrNGfv76gks7ibhoepiwEw4jVpRUsbqmQwELJNaDlslnqHTni?= =?us-ascii?Q?IZ21s2B3CGT/meRDs40QnI8K8rqcS+zBSZFC1S5u7MlA8y9yQro99m8FlYOf?= =?us-ascii?Q?nYIr0G8WiHC8hf7aMcTsZVEg5OojQ0t2YTe6s1mOwSAlIIKkgK/aNv+sUuSB?= =?us-ascii?Q?UKbvTroZZxUE5MXVTp7NIukku3JpL36WpoDwE75vrXYvhQDtfyNwmZjhmya6?= =?us-ascii?Q?UTQ9ZKYqrByZMRlnt19g6oFbNQmR5s5SPelReIZdT7qLiJjZWNo9/lXGofUR?= =?us-ascii?Q?zoPqbpuzJDWp9j2RURPrvmEmHJFWg51dEb7evrwPWdjCgbANrJna4WgTLrkX?= =?us-ascii?Q?TZSyXd6D//FPeFPvaPzIXGHjbIlc2SFCjRHB7BgzMozkupEn079JrXN+k3qo?= =?us-ascii?Q?18j9ZaDGMzRB2kZQwUI7brawVqkLRXd/YZrjnf6d/kBS8QJrlf9nsbG/+Keo?= =?us-ascii?Q?jIh67D8GZgN+QZVGMddEhFQavWrTdpAH5s6SjrJ2CK0O3wdtjlvG34BzDxDm?= =?us-ascii?Q?QHMXk3mFIiQc51Hh5pQPF4ZsjQFTFLkzKcJdFWjIPec5Ujl0cNNG5aosLwMH?= =?us-ascii?Q?nJvUG/EbPDZ9GHEJKUXGWWt0swjBPsH2fzA/NmPsuVTeWE7cDsDE9B+BuAIl?= =?us-ascii?Q?tbrINYmx791kHWo1P75irFmpTjlZKUK8QpwU/bs3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 738a7b00-40a9-4ad5-6f97-08db8792c8a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2023 13:27:50.3713 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UkreIrX8XTxqaKdaeb2poMX1sLcpxAzhxHVDOkZcvLMBjyGAyDwb95XsvECGCzDV+HPFcL4xK1zftE93L0LWVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5364 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Tuesday, July 11, 2023 12:15 PM > Stephen Hemminger wrote: > On Tue, 11 Jul 2023 18:20:44 +0300 > Alexander Kozyrev wrote: >=20 > > + case RTE_FLOW_ACTION_TYPE_METER_MARK: > > + rte_memcpy(&mtr_update.meter_mark, action->conf, > > + sizeof(struct rte_flow_action_meter_mark)); >=20 > Why use rte_memcpy? memcpy of fixed size is faster. > Also, more static checkers know what memcpy is. Ok, not a problem, switching to memcpy.