From: Asaf Penso <asafp@nvidia.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Wisam Monther <wisamm@nvidia.com>,
"Li, Xiaoyun" <xiaoyun.li@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
Roni Bar Yanai <roniba@nvidia.com>, Li Zhang <lizh@nvidia.com>,
Haifei Luo <haifeil@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v9 1/2] ethdev: add pre-defined meter policy API
Date: Tue, 20 Apr 2021 12:55:04 +0000 [thread overview]
Message-ID: <DM5PR12MB2406035FC3C08D854C69A39DCD489@DM5PR12MB2406.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB27961017FC4DAC63DBCD15CCEB489@DM6PR11MB2796.namprd11.prod.outlook.com>
Thank you, Cristian, appreciate this extra effort!
Regards,
Asaf Penso
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Dumitrescu, Cristian
>Sent: Tuesday, April 20, 2021 2:18 PM
>To: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>; Matan Azrad
><matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Slava Ovsiienko
><viacheslavo@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Wisam
>Monther <wisamm@nvidia.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh,
>Jasvinder <jasvinder.singh@intel.com>; NBU-Contact-Thomas Monjalon
><thomas@monjalon.net>; Yigit, Ferruh <ferruh.yigit@intel.com>; Andrew
>Rybchenko <andrew.rybchenko@oktetlabs.ru>; Ray Kinsella
><mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
>Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Roni Bar Yanai
><roniba@nvidia.com>; Li Zhang <lizh@nvidia.com>; Haifei Luo
><haifeil@nvidia.com>
>Subject: Re: [dpdk-dev] [PATCH v9 1/2] ethdev: add pre-defined meter policy
>API
>
>
>
>> -----Original Message-----
>> From: Jiawei Wang <jiaweiw@nvidia.com>
>> Sent: Monday, April 19, 2021 5:08 PM
>> To: matan@nvidia.com; orika@nvidia.com; viacheslavo@nvidia.com;
>> shahafs@nvidia.com; Wisam Jaddo <wisamm@nvidia.com>; Li, Xiaoyun
>> <xiaoyun.li@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>;
>> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thomas Monjalon
>> <thomas@monjalon.net>; Yigit, Ferruh <ferruh.yigit@intel.com>; Andrew
>> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Ray Kinsella
>> <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
>> Cc: dev@dpdk.org; rasland@nvidia.com; roniba@nvidia.com; Li Zhang
>> <lizh@nvidia.com>; Haifei Luo <haifeil@nvidia.com>
>> Subject: [PATCH v9 1/2] ethdev: add pre-defined meter policy API
>>
>> From: Li Zhang <lizh@nvidia.com>
>>
>> Currently, the flow meter policy does not support multiple actions per
>> color; also the allowed action types per color are very limited.
>> In addition, the policy cannot be pre-defined.
>>
>> Due to the growing in flow actions offload abilities there is a
>> potential for the user to use variety of actions per color differently.
>> This new meter policy API comes to allow this potential in the most
>> ethdev common way using rte_flow action definition.
>> A list of rte_flow actions will be provided by the user per color in
>> order to create a meter policy.
>> In addition, the API forces to pre-define the policy before the meters
>> creation in order to allow sharing of single policy with multiple
>> meters efficiently.
>>
>> meter_policy_id is added into struct rte_mtr_params.
>> So that it can get the policy during the meters creation.
>>
>> Allow coloring the packet using a new rte_flow_action_color as could
>> be done by the old policy API.
>>
>> Add two common policy template as macros in the head file.
>>
>> The next API function were added:
>> - rte_mtr_meter_policy_add
>> - rte_mtr_meter_policy_delete
>> - rte_mtr_meter_policy_update
>> - rte_mtr_meter_policy_validate
>> The next struct was changed:
>> - rte_mtr_params
>> - rte_mtr_capabilities
>> The next API was deleted:
>> - rte_mtr_policer_actions_update
>>
>> To support this API the following app were changed:
>> app/test-flow-perf: clean meter policer
>> app/testpmd: clean meter policer
>>
>> To support this API the following drivers were changed:
>> net/softnic: support meter policy API
>> 1. Cleans meter rte_mtr_policer_action.
>> 2. Supports policy API to get color action as policer action did.
>> The color action will be mapped into rte_table_action_policer.
>>
>> net/mlx5: clean meter creation management Cleans and breaks part of
>> the current meter management in order to allow better design with
>> policy API.
>>
>> Signed-off-by: Li Zhang <lizh@nvidia.com>
>> Signed-off-by: Haifei Luo <haifeil@nvidia.com>
>> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
>> Acked-by: Matan Azrad <matan@nvidia.com>
>> Acked-by: Ray Kinsella <mdr@ashroe.eu>
>> Acked-by: Ori Kam <orika@nvidia.com>
>> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
>
>Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
next prev parent reply other threads:[~2021-04-20 12:55 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 8:58 [dpdk-dev] [PATCH 1/2] [RFC]: " Li Zhang
2021-03-18 8:58 ` [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers Li Zhang
2021-03-23 21:33 ` Dumitrescu, Cristian
2021-03-25 8:21 ` Matan Azrad
2021-03-25 23:16 ` Ajit Khaparde
2021-03-29 19:56 ` Matan Azrad
2021-03-27 13:15 ` Jerin Jacob
2021-03-29 20:10 ` Matan Azrad
2021-03-31 10:22 ` Jerin Jacob
2021-03-23 21:02 ` [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API Dumitrescu, Cristian
2021-03-25 6:56 ` Matan Azrad
2021-03-29 9:23 ` Ori Kam
2021-03-29 16:24 ` Dumitrescu, Cristian
2021-04-01 13:13 ` Ori Kam
2021-04-01 13:35 ` Dumitrescu, Cristian
2021-04-01 14:22 ` Ori Kam
2021-03-29 16:08 ` Dumitrescu, Cristian
2021-03-29 20:43 ` Matan Azrad
2021-03-31 15:46 ` Dumitrescu, Cristian
2021-04-04 13:48 ` Matan Azrad
2021-03-29 10:38 ` Jerin Jacob
2021-03-29 20:31 ` Matan Azrad
2021-03-31 10:50 ` Jerin Jacob
2021-04-13 0:14 ` [dpdk-dev] [PATCH v3 0/2] Support " Li Zhang
2021-04-13 0:14 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined " Li Zhang
2021-04-13 14:19 ` Dumitrescu, Cristian
2021-04-14 3:23 ` Li Zhang
2021-04-13 14:59 ` Dumitrescu, Cristian
2021-04-14 4:55 ` Li Zhang
2021-04-14 8:02 ` Thomas Monjalon
2021-04-14 8:31 ` Matan Azrad
2021-04-14 8:47 ` Asaf Penso
2021-04-14 8:59 ` Li Zhang
2021-04-14 9:04 ` Thomas Monjalon
2021-04-14 14:00 ` Dumitrescu, Cristian
2021-04-14 16:21 ` Li Zhang
2021-04-13 16:25 ` Kinsella, Ray
2021-04-13 0:14 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-14 3:12 ` [dpdk-dev] [PATCH v4 0/2] Support meter policy API Li Zhang
2021-04-14 3:12 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add pre-defined " Li Zhang
2021-04-14 3:12 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-14 6:32 ` [dpdk-dev] [PATCH v5 0/2] Support meter policy API Li Zhang
2021-04-14 6:32 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add pre-defined " Li Zhang
2021-04-14 6:32 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-14 8:57 ` [dpdk-dev] [PATCH v6 0/2] Support meter policy API Li Zhang
2021-04-14 8:57 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add pre-defined " Li Zhang
2021-04-14 16:16 ` Dumitrescu, Cristian
2021-04-15 1:59 ` Li Zhang
2021-04-14 22:21 ` Singh, Jasvinder
2021-04-15 2:00 ` Li Zhang
2021-04-14 8:58 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-15 4:54 ` [dpdk-dev] [PATCH v7 0/2] Support meter policy API Li Zhang
2021-04-15 4:54 ` [dpdk-dev] [PATCH v7 1/2] ethdev: add pre-defined " Li Zhang
2021-04-15 4:54 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-15 9:20 ` [dpdk-dev] [PATCH v8 0/2] Support meter policy API Li Zhang
2021-04-15 9:20 ` [dpdk-dev] [PATCH v8 1/2] ethdev: add pre-defined " Li Zhang
2021-04-15 15:13 ` Ori Kam
2021-04-19 12:34 ` Singh, Jasvinder
2021-04-19 16:13 ` Jiawei(Jonny) Wang
2021-04-15 9:20 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-19 16:08 ` [dpdk-dev] [PATCH v9 0/2] Support meter policy API Jiawei Wang
2021-04-19 16:08 ` [dpdk-dev] [PATCH v9 1/2] ethdev: add pre-defined " Jiawei Wang
2021-04-20 11:18 ` Dumitrescu, Cristian
2021-04-20 12:55 ` Asaf Penso [this message]
2021-04-20 21:01 ` Dumitrescu, Cristian
2021-04-19 16:08 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: support policy actions per color Jiawei Wang
2021-04-20 11:36 ` [dpdk-dev] [PATCH v9 0/2] Support meter policy API Ferruh Yigit
2021-04-20 14:08 ` Jiawei(Jonny) Wang
2021-04-20 14:04 ` [dpdk-dev] [PATCH v10 " Jiawei Wang
2021-04-20 14:04 ` [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined " Jiawei Wang
2021-04-20 17:12 ` Ajit Khaparde
2021-04-21 19:43 ` Thomas Monjalon
2021-04-22 1:29 ` Li Zhang
2021-04-20 14:04 ` [dpdk-dev] [PATCH v10 2/2] app/testpmd: support policy actions per color Jiawei Wang
2021-04-20 17:14 ` Ajit Khaparde
2021-04-21 10:23 ` [dpdk-dev] [PATCH v10 0/2] Support meter policy API Ferruh Yigit
2021-04-20 17:56 ` [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined " Stephen Hemminger
2021-04-21 2:49 ` Li Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB2406035FC3C08D854C69A39DCD489@DM5PR12MB2406.namprd12.prod.outlook.com \
--to=asafp@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haifeil@nvidia.com \
--cc=jasvinder.singh@intel.com \
--cc=jiaweiw@nvidia.com \
--cc=lizh@nvidia.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=roniba@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=wisamm@nvidia.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).