From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF1B2A04D6; Mon, 21 Sep 2020 18:09:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33A6F1D9E1; Mon, 21 Sep 2020 18:09:27 +0200 (CEST) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 0F3131C199 for ; Mon, 21 Sep 2020 18:09:24 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 21 Sep 2020 09:09:11 -0700 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 21 Sep 2020 16:09:09 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 21 Sep 2020 16:09:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X+FqWQXXHB7VREwk1DLBm9EGQrG//uOmYxvjqunAZ4pjLZFjVO0u8GB/I5G4KATq4OmtrEW/gInGkrcTjdn3btQD/J3ggba8biqAVq/b9e1sUz3T5h1IBiwcnaJ4gpsA2l9USa2Nfqazj4kRgi+5SVhTMdpngw/DRJEa11z6QLuhttrE3+NBjMc7N6e/7E3EZNG8SAs04t/Jpl1QLzv5cf+26EdSr8mciIxlKJkizy2HAMVa1r+3rv58sHA8usa/r0JZZC5jHBjOOor1IN2GEy6ENucybj/voVxN2HTjSwfPdkIhvleLqEdKhGor0Ovbs6507+npFBwuyNWYHa2baQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YHUOtQXQSvdqZX+43hjItThBIQT5bBFFyo2VolxXN90=; b=dpBLIxtGFj/K4Q/G0l2vhUU6kpZfuHVRHXsMe/Zi6b8YRpobzJFnUqCc7CeZu0lHZhTkiWzpZKOAjNMfx0Xe1QEtfEg2kGae6t2k1U9scXL0PNlNfRM5nWImCAIWxJ69LG3oNlsqnLOuyd/qrt+gBVf42WTBNpezYaCu5Es8oYVtdbjVkkEXroPf0ABmtPnN3ZJXsDV+6KgFn+QTXohjPZuM8lByxEsHu26QFsHFRnkAsOcIJcbOVNqGnjhqJV7z7yD+oO8iW8zaUC7X2L7G3bz2esZf1rckxNqegJgGupGieVHVRDBK99ju1QFdnDsWKYl5OpLbqIW6/DzIhVWtRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM5PR12MB2406.namprd12.prod.outlook.com (2603:10b6:4:b7::23) by DM5PR12MB1676.namprd12.prod.outlook.com (2603:10b6:4:8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Mon, 21 Sep 2020 16:09:08 +0000 Received: from DM5PR12MB2406.namprd12.prod.outlook.com ([fe80::e9:a8b0:1353:45ac]) by DM5PR12MB2406.namprd12.prod.outlook.com ([fe80::e9:a8b0:1353:45ac%5]) with mapi id 15.20.3391.011; Mon, 21 Sep 2020 16:09:08 +0000 From: Asaf Penso To: Tejasree Kondoj , Stephen Hemminger CC: Akhil Goyal , Radu Nicolau , Declan Doherty , Ori Kam , NBU-Contact-Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , "Jerin Jacob Kollanukkaran" , Narayana Prasad Raju Athreya , Anoob Joseph , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ethdev: add security flow item Thread-Index: AQHWh4qU5v6qhShl+0iD4XdHRIkOS6liFKIAgAqIdNCABj61gIAAd9OQ Date: Mon, 21 Sep 2020 16:09:08 +0000 Message-ID: References: <20200910164441.7245-1-ktejasree@marvell.com> <20200910094558.0398145b@hermes.lan> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.127.30.106] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4cd4153-7769-40c4-1d18-08d85e48abb7 x-ms-traffictypediagnostic: DM5PR12MB1676: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LQs/l3zGz5Vw4+bKSTOK8OGfzwg0U0Gi0TgbCbQK/1QlpCDEnvqeQS8Mdjs8v35gqQ4TSM7P8Mw9K6ZVM8AQidPwNOQRLnUBG+V+taUGIc2tVFe8U6fCocugNC5MHREtxQPevxamNlI72xGyN5Ll7Vd1haLamRpvdN3pXskIPtCbViYbb9r2h/lDj4Vscldcef3Nq6u94Ld7+Iz/Hm0syTcTImDB9HxGI7G4VW2PDwRxSE/OX8YtVZavgH1iF8BIEYtZMatYLMlW4dYNJBv/dDUNX08Cwx2upAyAU2uFkBEImgT0kpJWlKiOCK3Zqvp8TmC7QHPkx2CeCoxiEJ4GMwWGEYzN7ICKaGJiB7HQAVnFNO5CVm5oYRuesw7pRmP3 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB2406.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(366004)(346002)(136003)(396003)(110136005)(8936002)(7416002)(316002)(33656002)(26005)(15650500001)(478600001)(8676002)(83380400001)(186003)(6506007)(86362001)(7696005)(55016002)(9686003)(2906002)(54906003)(66446008)(64756008)(66556008)(66476007)(71200400001)(5660300002)(52536014)(76116006)(4326008)(53546011)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: gWwmILmj9KUlAY1W4TNHvWgJvQ6Wc/d3TItaZ46RocfARmUBcYNL2ShT4h+sTSKgwnJe3VwVJC4dAdk3f+nrwshWC4TFgB03tFXnn4cmgnUpjvcT/RGB8acwD8I7anxbVr/EGtC/SBfacsNjXVd7iwa39QUWD65f3CuyhnheHnH/xugZqpQSv4DuzMXI71oEDyJ6d8KV8MZ2ATuqupqEi9M3fRpqJkmpXM0liN+xUUpIEo+BT3xhiWcpjxqGaZ83nYujrRw7IvQ/+iivo7mv8xadbcShYZowAisgOka4VYZ+reDfp12anUjGw8xDga+odiYUxDeFBYmnXYrqbTL/DiIbc8QL6p3tB7E78TR8STxVC4eFg1qe3o4suKn/Cf8KdXifQZmsDgR6KgJrxbor13UPx6+PX75aD4v2rT77SO0B9SnsCrCoEJQqQyg+IveMSqwACRqx0eUhkLxaiCiGC14MO02dELdcxtgjhGPi+LzazcEdvmRUdt/mKSU7xPYaAn2y/LwvBwHAuPvKmkeW6uCZZfxnQ6avKWXLA2HWVszV0KpCVM63bRnyurFEGlMZYU+Wff+g8WvwMo6MvX0gImo96/kOuxdcVCZ6ObO2iOuxfjczvsl0iebD/r3pEo4m29x1K8lKa0s4YSCoT0ldXg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2406.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4cd4153-7769-40c4-1d18-08d85e48abb7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 16:09:08.3296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sHNInqQ0LT5vHwq+bMcFFmfUSrTH9Bpfkad2Ef/33NCqPS5XA5xr3FIMIIjUzcPc1Z2y5n8kFBBgxvScwh/K0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1676 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600704551; bh=YHUOtQXQSvdqZX+43hjItThBIQT5bBFFyo2VolxXN90=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=At/FLxKO+MiwOQ7kXtVUe5wcLlvbbygqeCQmBdGQUA1yLTBK8WZq8LlssU/W4sHpy pCmvQEE761cPkjcHwfKWKs9koDbd0LGldPlA1oQBLznm1Cz1xBQd+XJkYEuwCoUl2Q XWMaXUviVb3fyhsJQBvPkDe/L3iJAocRZlpOPnR9AinN+Rk4Jnhtiy/+9TTf5SWZj3 wtNbzZ9+6H2O7jFy1Bqx465Sma9jD3905eDh/c7ibA3M1nas8h6PagfvQAdXq7G6Ec GPVQT2MnYdoTMDzSyc48g35kKDymbI+5ouOS6HOgiiz5/MOGrl8+ffIXMmLwDMvf8s k5+S8WBmUM1/Q== Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Regards, Asaf Penso >-----Original Message----- >From: Tejasree Kondoj >Sent: Monday, September 21, 2020 11:59 AM >To: Asaf Penso ; Stephen Hemminger > >Cc: Akhil Goyal ; Radu Nicolau >; Declan Doherty ; Ori >Kam ; NBU-Contact-Thomas Monjalon >; Ferruh Yigit ; Andrew >Rybchenko ; Jerin Jacob Kollanukkaran >; Narayana Prasad Raju Athreya >; Anoob Joseph ; >dev@dpdk.org >Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item > >Please see inline. > >Thanks >Tejasree > >> -----Original Message----- >> From: Asaf Penso >> Sent: Thursday, September 17, 2020 3:09 PM >> To: Stephen Hemminger ; Tejasree >Kondoj >> >> Cc: Akhil Goyal ; Radu Nicolau >> ; Declan Doherty ; >> Ori Kam ; NBU-Contact-Thomas Monjalon >> ; Ferruh Yigit ; Andrew >> Rybchenko ; Jerin Jacob Kollanukkaran >> ; Narayana Prasad Raju Athreya >> ; Anoob Joseph ; >> dev@dpdk.org >> Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item >> >> External Email >> >> ---------------------------------------------------------------------- >> >-----Original Message----- >> >From: dev On Behalf Of Stephen Hemminger >> >Sent: Thursday, September 10, 2020 7:46 PM >> >To: Tejasree Kondoj >> >Cc: Akhil Goyal ; Radu Nicolau >> >; Declan Doherty ; >> >Ori Kam ; NBU-Contact-Thomas Monjalon >> >; Ferruh Yigit ; Andrew >> >Rybchenko ; Jerin Jacob >> >; Narayana Prasad ; Anoob >> >Joseph ; dev@dpdk.org >> >Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item >> > >> >On Thu, 10 Sep 2020 22:14:41 +0530 >> >Tejasree Kondoj wrote: >> > >> >> Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to >> distinguish >> >> plain packets from IPsec decrypted plain packets. >> >> >> >> Signed-off-by: Tejasree Kondoj >> > >> >Please provide an implementation, API's without any driver support >> >should not be accepted. >> > >> >Also, we need a test for this. > >[Tejasree] We would like to defer the patch and add implementation, test >case in next cycle. > >> >> +1 >> Also, I think the word SECURITY is too high-level, and if specifically >> you mention here an item for IPSec, perhaps you can consider renaming. > >[Tejasree] This item matches security processed packets and not specific t= o >IPsec. >Will change commit description as follows: >" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match >packets that were security processed. For example, in case of inline IPsec= , it >can be used to distinguish plain packets from IPsec decrypted plain packet= s" >Would that be fine? It would be more clear, yes, thank you, but in this case I suggest to have = a field in the spec that you can match on it. For example, is it viable to know if the packet was processed by IPSec and = not AES? Maybe you want to have 2 flow with this new item, but still differ= entiate between the types.