From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B90F0A04BC; Thu, 8 Oct 2020 17:06:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9BF5F1C1AB; Thu, 8 Oct 2020 17:06:36 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id F3AE81C195 for ; Thu, 8 Oct 2020 17:06:33 +0200 (CEST) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 08 Oct 2020 23:06:31 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 8 Oct 2020 15:06:26 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.53) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 8 Oct 2020 15:06:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i8/RpKWNrhKzahihG+YpG4JRoFUbYuaDnNhTzLW/6KJVme2/l07cNkUjd8153iT1Sk8f1Z8NaiUdnA43qE2ov/0X1Le8dv0XhSJTGAUhfmpcbPijiuwGfYK0xPjR9oSbZ4LQxaaNsgtXLzb159AZQijdIJ1XdKbt5GhpCKp6zDW3B0CMzbgz6MY6WIsUkuriNWoypvC7ABc36W8wn09iIaAIF3G2PtRF7demNqpCEY1PmgygLl22uHJyjo7P7jIBZbZaSOLeqeKIH3mkiueDg1OnlFVLnBZBxOeKIiyCRCl4uIWP7I04K71vAVn9fsvsu7Z0MvEUwjAtq4tK4DctZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nv8SJLhfkmNjXSDIIvsCGzCB74MquOOsmlwXsQ67wT0=; b=f3Iq7A64Pm8VKufCEBK/SbqdkW1Fw2ptPWq95WmHjc9CyHoaEGoBoXoPMtUAXOwOztnY8CNUSFTSXVGUK72aLEt6mJ18Xus038SgdIvPJ9mB5dTJ7vDSSH+/G1NG2bP//WN3bEpuguFOZH6P3ps40ocIwDDYqM4km+EStGJXQPyNx6FD5t9Kz9ZeDZGdnoyIB6CGciBWHpIEKQRWoMepMAcm2y99LxGKtSbtFF0Ls90DeeGAyXo400t+EkNGEhCvwkDhW63XCzHMzvTJ4BE0ll93KLGcbCtEYiRZS8wLgORY/mqUCQIq2bhHbIz5ZDd0QLr51hPORK98bE8JG4q4Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM5PR12MB2406.namprd12.prod.outlook.com (2603:10b6:4:b7::23) by DM6PR12MB4300.namprd12.prod.outlook.com (2603:10b6:5:21a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Thu, 8 Oct 2020 15:06:23 +0000 Received: from DM5PR12MB2406.namprd12.prod.outlook.com ([fe80::c806:9c0b:4af5:a686]) by DM5PR12MB2406.namprd12.prod.outlook.com ([fe80::c806:9c0b:4af5:a686%6]) with mapi id 15.20.3455.024; Thu, 8 Oct 2020 15:06:23 +0000 From: Asaf Penso To: "nipun.gupta@nxp.com" , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@nxp.com" , "rohit.raj@nxp.com" Thread-Topic: [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to drop error packets Thread-Index: AQHWmuecjQh4oThsaE2mriMVymzkVKmN0yPg Date: Thu, 8 Oct 2020 15:06:23 +0000 Message-ID: References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20201005071506.28861-1-nipun.gupta@nxp.com> <20201005071506.28861-3-nipun.gupta@nxp.com> In-Reply-To: <20201005071506.28861-3-nipun.gupta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [217.111.27.204] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1255ed76-9b32-4f65-3b08-08d86b9bb8ef x-ms-traffictypediagnostic: DM6PR12MB4300: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3CaNSvGMpafQiiY0/WyLqfXOgpykF99Nww/Ik534ZCOASeovWMrKe80WqGfGW7tVmFPT9Y0enNk6dUO7aGWM5vnIvdY4e2HCtrYs0iuqzRii+SI9GdIFYAY3CbxEos19ef90Chdr4+8tUphLwq9JsKMmTe/pDWt+Q0irskZpl1hzWcxgUChDeGWqFrYvLFfhaSrmMv0JRlxj5oWZoFNNrDRpEoGiNnta186rPypzZItTaJOAHzuJ+/yYHjoutYhs14gMHJv98/7iv0L3kEmPcpvHEBs8poQqDKGrVo4q/iCsIWQQtjqnzP0K78bhEILLSNs+m+DBxgdRIxVcnSNyUQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB2406.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(366004)(39860400002)(136003)(26005)(55236004)(4326008)(5660300002)(71200400001)(2906002)(186003)(33656002)(6506007)(52536014)(55016002)(9686003)(8936002)(86362001)(64756008)(66446008)(110136005)(83380400001)(66946007)(478600001)(7696005)(316002)(76116006)(66476007)(66556008)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: F1VgOydt29ccCCiZA+leE/9LNi5JGIgE0j+J730434X+CchANCBbCB+1qEJI7hL3VKCrMKIyRbOUQVvfPELgcsm55DyTs3GZBOR9KIaWbXuRhjIL8wyA7PU1djf271ia+uvlkUPSnCkIVfCVXBUONPKLMgBnLaNC2Q0WDVA4Hc+5zwvmanadLpjGN9TdoAC/pBhcS9FGvFsFxh6Lqav7Mx3UkTePhq0CmHJ3vhjrOz7HxjL7zMzKcwaT3CyZbTjI3gL8A5eHgrewpBoXHIiC5xhTS72ISJ7SeH+xQHxSNuDeyWPTIwR4lqRsa0obpU3weop3hjMm38fPWoyvyDz9swQwlc6ocOP+yALVNc9kzY+L8fYUUp7zLJp8cUv/OaFHOLiC53XnjZ0ca3Ie0T/WTLCj9bd9OXu3udW7m5RFocwJCoMXDGT6dv13KJyC62naT44f1feQ/h54JlBkuRG2COOJGy6LokUirhyhy5h+DQMVXiQnbbWTA6l9Gk+kBFSAbIM3xprW9jmLVp9oZZPhCr5YmWaufeJbJflNrzRUaSli2Rf6WNYfMUMtqL0Zj8i3UjlgHZn3gW5BGcTC3qWNvemOHMRC3teCSF5fhvCTuc2Q4+ugnDJ+OW5w4KlINTs4ECCGlLnPRwlC/e5T2ZN0xA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2406.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1255ed76-9b32-4f65-3b08-08d86b9bb8ef X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 15:06:23.8514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fAkwjnWqY8UFG00giPpT2kYi4cyn5bYG6T+gOXghpsB4436bE4aRGqorUx4mrrW4TBBhrfTOtfuyiM5jHjPULQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4300 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602169591; bh=nv8SJLhfkmNjXSDIIvsCGzCB74MquOOsmlwXsQ67wT0=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=TZKRrLYRVilNrS9yqwKa821vbjTr1/O7+HQYAGhVdZhPr5E3chAZrNtjUOJKEGp5+ XFXmDV+59I8V40MzCXu/JAPvivWUsw2KQsyyfttmde/yBCdZiKMvXarAD/c6pzqaMf RRyKw/vMd+1W3ff8FIdDfvgB//V7WeDfIN1aJuYgqtGLrUSVTBKbK/0lOoeuoHd5Q1 dXde3FT7kk2KlvrUOjK/WNZueawPkGkj5wtTBo3rJsIRxHDsYv/h+GmILokdbaUFfO PwcBL+7wZ49oobEHNemoEt/BYQBlEgHZJDsY7SMAYDNJNvA4xajl1qqhs8eiVQla39 8qiPezFzzCMow== Subject: Re: [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev On Behalf Of nipun.gupta@nxp.com >Sent: Monday, October 5, 2020 10:15 AM >To: dev@dpdk.org >Cc: NBU-Contact-Thomas Monjalon ; >ferruh.yigit@intel.com; arybchenko@solarflare.com; >hemant.agrawal@nxp.com; sachin.saxena@nxp.com; rohit.raj@nxp.com; >Nipun Gupta >Subject: [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to >drop error packets > >From: Nipun Gupta > >With DEV_RX_OFFLOAD_ERR_PKT_DROP now defined as an offload >capability, testpmd showcases this with a new added configuration option >'enable-hw-drop-err'. > >Signed-off-by: Nipun Gupta >--- > app/test-pmd/parameters.c | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index >1ead59579..ada870e2d 100644 >--- a/app/test-pmd/parameters.c >+++ b/app/test-pmd/parameters.c >@@ -142,6 +142,7 @@ usage(char* progname) > printf(" --enable-hw-vlan-strip: enable hardware vlan strip.\n"); > printf(" --enable-hw-vlan-extend: enable hardware vlan extend.\n"); > printf(" --enable-hw-qinq-strip: enable hardware qinq strip.\n"); >+ printf(" --enable-hw-drop-err: enable hardware packet drop for error >+packets.\n"); > printf(" --enable-drop-en: enable per queue packet drop.\n"); > printf(" --disable-rss: disable rss.\n"); > printf(" --port-topology=3D: set port topology >(paired " >@@ -631,6 +632,7 @@ launch_args_parse(int argc, char** argv) > { "enable-hw-vlan-strip", 0, 0, 0 }, > { "enable-hw-vlan-extend", 0, 0, 0 }, > { "enable-hw-qinq-strip", 0, 0, 0 }, >+ { "enable-hw-drop-err", 0, 0, 0 }, > { "enable-drop-en", 0, 0, 0 }, > { "disable-rss", 0, 0, 0 }, > { "port-topology", 1, 0, 0 }, >@@ -1037,6 +1039,9 @@ launch_args_parse(int argc, char** argv) > "enable-hw-qinq-strip")) > rx_offloads |=3D >DEV_RX_OFFLOAD_QINQ_STRIP; > >+ if (!strcmp(lgopts[opt_idx].name, "enable-hw-drop- >err")) >+ rx_offloads |=3D >DEV_RX_OFFLOAD_ERR_PKT_DROP; >+ > if (!strcmp(lgopts[opt_idx].name, "enable-drop-en")) > rx_drop_en =3D 1; > >-- >2.17.1 I think it would be good also to update testpmd run_app.rst with this new o= ption.