RE: [PATCH v2 1/2] ethdev: add random item support

[Michael Baum <michaelba@nvidia.com>]

11/09/2023 19:00, Thomas Monjalon:
> 
> 11/09/2023 09:41, Michael Baum:
> > Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM".
> > This item enables to match on some random value as a part of flow rule.
> >
> > Signed-off-by: Michael Baum <michaelba@nvidia.com>
> > ---
> > +Item: ``RANDOM``
> > +^^^^^^^^^^^^^^^^
> > +
> > +Matches a random value.
> > +
> > +This value is not based on the packet data/headers.
> > +Application shouldn't assume that this value is kept during the life
> > +time of the packet.
> > +
> > +- ``value``: Random value.
> 
> I think it is the opposite:
> the value is defined by the application, right?
> Then it matches randomly based on a number generator?
Generating the random number is the PMD responsibility, it may be performed by either HW or SW.
The application provides the random value/range to match on.

> 
> Please describe where the random is generated and what is the range.
Ack

> 
> We could also wonder why it is not integrated in the existing sampling item.
We don't have sample item, we have existing sample action.