From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F292A0093; Thu, 10 Feb 2022 14:29:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98DA2411AE; Thu, 10 Feb 2022 14:29:14 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 5EE5B4013F for ; Thu, 10 Feb 2022 14:29:12 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21ABPBnl022300; Thu, 10 Feb 2022 05:29:11 -0800 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3e51348nxa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Feb 2022 05:29:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nFVB95kzdYtBYUrjTl8rSpwnaO4cCncKvoZNn/Ni9UwoQPWwNnlB1bu4v18Te299dHsgaPVT/DreYwlNSqD5B0PL4qKsGKnTYsKkY36lF0pd+2/wIWTAk8pPevMQROO6ay6a0YemMJMixNXRhOmwcvJaNtOWo/CBeidjU7Go2exhWp7PbmMBBrB0sKf+UMkDV8d7Y/De2ejtD4+NySuuDZG5X68Qo10ootX2GDH0VmMnO31k4uS1fklJ2uC5nQow7F13CbMw86Ia4X7trnZcdCzVyzKUcrgeFcWqJcMOmg9K5NZ7WKMZmJNn1KXE3N6k4F9JJ8ErNQtk9IyVZJPzkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sYlX8GdN02RSQwehFlLiHrn6BAPPsXmPp0iUJ+fNqY0=; b=YSbNFwypm1C/nZ4UFvoHMXI8/rVdV9qk2vdqd1c34hDfFKV5ky5OMlGMLWBFweRhVDEkLjERV2AognVCxcoNZXztLjAlYBJazRRkcwbKBd+FXl0yZRdeMmaDyJE7+e+AfEDvjV1rPfwJMmKkiJyNULJCE3i86cMXAiyIEbqad8IzM7Oq4DyqcflwYb4xipDp4KEMqDkaB758q/RizaNskpzCQ2tJpqZkJO/yOwI+Td8W/NGITWisCx0/K+UOrKQh3W9zQVBxJAsnuJLvEe/d5rNSO69k9gATZr8kyaezc/F/OIu3Kd1AZvOlXxo8P7vmwGM6w/K6LJG92YFTnJv09Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sYlX8GdN02RSQwehFlLiHrn6BAPPsXmPp0iUJ+fNqY0=; b=Us7wBeLHZ1C2gb+n9Mxv2XZE6B14RcHU6Z3SF6+u9D/PDeKwwYbgXV6Y5xhKFtRcm1TKMVP8ujaH7utnY8Y5TR+a0A/5YwyMeJGHC4fzdfjss956O6X5IrGau18Tyi3PoR/07DfuhLw+X6oiLQ4tgDG+4E8RWGxITpeg8sXMmW0= Received: from DM5PR1801MB1884.namprd18.prod.outlook.com (2603:10b6:4:65::20) by SA0PR18MB3503.namprd18.prod.outlook.com (2603:10b6:806:99::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.14; Thu, 10 Feb 2022 13:29:08 +0000 Received: from DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::a4ba:4f58:93bc:4bac]) by DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::a4ba:4f58:93bc:4bac%6]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 13:29:07 +0000 From: Ankur Dwivedi To: Bruce Richardson CC: "dev@dpdk.org" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Jerin Jacob Kollanukkaran , Anoob Joseph , Tejasree Kondoj , "ferruh.yigit@intel.com" Subject: RE: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec Thread-Topic: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec Thread-Index: AQHYHksA5Tu0GD31qU68f4wO7JMzAqyMgA4AgAAKCjCAABzxgIAAHBTA Date: Thu, 10 Feb 2022 13:29:07 +0000 Message-ID: References: <20220210065334.19942-1-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92921fee-fc7f-4f53-f85d-08d9ec9950cd x-ms-traffictypediagnostic: SA0PR18MB3503:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QTnlfemxY/4EPq+enf+ef0rt6g5B+9aPC7SEUKOwoY0pXjix1JQRxhJuMtdP3hA9HtMXACMc5ExeUOyl8yI6elqz1t8CO+WoBzbZyG9GhoLafqrZ0ku+WPA3EcK2EueDPmpNCk17u9ipr9yFgxt1nyAK6+8Og914FRs9d3ViD2a+98cqsIEkAd1HzCqbkdx95VK7hvvH2mJf5DTjXdukilyY1Nt1b9LO9BLF24rlhwYF3cOSKhJcxpDjj0mcOCKYZWv9Cyzw4rp5/uDpgHkr4q7l9pwuIv0QKaGU5bFxFFq5bFYODIr/oEP93eqf7LlFMVm2TyiyLb4rcJHMW1AheZw24Q/JLRTeCQZz6/bnb/fxSd77/U7Uq7jpjvqVDJs0xhAKuZ70JPILKunAXPObvvxnokYyPp8M0rlFh8SQt9dqAPNoFgnPyi+fISSBh9epX3TBJuRLPYJBwfyd25oB4cfiNK7ZpCBnrcvh+xra8O0rIqEi7LBCd1owY4bW1fPufFvih5AakXh471QX02yyUyF0DH9CKNqKXHJYKBhFkTnM8Wk+ZFuevSfOGdn2gDXn+Asq/h/fIHVOQOhmBJxAvzp27rbjnuAqlrcVHR5ICW1DVeJdxpjlEhS9ZIbZ2lSwd3GDf9d3edY/6DBgiAMeBwgD+sue+0F0a7d/GxbOtpZjrnDx0CwfJcgKjqq3oS9xjFseGipgSKTAz0I3wfmGintOLz8MKpRV4VMZSkaJximaqRG2Pi7Z7TbFH1E1oWOTjgqVSMSBCiWO0bWdRCajc5Alqr9FIYB/YNxgS4/NWKo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB1884.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6916009)(54906003)(2906002)(6506007)(186003)(19627235002)(26005)(86362001)(71200400001)(316002)(83380400001)(5660300002)(7696005)(8936002)(52536014)(55016003)(966005)(38100700002)(76116006)(508600001)(66946007)(66556008)(66476007)(66446008)(64756008)(8676002)(4326008)(9686003)(38070700005)(33656002)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LxKRglh37g7F8FjHR5GpJxqx8M6uCaqdbLbK+bS8ZC6fV2tJaoYpqjaz72h0?= =?us-ascii?Q?SXX/Gg3l0merCTtU3l9URb6ZFdzB5RM1GDTUe4A7LBASv5/TOSw8aknl9UXy?= =?us-ascii?Q?Y7/euUQs7jno0YOzEBZLFwFFnax7+JyQbgqUTKaFZXYhebFjwFYh8/lTEgyN?= =?us-ascii?Q?58NeRkQZuRuqz4dkmJ+/ywsm4gaj9PAMnfVdX3x4eU5E0rz2JJTUXOC7TBdd?= =?us-ascii?Q?8kaD/wtUPYCpgtzhUQdWUfMwPnYYx8M3P6fXj3awS/hTlZYLfaO/zum8B/Sb?= =?us-ascii?Q?cjiZy1M8ZqzWA7s+6lsA56FzG4EXKMWh3N/f8L2RReseUjYxDal3FFqIRwMH?= =?us-ascii?Q?8TeXi+YXcGom5maqStVIrOF4iDxaOUyXpZLlz2BJr069vDnqZ6IW5JhEo+hA?= =?us-ascii?Q?Ufb6EB8FrBn/cyDsZzeiQAwjG6JnsVyub8qWySss9pmK96NJrbk8XAiUXMk6?= =?us-ascii?Q?iZIQgXVXuN+RxTK0Fgfj2hlBcf4tt7sj4fgTTl8Xo0eb+dY8041EHUET9fZi?= =?us-ascii?Q?D43UkI//jRkLaqnEnpnYtLyZDSJMrznHE4AsMWPXZ6uz4rSex74JxUfDQFcE?= =?us-ascii?Q?1LUXpDJEtJnvG21Nsom5V0wmiW4n46tcPUQFq3G7f6wmvAigb/jIN2d1khOD?= =?us-ascii?Q?1i0jKkKjuCyZ8qfyf8w5+6qkn712hEphfZpsPbatfEFtK8m0x/0G4XqHlzi9?= =?us-ascii?Q?sm2GXrZxM085IziNjGuPqMZixAim0qExAQ3s9OA5RVNu/rh+PSCFTvd5UuVd?= =?us-ascii?Q?KJPELJ5j4+eh1caiGtvz16pjx1ePB9gXE9G45eKm2vkdmQGMnXx6MWh2azNj?= =?us-ascii?Q?RNalvUg8ExOsZmq5CyjA2UvObA00v3FHZM6o+Tu7f0Ka69xR3kqS0vOadhNn?= =?us-ascii?Q?FHHjnIrVlF5v9U2lwltIUmoepHxP+lYg4Pk0V0vFq5r1zqlDi5e8mzoCvSKA?= =?us-ascii?Q?3NiClD/L/9LCbP7QWROq+gaocZJsJwDiK4LqyRFsD3r0tw+J7IoW4GMEKCdV?= =?us-ascii?Q?KWfXtG3EI2oF8t+sdhAG7FnABwB8pHAlOcWTWJxIKcuYuq/IOEBmpF0Gk31i?= =?us-ascii?Q?18yN5Pcn3XsWr3jgaZAitKyrz7HQ8rpnFROGMeKkt+o7YngrqpEE34PCEmrV?= =?us-ascii?Q?FpEbsYc+ai/NEfOJG1TRJP/52TEYM8mGa7VHPrqxyu2A640psD8NWWyvp7s0?= =?us-ascii?Q?oU13V3mokqEUVytVYhdbsjV8eakED9J86BTVixcxcCzBG6XPPtvl0EHopz8L?= =?us-ascii?Q?z8275rnsyB8VmqdzXYXlDbV5E9zTVNRx4F69hQmp7T9HcCdlWAWE/wVomLuQ?= =?us-ascii?Q?+6haRWTo7YsY51zMowZCLecIG3dGsmXXGWxI6gwrc337MkQ+LtlHQewQ0u4T?= =?us-ascii?Q?JiZlDMSGzqIn8P20Nj3aHLPimNQlkEQXb7t9ZSjw6uLOe24D2cyunfMXXpJX?= =?us-ascii?Q?MrlTB0AIILalwyD6q2BQTwKAwiL20jUPV2ghlS4ljbeASfzVod7tf0MsHOWK?= =?us-ascii?Q?prKD6yaZqbk+/H5QbJNOVZe/EntuZ9W2aB1h7BE900cOetUmLzlrI+0saNGJ?= =?us-ascii?Q?fMHemYVjHsLsKxXxDY9/cMIQUQx2R3jYpkCJWWlHnvDFnXZdqBbPiBGo9qZs?= =?us-ascii?Q?FQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB1884.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92921fee-fc7f-4f53-f85d-08d9ec9950cd X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 13:29:07.8056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jN4OEXw3c49eSOfegCCcz6xyt9ETTh60NQZt0dp0iBv/tSGp0DLGcNXh7tkAKzQfpiqEHrGR1AZVmoINQqhWZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB3503 X-Proofpoint-GUID: UNSxeSk-dgzg8311QdK2ocRej13LoSen X-Proofpoint-ORIG-GUID: UNSxeSk-dgzg8311QdK2ocRej13LoSen X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-10_05,2022-02-09_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >-----Original Message----- >From: Bruce Richardson >Sent: Thursday, February 10, 2022 5:02 PM >To: Ankur Dwivedi >Cc: dev@dpdk.org; Nithin Kumar Dabilpuram ; >Kiran Kumar Kokkilagadda ; Sunil Kumar Kori >; Satha Koteswara Rao Kottidi >; Jerin Jacob Kollanukkaran >; Anoob Joseph ; Tejasree >Kondoj ; ferruh.yigit@intel.com >Subject: Re: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec > >On Thu, Feb 10, 2022 at 10:04:22AM +0000, Ankur Dwivedi wrote: >> Hi Bruce, >> >> Please see my comment inline. >> >> Regards, >> Ankur >> >> >-----Original Message----- >> >From: Bruce Richardson >> >Sent: Thursday, February 10, 2022 2:42 PM >> >To: Ankur Dwivedi >> >Cc: dev@dpdk.org; Nithin Kumar Dabilpuram >; >> >Kiran Kumar Kokkilagadda ; Sunil Kumar Kori >> >; Satha Koteswara Rao Kottidi >> >; Jerin Jacob Kollanukkaran >> >; Anoob Joseph ; Tejasree >> >Kondoj >> >Subject: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec >> > >> >External Email >> > >> >--------------------------------------------------------------------- >> >- On Thu, Feb 10, 2022 at 12:23:32PM +0530, Ankur Dwivedi wrote: >> >> Adds telemetry function for inline ipsec in net CNXK driver. >> >> >> >> This series depends on the following patch series: >> >> >> >> Series: Adding new features and improvements in cnxk crypto PMD >> >> https://urldefense.proofpoint.com/v2/url?u=3Dhttp-3A__patches.dpdk.or >> >> g_p >> >> roject_dpdk_list_-3Fseries- >> >3D21433&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r >> >> >> >>=3DILjiNF3GF25y6QdHZUxMl6JrStU0MIuCtO5dMzn3Ybk&m=3DszcLmV4s_NiVroE4 >B >> >vC5yW6 >> >> >> >>litxm6Pfo2ymX7QhE1qDSpKTa56lnfmMqfnohRfI6&s=3DVtKHr9SAo3R0g7lGPoSJl >g >> >xVxn >> >> r2t_TYhHbfH7rS4sE&e=3D >> >> >> >> Ankur Dwivedi (2): net/cnxk: add telemetry for inline IPsec for >> >> cn9k >> >> net/cnxk: add telemetry for inline IPsec for cn10k >> >> >> >Out of interest, is there any of this telemetry that could be made >> >generic and apply at a device-class or library level rather than >> >being tied to the cnxk driver only? >> I could think of that the callback function registered in >rte_telemetry_register_cmd() can be a generic one. The net device (eth_dev= ) >may have ops registered, which can be called depending on dev->tx_offloads >and dev->rx_offloads flags. However the data to be returned by telemetry >might depend on the PMD. >> Please let me know if this is possible. > >Thanks. So if I understand you correctly, the information returned would v= ary >based on the offload flags only? If that is the case, it does sound like i= t could >be generic, where the offload flags field in the return information identi= fy >what other fields are present in the reply. That would then make the >telemetry generic and possible to implement at the ethdev level. Is that a= ll >correct? Apart from offload flags, the information would vary depending on what a PM= D is willing to provide. That's why I was thinking ops callback function will be= required in struct eth_dev_ops which will be PMD specific. This ops callback will be ca= lled from the registered telemetry callback.