Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

[Ankur Dwivedi <adwivedi@marvell.com>]

Hi Akhil,

Please see my reply inline.

Thanks
Ankur

>-----Original Message-----
>From: Akhil Goyal <akhil.goyal@nxp.com>
>Sent: Monday, July 6, 2020 5:54 PM
>To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org
>Cc: declan.doherty@intel.com; Hemant Agrawal
><hemant.agrawal@nxp.com>; Vakul Garg <vakul.garg@nxp.com>; Anoob
>Joseph <anoobj@marvell.com>
>Subject: [EXT] RE: [PATCH] test/crypto: change cipher offset for esn vector
>
>External Email
>
>----------------------------------------------------------------------
>Hi Ankur,
>>
>> In the IPSEC ESN test vector the cipher offset for encryption should
>> be 8 bytes which is the size of esp header.
>> This patch also changes the ciphertext and the digest reference data
>> against which the operaton result is validated.
>>
>> Fixes: 699741912d71 ("test/crypto: add case for auth only trailer")
>>
>> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>> ---
>
>Why do we need this change?
>The existing test case is to demonstrate a generic case where we can have an
>auth only trailer as well. It is similar to a case of IPSEC ESN but not exactly
>IPSec. Cipher offset can be anything as per the app requirement.
>I don't think there is anything wrong in the vector. It should pass in every
>hardware without any issue.
[Ankur] It's a limitation in OCTEON TX PMDs that the (encr offset - auth offset) should be 8 bytes aligned.
In the IPSEC ESN scenario generally the offsets will be such.
But in the above IPSEC ESN test vector, this requirement is not met and hence the associated test cases fails on the PMD.
>
>Regards,
>Akhil