From: Ankur Dwivedi <adwivedi@marvell.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: set cipher operation in transform
Date: Mon, 18 Jan 2021 11:33:55 +0000 [thread overview]
Message-ID: <DM5PR1801MB1884BAFD413B7CBF1D247496DDA41@DM5PR1801MB1884.namprd18.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB1838A776115241A0B00AB8F8E8A40@MWHPR11MB1838.namprd11.prod.outlook.com>
Hi Abhinandan,
>-----Original Message-----
>From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
>Sent: Monday, January 18, 2021 2:42 PM
>To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org
>Cc: stable@dpdk.org; akhil.goyal@nxp.com; Anoob Joseph
><anoobj@marvell.com>
>Subject: [EXT] RE: [PATCH] test/event_crypto_adapter: set cipher operation in
>transform
>
>External Email
>
>----------------------------------------------------------------------
>Hi Ankur,
>
>> -----Original Message-----
>> From: Ankur Dwivedi <adwivedi@marvell.com>
>> Sent: Friday, January 8, 2021 2:11 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Gujjar, Abhinandan S
>> <abhinandan.gujjar@intel.com>; akhil.goyal@nxp.com;
>> anoobj@marvell.com; Ankur Dwivedi <adwivedi@marvell.com>
>> Subject: [PATCH] test/event_crypto_adapter: set cipher operation in
>> transform
>>
>> The cipher operation in the transform should be set to encrypt.
>>
>> Fixes: 74449375237f ("test/event_crypto_adapter: fix configuration")
>>
>> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>> ---
>> app/test/test_event_crypto_adapter.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/app/test/test_event_crypto_adapter.c
>> b/app/test/test_event_crypto_adapter.c
>> index a0169aa6cf..335211cd8c 100644
>> --- a/app/test/test_event_crypto_adapter.c
>> +++ b/app/test/test_event_crypto_adapter.c
>> @@ -183,6 +183,7 @@ test_op_forward_mode(uint8_t session_less)
>> cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>> cipher_xform.next = NULL;
>> cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
>> + cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
>NULL PMD does not refer " RTE_CRYPTO_CIPHER_OP_ENCRYPT ". Is your test
>code failing without this change?
[Ankur] Yes the test is failing, because in octeontx2 crypto pmd, during crypto session configure there is a check for the cipher xform op. If the op does not match either encrypt or decrypt, the session configure fails.
>>
>> op = rte_crypto_op_alloc(params.op_mpool,
>> RTE_CRYPTO_OP_TYPE_SYMMETRIC);
>> @@ -382,6 +383,7 @@ test_op_new_mode(uint8_t session_less)
>> cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>> cipher_xform.next = NULL;
>> cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
>> + cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
>>
>> op = rte_crypto_op_alloc(params.op_mpool,
>> RTE_CRYPTO_OP_TYPE_SYMMETRIC);
>> --
>> 2.28.0
next prev parent reply other threads:[~2021-01-18 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 8:40 Ankur Dwivedi
2021-01-12 4:55 ` Jerin Jacob
2021-01-18 9:11 ` Gujjar, Abhinandan S
2021-01-18 11:33 ` Ankur Dwivedi [this message]
2021-01-18 12:10 ` Gujjar, Abhinandan S
2021-01-18 14:54 ` Ankur Dwivedi
2021-01-18 16:19 ` [dpdk-dev] [PATCH v2] " Ankur Dwivedi
2021-01-19 7:13 ` Gujjar, Abhinandan S
2021-01-26 19:32 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR1801MB1884BAFD413B7CBF1D247496DDA41@DM5PR1801MB1884.namprd18.prod.outlook.com \
--to=adwivedi@marvell.com \
--cc=abhinandan.gujjar@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).