From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D46FA052A; Wed, 23 Dec 2020 10:43:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84A82CCD9; Wed, 23 Dec 2020 10:41:50 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 95F3BCCD9 for ; Wed, 23 Dec 2020 10:41:48 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9UhZl002385 for ; Wed, 23 Dec 2020 01:41:47 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=i6U0sYXCAa/zp9LWQ5aD7lCpu+GurCmGsgOojP6lL70=; b=aSjZPKVYGfRMQEPHgoCOGBG3gO7XrkyTFKIlDcrSB1VH3pOVo7C4lTS0uow6Nk9REzGe hpDB88dWI5SB+3MJ4iF8Rc8DSg5LZt5vOOJYaTV7thp9Qd76uGHNGO+aLXbUckMb0DTu OtAWcnyzOfHUQYkJmGA5mbK494JFas0YFrCB7D9J1xHckxVet1CXSylkbdrq8fTGncRs xEOpHdtgEnDlOG3M2bdYmZ/bX/nSkOG+UBZZ6L80rmTQ42VadRFbK/M5bnUyz2GDOTcl kcRhysSJO55y1rBHxXeC+Eto7knTsmR4y1Lb9rsLXA98tJ0T8oIvBl5Oh7QuTw5VQ/yY YQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5n87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:41:46 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:41:45 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:41:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E6jyYZjL4CPmNaH/uEStNMDcxAYqZsMFzV+KLOI7Zn60SvWFtu/TbRlx8ACW9CxxqwrfTPY5sJXobwXo7+KMBgwqUUCkqPmjnonNOVxqbPbNX8EU8/26e5blNS7IYXldue0pYLUea7tEFV6qRu4Ixgtphxy5jKZi1lZO5zMJTvdy/Q/gkhot8LheApaY03lnMr1Owp+ZVA5nqoW0Wy1q5JjD55XDaSAAdzxLNcbaefXuJkWsjEHprusYba0tuFZP05mKi5oTgXNJ0PvXBt13xHpgxMOE5vuo2PuCn9OM7xFB6XscKXC6koCm24+v6BzABQRL3vRGxUD606RPBxgAZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i6U0sYXCAa/zp9LWQ5aD7lCpu+GurCmGsgOojP6lL70=; b=Zj3dgNgxSL7pTu6X+1SD+7P11KTxyswM1xYr0syB0XhMixNdmJhr1bY9LWrwqc3c0nzqaueDET5GejwXyIiPxL7fXv28q8Tm28rfwm6wJ47Cvk3MpV8pQ/aBIZsHoGSIYITcQI30TDHCjB0CMUbBtA0ptWAks0+aZ6A6shA1qO7jIpeSa6WV1koCSKFLwuNLKNDsiq9Oh1Tm4lXMWqTWOvant0bYCcmrdXPQGKujuT4lDHzsapfDqYvKdECgCw/qzqVXuY5gUhB55/jm/zHl6PDdiISzhtYWqMTBugrxjPOgqnhl/JOQjWlxDMX65orWqdO7NM0vfzFBaxj2eU6kgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i6U0sYXCAa/zp9LWQ5aD7lCpu+GurCmGsgOojP6lL70=; b=dvrwRM5Wr4p8nGhvByzzETnNLZOKlOeCUxOzjxCh6kDdh2OnjWdWJMZo+xEvt+SIrkgQto8Q3UeqjYAarv/5m3tjTDXtLM8FbRyHJWTLmuRTNehLEg+Ae3GqCZrFT8RkM7RsX9nK/qJwUT5InBiS8LMbDsLjwMowvE3OaSNeT5U= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB3603.namprd18.prod.outlook.com (2603:10b6:5:2a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:41:44 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:41:44 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Yuri Chipchev , "Liron Himi" Thread-Topic: [dpdk-dev] [PATCH v1 11/38] net/mvpp2: align checking order Thread-Index: AQHWyJQwa/DxqGDZ0EiO1oyhwoY9jaoEjnTw Date: Wed, 23 Dec 2020 09:41:44 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-12-lironh@marvell.com> In-Reply-To: <20201202101212.4717-12-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97d8be6e-98bc-48be-eb8b-08d8a726f586 x-ms-traffictypediagnostic: DM6PR18MB3603: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uYlO6YVkXBurcvhCoI6OOBurmcr7rIQ6wzU+UMpQ8TKsYq+QdB0T2ljBMjLU3SYCph418QxxLxZ4N7BgcedIW3vBt6LaKDtCXQFSqu24dLxO8g6YHWTG6C6w0PdINbTeP35W44GauLXW5EqSgDtk4kBdjdbpCZKVdPn6ExvjjQo3lbrB40DeTAzsKfHMeph6hEn1lJo2ppyiId8ga61IeNECRldZkH+/MYUpO8AWALcbacil/9mERW9FThCthjs9EUqcrM1aZbRHsHodI7hu2YmiKOOVpHsbA+gTw/7AGNylsyybPeIrEp7LHnZ9lijO6bXPC2U3F2qSKNGKgUoZczTW3znXNc8416GPmDdKES+M7FOwzGc/pwOxHcbmkSA75hCcNZUZ6GZ4G+WI1LGPOA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(66446008)(53546011)(54906003)(66556008)(52536014)(66476007)(66946007)(4326008)(5660300002)(64756008)(107886003)(33656002)(8676002)(9686003)(6506007)(76116006)(55016002)(6636002)(86362001)(71200400001)(478600001)(7696005)(186003)(2906002)(110136005)(316002)(83380400001)(26005)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?zNaPup9yggYcV5KoPBKFgEKGnfhxjp2vVv4KSx3f08nahXJYQAz8RByl+dQm?= =?us-ascii?Q?tjzuqvHMUdD4s+Rqm0+Re8KcGh5Cau8g7p3Z2laAU20Y9igy8//7lVy6O5Wu?= =?us-ascii?Q?NoMWb/KYPF5rlDxN8bVMtT3WyGfKNVy5hnptphgmjG/V8UV/OG59F3uh8vEy?= =?us-ascii?Q?Dz9MjtqiKAp0BrS96GziNssCI/2nTKlPcnhcZ+XqMCMvCKzDhDvITa8GIiZE?= =?us-ascii?Q?dArukUqSfeGUGFWDFiqtPTlJEfr5/Ov0oLIITm7CfwrX3gDdNw1I7rf0ETuv?= =?us-ascii?Q?bx1nkI/Ns1PQaRntM+RYx31OvrMzfLRihcG49JhdfVYuNP90Z2ZXzwNV2xgx?= =?us-ascii?Q?c5eGLDlc7TzTxrO72W+oCy++t3fzuGmTVhuEYQHb3YTxjOLNjT2FpJpNQ7Fg?= =?us-ascii?Q?FESo0Nyq1XU8wIyAevId8u/rjcETlc+eVoK2LjzSFCAe8FYybz6NSyFYgKDo?= =?us-ascii?Q?3Hk/BNyYqq7z9C2Q+qM6iMYDhFNvH946i6teQ3odrzaQ08muxd4SGT+WPgvg?= =?us-ascii?Q?aPvSV0cUei9jyhW3jlJsQVYM7ElxZ8w2UX8q3FXg8P/taC1di8wlvqis0L3U?= =?us-ascii?Q?7vZTK92saNUqfZT93SUeKtdJF2f3fHJrmXZyr4yWQiZgx6ISH2ptjKO1KkG6?= =?us-ascii?Q?+OyQLG778crD6vkNAJz+dcts3MW4pe4R0syxzn8QUTc0u1G47pvJk9Co3qqL?= =?us-ascii?Q?wnQ924ok+miI37UPPxCHuZ7R5balvk2TgRqEc9d9b0VfRIZ5QRq/jM6W+hvT?= =?us-ascii?Q?stw38EF2q4Qgmajksy5vieijde4nu+d//dWWr8emqOV2IRVv3Cl59smYthgB?= =?us-ascii?Q?bDuUIJukr1lOmdWkJslB6ZQOA5XhoecLfwXrxnp0FTG3lxrVlHJiP8HF+QxR?= =?us-ascii?Q?xHaTjAf4LvxebNJEh+GCT0XFK66JDF2E0P2yFNif8PRtF7gl7Ef1I8hR1jRG?= =?us-ascii?Q?VjstD4XfAVyHybMBMLY91THp+vGQ4frXj9jHdiPUAV4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97d8be6e-98bc-48be-eb8b-08d8a726f586 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:41:44.1981 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fnBIL+qWzk1IP6LY62ESj03uNPo3p+jBG2uTiF6cLxRg8nSILSFPqbzaylt6+SbjrGtC2G6oj92Ts3e6x+qZZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3603 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 11/38] net/mvpp2: align checking order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 11/38] net/mvpp2: align checking order From: Yuri Chipchev first check for 'isolated' and then for '!ppio' Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index 130f5221d..76847b303 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -1007,10 +1007,10 @@ mrvl_promiscuous_enable(struct rte_eth_dev *dev) struct mrvl_priv *priv =3D dev->data->dev_private; int ret; =20 - if (!priv->ppio) + if (priv->isolated) return 0; =20 - if (priv->isolated) + if (!priv->ppio) return 0; =20 ret =3D pp2_ppio_set_promisc(priv->ppio, 1); @@ -1037,10 +1037,10 @@ mrvl= _allmulticast_enable(struct rte_eth_dev *dev) struct mrvl_priv *priv =3D dev->data->dev_private; int ret; =20 - if (!priv->ppio) + if (priv->isolated) return 0; =20 - if (priv->isolated) + if (!priv->ppio) return 0; =20 ret =3D pp2_ppio_set_mc_promisc(priv->ppio, 1); @@ -1067,6 +1067,9 @@ mrv= l_promiscuous_disable(struct rte_eth_dev *dev) struct mrvl_priv *priv =3D dev->data->dev_private; int ret; =20 + if (priv->isolated) + return 0; + if (!priv->ppio) return 0; =20 @@ -1094,6 +1097,9 @@ mrvl_allmulticast_disable(struct rte_eth_dev *dev) struct mrvl_priv *priv =3D dev->data->dev_private; int ret; =20 + if (priv->isolated) + return 0; + if (!priv->ppio) return 0; =20 @@ -1121,10 +1127,10 @@ mrvl_mac_addr_remove(struct rte_eth_dev *dev, uint3= 2_t index) char buf[RTE_ETHER_ADDR_FMT_SIZE]; int ret; =20 - if (!priv->ppio) + if (priv->isolated) return; =20 - if (priv->isolated) + if (!priv->ppio) return; =20 ret =3D pp2_ppio_remove_mac_addr(priv->ppio, @@ -1209,12 +1215,12 @@ mrvl_mac_addr_set(struct rte_eth_dev *dev, struct r= te_ether_addr *mac_addr) struct mrvl_priv *priv =3D dev->data->dev_private; int ret; =20 - if (!priv->ppio) - return 0; - if (priv->isolated) return -ENOTSUP; =20 + if (!priv->ppio) + return 0; + ret =3D pp2_ppio_set_mac_addr(priv->ppio, mac_addr->addr_bytes); if (ret) { char buf[RTE_ETHER_ADDR_FMT_SIZE]; @@ -1590,12 +1596,12 @@ mrvl_vlan_filter_set(struct rte_eth_dev *dev, uint1= 6_t vlan_id, int on) { struct mrvl_priv *priv =3D dev->data->dev_private; =20 - if (!priv->ppio) - return -EPERM; - if (priv->isolated) return -ENOTSUP; =20 + if (!priv->ppio) + return 0; + return on ? pp2_ppio_add_vlan(priv->ppio, vlan_id) : pp2_ppio_remove_vlan(priv->ppio, vlan_id); } -- 2.28.0