From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1905A052A; Wed, 23 Dec 2020 10:43:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8C35CA6A; Wed, 23 Dec 2020 10:42:00 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id E8045CA39 for ; Wed, 23 Dec 2020 10:41:59 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9Uike002395 for ; Wed, 23 Dec 2020 01:41:58 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=oYN1bWIA1tiCxPjLA5xWgq21T1A5OYyDXBi4jUwnc6Q=; b=XrtgKZ4kPg/82XJLVRtALQxUgkcFW2RYW6wF9QQyFr+cMEivD+V51VQwj7KqgY+oAiOM iM2L3P5x/GnZBGnoHGXwo+ltiqVuTvel/mJUqbFWjS9meZiVkF6aMC62nlSyDnwmx3lb gwt4tIT7dvZ2cn9q11U9xitxED2bh7en0DOpIuB+GZ2e6ipQBy9XaAlnGKManI4yQQAp Dnd0Y34Ik1gi87WMKocITdCTnOB1fSffa+J5OTEoQa7/TVCE7MAhXzgGPuxpcyjRV/rR K1udsg27h2rw4qcLf0YVPESo9+riqqB3VGoZ6l/HJS9XBUN8++N9Rp1kCgzjEVBnjjRG 0g== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5n8f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:41:58 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:41:55 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:41:54 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:41:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lj6h54CKqDend3K3GVBbmBAgYWm+0PdzDxFQkgAqWDcIQQ1qkyKSEiBCWx7zbOC2zOrLJWW9W1zos14sSOJMpomC/K93a9lEy8NEF3XiXuGIMU5KsqUbCuPqbu4icZCBZ8ZlQEvWl1YTX8zRmg21axXjnIGgaEDm6ZKFEl731e0fZgEmds/qqGFilZfXDwyDzFrLRg71vNGt0zOYLYYDMXS278+n05mcuK1hJ6/jAUJG+9DuHDbrjwjf1Syj9+YuBWiW/oQWvNPBb75V9/1jEqWfwL0ArEYgXdwpbtx/dlihfT6fDjDFA4ZUIHpaOdYeVAhabFW09NRHkQX2kIsRzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oYN1bWIA1tiCxPjLA5xWgq21T1A5OYyDXBi4jUwnc6Q=; b=huwDpHrm5H6KhfUB441G4sEHuznMgxGY9Ia+bxO3PvVjfwuCwaq+1KfHTEHhneXoz9HAhO2r6aGX6NAswWm4nPq5RlQfvYAg66iHmXOhoKiu/CEkRR/oMjCMNhYAiM9MK0lA3Jw5roWNBcLptX1xVxQZZeAt8ey/uy6Wg4WIO2Jp1vZ7AuCIuXuVltA23OrzuBtlxeQkgpFDBbw95iauZp/+B7pV4sfTnsfovu+h9zG0uosRbCOmPp31WAgzpMYNwcw83cehZ0Z/+PTfmcgE9ylxMg7s13jE56eNZc57Pue50dkjXcIvQxKtRPDAMNgiQ9qhd0luRx+E+gti0Tq9kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oYN1bWIA1tiCxPjLA5xWgq21T1A5OYyDXBi4jUwnc6Q=; b=fVaHpIXYFkPk0hfT0W0WJPpQRSW85aBiQhT/8d3u2cqStM4aBlrqHniTFco81jNu8XfkV32HeXZblwnIPBerGm0UaE7BWE388xIab6nTB5MsHvcd16Agc8N1f6SsgSipg/JXQSycY/3E5vCNAnhHdOqwVui9JNh9U/5l+ng60o8= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB3603.namprd18.prod.outlook.com (2603:10b6:5:2a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:41:53 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:41:53 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Yuri Chipchev , "Liron Himi" Thread-Topic: [dpdk-dev] [PATCH v1 10/38] net/mvpp2: cosmetic changes to cookie usage Thread-Index: AQHWyJQnGe+8G4XrX0+MiO849gbBK6oEjn5w Date: Wed, 23 Dec 2020 09:41:53 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-11-lironh@marvell.com> In-Reply-To: <20201202101212.4717-11-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa1a646d-fb47-44c6-1552-08d8a726fb10 x-ms-traffictypediagnostic: DM6PR18MB3603: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b9yv6nyeiSY/7otvbK7us6kt3a2KSyoFLl2o1dkxHZ6kpOb/3RUL9c0iL2hij8hgi0+WWbWec57vKgfA978EB4gWZoWYTDo8A+dZfQx6ZlB51lmqrQX0h/Foh0Qqy76elffxtoGyDgdP5hfBwspkq1aOQO+CN/25Ha95bVUhRJD+IyUnaJ5+1GqWLkXh+xg4q07phRWKONx3lQs0am+GhKkk8DB92oyPLSJHRh8uejqa8FnzojytGw1GhvcNJxVSsjqARR+RXtsNpOMzCJiAfnuGCs8U8ORlOkdKWu+7g/0CBrmtXBEAC8MG3NtHSUk+qrwhX0MPY4pwasYNt/bW9eeF+JmyaEvFpHOVztT67XYaGlnzjKAlKrtz2bt3Q0je8h9DqXX3C0H9lBln82QBbA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(66446008)(53546011)(54906003)(66556008)(52536014)(66476007)(66946007)(4326008)(5660300002)(64756008)(107886003)(33656002)(9686003)(6506007)(76116006)(55016002)(6636002)(86362001)(71200400001)(478600001)(7696005)(186003)(2906002)(110136005)(316002)(83380400001)(26005)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?G5mMg3RMm4wUR3eodcWNnprMuOW4kKTgaBAbt3BP+jexAk+Uj6RPyBMYgtDf?= =?us-ascii?Q?liWyjaGnN3dMDusEEaiKgdoGzr3x1bpjd7ksDgPFlnUKOwD8zQ9oYQNTSaC3?= =?us-ascii?Q?kdlmOgd5Tkjr7Wcgn4L4moLutLL5RF5vdVtyqY27cWR6sk2rtxeD5Ajj1yFI?= =?us-ascii?Q?GQzZssse2D0GOxvS8jDOOl6sjqjk2ocVbWUJ0jz6SCgLFiARjJ3W1ZDE6YBF?= =?us-ascii?Q?MqEe5REJV9rDENemYYQUL+D8wcV/PwmbVhAKMHZUBXMpRoXbY5CWL5KTyBrC?= =?us-ascii?Q?RG0NAOz1Ke5TIXowkGpicc7s3p2b7lmHIOruYgT+/pKGa2628VnwmyBRHY9J?= =?us-ascii?Q?Zpwz4QS02AWZWj9V68/2m9lHjn2mz2FzzfDc99v6A9deC3lm6B0Orkdrq8f0?= =?us-ascii?Q?52yib+Z4DRfs10qPZeplt9RTj8FpOMMrSJqRp0z6KjOcxIF3XPYmkaIWkEK7?= =?us-ascii?Q?xng3dVtzOi3vSTgR1ao5VDG0tKey7UrRmVgZ26meJbaofh3UR8iR8f9TKbru?= =?us-ascii?Q?YwQQCbV4qqYKdnUB2fT/x9QnTSm8QCUonw5MPws8LVcUefbk0Cb9VPvrQb6S?= =?us-ascii?Q?09KW+G6EUMLJ1gffhTpbMdJIWUcscCZH8YyUCNmRXr7zlAq0a+kX+BTQ/5xt?= =?us-ascii?Q?v7BQSG4xKkvGTTeTDdVaFFsTEQcGEArcygow71twhKLL/oXdKNS9ydZ0phD2?= =?us-ascii?Q?ZtNQERPAeu/NIArTXo0mFmfpPRj/uMHXtmbqQVdeu1cvXkmhwOemnxYpLxeB?= =?us-ascii?Q?CyB0qgY4loinux/rOjfs/sGhSIacITZGpPkqSDDlKXtNtvUu2ABWZ1o6Ox6M?= =?us-ascii?Q?wH9hO5CGJAyDKILI/ZYC+5yIsO6HFEOrslP8hjz7DHc/AVsdK2chGYWoaUmq?= =?us-ascii?Q?U7Z1q0wQoLCRcbG1xqPXXc7wXW9cfWHvpTivSwtaReCfe4h2ABZWFsSc0Si0?= =?us-ascii?Q?XbzdMbGL6zToToG3Sn0DTJUsH84zKfyX+fTZ5vQn1IM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa1a646d-fb47-44c6-1552-08d8a726fb10 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:41:53.4337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F+GeOybMF7+wmUtffN2wJBllXfZkcCD2/MoMYa4rGizA0qvFLa/Rv4XdwAaGeDyHT4E69vvOn/MeN3aL9HWloA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3603 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 10/38] net/mvpp2: cosmetic changes to cookie usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 10/38] net/mvpp2: cosmetic changes to cookie = usage From: Yuri Chipchev No need to add high address to cookie on transmit side, as it has already 6= 4bit value Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index e81d5ee91..130f5221d 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -1643,14 +1643,16 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num) if (((uint64_t)mbufs[i] & MRVL_COOKIE_HIGH_ADDR_MASK) !=3D cookie_addr_high) { MRVL_LOG(ERR, - "mbuf virtual addr high 0x%lx out of range", - (uint64_t)mbufs[i] >> 32); + "mbuf virtual addr high is out of range " + "0x%x instead of 0x%x\n", + (uint32_t)((uint64_t)mbufs[i] >> 32), + (uint32_t)(cookie_addr_high >> 32)); goto out; } =20 entries[i].buff.addr =3D rte_mbuf_data_iova_default(mbufs[i]); - entries[i].buff.cookie =3D (uint64_t)mbufs[i]; + entries[i].buff.cookie =3D (uintptr_t)mbufs[i]; entries[i].bpool =3D bpool; } =20 @@ -2549,8 +2551,7 @@ mrvl_free_sent_buffers(struct pp2_ppio *ppio, struct = pp2_hif *hif, if (unlikely(!entry->bpool)) { struct rte_mbuf *mbuf; =20 - mbuf =3D (struct rte_mbuf *) - (cookie_addr_high | entry->buff.cookie); + mbuf =3D (struct rte_mbuf *)entry->buff.cookie; rte_pktmbuf_free(mbuf); skip_bufs =3D 1; goto skip; @@ -2663,7 +2664,7 @@ mrvl_tx_pkt_burst(void *txq, struct rte_mbuf **tx_pkt= s, uint16_t nb_pkts) for (i =3D nb_pkts; i < num; i++) { sq->head =3D (MRVL_PP2_TX_SHADOWQ_SIZE + sq->head - 1) & MRVL_PP2_TX_SHADOWQ_MASK; - addr =3D cookie_addr_high | sq->ent[sq->head].buff.cookie; + addr =3D sq->ent[sq->head].buff.cookie; bytes_sent -=3D rte_pktmbuf_pkt_len((struct rte_mbuf *)addr); } -- 2.28.0