From: Vidya Sagar Velumuri <vvelumuri@marvell.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 3/3] test/crypto: add ZUC test cases for 256 bit key
Date: Thu, 7 Oct 2021 04:44:00 +0000 [thread overview]
Message-ID: <DM5PR18MB10354AF70A3A2694EBCB8CB0A7B19@DM5PR18MB1035.namprd18.prod.outlook.com> (raw)
In-Reply-To: <DM8PR11MB55916E82740A7A92A29C26CD84AB9@DM8PR11MB5591.namprd11.prod.outlook.com>
Hi Pablo,
________________________________
From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
Sent: 01 October 2021 17:38
To: Vidya Sagar Velumuri <vvelumuri@marvell.com>; Ankur Dwivedi <adwivedi@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>; Akhil Goyal <gakhil@marvell.com>; Doherty, Declan <declan.doherty@intel.com>
Cc: dev@dpdk.org <dev@dpdk.org>
Subject: [EXT] RE: [dpdk-dev] [PATCH v1 3/3] test/crypto: add ZUC test cases for 256 bit key
External Email
----------------------------------------------------------------------
Hi Vidya,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Vidya Sagar Velumuri
> Sent: Wednesday, September 15, 2021 7:11 AM
> To: adwivedi@marvell.com; anoobj@marvell.com; ktejasree@marvell.com;
> ndabilpuram@marvell.com; kirankumark@marvell.com; skori@marvell.com;
> skoteshwar@marvell.com; gakhil@marvell.com; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v1 3/3] test/crypto: add ZUC test cases for 256 bit
> key
>
> Add test cases for zuc 256 bit key.
> Add test case for zuc 8 and 16 byte digest with 256 bit key mode
>
> Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
I see you added some test vectors for ZUC-256 and they all contain 24 bytes of IV.
From the specs, I see that the IV is actually comprised of 23 full bytes or 25 bytes (where the first 17 are full and the last 8 contain 6 least significant bits each).
Could you tell me where those 24 bytes are coming from? I think there could be a conflict here with other implementations.
[sagar]: yes, the IV should be 25 bytes. Will update the vectors with IV as per spec and push a new patch.
Thanks,
Pablo
next prev parent reply other threads:[~2021-10-07 4:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 6:11 [dpdk-dev] [PATCH v1 1/3] common/cnxk: set key length setting for PDCP algos Vidya Sagar Velumuri
2021-09-15 6:11 ` [dpdk-dev] [PATCH v1 2/3] crypto/cnxk: support for 256 bit key length in ZUC Vidya Sagar Velumuri
2021-09-15 6:11 ` [dpdk-dev] [PATCH v1 3/3] test/crypto: add ZUC test cases for 256 bit key Vidya Sagar Velumuri
2021-10-01 12:08 ` De Lara Guarch, Pablo
2021-10-07 4:44 ` Vidya Sagar Velumuri [this message]
2021-09-29 15:43 ` [dpdk-dev] [PATCH v1 1/3] common/cnxk: set key length setting for PDCP algos Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR18MB10354AF70A3A2694EBCB8CB0A7B19@DM5PR18MB1035.namprd18.prod.outlook.com \
--to=vvelumuri@marvell.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ktejasree@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).