From: Liron Himi <lironh@marvell.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Luca Boccassi <bluca@debian.org>,
"Kevin Traynor" <ktraynor@redhat.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Liron Himi <lironh@marvell.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] meson: update meson build for armada drivers
Date: Wed, 16 Dec 2020 21:15:34 +0000 [thread overview]
Message-ID: <DM5PR18MB2214D86FDD0EE9015E010C11C6C50@DM5PR18MB2214.namprd18.prod.outlook.com> (raw)
In-Reply-To: <4469d988-c732-b302-85bf-f8bbc93a33d0@intel.com>
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com>
Sent: Wednesday, 16 December 2020 15:49
To: Liron Himi <lironh@marvell.com>
Cc: dev@dpdk.org; Luca Boccassi <bluca@debian.org>; Kevin Traynor <ktraynor@redhat.com>; Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [EXT] Re: [PATCH v2] meson: update meson build for armada drivers
On 12/16/2020 1:41 PM, Liron Himi wrote:
>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Wednesday, 16 December 2020 15:37
> To: Liron Himi <lironh@marvell.com>
> Cc: dev@dpdk.org; Luca Boccassi <bluca@debian.org>; Kevin Traynor
> <ktraynor@redhat.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [EXT] Re: [PATCH v2] meson: update meson build for armada
> drivers
>
> External Email
>
> ----------------------------------------------------------------------
> On 12/15/2020 10:23 PM, lironh@marvell.com wrote:
>> From: Liron Himi <lironh@marvell.com>
>>
>> With pkg-config support available within musdk library (from
>> musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir'
>> can be removed.
>> PKG_CONFIG_PATH environment variable should be set appropriately to
>> use the musdk library.
>
> Hi Liron,
>
> It is good change to get rid of an custom meson option, can we or should we backport this to the v20.11?
> [L.H.] yes, it can be backported.
>
>>
>> docs are updated with new musdk version and meson instructions.
>>
>> Signed-off-by: Liron Himi <lironh@marvell.com>
>> Reviewed-by: Liron Himi <lironh@marvell.com>
>> ---
>> v2:
>> * include updated docs in this patch
>> * add musdk version in commit message
>> ---
>> doc/guides/nics/mvneta.rst | 13 ++++++++-----
>> doc/guides/nics/mvpp2.rst | 15 +++++++++------
>> drivers/common/mvep/meson.build | 14 +++++---------
>> drivers/crypto/mvsam/meson.build | 15 +++++----------
>
> @Ahil, is it OK if I get this to the next-net, since logically related?
>
>> drivers/net/mvneta/meson.build | 19 +++++--------------
>> drivers/net/mvneta/mvneta_ethdev.h | 1 +
>> drivers/net/mvpp2/meson.build | 15 +++++----------
>> meson_options.txt | 2 --
>> 8 files changed, 38 insertions(+), 56 deletions(-)
>>
>
> <...>
>
>> @@ -94,7 +94,7 @@ be passed as part of EAL arguments.
>> -c 3 -- -i --p 3 -a
>>
>>
>> -Building DPDK
>> +Building MUSDK
>> -------------
>>
>
> This is giving doc warning because of "Title underline too short".
> [L.H.] okay, will fix in v3
>
> <...>
>
>> @@ -108,7 +108,7 @@ Prerequisites
>> DPDK environment.
>>
>>
>> -Building DPDK
>> +Building MUSDK
>> -------------
>>
>
> Ditto.
> [L.H.] same
>
> <...>
>
>> diff --git a/drivers/net/mvneta/mvneta_ethdev.h
>> b/drivers/net/mvneta/mvneta_ethdev.h
>> index ef8067790..e090abc25 100644
>> --- a/drivers/net/mvneta/mvneta_ethdev.h
>> +++ b/drivers/net/mvneta/mvneta_ethdev.h
>> @@ -21,6 +21,7 @@
>> #undef container_of
>> #endif
>>
>> +#include <env/mv_autogen_comp_flags.h>
>
> Is this include related with this patch?
> [L.H.] yes, without it meson build will fail
>
There is no change in the code, how it was working before but failing now? Can you please give more details why it is needed?
[L.H.] I have updated the musdk pkg-config, so this change is not needed. Will be removed in v3
next prev parent reply other threads:[~2020-12-16 21:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 13:05 [dpdk-dev] [PATCH v1 0/2] armada: introduce musdk pkg-config lironh
2020-12-02 13:05 ` [dpdk-dev] [PATCH v1 1/2] meson: update meson build for armada drivers lironh
2020-12-09 10:49 ` Ferruh Yigit
2020-12-13 20:06 ` [dpdk-dev] [EXT] " Liron Himi
2020-12-14 9:57 ` Ferruh Yigit
2020-12-15 10:04 ` Liron Himi
2020-12-15 10:29 ` Ferruh Yigit
2020-12-15 22:19 ` [dpdk-dev] [PATCH v2] " lironh
2020-12-15 22:23 ` lironh
2020-12-16 13:37 ` Ferruh Yigit
2020-12-16 13:41 ` [dpdk-dev] [EXT] " Liron Himi
2020-12-16 13:48 ` Ferruh Yigit
2020-12-16 21:15 ` Liron Himi [this message]
2020-12-16 13:52 ` Ferruh Yigit
2020-12-17 10:06 ` Luca Boccassi
2020-12-17 10:16 ` Ferruh Yigit
2020-12-16 21:36 ` [dpdk-dev] [PATCH v3] " lironh
2020-12-17 12:15 ` Ferruh Yigit
2021-01-11 11:28 ` Thomas Monjalon
2021-01-11 15:29 ` [dpdk-dev] [EXT] " Liron Himi
2021-01-11 16:05 ` Thomas Monjalon
2021-01-11 16:08 ` Liron Himi
2021-01-11 16:17 ` Thomas Monjalon
2021-01-11 17:07 ` Bruce Richardson
2021-01-11 17:30 ` Thomas Monjalon
2021-01-11 18:01 ` Luca Boccassi
2021-01-11 17:04 ` Bruce Richardson
2021-01-11 17:06 ` Thomas Monjalon
2020-12-02 13:05 ` [dpdk-dev] [PATCH v1 2/2] doc: update armada docs lironh
2020-12-09 10:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR18MB2214D86FDD0EE9015E010C11C6C50@DM5PR18MB2214.namprd18.prod.outlook.com \
--to=lironh@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ktraynor@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).