From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28A0BA0A0E; Wed, 3 Feb 2021 13:09:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA7BE240516; Wed, 3 Feb 2021 13:09:23 +0100 (CET) Received: from mail1.bemta26.messagelabs.com (mail1.bemta26.messagelabs.com [85.158.142.114]) by mails.dpdk.org (Postfix) with ESMTP id AC3F3240509; Wed, 3 Feb 2021 13:09:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=rbbnselector03122020; t=1612354162; i=@rbbn.com; bh=ZSQEnBOI4edS8Vy6pKv7oq3JG2ABR/Ws9uJREcpOPcQ=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=dglIyhLzTvG2uEZZvC1M4oE7ZO38nV+GAmC73zsWm6j/bTqKyE67ND0zRaPDufy7p kcc660pLEEoPrrBRqZCbR6psmpJSPoFavK22eAVWvoRVP9pgNL1RM1V5Pi7l3NDqCb 6k7AgCODLtKcCLaoV3cr77DY7Z6Dsx0+YnJZ46qIH0YsKFEyXYvEHZCigU4Ghq7W1F LpVfZQLOPO/fyCrHDOCms3sH+WaW/u8LrAtIh5kTQO/ssIdWqN3GVaYtQ4lSXXOghZ 9MIDwwOxVnHH/OmYOy3HQqprkbFPUv28yaMCywGvruF/LW24sqIcneIXDGsRRfNN3L ke6B8INO6SFnw== Received: from [100.113.6.165] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-3.bemta.az-b.eu-central-1.aws.symcld.net id 65/6D-23163-2729A106; Wed, 03 Feb 2021 12:09:22 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1WScUwTZxjG+XrX9uioOQuU1wYN64hxbq1tFl3 hj4WMxNTINrdpSMzcOOSgF9sD2rKBgwQ3SKSCtugycJUWtEjqMKab08wyaWewVFk3tzCcU6fS YalFYSZsTGFtr7rtv9/zPc/3vc9dXgKT+AUygq4300aW0ssFIly3rlCnqO2UlamiNpVmZu4MT /NroIWv6fbdFWoW9z4Sarx7hvAivnbB6eJrOz6eEWzhbeczbHl1fRlfF7o2hWpOPlsf8fzIa0 ZLORYkIhDpwuBQpJ3PiREcIgNRISfcCNocj5AFpRM4eQ6DC+HnE4aEtPLg0z4b4sQNBFOBfiy REpD5cLX1UJKzSDNcn/pdmGCM3AiP99n5Cc4k34bW3jbEZbbCCd+lVL4QLvrcAm5aPlhGP0me i8kdcHQsIOCGnUTQ7fUmH00n34XhxyPJECKlMB/8nMcNy4FfJh1JBpKEY94QxnE2RO4spj7Ug uCgc4jPGXkQ9npSoZVwxbEPcfwa2H6+iHO8FqxjoRTrYTxmT2VWwx/hn1J3V4G741Yqkwu/TZ xJtgbSi0PwszspMYdB+NIgxon9BHwTuMm3onWH/1Od4xfBeW5OwPEL0N8bxQ4n/8dyGO2exJ0 Id6OCciNTpTMbKEavUKtUCrX6JcXLcVqvpHYrypV0nWInzZqNVNxVUh+YlKYGw059hZKlzR4U X6eKWiFzFh2890DpRysInjxbvHdhRZlkWXl1RYOOMuneM9bpaZMf5RKEHMTpNlmZZLmRrqLrK xl9fCmf2EBkyLPEQ9a4LTbVUAYTU8VZQaQgrJEjfZgEZ6tZWpYj1iZCZCKkq2OfPvFkta+glb JMMUpLS5Nk1NBGA2P+vz+NcggkzxS/mWiSwbDmp5Om4yV48RKzp6WJEmbqX0vWzHvHd7d9S0+ MuXa2NPdW5/01C88MGqaONdy4f2RGJFo9PPjh98NLjZO8YNZfbZd7NtwsGaset513zZeWzmRr WyRfi77d9HrQ3YUWmjxFr+wYfyt7dPaLV59rxZnd8l2n2tiPVLFtxi/1eV3+opaC1q+m2cKNj Y7Fv/XWaMHEhssTDYFox21X8Z6S8w7HyNHjB/Si7X0tYvs91hyT9Nqv2/ubTudZpFLMUZIfgs pG/kB4uLbpwapSbXOQPrU02+5s9lH6/Vc3b9r1XWjZ5q4w/bDztoEodi29r6z0F9fGjo8orLN znskD84WG3hMZuqGH69+ISNVrfvDJ/hT2FJRcqBiQ4yYdpV6LGU3UP+ZJLeRVBAAA X-Env-Sender: sodey@rbbn.com X-Msg-Ref: server-23.tower-245.messagelabs.com!1612354160!4376547!1 X-Originating-IP: [104.47.58.104] X-SYMC-ESS-Client-Auth: mailfrom-relay-check=pass X-StarScan-Received: X-StarScan-Version: 9.60.3; banners=rbbn.com,-,- X-VirusChecked: Checked Received: (qmail 27289 invoked from network); 3 Feb 2021 12:09:21 -0000 Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) (104.47.58.104) by server-23.tower-245.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 3 Feb 2021 12:09:21 -0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b+5GQcCaY2q2g0lB/Fxerl4mC40qgDHYmHuehLc0YYGzp8gnkyNYzTzS97IOi/Yhhj+DCJIS7AXupruvjRmDzpHiH/L7mv3TAvtBkTdXLDGuY1vQt/kllWopaeR6+BvuGg9QI45tPlurnquospkAm3++E6jdpaxW9JQYc23RjzBylw+fbu4TrMXA81Na2ECaL9QkQaz0n8jIWFTa/IHfKRmhJ/535VCX/tRYnj9gBRE8YbKtUsw/kBuDrByJE6I2VguKKJY4bOkOHlns9UAXlEaNrd/3lua31fkWeOZg8haCcqNrHbmNwbzVCVobdWhvTtwJTd1wGg7LqM8Brgkp8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fS7/qfM/UeRSVpBp+GWqJN/epeWbhjAlFl6XdINkkLc=; b=P6k+NytxtMdiOYhIyt6e1BJ+UCPxsi/6PuUK4Ij0a/updUp4DrUIMTqdJ+TtXnjIJOu0zGDzC45pMUlP5oTEqM+YUGMkTzP5pE3YEyN+9T2dK1ZpIDjirP5CtA1jx7Fppsdjt21ql9XrUpn/klyJE0vzxQVKvLeEy8pv2lLNyKZXt753J8Un4XqUQhwvPuNEzNHXsvlckT4VTZyFJu8BD/4TxKzL18A2v94+v0FyFP+qvaaEGhZrXCtGERhGJCptAVh1sKEkk9KL/iCrmXyiYl6CuB0WGPmJFMdq+HnqeGwsLq/mDs+ySOTmlQa34VF44kOczuMfiS299wgUypN/WQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=rbbn.com; dmarc=pass action=none header.from=rbbn.com; dkim=pass header.d=rbbn.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector2-SonusNetworks-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fS7/qfM/UeRSVpBp+GWqJN/epeWbhjAlFl6XdINkkLc=; b=JM7UaNtQ9NtNsowzGEoUCzNr6Q7xFt74Klo2+Wpa5/4dFOZy1qMp1pyFPk0sSjkJMQ+QuIoBJJ5gakO2i74WwAibzK3RDCJ7eMuAicDY77hSE+ROvyab88M9EUD7iUfXFTakqZcQTc8xoo7Lw/qFLX7w66zHrMzcle3/blSfXDI= Received: from DM6PR03MB4777.namprd03.prod.outlook.com (20.179.106.218) by DM6PR03MB4076.namprd03.prod.outlook.com (20.176.120.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.24; Wed, 3 Feb 2021 12:09:18 +0000 Received: from DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::3958:bb2f:f23e:f89e]) by DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::3958:bb2f:f23e:f89e%7]) with mapi id 15.20.3825.019; Wed, 3 Feb 2021 12:09:18 +0000 From: "Dey, Souvik" To: Slava Ovsiienko , Raslan Darawsheh , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] common/mlx5: fix storing the synched MAC to internal table Thread-Index: AQHW+Yurjd3fsGRaxkKVFmXrzXDhiKpGEz0AgABCbbA= Date: Wed, 3 Feb 2021 12:09:18 +0000 Message-ID: References: <20210202035352.24512-1-sodey@rbbn.com> <20210202174841.15784-1-sodey@rbbn.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [72.70.55.110] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7159e2cd-8ba5-4af4-88b8-08d8c83c8896 x-ms-traffictypediagnostic: DM6PR03MB4076: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rS/cIL+bSkHmhTO2ayWf1w+eC9m+f9FBZ/lCXoiqy99kx6da7C/LxCARcj5BlanmvUsCIMrjLGq4CxVOnf0t3mEA5F3y28ga8LThFK93bgNsX4jm29K1joYD/ZRKCR3oVVmdWRJmqTS3PBblbh4p4GVSan95EqKJmVuxqAWwaTc+mdSMa0U+0qm+93Z5pmZFoC9REC+GkLGjiEglPIN8VCJarAxhtddw7YvuiIJoqAVEhfGzD19FnaubjDSPXq0mjMW9ukmGU3k3XzirNsUDinvGk4tttU8XlzlQo/xnclAOvzzyULo+K8/UPyB5dGsXnc3mLZejgpfvVRUC5LMhZ76YG0spjDR70yrfnnSNIDK27b+6MSPLq8BgPSW5nDOlggc+u/kKvAPnlMxUVGcCKD2v+hxGirV9IwclqR+gGwQkL/hPYEilNOmJGdi2Qi+v82O/e4/hvMB3wEiC1PL9YNK1OUiX++prqQsmAJKc+k1yC52C3MjVXGJLDEiljiRZhNgrYJVwK5UnfoKAY+2oVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR03MB4777.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(66446008)(83380400001)(478600001)(52536014)(6506007)(26005)(8676002)(110136005)(55016002)(7696005)(66476007)(66946007)(64756008)(5660300002)(186003)(76116006)(8936002)(53546011)(66556008)(9686003)(54906003)(71200400001)(4326008)(86362001)(2906002)(316002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?bLaaQlQBpxvA7iv1GX21B8XSBafpCY3BfhKok1ERd9Wsv76VBIZJLA/aE6MV?= =?us-ascii?Q?cEwkXifnTIJXTeCyALuUnHJ5kQM0wdEVY819HFdPWjoR7nU1Ys614UjbakOw?= =?us-ascii?Q?B4/83ooZdaR03Rplv+OouVBGPOrXyGFPSsK6spNh8KyxTBhbygkKA4yFFv0y?= =?us-ascii?Q?eQlntgURFfWvKz7Hyh99O7YwAkuOF8ulclKW1b0tRXa9BT5Jn1tyYFXXv8EF?= =?us-ascii?Q?IX8JJoRjg5BsMdYsprKD/7nn/Ny9yOR2KiKbcadEZaKwdTgs67t3qcpc5G4v?= =?us-ascii?Q?OT8LfU4bmLZO2JVdCW+qWNyVbQo1D/TeXXcX5a98N8QU6QZPmFNqPxatFMrE?= =?us-ascii?Q?ph1iCpJSMS71dxOHce2u8I0C53ttPTzDYnlVgYhqY9M3fq6pcSQvEMM31gHJ?= =?us-ascii?Q?tuZr0Srjp3aWhw/QPG7EJvSm1d3zO0uOytfurYY99/N9wuVIYSqUoeapItem?= =?us-ascii?Q?/BxVhFsu6tGrY7V6X38QN4wpKD7fpmYKwOuIP8SbB+jokyiaFPYMJqQ7FGB6?= =?us-ascii?Q?1LW6D4HjuAOXxBWLzo1jh9Ba8lUFr1tFvR1XcWDJ5XKxSFMMHqJNspZOFqlp?= =?us-ascii?Q?A0WtP4PodZ1nzEttYWQLf+EBP0D3mhBHnxVqIauUzndeBanvkOpmstRwu46I?= =?us-ascii?Q?Z2U0G7UNwJsze/+kC4YuGmh89VJoEGgpmKcG3SZoMU9r840TzvPMKLvQd10e?= =?us-ascii?Q?6QYo7L7tGYVGl91Z7iCwh3vml7BhqswPKvVBQUFIQJzesIt3SvwOGrpl2Udm?= =?us-ascii?Q?klvpVxp8clEpcWTOc6eIaUkgzoePp08wYLF9PCwbYKUGrlFhlfUSJHCG/mZq?= =?us-ascii?Q?MSoy1q3LLPc2EppwC9ENTXo2LbaI0l2lgZWP/nPNqymNHFdB7Erp/r0GxDHA?= =?us-ascii?Q?6ISfT3SXhXzB9pILNaZDMZZryvKeWvGEzWRd83AY6knaR3VUzNgkAXZgb6oL?= =?us-ascii?Q?tDEm2wR9sz0O2CodMNrdXJ8mQzxzQ86W/qJRLHyCHQflJu9c9QnDYwbFc7ol?= =?us-ascii?Q?De40G/k0XOR4kwuz+Z6vSTEdhIwgEGHoYqQjKLI9IBdSsItpwBGTOQa2TUWu?= =?us-ascii?Q?K2NL2a8J?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: rbbn.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4777.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7159e2cd-8ba5-4af4-88b8-08d8c83c8896 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2021 12:09:18.6455 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PqrVXgI0F5NgO3GTEfH9yOIU5HRpCVzXrx+ErzG3wYtOFeQUhAUgOjp2XtGzqcJJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4076 Subject: Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Slava, =09Initially v2 of the patch has " instead of ' in the Fixes tags, but it = gave some warnings as wrong quota. So thought of changing it to '. I can c= hange it back again, do you suggest me to submit v4 with with corrected qu= ota character or its ok to have the v3 of the patch itself as you have alr= eady acked ? -- Regards, Souvik -----Original Message----- From: dev On Behalf Of Slava Ovsiienko Sent: Wednesday, February 3, 2021 3:04 AM To: Dey, Souvik ; Raslan Darawsheh ; M= atan Azrad Cc: dev@dpdk.org; stable@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MA= C to internal table NOTICE: This email was received from an EXTERNAL sender. Hi, I'm sorry, but quota character in "Fixes" tags is still wrong, causing the= checking script errors. It should be " (0x22 ASCII), not ' (0x27 ASCII). Beside this: Acked-by: Viacheslav Ovsiienko > -----Original Message----- > From:=20Dey, Souvik > Sent: Tuesday, February 2, 2021 19:49 > To: Raslan Darawsheh ; Slava Ovsiienko=20 > ; Matan Azrad ; Shahaf=20 > Shuler > Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey > Subject: [PATCH v3] common/mlx5: fix storing the synched MAC to=20 > internal table > > From: Souvik Dey > > As the internal MAC table is divided into Unicast and Multicast=20 > address sections, we should check the type of synched MAC address=20 > before storing it to the internal table. Currently the check is not=20 > done, and the synched MAC of > 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1)=20= > causing all subsequent mlx5_set_mc_addr_list() to fail with error=20 > -EADDRINUSE, as the mac_list contains the MAC 33:33:00:00:00:01. This=20= > denies adding of any new multicast address to the internal list and=20 > also fails to add the MAC address to the device in case of SR-IOV VF. > > Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies') > Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC=20 > addresses') > Cc: stable@dpdk.org > > Signed-off-by: Souvik Dey > --- > v2: > * net/ -> common/ > * space after mlx5: > * synched -> synched > * section -> sections > * rewording which causes -> causing > * typo: case (to remove) > * added Fixes for LTS ML > --- > v3: > * Changed the "" in Fixes tags to ''. > --- > drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/drivers/common/mlx5/linux/mlx5_nl.c > b/drivers/common/mlx5/linux/mlx5_nl.c > index 40d8620..ef7a521 100644 > --- a/drivers/common/mlx5/linux/mlx5_nl.c > +++ b/drivers/common/mlx5/linux/mlx5_nl.c > @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int=20= > iface_idx, > break; > if (j !=3D n) > continue; > - /* Find the first entry available. */ > - for (j =3D 0; j !=3D n; ++j) { > - if (rte_is_zero_ether_addr(&mac_addrs[j])) { > - mac_addrs[j] =3D macs[i]; > - break; > + if (rte_is_multicast_ether_addr(&macs[i])) { > + /* Find the first entry available. */ > + for (j =3D MLX5_MAX_UC_MAC_ADDRESSES; j !=3D n; ++= j) > { > + if (rte_is_zero_ether_addr(&mac_addrs[j]))= { > + mac_addrs[j] =3D macs[i]; > + break; > + } > + } > + } else { > + /* Find the first entry available. */ > + for (j =3D 0; j !=3D MLX5_MAX_UC_MAC_ADDRESSES; ++= j) > { > + if (rte_is_zero_ether_addr(&mac_addrs[j]))= { > + mac_addrs[j] =3D macs[i]; > + break; > + } > } > } > } > -- > 2.9.3.windows.1 > > Notice: This e-mail together with any attachments may contain information = of Ribbon Communications Inc. and its Affiliates that is confidential and/= or proprietary for the sole use of the intended recipient. Any review, dis= closure, reliance or distribution by others or forwarding without express = permission is strictly prohibited. If you are not the intended recipient, = please notify the sender immediately and then delete all copies, including= any attachments.