From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E751541C40; Wed, 8 Feb 2023 14:17:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B8FB42B7E; Wed, 8 Feb 2023 14:16:52 +0100 (CET) Received: from MW2PR02CU002-vft-obe.outbound.protection.outlook.com (mail-westus2azon11013003.outbound.protection.outlook.com [52.101.49.3]) by mails.dpdk.org (Postfix) with ESMTP id F0E7040042; Tue, 7 Feb 2023 11:42:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UoRKk72c6h3PN9axJnM33apA2Z/LDZ9VLxbQbwbQF4bxqvOtaLtaZBoIjJuLm22yGfScQSxU5QBCc7EXWAKUt2l04JSQjw03zhftmnpReBs4hRkik17LdEVcee2GOo9T2UVMVC01pN7NuW1rTu8kRi1NAKjrVHlDb1iNOj/PoECm0Hbrs2GKCD8LU7nSZNkZQFNl55pm3mHjWHreroMdXA0Q2jWSf1KLZC37rZc0Ll9MC8fyt9im7C1cCeLisPkI7ew7H6y5NrKZqW0uNULPqpWr9v0+ojpb0M0ZCZ6yHvQf7YZH9O0Z5Rcx4MkScSusHtvcdlZOnb468+30VXKFkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fDG9FgbvKyPvrMbYehnNkjlWjj9TViXnBbGWvl2OUhU=; b=RM0TOmOWPLFnsFbSMmtxo5CmsyX4qttsjen1DJ+SDXT71PoK6H09KVs17I6PmRQDW1AOpngSgkSwuGAWGJ3epVkpl7hAONGg2/BtJYvWsg38vRkt4fv0OLiL0nq8OkURQT/HnvZiUlkMQHu/LIMj1V6CYBvcJVtNAARTj0VnC9W7k91M8LknoDgvMYQZ0eD6JyQXT2iKZvK/Qd9ZaK6ipKI+PwafS4Aw7Z4gBG2Cq39HEAXhspv5nA3S5Su1j/HfP3FNFDvOvDEksg52MuB9/aQQdWEnDedtujeAAmu4bv0g9aFW0bwTdV4XC2kTHUpWostcMhSR2DspX7fMNYqjSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fDG9FgbvKyPvrMbYehnNkjlWjj9TViXnBbGWvl2OUhU=; b=FInlSeiZ19TMdUj3AmHz7hL1hu8ZOU97Sj0JWRtbK3Yf0P5cy7yF3HWDmE2571Cx05zoAEij3F2ETAqhGdVC6SnUlehj48IPn3eHhoNAPkgYk5XEsg9tz2yGcK5gselFzPEU+jp0xSbdx5OosKJxyLgB3tjML4B9VnMRCd/cH/w= Received: from DM6PR05MB5577.namprd05.prod.outlook.com (2603:10b6:5:c::16) by SA1PR05MB8471.namprd05.prod.outlook.com (2603:10b6:806:1da::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35; Tue, 7 Feb 2023 10:42:54 +0000 Received: from DM6PR05MB5577.namprd05.prod.outlook.com ([fe80::4cbc:cca6:3a16:5023]) by DM6PR05MB5577.namprd05.prod.outlook.com ([fe80::4cbc:cca6:3a16:5023%7]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 10:42:54 +0000 From: Vipin P R To: "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: Re: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address Thread-Topic: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address Thread-Index: AQHZJ1GwRdTzE93uukCXBSId9SLJw66h3oqAgCGTTuM= Date: Tue, 7 Feb 2023 10:42:54 +0000 Message-ID: References: <1673615963-21216-1-git-send-email-vipinp@vmware.com> <1673615963-21216-2-git-send-email-vipinp@vmware.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR05MB5577:EE_|SA1PR05MB8471:EE_ x-ms-office365-filtering-correlation-id: 8d6e07b9-29ed-4d00-d3f2-08db08f811d7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tmJ7O70nzGnRoYpMe/xT152ni3htYWRccfloRKKZT8+bR6+HKEUqCV5E291xjr302qlTIpmUdg5aRez2QMdtJEkYIgWJOmrwk2UAttEVrT90Vegzxl1eGXZY07IMIOi/95PXcGotYo5rOyz/Smid3s6lZPl8ukcVkdZCyB8BF9pE82Wks//5yfbJc5KLateP+llbzDmGEaSlG8+u4Hb9YXVZramwWKdFYyxgR7rLPKmgggttCNdC1Hhh2FKwYehRmXm46ko9xSt90dqw+CsD7aAu+WX50HfYdjRSmq6PqSH3iIEGWHMDiRwL1Sh/MR4N0qQ+HZJaCqYNNDYSE+L7eufUKQ5a7fqw1WHCq0m2m+hQI3WAYRnHej04twgZCgZH7uEtJLgtoVaAxUkghiCmgu9tctLR/k0OZT1n2+L4USi+j29vmtWfIQgsJ8TUQseW6PTXRGVwsUNokHejIHW08IAJX+1cUklI9mrIwxtpvnP+dnGUVe0waBExQp5L+R75Ses8DgCACI7/DkC0B4MRJi48yQKkOuGi6tIFGb4m5N/ZtW9N5izJRb0BmB+GqAbrb+vhJlYhZKm+rLu8EQKRiRQw0n1Zahx55f2HA3KSo3QJky1Po5Kh/Q4EJGPLZ5Et46gw1K6JevK1Pa07Y/aAYN063p9L9Ksc13EGc+FJAkYA6pua489skyISrC6JE4tnKLDkDfG/2GyaPiTvzhLlLxTzpTVRo78uNPnO39BKk8Vy4aVHORa+XY506Ni5PPY/ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR05MB5577.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(346002)(366004)(396003)(376002)(39860400002)(451199018)(2906002)(122000001)(38100700002)(38070700005)(83380400001)(66556008)(66946007)(4326008)(91956017)(66476007)(66446008)(64756008)(76116006)(110136005)(54906003)(8676002)(52536014)(8936002)(5660300002)(33656002)(316002)(86362001)(6506007)(9686003)(41300700001)(26005)(53546011)(55016003)(7696005)(71200400001)(186003)(478600001)(19627405001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ijePKBw0JascB8iLR8j88vInKDLinZNaYFIVbY4f48L8VU7Uf7MYbCt7nu?= =?iso-8859-1?Q?W8oBa6Uf/zQCftVJkfBKDF//n99tWKdaSNQrpXJEnyUA0fAJfmvQu35udH?= =?iso-8859-1?Q?OrE2nLBwhIvnDgghw6VknXw9QlOwMwpPA+5CE9Gdy7aAVFxvveznpWQL9A?= =?iso-8859-1?Q?CaNQKa1juKpcnqNMIWRv91XH8LZgbDvQLrUuRMofngKSkUP8HQMQIdJ73L?= =?iso-8859-1?Q?ZxGu7z6TAfpo1AH7k8ku30BtKgtJ4e569qDs+MJJOEJGl6c02j8Nuh0j+B?= =?iso-8859-1?Q?pcyvwf3133nns68/AmUbz4LuV+6MU2G0eyJxI0zbFj7m6WyTFJX9Q9bT8U?= =?iso-8859-1?Q?LTnIii3O6mw+bK5+y6KpK7Wezw2w9SFNFDezqNrI/za0D5FUQkyWUNMCNA?= =?iso-8859-1?Q?2cjlJTc+LMq1nuH/NOyGc2B447isL14YyxmZrDI5Ku6Pf+9dLr6aYhvTka?= =?iso-8859-1?Q?GK+ARBdYfBe38o6VjfOwv/RJcbvq6ciz9JK9XqqzkL9woxHv56OCvDrXbj?= =?iso-8859-1?Q?WOn2WYn48XcUQcsnsVdUcwMufvjYM2KZsay3/PHj9Ce74vr9KhX1tuG2Jr?= =?iso-8859-1?Q?t5C0V4o3SkyW5REEh6ASiDSTSfYp/RVdJRnh5/GzOWFAo0S/CWfhZutRLY?= =?iso-8859-1?Q?SWMnVYCrgj93dnLU8JR4eoaCW3K/qAn9WrfzCUjkJj2yrX2EyMfi5SL609?= =?iso-8859-1?Q?Om5h4+0VDIjX7/qdH7v91ntuSaMWlg5Vwrte6LN+61fnWSdeg6QIhpkMNX?= =?iso-8859-1?Q?Hrd/qepbJN7llcMpcxLOaR9AI5MGIR7DFIg59c4EEsk62AxSLHcDRQV3i0?= =?iso-8859-1?Q?+02jYIqlr8jamHd3psIqzVZsN3uPWWGCUGkY2uoft2AarIxOENoyU4+S/7?= =?iso-8859-1?Q?07kLgtf8zdNB8hTaIO0dESKN94Nh978biOAQ27mjxcmysDFWIxNeQMsUlz?= =?iso-8859-1?Q?xEhsY6T1dhpdePdRDhaWYAssF+EbiPMPLleFyEqJl+uBYkPJortZsobC+Q?= =?iso-8859-1?Q?ib60xcnAQFw1/2a7V6yRo0HCIRe5V5toH5Ljb7wvQf9NiBraKJVUsVLqTt?= =?iso-8859-1?Q?OYZ93wXgcht2u3FXwCyTFgXfSjJ9Cu8c1IrLTwhOHmnfQ6sWH5b34xX6kw?= =?iso-8859-1?Q?9Fbi2v8mN7ZSHYReVh4tp+xNajM3vpBnh2z9WH5Rinm1b5JGQg/1M92H9U?= =?iso-8859-1?Q?uFJa7vZNuMdjUjybx1gtK0BM5Si0jbkOb3qFOG4mrmZCrd041PwQyfcaUu?= =?iso-8859-1?Q?uq+VMskcjJvsnXJHcMHX46xpF2T8sW7+0Mh2jH0O6RshWG76HKhbodgLLO?= =?iso-8859-1?Q?CCy9vZt97LSwHDgCquJmub6/V5dcNnP2MvZN/b0E/HRIRcdEReZ3ch41J7?= =?iso-8859-1?Q?RK+/Uz7fJYTPTT42XZC1NFxlN1wUH9UEGID6z3ma0uAdmn5PKVJWMXpteg?= =?iso-8859-1?Q?Co1yZcRXxt4j4xpQCpNpA+rR3rWP/U7huOORri5FhR+5OlKboIrA/8MZYl?= =?iso-8859-1?Q?M7K5ZWFiokfKvOiy39HtWb9kMezNzakNKLc4JYhNj5u2sDd5BKJN9lSIeI?= =?iso-8859-1?Q?4hkf3XtfjB6KissfT4l4hB3rbETngKaAAUPMN3K71jpS+Q4HngrPy0wEwr?= =?iso-8859-1?Q?7+iZhSoLH+4MFQ2XZXI3oRvbgI7/HDgZ8z?= Content-Type: multipart/alternative; boundary="_000_DM6PR05MB5577F9DF1A03D0E4722097A1B7DB9DM6PR05MB5577namp_" MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR05MB5577.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d6e07b9-29ed-4d00-d3f2-08db08f811d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 10:42:54.6857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 283NIr5BEoDIm0XytfLvUwVd/nRL0uCUl2a7S8KCviowc2keG3bLYrba1ZnNf74DtIj8S3Y/SQmhxGuLaY3bQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR05MB8471 X-Mailman-Approved-At: Wed, 08 Feb 2023 14:16:49 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_DM6PR05MB5577F9DF1A03D0E4722097A1B7DB9DM6PR05MB5577namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable ________________________________ From: Zhang, Qi Z Sent: 17 January 2023 07:24 To: Vipin P R ; Wu, Jingjing ; Xi= ng, Beilei Cc: dev@dpdk.org ; stable@dpdk.org Subject: RE: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address !! External Email > -----Original Message----- > From: Vipin P R > Sent: Friday, January 13, 2023 9:19 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Vipin P R ; stable@dpdk.org > Subject: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address > > In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and > VIRTCHNL_OP_ADD_ETH_ADDR are unsupported. > i40evf_execute_vf_cmd is invoked with these operations as part of > i40evf_set_mc_addr_list() > > The cases are not handled in i40evf_execute_vf_cmd() thus hitting the > default case. > There is a retry logic of upto 200 times (2000 in iavf) with a delay of 1= 0ms (1ms > in iavf). > This results in a needless delay of 2s in the init phase for each VNIC. > Sorry I didn't get this, why this is related with i40evf? I40evf PMD has be= en replaced by iavf PMD. The iavf PMD works with both i40e and ice, does this will break ice's usage= ? Hi, this is problem was discovered while using i40vf (which was deprecated = and replaced by iavf). Upon inspecting the code, this problem would also be= hit in iavf, if the VIRTCHNL_OP_DEL_ETH_ADDR and VIRTCHNL_OP_ADD_ETH_ADDR = are not supported. > The patch aims to rectify that delay. > In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was > deleted. Hence adding this in iavf_vchnl.c. > > Cc: stable@dpdk.org > > Signed-off-by: Vipin P R > --- > drivers/net/iavf/iavf_vchnl.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.= c index > f92daf9..e2f65f5 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -367,6 +367,14 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, > struct iavf_cmd_info *args, > } > _clear_cmd(vf); > break; > + > + case VIRTCHNL_OP_ADD_ETH_ADDR: > + case VIRTCHNL_OP_DEL_ETH_ADDR: > + PMD_DRV_LOG(WARNING, "OP_{ADD/DEL}_ETH_ADDR > unsupported"); > + err =3D 0; > + _clear_cmd(vf); > + break; > + > default: > /* For other virtchnl ops in running time, > * wait for the cmd done flag. > -- > 2.7.4 !! External Email: This email originated from outside of the organization. = Do not click links or open attachments unless you recognize the sender. --_000_DM6PR05MB5577F9DF1A03D0E4722097A1B7DB9DM6PR05MB5577namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


From: Zhang, Qi Z <qi.= z.zhang@intel.com>
Sent: 17 January 2023 07:24
To: Vipin P R <vipinp@vmware.com>; Wu, Jingjing <jingjing.w= u@intel.com>; Xing, Beilei <beilei.xing@intel.com>
Cc: dev@dpdk.org <dev@dpdk.org>; stable@dpdk.org <stable@dp= dk.org>
Subject: RE: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH a= ddress
 
!! External Email

> -----Original Message-----
> From: Vipin P R <vipinp@vmware.com>
> Sent: Friday, January 13, 2023 9:19 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beile= i.xing@intel.com>
> Cc: dev@dpdk.org; Vipin P R <vipinp@vmware.com>; stable@dpdk.org=
> Subject: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address=
>
> In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and
> VIRTCHNL_OP_ADD_ETH_ADDR are unsupported.
> i40evf_execute_vf_cmd is invoked with these operations as part of
> i40evf_set_mc_addr_list()
>
> The cases are not handled in i40evf_execute_vf_cmd() thus hitting the<= br> > default case.
> There is a retry logic of upto 200 times (2000 in iavf) with a delay o= f 10ms (1ms
> in iavf).
> This results in a needless delay of 2s in the init phase for each VNIC= .
>

Sorry I didn't get this, why this is related with i40evf? I40evf PMD has be= en replaced by iavf PMD.
The iavf PMD works with both i40e and ice, does this will break ice's usage= ?

Hi, this is problem was discovered = while using i40vf (which was deprecated and replaced by iavf). Upon inspect= ing the code, this problem would also be hit in iavf, if the VIRTCHNL_OP_DEL_ET= H_ADDR and VIRTCHNL_OP_= ADD_ETH_ADDR are not supported.

> The patch aims to rectify that= delay.
> In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was
> deleted. Hence adding this in iavf_vchnl.c.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Vipin P R <vipinp@vmware.com>
> ---
>  drivers/net/iavf/iavf_vchnl.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vch= nl.c index
> f92daf9..e2f65f5 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -367,6 +367,14 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter,=
> struct iavf_cmd_info *args,
>            = ;   }
>            = ;   _clear_cmd(vf);
>            = ;   break;
> +
> +    case VIRTCHNL_OP_ADD_ETH_ADDR:
> +    case VIRTCHNL_OP_DEL_ETH_ADDR:
> +        PMD_DRV_LOG(WARNING, "= ;OP_{ADD/DEL}_ETH_ADDR
> unsupported");
> +        err =3D 0;
> +        _clear_cmd(vf);
> +        break;
> +
>       default:
>            = ;   /* For other virtchnl ops in running time,
>            = ;    * wait for the cmd done flag.
> --
> 2.7.4


!! External Email: This email originated from outside of the organization. = Do not click links or open attachments unless you recognize the sender.
--_000_DM6PR05MB5577F9DF1A03D0E4722097A1B7DB9DM6PR05MB5577namp_--