From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 286EDA0563; Wed, 15 Apr 2020 17:01:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F58D1D8F0; Wed, 15 Apr 2020 17:01:51 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1836F1D8DF for ; Wed, 15 Apr 2020 17:01:49 +0200 (CEST) IronPort-SDR: 6sdP75DPKv/K34qWJN3L+6tGzccn2THmzMtuKjL0F/z5KC4RtdbOUkH6Yg9AW779IXqOmZHfEM jtvCjS/Chdxw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 08:01:38 -0700 IronPort-SDR: swknhitTZ+9bRSJT3fTicUDwhQ9r4Ie7E+cyB0TtjqDAv7gbbPzr70zjAHpJ+aNtIDO30YV/d1 D2WNe+5+Zjtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,387,1580803200"; d="scan'208";a="245711243" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 15 Apr 2020 08:01:38 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Apr 2020 08:01:31 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Apr 2020 08:01:31 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.56) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Apr 2020 08:01:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JEmlzJn9s8ZJbQk6dbBmCMoPrsl/+9utRxu8rljyYlThm2X+GEo36hhIdxRs/kPphVTDZ/FYFj3Yw4Jo99u5y/qYbghURbA3bfkj1OckCTtnXSmyykxsTQr/W6FZN1Zvo6ZInR+gwjUwtL32SM08ky1oW3ThKaB19IbSFBJTC6qyWIZTRXWuT3fZ4bkjt63a6kuXqj1stMlF75RjENYel2l8pr5eGbtCwjg7GHOUb7VgY3IJ64eUYzXbETIZjX2+AWMjL3iV6Ez6iyRlKSqIfTDJgaEpIGDfmG9eza6OfxvMJDo3pXii102bXzLzrZhJme+xfo1uJwiLXg45caHeoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9c6oeIs46yaPAM44MoATs3z/mV3GqzOTCMtykvMobHE=; b=Qcd9yy4RoenAQsOpNJxsxRgGL43OAlylHkh/bYLp4yEiLU7RHPQAL2kTd+OSGXO4c9ZciqTtsWP7RUs2EZiOjRv2TnkFwQLmbooZ38Uxaxl4Ay9xmD73JRmScy1kzi4CSD3qetVV2ssFM6GIqv/eKxR2cPXLCLQ0Qqg8DRGBe7tFMmxR/C2PFVhL3quvDXN9wVjC4U1z9lhMxmSkawn3iI5mzSVYPyY7HYinwah45ybt6RTB1yXVr2USxN4+k9d/eEhr3v6d/XtNpwyrcoHT75mNw4UHR0HxJJ7q+ZaD17iEylQYCU10hr1QfDMHnCKmPRUfzESUU8J9enYMQJ62Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9c6oeIs46yaPAM44MoATs3z/mV3GqzOTCMtykvMobHE=; b=IU0GOvCRfFpViAgT613QIHALNuWx32tbidRNjWb4eKbBIpZ5S7kAp4nyjrwcQZdeLe6stlM5BPLihPjWfhbVWV8xyAQwno6AW8WT/Tyzh8xhDqnzQ9PFZeTGWxmvQIfUe+Bj8IK940sov0IL9vhhaIXSExfHY3d65CuOYgdPNxE= Received: from DM6PR11MB2537.namprd11.prod.outlook.com (2603:10b6:5:cd::16) by DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.20; Wed, 15 Apr 2020 15:01:30 +0000 Received: from DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::7c08:b4ae:e9c2:a4fa]) by DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::7c08:b4ae:e9c2:a4fa%6]) with mapi id 15.20.2900.028; Wed, 15 Apr 2020 15:01:30 +0000 From: "Iremonger, Bernard" To: "Guo, Jia" , "orika@mellanox.com" , "Ye, Xiaolong" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Wu, Jingjing" , "Cao, Yahui" , "Su, Simei" Thread-Topic: [dpdk-dev v5 3/3] app/testpmd: add new types to RSS hash commands Thread-Index: AQHWEv4de+vcvZGi8ku1SqHmkULXFKh6N0ww Date: Wed, 15 Apr 2020 15:01:29 +0000 Message-ID: References: <20200318170401.7938-5-jia.guo@intel.com> <20200415171129.86297-1-jia.guo@intel.com> <20200415171129.86297-4-jia.guo@intel.com> In-Reply-To: <20200415171129.86297-4-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.165] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1677945-6b42-4328-ee81-08d7e14de10b x-ms-traffictypediagnostic: DM6PR11MB3516: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:235; x-forefront-prvs: 0374433C81 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2537.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(136003)(39860400002)(366004)(376002)(346002)(396003)(107886003)(81156014)(26005)(66556008)(7696005)(66946007)(76116006)(86362001)(66476007)(71200400001)(9686003)(110136005)(64756008)(66446008)(55016002)(54906003)(52536014)(33656002)(8676002)(5660300002)(186003)(2906002)(316002)(6636002)(4326008)(53546011)(8936002)(478600001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I2VjEPXoilt2kl+tnWE+m1eW1j3Vpq4G6VTnyi2FlBzhiYWVkdrFMieo5RWyPnzjgDEYnYfMMxCbOfiLWfc856w1NykbLJ+hhvt0uubrIxcn57RTO4TldO90UmsqXdlbkPD6a5oPEf1AZ71OB0J9UPGFVt0vNXWR8jOI1YYBitpGnC/IsOuMr8PacPjyEEi3JqOjrT0uNGxOnDHLKGEOiDcaCO0L83P/RwmLRNDlGTufqeYYx0TGjCc21/+/5tBZrc3EFWjX1+Nog8MoRu5vTr5EQKCJo+AAyQGzuwzdAWyCn8T5Q7nKs1lfgcmqzIA3ziWJvtG6UsA6BzyrsMRSeOJlPIpVwuQeV+LkAEnKcmFz1uXNuhPcmJ9u+mM4BemsibIy9fi/d/8h3u+9hv9MoSJB9N34/iZ/WJLSLBaVbMykfyou0VJMWok8VA06IRHt x-ms-exchange-antispam-messagedata: vfms34AlyUb6tY+5oPJY8916WIY+2TlO2e/iGQulbImRtftKj7xvGaxMFeZd3u81z9uXtpsUs0HyXkg6VruUD6E6MMJ7boiewa1RkZwexOYYw1qIR4GAu08MDF4xsTcylqQN3y34/Kfhg/pAHB5Olw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c1677945-6b42-4328-ee81-08d7e14de10b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2020 15:01:29.8712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HUStfBhD4wwvakgQBcLoHIPJOU98QvcbWZGUY0W04Iq+WFjDT8V+FhwXSh5qAFvTtM4oYJRyAbOrRajDL6QMEWpSQoaR2spAWiTif65q2UU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3516 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-dev v5 3/3] app/testpmd: add new types to RSS hash commands X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jeff, > -----Original Message----- > From: Guo, Jia > Sent: Wednesday, April 15, 2020 6:11 PM > To: Iremonger, Bernard ; > orika@mellanox.com; Ye, Xiaolong ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui > ; Su, Simei ; Guo, Jia > > Subject: [dpdk-dev v5 3/3] app/testpmd: add new types to RSS hash > commands >=20 > Add some new types, such as eth/l2-src-only/l2-dst-only/svlan/cvlan/ > l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used to > configure these rss input set by cmdline. >=20 > Example testpmd commands are: > Eth: > testpmd>flow create 0 ingress pattern eth / ipv4 / end actions rss \ > types eth l2-src-only end key_len 0 queues end / end >=20 > testpmd>flow create 0 ingress pattern eth / ipv4 / end actions rss \ > types eth l2-dst-only end key_len 0 queues end / end >=20 > testpmd>flow create 0 ingress pattern eth / ipv4 / end actions rss \ > types eth end key_len 0 queues end / end >=20 > s-vlan: > testpmd>flow create 0 ingress pattern eth / ipv4 / end actions rss \ > types c-vlan end key_len 0 queues end / end >=20 > c-vlan: > testpmd>flow create 0 ingress pattern eth / ipv4 / end actions rss \ > types c-vlan end key_len 0 queues end / end >=20 > l2tpv3: > testpmd>flow create 0 ingress pattern eth / ipv4 / l2tpv3oip / end \ > actions rss types ipv4 l2tpv3 end key_len 0 queues end / end >=20 > esp: > testpmd>flow create 0 ingress pattern eth / ipv4 / esp / end actions \ > rss types ipv4 esp end key_len 0 queues end / end Should "rss types ipv4 esp" be "rss types esp" ? >=20 > ah: > testpmd>flow create 0 ingress pattern eth / ipv4 / ah / end actions \ > rss types ipv4 ah end key_len 0 queues end / end >=20 Should "rss types ah" be "rss types ah" ? > pfcp: > testpmd>flow create 0 ingress pattern eth / ipv4 / udp / pfcp / end \ > actions rss types ipv4-udp pfcp end key_len 0 queues end / end The above sample commands might be better in a doc file, rather than in the= commit message. For example doc/guides/howto/rte_flow.rst The flow create/validate commands are normally parsed in app/testpmd/cmdlin= e_flow.c This patch is updating the following commands: "port config all rss all"=20 "port config rss-hash-key " >=20 > Signed-off-by: Jeff Guo > --- > v5->v4: > rename eth to l2 and refine commit log > --- > app/test-pmd/cmdline.c | 28 +++++++++++++++++++++++++--- app/test- > pmd/config.c | 9 +++++++++ > 2 files changed, 34 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 863b567c1..6b688ab66 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2270,9 +2270,11 @@ cmd_config_rss_parsed(void *parsed_result, > int ret; >=20 > if (!strcmp(res->value, "all")) > - rss_conf.rss_hf =3D ETH_RSS_IP | ETH_RSS_TCP | > + rss_conf.rss_hf =3D ETH_RSS_ETH | ETH_RSS_IP | > ETH_RSS_TCP | > ETH_RSS_UDP | ETH_RSS_SCTP | > ETH_RSS_L2_PAYLOAD; > + else if (!strcmp(res->value, "eth")) > + rss_conf.rss_hf =3D ETH_RSS_ETH; > else if (!strcmp(res->value, "ip")) > rss_conf.rss_hf =3D ETH_RSS_IP; > else if (!strcmp(res->value, "udp")) > @@ -2299,6 +2301,22 @@ cmd_config_rss_parsed(void *parsed_result, > rss_conf.rss_hf =3D ETH_RSS_L4_SRC_ONLY; > else if (!strcmp(res->value, "l4-dst-only")) > rss_conf.rss_hf =3D ETH_RSS_L4_DST_ONLY; > + else if (!strcmp(res->value, "l2-src-only")) > + rss_conf.rss_hf =3D ETH_RSS_L2_SRC_ONLY; > + else if (!strcmp(res->value, "l2-dst-only")) > + rss_conf.rss_hf =3D ETH_RSS_L2_DST_ONLY; > + else if (!strcmp(res->value, "s-vlan")) > + rss_conf.rss_hf =3D ETH_RSS_S_VLAN; > + else if (!strcmp(res->value, "c-vlan")) > + rss_conf.rss_hf =3D ETH_RSS_C_VLAN; > + else if (!strcmp(res->value, "l2tpv3")) > + rss_conf.rss_hf =3D ETH_RSS_L2TPV3; > + else if (!strcmp(res->value, "esp")) > + rss_conf.rss_hf =3D ETH_RSS_ESP; > + else if (!strcmp(res->value, "ah")) > + rss_conf.rss_hf =3D ETH_RSS_AH; > + else if (!strcmp(res->value, "pfcp")) > + rss_conf.rss_hf =3D ETH_RSS_PFCP; > else if (!strcmp(res->value, "none")) > rss_conf.rss_hf =3D 0; > else if (!strcmp(res->value, "default")) @@ -2467,7 +2485,9 @@ > cmdline_parse_token_string_t cmd_config_rss_hash_key_rss_type =3D > "ipv4-other#ipv6#ipv6-frag#ipv6-tcp#ipv6- > udp#" > "ipv6-sctp#ipv6-other#l2-payload#ipv6-ex#" > "ipv6-tcp-ex#ipv6-udp-ex#" > - "l3-src-only#l3-dst-only#l4-src-only#l4-dst- > only"); > + "l3-src-only#l3-dst-only#l4-src-only#l4-dst- > only#" > + "l2-src-only#l2-dst-only#s-vlan#c-vlan#" > + "l2tpv3#esp#ah#pfcp"); > cmdline_parse_token_string_t cmd_config_rss_hash_key_value =3D > TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, > NULL); >=20 > @@ -2478,7 +2498,9 @@ cmdline_parse_inst_t cmd_config_rss_hash_key =3D > { > "ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|" > "ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|" > "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|" > - "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only " > + "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|" > + "l2-src-only|l2-dst-only|s-vlan|c-vlan|" > + "l2tpv3|esp|ah|pfcp " > "", > .tokens =3D { > (void *)&cmd_config_rss_hash_key_port, diff --git > a/app/test-pmd/config.c b/app/test-pmd/config.c index > 71aeb5413..e4a97388b 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -79,6 +79,11 @@ const struct rss_type_info rss_type_table[] =3D { > ETH_RSS_UDP | ETH_RSS_SCTP | > ETH_RSS_L2_PAYLOAD }, > { "none", 0 }, > + { "eth", ETH_RSS_ETH }, > + { "l2-src-only", ETH_RSS_L2_SRC_ONLY }, > + { "l2-dst-only", ETH_RSS_L2_DST_ONLY }, > + { "s-vlan", ETH_RSS_S_VLAN }, > + { "c-vlan", ETH_RSS_C_VLAN }, Should these additions be at the bottom of the array with the other additio= ns ? > { "ipv4", ETH_RSS_IPV4 }, > { "ipv4-frag", ETH_RSS_FRAG_IPV4 }, > { "ipv4-tcp", ETH_RSS_NONFRAG_IPV4_TCP }, @@ -108,6 +113,10 > @@ const struct rss_type_info rss_type_table[] =3D { > { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, > { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, > { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, > + { "l2tpv3", ETH_RSS_L2TPV3 }, > + { "esp", ETH_RSS_ESP }, > + { "ah", ETH_RSS_AH }, > + { "pfcp", ETH_RSS_PFCP }, > { NULL, 0 }, > }; >=20 > -- > 2.20.1