From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 14423A00C5;
Thu, 7 May 2020 11:48:18 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id EB84B1BF80;
Thu, 7 May 2020 11:48:17 +0200 (CEST)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id 815AA1BFBB
for <dev@dpdk.org>; Thu, 7 May 2020 11:48:16 +0200 (CEST)
IronPort-SDR: SmxDpO/Ow++ezZ2h0TfB81qWIAZ2etBHIYJkQSGjRsFT//XYupqQrs/rn7xvUxbmrcnle5UgBf
krZOG7bFf45w==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
07 May 2020 02:48:15 -0700
IronPort-SDR: F7q06f3j2JaHnzzAflhDqnp7VVuPNg88wqJLmDtkpPIEOWaPQzlGYlrcdarBGBBXakl63vTk0D
hY5g3yWK6XMA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.73,363,1583222400"; d="scan'208";a="462082345"
Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7])
by fmsmga006.fm.intel.com with ESMTP; 07 May 2020 02:48:14 -0700
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Thu, 7 May 2020 02:48:14 -0700
Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by
ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Thu, 7 May 2020 02:48:13 -0700
Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by
orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5
via Frontend Transport; Thu, 7 May 2020 02:48:13 -0700
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.53) by
edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
(TLS) id 14.3.439.0; Thu, 7 May 2020 02:48:13 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=l6/dVzytfBdQud52DF9HbBSc3CI9D24aHxZ2/mp5H3nYpMW715hW7f5xvTAdLKcmE/0YCOoCHb8iStLwADRNny7w0ABR65yJaULUO95QqwdSIX1J0bjH5/pf2KTTlr5HI8RHFPYBU50iItTg1tX0nLTyUiabxJVmuH+raedYr4Fl5/hoxan5aYCpFHgGyl3khu5AxNicK9wP0DMKyA5KtksU6wL+U7Ey7I8D2qqSSYSJ//71WASeNRPRyGFAi2GKYynTzgDXnGK3BHwskZ0R3cpkLtbrpsliNWh489sEBFKLu9itn2oC1k2NcnUuPuVh2huaRA0nh1yxMosa9Hoy7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=cJ0izhYFKKTgOBNGoGPwIGdPKMt+mpfOapyKD/6llb8=;
b=RPrLf4uP72Xt2Nb58QyjkTPjOHWrvY/wJJJIJ3TdGlFNAzRFXFxHd88sJ/xx2UoxthxbOnXdmYBG2yV8HXpCcew620G4w+GzqwxwnuD/cMPxTqpuMRsKPrRKlpsXdtCxxcmC+B89v+B7Rf7BQ+SdFQRETAR/RudcFkTH7V2M+QHdWvAvwNwPW1Jn+yWiKI7y1df/wrVHBNhHYSweQ4bOo2HEgkXZDNAxv2aSaETOQuwPS5guOixQo3kV5SdCJ/tbeeN9CUib/LAq9c1X+TKuH/y6zc9bMXQcoCQtAqUYAwBFW2IS1iKO5E1el1K0+7WW7ogNC2frHkTkfxlBusMVqQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=cJ0izhYFKKTgOBNGoGPwIGdPKMt+mpfOapyKD/6llb8=;
b=s7Mta241Z1LIWxGB3Jm/eY/jB7PaWUiqCS2cHG6DB7B/iCmtv0wQh4msOi4uH/eLh0Uq41GAL/BCt02AxTsOJyOCFW0Au6j0xYlj5Exe9FGX3fxKPGPwkijebdHqmPby6FOWksSu80lUkjF1UZqI4IjaOVmKZY2CpaqM5cEXq+g=
Received: from DM6PR11MB2537.namprd11.prod.outlook.com (2603:10b6:5:cd::16) by
DM6PR11MB3227.namprd11.prod.outlook.com (2603:10b6:5:5d::16) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.2979.26; Thu, 7 May 2020 09:48:11 +0000
Received: from DM6PR11MB2537.namprd11.prod.outlook.com
([fe80::7c08:b4ae:e9c2:a4fa]) by DM6PR11MB2537.namprd11.prod.outlook.com
([fe80::7c08:b4ae:e9c2:a4fa%6]) with mapi id 15.20.2958.034; Thu, 7 May 2020
09:48:10 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>, "dev@dpdk.org"
<dev@dpdk.org>
CC: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Xing, Beilei"
<beilei.xing@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing
issue
Thread-Index: AQHWJEzvfTZ2W0yJBUeUhy8l2Ebzj6icYEQA
Date: Thu, 7 May 2020 09:48:10 +0000
Message-ID: <DM6PR11MB2537230CE34028A3D69C1B1FEFA50@DM6PR11MB2537.namprd11.prod.outlook.com>
References: <20200507090827.27945-1-kalesh-anakkur.purayil@broadcom.com>
In-Reply-To: <20200507090827.27945-1-kalesh-anakkur.purayil@broadcom.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
authentication-results: broadcom.com; dkim=none (message not signed)
header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [192.198.151.188]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d4eb41f6-4fd5-409c-6b5a-08d7f26bc103
x-ms-traffictypediagnostic: DM6PR11MB3227:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM6PR11MB3227CACAF4742864708E15ECEFA50@DM6PR11MB3227.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5236;
x-forefront-prvs: 03965EFC76
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: XKAPzwAMYCEXbp09ocYA4E7Ra19JpK5gjnn2bXJ2iKAp0a+0F15HMsbhwlRglLftQ0XjPPQI93PMojQ60InIjZxeEz02z365nnndjeHEfrk3PwTpOW0TKPoK6duFHNlh3X5AQSlHlXVHhMVw1e1VhqpP0dTMWtB0Kur3z4jAkLdL3N/CsVMfCJNYYCKUL+GpfEzKegLHZYvmBGWpMPx0DN0iZWy/nT9Jrzb3akk3imyderAuEi1RZAYKGobHPR2s2liqS8cLg5mTdGOU/0vvs14tKiiFNfgJK3/VfR6b9KyQjLe2btPKjbt6bWfTdV6i2HkPJJn3qW7uctLtbRHh6Xa7i58LxLiYAGlqcFLv54iy5q24GCAwIugp0/m0yiDH7NNoWPZ+LneAvpO2pc+afN9UmRgocPKg/PwBBV2UwH+fkfnhWtebseAzq3CaghcZvNl87kzfWGwb4APsHEzDsysuDC0ia42GSIrPtyCeHvpTA/4HImZLzwAHr8Xk/e6KGkefgdX/uXhKGt49ZnKfVA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM6PR11MB2537.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFTY:;
SFS:(39860400002)(366004)(396003)(136003)(346002)(376002)(33430700001)(107886003)(52536014)(7696005)(26005)(110136005)(54906003)(186003)(478600001)(5660300002)(33656002)(71200400001)(6506007)(316002)(2906002)(66446008)(76116006)(66946007)(55016002)(66476007)(64756008)(8936002)(9686003)(66556008)(86362001)(33440700001)(83320400001)(83280400001)(8676002)(53546011)(83310400001)(83300400001)(83290400001)(4326008);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: vQfgFxfu64Kg+uqZTKXi3rOyw7e8GqB5mvYWWTYFcFlADY6TNfPisKTptMHdFSqphJI9Yp90zJqz8oZ6PjIotWghRTALRUJ2/T9rbfHllR1FxKhIklPIvLvo6qH2AdIvWJ5UBoKr+UwznY1r1nR0U1wOM+Vst9dvMxiUgeNIqsRWuiSWJ3dwkmtuSskHlxiP/nPxmGi2YR9CX7qokIbiQnBmlIKfED088B0ukV5CnJi0v76D7xwZz3ouyB5Mgo5vFCS9JYmAbXQjhQ2DzHTbsODyUSHaiPOJqwNNH8iT6naEK6e8lyEQvgtHzjLBFbUmMjeR+rvlDDCd0/82LMekFgRmLjnl8xUKtQ0bh8zjwsjgCnnYmDzQit9zVjNC24exHZSD3+uFrT4qz+99Mcz2hEVDx+pfiCoedQdyj2n6G+MkkR1GqKF8WMbS7CN3j9U8t/JbgFaHVNKlIS/U+222S7PYCVbanKX/J2EEk9cjaVgwIewtM3XNCXiwzgCRwLk/5OUYiZSqmePxPQf50l+749e8/9aJBfgHT91DkqK04h5p1mnmEQC4XYbnhhZt+IcIz8MKvOt5PvNvU2woQQXU4QFECetI/UQvbrnXDvshWwUBnz8A/UPNev9ELoI3Y1pJTnAKOlWUo0UxrVBG2fsXB458KgbHnOa0m+eLWiwU2CLfOFQhTB504Fop+xqfbVa6zVHl+nXbDi2BoJB5C9x8opVhB1p7DPQvtaLTjf6uoykuupgGlzIKubjit+0eQ6lt7tZN3vdgGM/DAD+oZNNb230eOO8SVobnJxsCeiIkhC2R0JfC15eQs3K8rzUmbWN8
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d4eb41f6-4fd5-409c-6b5a-08d7f26bc103
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2020 09:48:10.9054 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rj3zYn6/AifoOHF+dZwQsBUrxW/bAalNOvKkICwa9kH0FlknMKxhNgMELBYHO6zER9MC1HnGp/eLEsY/qL0/in5ySYeZe2w6Fxdt3+WmWCY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3227
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing
issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi Kalesh,
> -----Original Message-----
> From: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
> Sent: Thursday, May 7, 2020 10:08 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Iremonger,
> Bernard <bernard.iremonger@intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing
> issue
>=20
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>=20
> Note that the issue was observed in an internal Coverity scan.
>=20
> Fixes: e088907bb851 ("app/testpmd: add command for getting loaded DDP
> profiles")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> ---
> app/test-pmd/cmdline.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> b040630..996a498 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -16891,8 +16891,10 @@ cmd_ddp_get_list_parsed( #ifdef
> RTE_LIBRTE_I40E_PMD
> size =3D PROFILE_INFO_SIZE * MAX_PROFILE_NUM + 4;
> p_list =3D (struct rte_pmd_i40e_profile_list *)malloc(size);
> - if (!p_list)
> + if (!p_list) {
> printf("%s: Failed to malloc buffer\n", __func__);
> + return;
> + }
>=20
> if (ret =3D=3D -ENOTSUP)
> ret =3D rte_pmd_i40e_get_ddp_list(res->port_id,
> --
> 2.10.1
./devtools/check-git-log.sh -1
Wrong headline case:
"app/testpmd: fix NULL pointer dereferencing issue": NULL --> null
Missing 'Coverity issue:' tag:
app/testpmd: fix NULL pointer dereferencing issue
Regards,
Bernard.