From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05E48A04B7; Wed, 14 Oct 2020 12:34:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDDB71DE15; Wed, 14 Oct 2020 12:34:38 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E97751DE15 for ; Wed, 14 Oct 2020 12:34:35 +0200 (CEST) IronPort-SDR: 87e+RXccCuAx4ZMRCB2ICw/Fwcx2DINYE34RWynqV7QLC22QTcOaYK/OOr80+rZP/3LA4bQnNf 031JFWtzVbvg== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="145941562" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="145941562" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 03:34:34 -0700 IronPort-SDR: +glmn6YdpiJxzZnvxxOlBkoI2CyKBj2h5m2SbBWNSDG7Zoljh5sRlZypsYRJZ0NoQ09c151sBW Be2ujzhpwytw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="351447168" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 14 Oct 2020 03:34:34 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 14 Oct 2020 03:34:34 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 14 Oct 2020 03:34:34 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.51) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 14 Oct 2020 03:34:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h5VMowPq6mTLCjPP56c98MCb5BbFk79idk06C5apo8u2FD0j0Rf2TIKzqS9Y3EmQorGKizZSYa7sI/LS+oX11sBXFNhilx807vIGnslwQAd2K8rPHpjDZbJuraDznrGJaSHQD4uqKWrcs83n5AIoIpSq8f8TYhOjJ2zeMDD9Cnac3fd/p7yU1nrETirr8TugBM0J675tlMC4IFzRdCzxqoeLNmI7doRVbj1XTTqaM/xMy7T12I7u1cHc/Xq1LLOSi1qfYEBpIXkGH+FfOSB02hOD/DGix2JSRVSCiduk0U57ywryLQ/7AUgVsOyiatDxRRwokPVlBzMjXmkrknIgfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hob3tMqYgdQ5S1N89MC+BvfiOFuhqUULhNUZKXVDXP4=; b=JeepzC+9lURXmeaEXbeAarogWvTND+y/aE2P8tbsg5vAzvtfDE/2bB/5cbd/egT07Tc6n80veX/mDv19vNaN67HpFd+vEWAXbN/Eg30TBTclbG5W7la0FZk2R1FFu10cxOdvOUn5CetdeU8t01NrXTkQiKHxmBekngrtAwly5OqFS1ASn38jEp8FL+uI7FoX2Poes2u+EfYf5ryd8JCPzYYpcMI8xNOUw80QI7Og5Jqzf8TWZhNyTTxo6yubi+V7/V9KheFOEqzt8NNqwgEZOBLHe46FW7B4LwpSit5JHdj5/7FZ4+/IrNCgVLp4ksJNLwp4jLlZGFL31pjgMBUetQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hob3tMqYgdQ5S1N89MC+BvfiOFuhqUULhNUZKXVDXP4=; b=gWmzuYuZ26RHonDkO1KZwuZ9tsoZEOjbIzPy6jA2mTNJVsf02bSE356sbLXVsqXjJcfloOQg2lEGKkjaN6BLfGXthumsMs/CSct4Aa6U4jXQO5JBA7yDADcRFIZpUS7CYEBiUSZQ/xrR55bA6J8EY1L6YF7Gp6mMhh5DzHI8q2A= Received: from DM6PR11MB2537.namprd11.prod.outlook.com (2603:10b6:5:cd::16) by DM6PR11MB4595.namprd11.prod.outlook.com (2603:10b6:5:2ac::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Wed, 14 Oct 2020 10:34:31 +0000 Received: from DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::bcd1:7fe:8536:f15]) by DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::bcd1:7fe:8536:f15%5]) with mapi id 15.20.3477.021; Wed, 14 Oct 2020 10:34:31 +0000 From: "Iremonger, Bernard" To: "Connolly, Padraig J" CC: "dev@dpdk.org" , "Xing, Beilei" Thread-Topic: [PATCH v1] net/i40e: fix qinq flow pattern to allow non full mask Thread-Index: AQHWoWkPGA4Mg9GqYE+pXi9gXDRpEKmW5oUg Date: Wed, 14 Oct 2020 10:34:30 +0000 Message-ID: References: <20201013135756.23193-1-padraig.j.connolly@intel.com> In-Reply-To: <20201013135756.23193-1-padraig.j.connolly@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.45.36.39] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 458519a1-f02b-4f9f-2c9d-08d8702cbc33 x-ms-traffictypediagnostic: DM6PR11MB4595: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:40; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KXFwzedue+QahN/Axsd2bzjFvgrEeqsKAnnfIlWOkQgYOGtcKXa0hsw18lW4nZRvqf2FNRAQWyM/0caEs84mz/pRj85zfaL2I2IqsQEFWMjPG4BfiuNyiqe4s9MH98Ap0Kj9cMv1vV+whrdIhvDs25+UQv0hTV6mJMpRB3zJfEz0gxeDonh9FAGu7m3tFGn4vYjFweUQy6lJCp7UpjeDSdyKVY/67v9Np5DrY4D0P0ke5PukxDFjKaW3PvTi1Hva3p+c/LyfKAKPmwal8VNn+hSNgDNQl1jVXNvuxAtgCpC/vEdZ7NgKwWXR10jCEUacmy0gC/tmijpeDDuPo9Th8A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2537.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(366004)(39860400002)(136003)(7696005)(33656002)(6862004)(6636002)(83380400001)(54906003)(8676002)(52536014)(316002)(2906002)(8936002)(64756008)(76116006)(66446008)(66476007)(66946007)(6506007)(107886003)(4326008)(66556008)(53546011)(26005)(5660300002)(478600001)(186003)(55016002)(71200400001)(86362001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: ES3X8W3N4bv8dSdNqkRJmjKVblNq831Eak2Srzt1leggVLFwvk+qnqima7B35VMqtii8n7qk3RlErOkTYRMRvRu7nUwE5I4bxCiuNQOrJnd9g3vG+u+RVbb0yzxOjXf2/jKqoeulXMgieRhKWt+0Dzd4bmHq+yn9uprupRepaO5QDdFg9hnISnmbzWY0Ml3oRc4coVcyqkjF8TOihnv5mSa6NYnxgNfAUep0Um4UYdrqjhwuo2tL2QGq3ChCaP0VXBqasOQgrCBrD9o2jKoUNmHTuQge1+7rUu8j4VEk9mxVuZLOxJ9G8opQJfssP6BYLQZKYgVkgN4N38LMuG0wQhCr+WK27kBir4oTqQwAO+Uif7UxdEQNveJ1U2yOBNS8eTTwApsM+TooqEay9Od/1EIoJ152VvBynk3A5Ou5H9nUv6dDA2WXOwtS3/wwOgiVwSkOFUu5U2p874nj6uPlpDYq1MrV3bjHBdPxRuI4WCsBgRpYcPMEPNlEbrcXlNsRKB/KZV5ZFvTYZHwVpwZayxrEal5GpcYWxG5+IZjuJHAVQwEWye9jmtPn7F+IO5fMrku9AldI0zya8c2nvr1UrYGyz/t6VKjNmueZj/GdtxPP3a4LIuzyoXKKOrxbA6DJR5k1bm/hTeYYTKivSMDWHw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2537.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 458519a1-f02b-4f9f-2c9d-08d8702cbc33 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2020 10:34:31.0148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lF98siFQ69IDjJk7eXPR383qzO1qv6pM3DY0GaYSCAgoPSlWU0DjVXKKm9icykTrp7ct1J3geUyfSbSEVOEgw/4laHzCx0CEnE9A4I4H7Zw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4595 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: fix qinq flow pattern to allow non full mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Padraig, > -----Original Message----- > From: Connolly, Padraig J > Sent: Tuesday, October 13, 2020 2:58 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Connolly, Padraig J ; > Iremonger, Bernard > Subject: [PATCH v1] net/i40e: fix qinq flow pattern to allow non full mas= k >=20 > Issue reported by customer that only full mask was allowed on inner and > outer VLAN tag, thus not allowing mask to set VLAN ID filter only. Remove= d > check that enforces inner vlan and outer vlan equal I40E_TCI_MASK (full > mask 0xffff). >=20 > Fixes: c2be7f9b232f ("net/i40e: fix parsing QinQ pattern") > Fixes: d37705068ee8 ("net/i40e: parse QinQ pattern") >=20 > Cc: bernard.iremonger@intel.com > Cc:stable@dpdk.org >=20 > Signed-off-by: Padraig Connolly > --- > drivers/net/i40e/i40e_flow.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c > index adc5da1c5..509c18c45 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4649,14 +4649,9 @@ i40e_flow_parse_qinq_pattern(__rte_unused > struct rte_eth_dev *dev, > } >=20 > /* Get filter specification */ > - if ((o_vlan_mask !=3D NULL) && (o_vlan_mask->tci =3D=3D > - rte_cpu_to_be_16(I40E_TCI_MASK)) && > - (i_vlan_mask !=3D NULL) && > - (i_vlan_mask->tci =3D=3D > rte_cpu_to_be_16(I40E_TCI_MASK))) { > + if ((o_vlan_mask !=3D NULL) && (i_vlan_mask !=3D NULL)) { > filter->outer_vlan =3D rte_be_to_cpu_16(o_vlan_spec->tci) > - & I40E_TCI_MASK; > filter->inner_vlan =3D rte_be_to_cpu_16(i_vlan_spec->tci) > - & I40E_TCI_MASK; > } else { > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ITEM, > -- > 2.17.1 Checkpatch is showing the following warnings which should be fixed. :~/dpdk_20_11/devtools# ./checkpatches.sh /home/bairemon/patches_patchwork_= 20_11/v1-net-i40e-fix-qinq-flow-pattern-to-allow-non-full-mask.patch=20 ### [dpdk-dev] [PATCH v1] net/i40e: fix qinq flow pattern to allow non full= mask WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer= a maximum 75 chars per line) #60:=20 Issue reported by customer that only full mask was allowed on inner and out= er WARNING:BAD_SIGN_OFF: Use a single space after Cc: #68:=20 Cc:stable@dpdk.org CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'o_vlan_mask = !=3D NULL' #87: FILE: drivers/net/i40e/i40e_flow.c:4652: + if ((o_vlan_mask !=3D NULL) && (i_vlan_mask !=3D NULL)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i_vlan_mask = !=3D NULL' #87: FILE: drivers/net/i40e/i40e_flow.c:4652: + if ((o_vlan_mask !=3D NULL) && (i_vlan_mask !=3D NULL)) { total: 0 errors, 2 warnings, 2 checks, 15 lines checked 0/1 valid patch The check-git-log tool is also showing an issue with the commit message. :~/dpdk_20_11/devtools# ./check-git-log.sh -1 cat: VERSION: No such file or directory Line too long: Issue reported by customer that only full mask was allowed on inner= and outer VLAN tag, thus not allowing mask to set VLAN ID filter only. Remove= d check that Invalid patch(es) found - checked 1 patch Regards, Bernard.