Re: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing issue

["Iremonger, Bernard" <bernard.iremonger@intel.com>]

Hi Kalesh,

From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Sent: Thursday, May 7, 2020 11:33 AM
To: Iremonger, Bernard <bernard.iremonger@intel.com>
Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing issue

Hi Bernard,

On Thu, May 7, 2020 at 3:18 PM Iremonger, Bernard <bernard.iremonger@intel.com<mailto:bernard.iremonger@intel.com>> wrote:
Hi Kalesh,

> -----Original Message-----
> From: Kalesh A P <kalesh-anakkur.purayil@broadcom.com<mailto:kalesh-anakkur.purayil@broadcom.com>>
> Sent: Thursday, May 7, 2020 10:08 AM
> To: dev@dpdk.org<mailto:dev@dpdk.org>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>>; Xing, Beilei
> <beilei.xing@intel.com<mailto:beilei.xing@intel.com>>; Wu, Jingjing <jingjing.wu@intel.com<mailto:jingjing.wu@intel.com>>; Iremonger,
> Bernard <bernard.iremonger@intel.com<mailto:bernard.iremonger@intel.com>>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing
> issue
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com<mailto:kalesh-anakkur.purayil@broadcom.com>>
>
> Note that the issue was observed in an internal Coverity scan.
>
> Fixes: e088907bb851 ("app/testpmd: add command for getting loaded DDP
> profiles")
> Cc: stable@dpdk.org<mailto:stable@dpdk.org>
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com<mailto:kalesh-anakkur.purayil@broadcom.com>>
> ---
>  app/test-pmd/cmdline.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> b040630..996a498 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -16891,8 +16891,10 @@ cmd_ddp_get_list_parsed(  #ifdef
> RTE_LIBRTE_I40E_PMD
>       size = PROFILE_INFO_SIZE * MAX_PROFILE_NUM + 4;
>       p_list = (struct rte_pmd_i40e_profile_list *)malloc(size);
> -     if (!p_list)
> +     if (!p_list) {
>               printf("%s: Failed to malloc buffer\n", __func__);
> +             return;
> +     }
>
>       if (ret == -ENOTSUP)
>               ret = rte_pmd_i40e_get_ddp_list(res->port_id,
> --
> 2.10.1

./devtools/check-git-log.sh -1
Wrong headline case:
"app/testpmd: fix NULL pointer dereferencing issue": NULL --> null
[Kalesh]: will fix it.
Missing 'Coverity issue:' tag:
        app/testpmd: fix NULL pointer dereferencing issue
[Kalesh]:  This was found in an internal scan. So there is no Coverity issue tag for this.

If there is no Coverity issue tag for this bug, then best not to mention Coverity in the commit message.
An explanation of the fix should be added to the commit message.

Regards,

Bernard.