From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 073B5A0588; Thu, 16 Apr 2020 13:16:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9CF61DA2A; Thu, 16 Apr 2020 13:16:44 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 808311DA22 for ; Thu, 16 Apr 2020 13:16:43 +0200 (CEST) IronPort-SDR: Sh7dI6JAqy9A5Di9SvyqHcRhiBu2+WjMK4Gq6xvxOv35U2+fg2I9yZz7QW4clW+AIi4dG8HKg+ 1UKet7N1IWnw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 04:16:42 -0700 IronPort-SDR: NTrH7aN/22pytddaPhSHb12qaSLttgo/OKf0i8fkM95uF+JAOyWw1eK7+s8Z3DcX+P97FqbtoY QkqFgk4I/i6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="277959805" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga004.fm.intel.com with ESMTP; 16 Apr 2020 04:16:41 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 04:16:40 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 16 Apr 2020 04:16:40 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 16 Apr 2020 04:16:40 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.52) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 04:16:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CG5lEFOOgSyFda0wlfWcnl1pAQ0SHO81Y63ZUSa5uJIf1VlSPMnuwZO0p2RxCHkwvsSTF/Cx/PoIBbenZyWNjrX4P7eNmZCTTbLbp24GwY9Yu5263CgZ2KSMdBj6gnThnYd//Q1s9IBJYPcFh4K5/G7QCf5IdsxvtVKPzn2fX8yMKS4lR6yIrJegHp/7gx4UFXKwoOLsOrJZUhspa05p4l5Myu06+ggo8jzkcc5w7YIgQERX++Mg8JFlm129cZR5eRITc/b9VFYIDt9ovc1IxivIYskfkf8lJO8aevYUd/dnvRdizFVgWaNfkv3jm5qxX5FcbsGt6REtccmRZGs7oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wn1NI9qsLy2fU4p2288XgTqkPensJ3b/pN1Ouo1LZpA=; b=bGqWazOedqK1GeTgC4S/JEmVHgDMMmpQyg9MZ6xZLU7xRpeWqYJkszjDXV2HBJQPwsF1CQbXZrvfFxeUVr1guVgaahOdNk4ya79ietuIRi56ITMaQzCjgLg3LAAet9kFSm7Rmk3RR39GfC0MntxEK1ocoH1gWoRUDwPOJR5Ja5JErO5n5BUn5NEhYYNJlHJ2OdHwDSV99TRyQ5UEfzxmw/yrcUPNdoodgQj0Orht59WEEO+sJdiF3eEdIoUQxJ2WsXOzy/y6qdCG/GTDecEKHtp1ovAaLx9I3n2mvVgPiIv2J35y1Z+ouXBcWCUYoGbW+eyDLj/lGUpY0tqrPxruUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wn1NI9qsLy2fU4p2288XgTqkPensJ3b/pN1Ouo1LZpA=; b=knWND8tsdTMJpZLbEQu4KiNk3H3iDCPTQepZS+AZtizpLVSAnk4Kw/pigbHTRLoo0BqDadFHnZe7iAwP+4ZxLtnsrAatX/xD6D/wZXFYVzG3jM7hnN9C4HkPkI36+CA3DZl9kZ20NMK29zXHBlyD7gArv1IN/PA18Z8Fz4qAqMw= Received: from DM6PR11MB2537.namprd11.prod.outlook.com (2603:10b6:5:cd::16) by DM6PR11MB3162.namprd11.prod.outlook.com (2603:10b6:5:55::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.17; Thu, 16 Apr 2020 11:16:36 +0000 Received: from DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::7c08:b4ae:e9c2:a4fa]) by DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::7c08:b4ae:e9c2:a4fa%6]) with mapi id 15.20.2921.027; Thu, 16 Apr 2020 11:16:35 +0000 From: "Iremonger, Bernard" To: "Guo, Jia" , "orika@mellanox.com" , "Ye, Xiaolong" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Wu, Jingjing" , "Cao, Yahui" , "Su, Simei" Thread-Topic: [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash commands Thread-Index: AQHWE9k2itdrQ8tOsU6kVttc0NdvDah7lxHg Date: Thu, 16 Apr 2020 11:16:35 +0000 Message-ID: References: <20200318170401.7938-5-jia.guo@intel.com> <20200416191944.23284-1-jia.guo@intel.com> <20200416191944.23284-4-jia.guo@intel.com> In-Reply-To: <20200416191944.23284-4-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 31dd804f-9a8c-4762-624a-08d7e1f7a05d x-ms-traffictypediagnostic: DM6PR11MB3162: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:169; x-forefront-prvs: 0375972289 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2537.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(346002)(39860400002)(396003)(366004)(376002)(136003)(76116006)(6636002)(8936002)(33656002)(64756008)(9686003)(55016002)(66946007)(66476007)(66556008)(66446008)(5660300002)(86362001)(81156014)(2906002)(8676002)(4326008)(107886003)(54906003)(71200400001)(52536014)(6506007)(186003)(316002)(478600001)(53546011)(26005)(110136005)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oBNU8TSCF4weGbNt+BKHo0v9wpyF43MdIUrWSk7a3qWYVxHpGLKkNz7okavdJHo+q8rEcq8kPnDHppFJ2W/6vQNZU35ZZzMZp6M9KcmsxY1xrd2YAt+qF0SPh5MKGfMWdoPcriGSRYFtvFbLh0Se6NPfiBgSrSu8BWFvS2oPhZWCc6nZOrP82zXbn3sfUyl8AINXTZrAEdUTzuB/DoqHotdt6J8zkPFql4FZvq09xLV3UOzIZ9mjcSl7anIku+Q9h69Dck8EaRXN73XJzeS/9gFOXGtEOWfiI2XBtkdsRiKkLF0ObTwsJKr7Ynw+UamROk4QWeiGnfuZ1cZxQR+kiA/TiSoDPU9zPxoinUHOfXmRO/siE/XPst1McfmlE/NlazAvD1ztWagrUX7hpdABhyQczSZpxdjhI/1G6Blmo5mgqD5iNg5vt+EkLPffF7um x-ms-exchange-antispam-messagedata: 02MrZC268BvHP7haoD84LZnrBOqtwrPNE2/f9eab1fTOQ5UUqXNOBkvfbiOkSiMhlG7tOFeGxA3HRk2tPXwuLU5ziodjJx6fDdXu8woZF/qkjUgY1aIQb0KjeojOjeogqWIU6dK9ZOiCn9QHVqqpwA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 31dd804f-9a8c-4762-624a-08d7e1f7a05d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2020 11:16:35.8831 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FGPKkulSIo/+EPoaC4kNNXssIdeja5JD96yaMGKcOvBvXzpTjkQNcO2xxAyeqySF6Mfsoaww2plpomdV6vc0scRYSNw6HGxjeTFKXpO/VlQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3162 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash commands X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jeff, > -----Original Message----- > From: Guo, Jia > Sent: Thursday, April 16, 2020 8:20 PM > To: Iremonger, Bernard ; > orika@mellanox.com; Ye, Xiaolong ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui > ; Su, Simei ; Guo, Jia > > Subject: [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash > commands >=20 > Add some new types, such as eth/l2-src-only/l2-dst-only/svlan/cvlan/ > l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used to > configure these rss input set by cmdline. >=20 > Example testpmd commands was: > testpmd>flow create 0 ingress pattern eth / ipv4 / l2tpv3oip / end \ > actions rss types l2tpv3 end key_len 0 queues end / end >=20 > Signed-off-by: Jeff Guo > --- > v6->v5: > add some missing part and refine commit log > --- > app/test-pmd/cmdline.c | 34 +++++++++++++++++++++++++++++----- > app/test-pmd/config.c | 15 ++++++++++++--- > 2 files changed, 41 insertions(+), 8 deletions(-) >=20 The dpdk/doc/guides/testpmd_app_ug/testpmd_funcs.rst file needs to be updat= ed for the new RSS values. Section 4.6.16. port config -RSS > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 863b567c1..4164767b8 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2270,9 +2270,13 @@ cmd_config_rss_parsed(void *parsed_result, > int ret; >=20 > if (!strcmp(res->value, "all")) > - rss_conf.rss_hf =3D ETH_RSS_IP | ETH_RSS_TCP | > - ETH_RSS_UDP | ETH_RSS_SCTP | > - ETH_RSS_L2_PAYLOAD; > + rss_conf.rss_hf =3D ETH_RSS_ETH | ETH_RSS_S_VLAN | > + ETH_RSS_C_VLAN | ETH_RSS_IP | ETH_RSS_TCP | > + ETH_RSS_UDP | ETH_RSS_SCTP | > ETH_RSS_L2_PAYLOAD | > + ETH_RSS_L2TPV3 | ETH_RSS_ESP | ETH_RSS_AH | > + ETH_RSS_PFCP; > + else if (!strcmp(res->value, "eth")) > + rss_conf.rss_hf =3D ETH_RSS_ETH; > else if (!strcmp(res->value, "ip")) > rss_conf.rss_hf =3D ETH_RSS_IP; > else if (!strcmp(res->value, "udp")) > @@ -2299,6 +2303,22 @@ cmd_config_rss_parsed(void *parsed_result, > rss_conf.rss_hf =3D ETH_RSS_L4_SRC_ONLY; > else if (!strcmp(res->value, "l4-dst-only")) > rss_conf.rss_hf =3D ETH_RSS_L4_DST_ONLY; > + else if (!strcmp(res->value, "l2-src-only")) > + rss_conf.rss_hf =3D ETH_RSS_L2_SRC_ONLY; > + else if (!strcmp(res->value, "l2-dst-only")) > + rss_conf.rss_hf =3D ETH_RSS_L2_DST_ONLY; > + else if (!strcmp(res->value, "s-vlan")) > + rss_conf.rss_hf =3D ETH_RSS_S_VLAN; > + else if (!strcmp(res->value, "c-vlan")) > + rss_conf.rss_hf =3D ETH_RSS_C_VLAN; > + else if (!strcmp(res->value, "l2tpv3")) > + rss_conf.rss_hf =3D ETH_RSS_L2TPV3; > + else if (!strcmp(res->value, "esp")) > + rss_conf.rss_hf =3D ETH_RSS_ESP; > + else if (!strcmp(res->value, "ah")) > + rss_conf.rss_hf =3D ETH_RSS_AH; > + else if (!strcmp(res->value, "pfcp")) > + rss_conf.rss_hf =3D ETH_RSS_PFCP; > else if (!strcmp(res->value, "none")) > rss_conf.rss_hf =3D 0; > else if (!strcmp(res->value, "default")) @@ -2467,7 +2487,9 @@ > cmdline_parse_token_string_t cmd_config_rss_hash_key_rss_type =3D > "ipv4-other#ipv6#ipv6-frag#ipv6-tcp#ipv6- > udp#" > "ipv6-sctp#ipv6-other#l2-payload#ipv6-ex#" > "ipv6-tcp-ex#ipv6-udp-ex#" > - "l3-src-only#l3-dst-only#l4-src-only#l4-dst- > only"); > + "l3-src-only#l3-dst-only#l4-src-only#l4-dst- > only#" > + "l2-src-only#l2-dst-only#s-vlan#c-vlan#" > + "l2tpv3#esp#ah#pfcp"); > cmdline_parse_token_string_t cmd_config_rss_hash_key_value =3D > TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, > NULL); >=20 > @@ -2478,7 +2500,9 @@ cmdline_parse_inst_t cmd_config_rss_hash_key =3D > { > "ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|" > "ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|" > "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|" > - "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only " > + "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|" > + "l2-src-only|l2-dst-only|s-vlan|c-vlan|" > + "l2tpv3|esp|ah|pfcp " > "", > .tokens =3D { > (void *)&cmd_config_rss_hash_key_port, diff --git > a/app/test-pmd/config.c b/app/test-pmd/config.c index > 71aeb5413..c8196e47a 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -75,10 +75,15 @@ static const struct { }; >=20 > const struct rss_type_info rss_type_table[] =3D { > - { "all", ETH_RSS_IP | ETH_RSS_TCP | > - ETH_RSS_UDP | ETH_RSS_SCTP | > - ETH_RSS_L2_PAYLOAD }, > + { "all", ETH_RSS_ETH | ETH_RSS_IP | ETH_RSS_TCP | ETH_RSS_UDP | > + ETH_RSS_SCTP | ETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 | > + ETH_RSS_ESP | ETH_RSS_AH | ETH_RSS_PFCP}, > { "none", 0 }, > + { "eth", ETH_RSS_ETH }, > + { "l2-src-only", ETH_RSS_L2_SRC_ONLY }, > + { "l2-dst-only", ETH_RSS_L2_DST_ONLY }, > + { "s-vlan", ETH_RSS_S_VLAN }, > + { "c-vlan", ETH_RSS_C_VLAN }, > { "ipv4", ETH_RSS_IPV4 }, > { "ipv4-frag", ETH_RSS_FRAG_IPV4 }, > { "ipv4-tcp", ETH_RSS_NONFRAG_IPV4_TCP }, @@ -108,6 +113,10 > @@ const struct rss_type_info rss_type_table[] =3D { > { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, > { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, > { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, > + { "l2tpv3", ETH_RSS_L2TPV3 }, > + { "esp", ETH_RSS_ESP }, > + { "ah", ETH_RSS_AH }, > + { "pfcp", ETH_RSS_PFCP }, > { NULL, 0 }, > }; >=20 > -- > 2.20.1 Regards, Bernard.