DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Power, Ciara" <ciara.power@intel.com>
To: "Laatz, Kevin" <kevin.laatz@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3] doc: add more detail to telemetry guides
Date: Fri, 24 Jul 2020 11:45:10 +0000	[thread overview]
Message-ID: <DM6PR11MB255593BD10D082C306E188BAE6770@DM6PR11MB2555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200724112033.24860-1-ciara.power@intel.com>


>-----Original Message-----
>From: Power, Ciara <ciara.power@intel.com>
>Sent: Friday 24 July 2020 12:21
>To: Laatz, Kevin <kevin.laatz@intel.com>
>Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>;
>thomas@monjalon.net; Power, Ciara <ciara.power@intel.com>
>Subject: [PATCH v3] doc: add more detail to telemetry guides
>
>This patch adds examples to the Telemetry HowTo guide, to demonstrate
>commands that use parameters. The programmer's guide is also modified to
>include details on writing a callback function for a new command.
>
>Signed-off-by: Ciara Power <ciara.power@intel.com>
>
>---
>v3:
>  - Replaced direct code examples with generic examples.
>  - Replaced ref label with :doc: syntax to link guides.
>  - Replaced console code-block label with :: on previous lines.
>  - Added links to API doc.
>  - Modified some formatting.
>v2:
>  - Replaced examples of using commands in the programmer's guide with
>    a link to the HowTo guide.
>  - Added an example showing the use of a single string value.
>  - Replaced inline functions with a synthetic example function below
>    the list of parameters.
>---
> doc/guides/howto/telemetry.rst          |  67 ++++++----
> doc/guides/prog_guide/telemetry_lib.rst | 160 +++++++++++++++++++-----
> 2 files changed, 172 insertions(+), 55 deletions(-)
>
>diff --git a/doc/guides/howto/telemetry.rst
>b/doc/guides/howto/telemetry.rst index b4a34ed674..e7b5434152 100644
>--- a/doc/guides/howto/telemetry.rst
>+++ b/doc/guides/howto/telemetry.rst
>@@ -29,17 +29,13 @@ Telemetry Initialization
>

<snip>

I forgot to preserve the Ack from v2.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2020-07-24 11:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 16:09 [dpdk-dev] [PATCH v2] " Ciara Power
2020-07-21 17:38 ` Bruce Richardson
2020-07-22 17:27 ` Thomas Monjalon
2020-07-24 11:32   ` Power, Ciara
2020-07-24 11:20 ` [dpdk-dev] [PATCH v3] " Ciara Power
2020-07-24 11:45   ` Power, Ciara [this message]
2020-07-30 18:28   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB255593BD10D082C306E188BAE6770@DM6PR11MB2555.namprd11.prod.outlook.com \
    --to=ciara.power@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).