From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 456F5A04E1; Tue, 22 Sep 2020 10:39:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2850A1D6B1; Tue, 22 Sep 2020 10:39:57 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DE3EA1BFF0 for ; Tue, 22 Sep 2020 10:39:55 +0200 (CEST) IronPort-SDR: jsuEybZ8Mz/zN4tWgPKH9hwnglS5t8ZalxZHIn0MVyFnh2ACGnHQrqE7zKy6WMQN3ARIzh4NEq cYg85AqWF2fA== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="224710100" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="224710100" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 01:39:54 -0700 IronPort-SDR: w08gFAkC3/rhf4PCiOa73SKYfX94Uwaj4v5wqJb2V3G+Rz66/zbh6GgUjsvEOlTS2cgMQn4bBe VCoH1a5fljOQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="341945193" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 22 Sep 2020 01:39:54 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Sep 2020 01:39:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 22 Sep 2020 01:39:54 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 22 Sep 2020 01:39:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L79TgDRqGJBum4LLbK6G9jfDtRCz9cnHh+7QK0XDQ7cptu06eRiOjWbMlrLH5Yjhc1EytAtQO5Ty3dUpoz5FSQnMMJGsU+cZXKgqNFtAei81DkbFfNjemxJKYlNGhsCJL38KynExNyTFwPbw02x2wP7IBDXAhM2tg5IjU27Jw/NU5zvGty92CYvMPHGBt830zMiJt++aI+B7ADN+C1R4u/gsvpvxSUmj7HypHPWBtCgXCvOtTy1jzFL8UnaD/feS6JRM5JpbkuBCmQgrxNcCYcpsz3MRYh4EZLxXJGflncSjuT6TUk6YUDLVMv3VYqnBC6H/Ry2j8Osrsc4+sxmHyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zU3JWYJG1DLAcTyVcd3GvJN19QdL/mfDKVtwxZuEHTw=; b=Ch6XO2P+mj7UB06Hl+9hF2P9wYiTW7NZT/Jg+MSCJvwivKrGJ/rBQiLUMuehuKWHLEcX4RDMKwgSxBAFQXmKZvlwABvbzoMLHLpPRQKe8IjP6u3eReJD+H0D/tLF4IoLPL5Cuzl//2wx9beNUA1OBWkVWcbzaonxIuiweIz5GGdBzNf1JoUg0Egt5L1Yzpm5OBVm3kv3W3+rsP712Wj5JNpGmbO2cxn2K35gOL/aeTavulPM6gWuIRJUncV9DYWhssXUpqs6MS276lvR6kkrxFd8cquA8a7cnL8aiAT9xPsEGE35HOpe0v516fsg2TcNQEgJsdDfOq8HMhtn5qwZUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zU3JWYJG1DLAcTyVcd3GvJN19QdL/mfDKVtwxZuEHTw=; b=O+euU/10vA4BzMV0yQBp9DTK7IuAaoFs7X+pCGu6V0Vu0l/CTQEXLjifxAO6O04yHXO8P3vR9BR//E6nhp9q2Wb64EP6vtAbsiB8EA6e0Y9fCJRSX5RcrBfC+gs+Mro/M1nnT4yzBXmbw/LicAG0SIPcOjb7FWnneMpljfd290s= Received: from DM6PR11MB2555.namprd11.prod.outlook.com (2603:10b6:5:c5::33) by DM5PR11MB1513.namprd11.prod.outlook.com (2603:10b6:4:9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15; Tue, 22 Sep 2020 08:39:49 +0000 Received: from DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::59db:260c:93d9:2439]) by DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::59db:260c:93d9:2439%5]) with mapi id 15.20.3391.026; Tue, 22 Sep 2020 08:39:49 +0000 From: "Power, Ciara" To: "Dumitrescu, Cristian" , Thomas Monjalon CC: "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides Thread-Index: AQHWkDJ6uejDH11LFE2CwvVdpJ6cJKlzdmeAgADfhmA= Date: Tue, 22 Sep 2020 08:39:49 +0000 Message-ID: References: <20200903152717.42095-23-ciara.power@intel.com> <2501902.3BE8iA8HS7@thomas> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [37.228.239.233] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8aa634ee-9cac-41de-38c7-08d85ed3119c x-ms-traffictypediagnostic: DM5PR11MB1513: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ni1V/ljQtKE3MsO8+qJKH/5lcgoFizTfOyZYxCiuvXdf0cgmmSUjY8rDLFf8AcaZS6ZlRehWpixstEbpfhGycJhw0axYjYBp8WUnD0OuR7wUjOtCIk6bzYwM0njldUHMYtVCddKiycXPFjiOgebM8iczeC5W4FCspRojEqPHvCriuDPh1Anlyg2RTOVYmJzKurSS22wIsojLdBY7ldsu55L+eN7LLyTs6MtNFkf+Vg40RCiaXm99/DoDE34RLuLV+t/BMiN7v5Y4oZ+2Qi9ccDKlZnKdGBFxSODr5yvsId2O56C85tkQf7P1U6r/EI2c3ldNyZW6hFPstV9gmg2sG+w8crME/fOGkP3oTw0K/xOU+OoqHfVnbxTIbAeOOhQtNHHPClyCw0nI97F0TgpcCA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2555.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(83380400001)(2906002)(966005)(4326008)(71200400001)(478600001)(8936002)(9686003)(316002)(55016002)(186003)(110136005)(54906003)(33656002)(66446008)(107886003)(64756008)(66556008)(66476007)(66946007)(76116006)(7696005)(6506007)(8676002)(86362001)(5660300002)(26005)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: p98lpGEfeV11b4/sewKep2XGa2Izxsfntde0V9NnOv8G7g4jTAh+zgu+VReLS5anOu+qTov4wiR8cTgxT8XLeeyGp1fi113YyXLCE0W0dbdY+i1NJWwmr/wdu/FcEGD4h7wEmj0aMIif7TmJAh1PqxlE413fQa8fOWZxlWtx3nUe4DlDEOtAWFo5HBfM9SiCDf0joNH7WP/wfKblY0yPh75D+eXZqNh9sIv5SUCuc6WahisyIAasCbB6lhoJAn8JzKtpNGDc11AlvG/gQzcEyVTeCbS163mVdT2eBmDhHmM1jwBGCM5K16Cqwy1LLl0j1NzFkpodJ8lY0daySbn9oANfYr27jUQtWn52Hmwn1n5UZ0o7wgsr78imWOv/rVB3a2G+QvbQvFc3H1hIVcKszIB+Fv9ru1Y3ZazfGSR698DfxlusA+3e5xD7FXDVCj1CQMy3ajAgzwNsBnUJPaYYbEjlurSrL10SRa22/M4JHgCvMsuhnkuzee6m6vbpRE0rInYmd0TQ9NvQ1SJocJQ1RaNCTjB8LRbRrKeX6xRTYFpQC21pazGMS31KoycBhqtP6rqFWhuTx/suGRvKf4qlnzoiQ36z4+c946Fnejp6zyQmvu28XBN54Fibv/y/5rGefqF+2osSwA6rYleqlBJn8w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2555.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8aa634ee-9cac-41de-38c7-08d85ed3119c X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2020 08:39:49.7027 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RG0fcYlPYooymHk6cnRcwY1aKpdA3+SY3hevIhxLfSnpWZMVylRmrC57BJPVn3FSrTYbVTGeuLSC9R/bLwiZVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1513 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Cristian, Thomas, >-----Original Message----- >From: Dumitrescu, Cristian >Sent: Monday 21 September 2020 20:14 >To: Thomas Monjalon ; Power, Ciara > >Cc: dev@dpdk.org; Mcnamara, John ; Kovacevic, >Marko ; Richardson, Bruce > >Subject: RE: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in >contributing guides > >> > >[...] >> > >> -Library Statistics >> > >> ------------------- >> > >> - >> > >> -Description >> > >> -~~~~~~~~~~~ >> > >> - >> > >> -This document describes the guidelines for DPDK library-level >> > >> statistics counter -support. This includes guidelines for turning >> > >> library statistics on and off and -requirements for preventing >> > >> ABI changes when implementing statistics. >> > > >> > >I think the ABI part is still relevant. >> > >> > Looking for some clarification on this. Which parts (if any) of the >> > library >> statistics section should be >> > added back in for the ABI section below to make sense being >> > included? Or >> what do you suggest doing here? >> >> I think we can consider we still have the ability to turn stats off >> because of the #ifdef still being there. >> Cristian, do you think we should remove this doc? >> Is on/off still possible in the new pipeline libs? >> > >Hi Ciara and Thomas, > >IMO this section is still relevant and it is unrelated to the topic of thi= s patch >set, why do we want to remove it? > >>From the make removal point of view, we only need the following change, >and everything else is still logically valid: >- # DPDK file config/common_linux, config/common_freebsd, etc. >- CONFIG_RTE__STATS_COLLECT=3Dy/n >+ /* Library API header file. */ >+ #define RTE__STATS_COLLECT > >On the larger stats topic, I think the section is still relevant, especial= ly from >the point of view of avoiding ABI breakage due to stats, which is applicab= le to >several libraries, so I suggest to keep it. > >In the new pipeline libs (rte_swx_pipeline.h API), all the stats are enabl= ed by >default. > >Regards, >Cristian > I agree the Library Statistics is still relevant, having looked at it again= since sending v1. I sent a v5 of this patchset yesterday just before your feedback here, and = kept the full section but modified the instructions on how to enable/disable, removing th= e mention of CONFIG options. Please have a look at those changes here: https://patchw= ork.dpdk.org/patch/78208/ Thanks, Ciara =20