Re: [dpdk-dev] [PATCH] lib/cfgfile: update map file

Re: [dpdk-dev] [PATCH] lib/cfgfile: update map file

[David Marchand]

Comment on the patch title, we never prefix titles with lib/.
This is implicit and just makes the title longer.

Please look at the dpdk git history.
I would go with the 'cfgfile: ' prefix.


On Tue, Dec 17, 2019 at 9:28 AM <lironh@marvell.com> wrote:
>
> From: Liron Himi <lironh@marvell.com>
>
> rte_cfgfile_section_num_entries_by_index was missing from the map
> file.
> meson build failed when calling this function

The problem is not linked to meson, but linking a binary to cfgfile
built as a shared library.


We are missing a Fixes: line and a Cc: stable@dpdk.org (the backport
won't apply cleanly though).

>
> Signed-off-by: Liron Himi <lironh@marvell.com>
> ---
>  lib/librte_cfgfile/rte_cfgfile_version.map | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_cfgfile/rte_cfgfile_version.map b/lib/librte_cfgfile/rte_cfgfile_version.map
> index 906eee96b..b0389e7d8 100644
> --- a/lib/librte_cfgfile/rte_cfgfile_version.map
> +++ b/lib/librte_cfgfile/rte_cfgfile_version.map
> @@ -14,6 +14,7 @@ DPDK_20.0 {
>         rte_cfgfile_save;
>         rte_cfgfile_section_entries;
>         rte_cfgfile_section_entries_by_index;
> +       rte_cfgfile_section_num_entries_by_index;

Those entries must be sorted in alphabetical order.

>         rte_cfgfile_section_num_entries;
>         rte_cfgfile_sections;
>         rte_cfgfile_set_entry;
> --
> 2.23.0
>


-- 
David Marchand

[dpdk-dev] [PATCH] lib/cfgfile: update map file

[lironh]

From: Liron Himi <lironh@marvell.com>

rte_cfgfile_section_num_entries_by_index was missing from the map
file.
meson build failed when calling this function

Signed-off-by: Liron Himi <lironh@marvell.com>
---
 lib/librte_cfgfile/rte_cfgfile_version.map | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_cfgfile/rte_cfgfile_version.map b/lib/librte_cfgfile/rte_cfgfile_version.map
index 906eee96b..b0389e7d8 100644
--- a/lib/librte_cfgfile/rte_cfgfile_version.map
+++ b/lib/librte_cfgfile/rte_cfgfile_version.map
@@ -14,6 +14,7 @@ DPDK_20.0 {
 	rte_cfgfile_save;
 	rte_cfgfile_section_entries;
 	rte_cfgfile_section_entries_by_index;
+	rte_cfgfile_section_num_entries_by_index;
 	rte_cfgfile_section_num_entries;
 	rte_cfgfile_sections;
 	rte_cfgfile_set_entry;
-- 
2.23.0

Re: [dpdk-dev] [PATCH v2] cfgfile: update map file

[Dumitrescu, Cristian]

> -----Original Message-----
> From: lironh@marvell.com <lironh@marvell.com>
> Sent: Tuesday, December 17, 2019 11:52 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; stable@dpdk.org;
> Liron Himi <lironh@marvell.com>
> Subject: [PATCH v2] cfgfile: update map file
> 
> From: Liron Himi <lironh@marvell.com>
> 
> rte_cfgfile_section_num_entries_by_index was missing from the map
> file.
> meson build failed when calling this function, due to linking a binary to cfgfile
> built
> as a shared library
> 
> Fixes: 85ff364f3b ("build: align symbols with global ABI version")
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> ---

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

[dpdk-dev] [PATCH v2] cfgfile: update map file

[lironh]

From: Liron Himi <lironh@marvell.com>

rte_cfgfile_section_num_entries_by_index was missing from the map
file.
meson build failed when calling this function, due to linking a binary to cfgfile built
as a shared library

Fixes: 85ff364f3b ("build: align symbols with global ABI version")

Signed-off-by: Liron Himi <lironh@marvell.com>
---

v2:
  - update commit msg.
  - add 'Fixes'
  - follow alphabetical order

 lib/librte_cfgfile/rte_cfgfile_version.map | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_cfgfile/rte_cfgfile_version.map b/lib/librte_cfgfile/rte_cfgfile_version.map
index 906eee96b..22c999fe1 100644
--- a/lib/librte_cfgfile/rte_cfgfile_version.map
+++ b/lib/librte_cfgfile/rte_cfgfile_version.map
@@ -15,6 +15,7 @@ DPDK_20.0 {
 	rte_cfgfile_section_entries;
 	rte_cfgfile_section_entries_by_index;
 	rte_cfgfile_section_num_entries;
+	rte_cfgfile_section_num_entries_by_index;
 	rte_cfgfile_sections;
 	rte_cfgfile_set_entry;
 
-- 
2.23.0

Re: [dpdk-dev] [PATCH v2] cfgfile: update map file

[Thomas Monjalon]

17/12/2019 12:12, Dumitrescu, Cristian:
> 
> > -----Original Message-----
> > From: lironh@marvell.com <lironh@marvell.com>
> > Sent: Tuesday, December 17, 2019 11:52 AM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; stable@dpdk.org;
> > Liron Himi <lironh@marvell.com>
> > Subject: [PATCH v2] cfgfile: update map file
> > 
> > From: Liron Himi <lironh@marvell.com>
> > 
> > rte_cfgfile_section_num_entries_by_index was missing from the map
> > file.
> > meson build failed when calling this function, due to linking a binary to cfgfile
> > built
> > as a shared library
> > 
> > Fixes: 85ff364f3b ("build: align symbols with global ABI version")
> > 
> > Signed-off-by: Liron Himi <lironh@marvell.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>


Fixing the "Fixes" line with the real root cause:

Fixes: 3d2e0448ebb5 ("cfgfile: add section number of entries by index")
Cc: stable@dpdk.org


Applied, thanks