From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B829A00E6 for ; Mon, 2 Sep 2019 08:40:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C5FC1C197; Mon, 2 Sep 2019 08:40:26 +0200 (CEST) Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) by dpdk.org (Postfix) with ESMTP id 693731BFDB for ; Mon, 2 Sep 2019 08:40:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2026; q=dns/txt; s=iport; t=1567406424; x=1568616024; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Z+PDjEzWtCyWyJaFk4Wx04ZKk2A9u5C2Selc+YjkPKQ=; b=at/j9ASmxX2OUEDZDuCTGjRjeFGcryvLgwWHElSKoI/+aoWLYPG3sxK1 Lc+Dw6b+f9pBcdxThRh2uUU0++a4ciRWZlEDrzCn+fSzTXsKacWMnf9By GO0baXcv6nXwxX3tL/Ph/cbLwIiehtYSGPr42IkBAcPrdwdeKcNdjeSpG A=; IronPort-PHdr: =?us-ascii?q?9a23=3A68CuEx+lIPN8ff9uRHGN82YQeigqvan1NQcJ65?= =?us-ascii?q?0hzqhDabmn44+8ZB7E/fs4iljPUM2b8P9Ch+fM+4HYEW0bqdfk0jgZdYBUER?= =?us-ascii?q?oMiMEYhQslVc6UDkv4LfvCZC0hF8MEX1hgrDm2?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AwAABMuGxd/4kNJK1lGwEBAQEDAQE?= =?us-ascii?q?BBwMBAQGBVAUBAQELAYFEUAOBQyAECyqHaAOKdE2CD5dsgS6BJANUCQEBAQw?= =?us-ascii?q?BAS0CAQGEPwKCYSM1CA4CAwgBAQQBAQECAQYEbYUuDIVKAQEBBBIVEwYBATg?= =?us-ascii?q?LBAIBCBEEAQEfEDIdCAIEARIIGoRrAx0BAqBcAoE4iGGBcjOCfAEBBYUUGII?= =?us-ascii?q?WCYE0AYt3GIFAP4FXgkw+hEaDO4ImjFCIHpcvCoIflHaCM5YzjXaBN5cSAgQ?= =?us-ascii?q?CBAUCDgEBBYFSATUqgS5wFYMngkIMF4NPilNzgSmOUQEB?= X-IronPort-AV: E=Sophos;i="5.64,457,1559520000"; d="scan'208";a="622784919" Received: from alln-core-4.cisco.com ([173.36.13.137]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 02 Sep 2019 06:40:22 +0000 Received: from XCH-ALN-012.cisco.com (xch-aln-012.cisco.com [173.36.7.22]) by alln-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id x826eMFP013769 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 2 Sep 2019 06:40:22 GMT Received: from xhs-aln-002.cisco.com (173.37.135.119) by XCH-ALN-012.cisco.com (173.36.7.22) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 2 Sep 2019 01:40:22 -0500 Received: from xhs-aln-001.cisco.com (173.37.135.118) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 2 Sep 2019 01:40:20 -0500 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 2 Sep 2019 01:40:20 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F1mqtiU6v4ORprt90R9udT9BMfFaQO708c13U2bYKz/FpCrYZjAVsSuKajIHxumH44mqgVyHjaBJRYfJ7H49WNWZhgE3DWOUf2piCPza8oyTMDCNVKpkEBq6Vkr6SD3fML991q79Q5h+2boKNmn/uLM5AfILXz3YsDQx5h3JwD8te7pWwzsyHG7ibDGz4zLIolpdfluobjuCETrQSTcnrNpVdDjP/8PDLKDpE5RjfwmtlK6YVDDGclc5cGgnI3HU16sijvtMsDAuYsCNplZ71sby4PHmIqVnfemzdyznhiM5VBkL9hwC2zDnuCRpj0GF+dEOeUPlH1KtxWZKg5naqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IYJqPv1DLVNOHifKzUoQhIeySk2Zlpr8ayC2i3banwA=; b=CT+gb/sSZ9y9l1NqcUKCZbr+zRmxb9tLhbISSSKnqdDjABT9uv6W9EerTEKmNPDqUOwQ3TmQEmu7oenYlAmDLaNdrPUfLEFDDPqWZGT29pZaxQHO83vcyHzdUsjI7pfDI/fTZmTZQgo76/UP5kyaT79bPsFBxQmNWLi3K2oqUXvHWwpeW2MjEF9z2/b0Dzgbxx/pJMEucwnZmN3UOFY6eaWCQWDaAhdO4LjEf4hU345aRR9xzNZDQ3ur01J9Yyy0JI7lcYqK8qi3kU2GYSS56xYVkUFtaT7p4px5N4SjiLNKwqv+HFJk2o4RtNj2nPrve3lgXyNK/qC2iDrutLt4PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IYJqPv1DLVNOHifKzUoQhIeySk2Zlpr8ayC2i3banwA=; b=xowheGIJ0DXrqt+RTDe1wdxQiLImA4SdimRi9flbIwqLx3rpDuKKoE2JknkD/0911VkTcGz+3GRFrC7nLm2Mz4pkZHcNeUtptwXTCkahsQwH+pIa68amg/hf9xk40vb2nZbS5hSml05m620DW7vZdq0JZU3Mdp5fml82moTIbqQ= Received: from DM6PR11MB2745.namprd11.prod.outlook.com (20.176.99.159) by DM6PR11MB3930.namprd11.prod.outlook.com (10.255.61.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Mon, 2 Sep 2019 06:40:18 +0000 Received: from DM6PR11MB2745.namprd11.prod.outlook.com ([fe80::d81c:f0d2:dae:7dd5]) by DM6PR11MB2745.namprd11.prod.outlook.com ([fe80::d81c:f0d2:dae:7dd5%5]) with mapi id 15.20.2178.023; Mon, 2 Sep 2019 06:40:18 +0000 From: "Hyong Youb Kim (hyonkim)" To: dirk , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd process Thread-Index: AQHVXLZKmLdoaFqM/US9KPqZd4ACw6cX8uhA Date: Mon, 2 Sep 2019 06:40:18 +0000 Message-ID: References: <20190827090248.6185-1-dirk.lenz@ng4t.com> <20190827090248.6185-2-dirk.lenz@ng4t.com> In-Reply-To: <20190827090248.6185-2-dirk.lenz@ng4t.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hyonkim@cisco.com; x-originating-ip: [2001:420:c0dc:1001::66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 388ad609-1d64-4413-e51a-08d72f706bdf x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:DM6PR11MB3930; x-ms-traffictypediagnostic: DM6PR11MB3930: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01480965DA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(346002)(39860400002)(396003)(136003)(51914003)(13464003)(199004)(189003)(99286004)(486006)(476003)(46003)(446003)(229853002)(71200400001)(71190400001)(478600001)(102836004)(55016002)(11346002)(86362001)(33656002)(53546011)(6506007)(14454004)(76176011)(7696005)(66946007)(76116006)(66556008)(66476007)(66446008)(52536014)(64756008)(2906002)(305945005)(9686003)(6436002)(81166006)(81156014)(5660300002)(186003)(7736002)(25786009)(316002)(2501003)(53936002)(6116002)(256004)(6246003)(14444005)(74316002)(8936002)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3930; H:DM6PR11MB2745.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WSsNiXxJK8+c0EELUGDH4Je0LBb188bg59eQmWFY3DNMIKWDobsj7qgCHew3ihButvObHeIrmh9oIp3jkyIFDdNitwSnBCMTeAEyti72yz/CIqgC4jxkykcMoFrT0aWGNFtRkOjp4X+ApwxPcKh6Y1dqfrOCNarNF4lt4OZn9t76QlQL30ZA5ephVPYSxYlYto+HrDcMQYIevNdPw61dj3mmZuRdwnexXlGL86ro6vdu47IyWBAvYdo9z8BpsolEdh958kk8SdknFRCm0mgPBuiWNuMbgcKhsed1Xqv9KT6mbSuhPqDuWLOroRDBVeh7VtbsPycTq9/n9gxCbFaQ6wVObnBmM9awV2vRHJ4867YljjIr51ZVhO2kzalBgYGtyXNdBDB4fVBNKFNkadpCwmy79Z/9AoldE3XRS/sgcX0= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 388ad609-1d64-4413-e51a-08d72f706bdf X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2019 06:40:18.7773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g5urbB0w4uqfrVZfjtQrkYeFB8UbxpYFpQ66PPAEXfG5KWBV225KEgOfPDjxavbJweywZE+OwFWJkKAxMJD7hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3930 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.36.7.22, xch-aln-012.cisco.com X-Outbound-Node: alln-core-4.cisco.com Subject: Re: [dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of dirk > Sent: Tuesday, August 27, 2019 6:03 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2= nd > process >=20 > net/enic: enic driver doesn't work with 2nd process. the problem is that = the > private data structure enic uses pointers to rte_eth_dev and rte_pci_devi= ce > which are overwritten when a 2nd process starts using this device. > given patch removes these two pointers from the private data and uses the > correct pointers. For us the given patch works fine on a cisco rack. > (we used three processes working concurrently) >=20 > Signed-off-by: dirk > --- > drivers/net/enic/enic.h | 36 ++++--- > drivers/net/enic/enic_clsf.c | 5 +- > drivers/net/enic/enic_ethdev.c | 79 ++++++--------- > drivers/net/enic/enic_main.c | 177 +++++++++++++++++++---------= ----- > - > drivers/net/enic/enic_res.c | 7 +- > drivers/net/enic/enic_res.h | 6 +- > drivers/net/enic/enic_rxtx_vec_avx2.c | 5 +- > 7 files changed, 156 insertions(+), 159 deletions(-) >=20 Hi, Thanks for the patch and reporting the bug! Yes, enic->rte_dev and enic->pdev are supposed to be set and used only by the primary. I can reproduce the crash by running two different executables as primary and secondary. Using different executables so that primary and secondary processes load rte_eth_devices at different addresses. I see other related issues including... - eth_enicpmd_dev_init overwriting primary's fields in struct enic, other than rte_dev and pdev. - Secondary not setting optimal rx/tx handlers. - RSS update handlers (e.g. rss_hash_update) not checking for primary I will send a patch series with Reported-by: Dirk Lenz. And you can try it out and add Tested-by on that series. Are you okay with this plan? Did I get your name right? Thanks a lot. -Hyong