From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B697A0A02; Wed, 24 Mar 2021 11:23:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0369E4067B; Wed, 24 Mar 2021 11:23:35 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 5D9824014F for ; Wed, 24 Mar 2021 11:23:32 +0100 (CET) IronPort-SDR: waC45QfIYGxNtABC47gTPyCpYe84vLRJOX462ko1wT0W9Kc/V83qwU01iCcRQ9QtZjKAEk0Kf8 5mtdByulTI6A== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="190086474" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="190086474" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 03:23:32 -0700 IronPort-SDR: KXGllfezBe3yKyDOAR6iG4ShJlhmJ22ieXbcWwHvjUvpBkOLyR7ULMW+XFtlVoQZv3GAooaGeh JgpAjtbYvosg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="442152797" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 24 Mar 2021 03:23:32 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Mar 2021 03:23:31 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Mar 2021 03:23:31 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 24 Mar 2021 03:23:31 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.54) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 24 Mar 2021 03:23:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UI6ozWfNnG1CRU98bevBLGsAj3yR/pG4kL+P8CaJfhJJSF9QLlc5SMssd+DEencdVYaiSbeZCSl5wqZLeOhL0jLuqgBW6zoExWQTh+SumW4C3uYVv2qfvr3GGwEK3sya7G/ygLKlmkKgyMLoSooW6pf5Zc7PUZplf8AazratK6zPO3FTTsNhEHDpef0l+t7VeA5Zb7fqkPk9onWxgAcuthHvfmOe5ZkI+tUU6VLkKm8CsDhgD8ZaKzbqSSFM6wu9aknk3NcxRFyzyl0cCOCffBhywt/bami2ZsDLcp+1Ux53WpzlKNPpgILAWGSojc1zLsJZTps/ut4JDYGsn2PL1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yGB3jo3ZQ2852LKpHvGb+9rsIBbt1b8aLIMiCXScP54=; b=LcFrkwq/gnlyZmm7m+ybtAOji/lz3YE1bEEOra4bR1t1ShnGGbR6pJTxl8gEGrfM2cY2qXvq0nTkAEm+bQLAf1OIYsskwGz26xG+nkwi8+u0LGGEXwJNXIMeWizl4zNRIdR/W40SHzow1o8wFjxH71JxCcg0dYalCAxAWYKhpfbb69Wj+QeIuklxTmseibTcpeqpN2q7bj3WSupsKMWopwOYUBEgQKsrA6O5JqXRkajLLGH8DJozo4VkhRR+rulNVAaJ1V6ow5gYEJlQqnY3K5QZvofGRN2cip8mD4UYqj34bEy7E7eiQbvaPyatGk1BdyEgHyhUtcQEzcok+Ek04g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yGB3jo3ZQ2852LKpHvGb+9rsIBbt1b8aLIMiCXScP54=; b=ZDqWroNL2eFbBsFwW+Yn04+x2ENFBTIAoWwjCoLD7UBh+fANXo0RgABlYhEesJ+dnm7NS3spS4kiAY0h5yXprtJGk1f09pXBAbo2fy1VpK+i121QrKEQBraKXwv8Go5pxlytnYLX4c1Ad8geFQ6OPFGJzj/zQVrwVrBI6FckA38= Received: from DM6PR11MB2796.namprd11.prod.outlook.com (2603:10b6:5:c8::23) by DM4PR11MB5312.namprd11.prod.outlook.com (2603:10b6:5:393::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Wed, 24 Mar 2021 10:23:28 +0000 Received: from DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::b5d2:6f20:3c0:3627]) by DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::b5d2:6f20:3c0:3627%7]) with mapi id 15.20.3955.027; Wed, 24 Mar 2021 10:23:28 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "P, Venkata Suresh Kumar" CC: "dev@dpdk.org" , "Khangar, Churchill" , "Jangra, Yogesh" Thread-Topic: [dpdk-dev] [PATCH] port: add file descriptor SWX port Thread-Index: AQHXHLdHCjSRFf2gLEy6r5vkzL6GqqqRx+mAgAAdhoCAAAiqAIAAA7aggAARzYCAAPIy4A== Date: Wed, 24 Mar 2021 10:23:27 +0000 Message-ID: References: <1616155326-2639-1-git-send-email-venkata.suresh.kumar.p@intel.com> <7787288.vlQI503CXK@thomas> <5428359.QSTuVHgDrv@thomas> In-Reply-To: <5428359.QSTuVHgDrv@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.64.137] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d075affb-6275-4412-bbb3-08d8eeaedd95 x-ms-traffictypediagnostic: DM4PR11MB5312: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 30gxV/7QLeG6WcsXEN/JnonMDk40+FlArQqoMkMMpIGi78zDbKosE2ToMn1MumYW6Nj8gOgWQRmvOJhbWxX0z9TOBF9SLXrpgYOc24GbwCwCeGqSX5tpEeIukg/PRnUOx/zSla+nadDDZPnX4f3bM+AkZAuZeMf/4NAlW06T9nFaz2FdzjoneYh7GcVbm7Rf2NQqlQT9kv8AC8UUskYNZfdgCMiAmLg4MEonAe5iG4Ecm9mwqx5EMJXgW6pKpWzMleFVj5z6pF6hJBrmHlBHqarYgX3sgqRYt7Wku5Je6UB2dnFbsrEXaa3kuW2lFK6WTOHatGjwVc67LJx81Ko2JyeXRT6dsbYfCQ+FJM5ViROb8ErwyrjDgtWKQMRV9aha58M9hmxE/K5w9P4vNkgMlgwlRNQlY0MdSVJndks0aeqgXUH0S4CAwFTmk32qdIGv2eyo9VK5bSFfvkM8pPGrECutywlCgr4OqAKtrgLEuFSQtItj+KC4KlRVL+sWjQH4lvoFZ/CUlndvvhaKwhPJ87uSjCW4kpglqlaw9AX3/YeDR39zaOc8rA3iLu2gTqMBz9kZEW3MbgHgTLgSEqrQWIYlBFcu+zp0mxVcanf/Hmv1/m85bGIcAG9A5Ujy2fGmfc6UZ0umLVUDjDluJ9LLefL7wZy9u7DJGo4MwT0B+Hw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2796.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(366004)(136003)(396003)(39860400002)(9686003)(55016002)(52536014)(4326008)(6636002)(107886003)(2906002)(54906003)(53546011)(86362001)(6506007)(38100700001)(71200400001)(478600001)(316002)(8936002)(186003)(7696005)(66946007)(33656002)(8676002)(26005)(110136005)(66556008)(66446008)(76116006)(83380400001)(5660300002)(66476007)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: KS5iLoK0vvlOMzbxiBKBs1T6mE54SnFC3HNwvmMB1dvLRd/wl7tClYqdSrb1Ahl55cqyk9geN+nKpoqMzrY6+c48c2P4o7slgOdgeWP4yhVs+nFNu0KOPI6KonZ00nVm3lHW4N3lMLa+LDDybDxVqsNYJxaE5phN8Xcme5+lNm+D/roKXn18B8ij1BR0QX8LygSSDAbBMYY3tOvVJ7fUo0bfRXi8MS9H3+AJW8/XlKyq2KGClrNc7d2LaewTo6tsZw0GTORxMn9HQ8GSB9AyGWL1SmG3yuwJr9JrUhpSMd9OB2p0vtfqr7huPYmtJguXmW3K1fkH6NDLsJ7NG4teV5f2CjU2aDOetncxf07XAbn+PGq1inWXbJOl1Wp6BvjcHlXwRg299AYLk8Y3c1XlREGCHpbHZQrSZ4Q9u7CqtsZV9WX28qSRb24KxtM13W6TsDJyc/cYRTm3fTxVCAa60UBWOq1IkWyLvIgv5K8VGhnhy2g+hj8qU8RDSo9wMT/M/zIVzGJz9pEw5XqyPGnedh64f//MDExzOxrqjBFf9DFYO9EgPGj6Fqvf4MOKxuATQaDAZL/rlXoZENdUKuktGJgaXHYODzvJwPVcWU3tGwRQgekCFbodfZN+bAN/CmpMp1vDW1dh+sh4ZA1Pd+ZnyRiXROtSPSXszMRFfn3AmyvgWoIWvr9srstmIGxvTKjH6/9+heLozsGHP0Ihj/VZFRpYeR4tod6IsZYTxFtjvIk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2796.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d075affb-6275-4412-bbb3-08d8eeaedd95 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2021 10:23:28.1473 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VU96lAiw1aI7lJHetVbeJEXu259HGggSR9nATukQNQhnV2eCGBavkGpntqZJabN1DzLBth0YP0BBYICEqTfeQfr3uiIhmNQnWkFcdt2yM10= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5312 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, March 23, 2021 7:56 PM > To: P, Venkata Suresh Kumar ; > Dumitrescu, Cristian > Cc: dev@dpdk.org; Khangar, Churchill ; Jangr= a, > Yogesh > Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port >=20 > 23/03/2021 19:56, Dumitrescu, Cristian: > > From: Thomas Monjalon > > > 23/03/2021 19:07, P, Venkata Suresh Kumar: > > > > Thanks a lot for reviewing the code and providing your comments. > > > > > > > > I have addressed below comments in V2 patch. > > > > > > OK thanks. > > > > > > What about the question about rte_trace? > > > Opinions? > > > > Hi Thomas, > > > > All rte_swx_port ports are currently following this pattern, > > so it makes sense to have this one do the same for now. > > > > I am not that familiar with the (relatively new) rte_trace mechanism, s= o I > am not sure if it has any run-time performance (I am assuming that it > doesn't). We will take the AR to take a look at rte_trace and come back w= ith a > patch to convert traces for all ports to rte_trace, most likely in the 21= .05 time > frame. Is this OK for you? >=20 > Yes, would be great. > In general we should avoid such #ifdef in DPDK code. > Maybe rte_trace can help, maybe rte_log levels would suffice. > Note there is RTE_LOG_DP_LEVEL for logging in datapath. >=20 Yes, we will look at rte_trace for 21.05 and come back with a resolution. T= hanks, Thomas!