From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C02DA0547; Wed, 21 Apr 2021 15:58:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8839341AC8; Wed, 21 Apr 2021 15:58:29 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 7C687410F9 for ; Wed, 21 Apr 2021 15:58:27 +0200 (CEST) IronPort-SDR: ZDlTDA7AOzZLaim75I93w2uL4wgVjeX2jSCoaGodS23ta9XYoRbbwoHYNhG8in9WaaIq9shrqQ AGxW96A5mLAg== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="195813965" X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="195813965" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 06:58:26 -0700 IronPort-SDR: kZzz/1wlOx22XIBsHQ7csI7iRd4dDnbq8bYzoK7DrqeBWB5MEQ0kWzEweQqlu4RlOkyiAWLhkC 4j2OAujQo4Qw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="452944463" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 21 Apr 2021 06:58:25 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 06:58:25 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 21 Apr 2021 06:58:25 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 21 Apr 2021 06:58:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGYbfme9gaMcMbwl5DTLk9S7S/iVMi+wa6z1fH6K0e+pWXurEysSU+fPCr5C8uMx3fBo2eHZ1cUavGiQqLl9a+32+Xz5ltm+eHOnUVABpJwBUp6wkP8PqYy3hMs+oAPQ1JT9yddCwB86DATftGsZvi4LH5NbbzcgpdYFL6SwlN0TAU5kGVKttg3Fiw3SgNo2vlEg+ikPzMfk0xjXm58BJHV4WxnYlw5ib7u/4Zi3BRuqA6BROkkvDa9nSXDdVk9cFa1YLRc+3vPVf0Gw0nY7z22cQSp2nmx0v2GIvVnXU051JsU6gvXhZF9CuYehytRFuALa9U16hclI2Zd4QbYWhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vwr5w4OQ1xyF+6gdOnumgovgzjFMfMWfDkWy6buj/b4=; b=G48muxE4z4jYcILeF5F9AkhrdgjopjlZxIvOwIPt/zuim3LGNTmvqYmicWzaGwVnM8FfaIVs2eqheQZUgtmb9l7X0EzWVFcnV1AoKkSqalPHZby+NWK+YwuzkyVrWuUbT2RtQtbGk4OJB1JuBY/dkRXKHx5pq036B9eM+sIJ32YgdteMcD4uq9/hF3+lpfjGQayFEld5P285A+GcZb++64omeqkBR0DPH8fEyu19GezrFiPRd2xjoTlmIN5Ir4wCXP6MVI0GjXTqzKZ0D8+6NEETJU8c6+uvgsTxvJrLMj5A+lVZqpo1dmHsNvGZLNtOZFmG8bbd0OC1Qao3Q2S2yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vwr5w4OQ1xyF+6gdOnumgovgzjFMfMWfDkWy6buj/b4=; b=A+BkWx9s5/g+rOvO6N1sN6G93gfq6+fjyOiZWGuLOmjrTwIdHKUwJBw0nVT+4HPvusg9x6mSNon9uiIxaTBmwOsZvoR1IRMB5jiJBt8kgl+qfgqn0PDDWlnLdp2hG1CcvCLhS2rCr7gkOFFax2j7pYyFA17lTvRb6G+RFZ3DWks= Received: from DM6PR11MB2796.namprd11.prod.outlook.com (2603:10b6:5:c8::23) by DM4PR11MB5245.namprd11.prod.outlook.com (2603:10b6:5:388::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Wed, 21 Apr 2021 13:58:24 +0000 Received: from DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9]) by DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9%3]) with mapi id 15.20.4042.024; Wed, 21 Apr 2021 13:58:24 +0000 From: "Dumitrescu, Cristian" To: Ali Alnubani , NBU-Contact-Thomas Monjalon , Aaron Conole CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args Thread-Index: AQHXLyneEQreL0SXuESXCf4XuBA+W6q94I+AgADG4ICAAGIVMA== Date: Wed, 21 Apr 2021 13:58:24 +0000 Message-ID: References: <20210411232338.4005-1-cristian.dumitrescu@intel.com> <20210411232338.4005-2-cristian.dumitrescu@intel.com> <2003889.D9zfWNbQnx@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.10.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b140fe48-903a-48ea-7ecf-08d904cd87d3 x-ms-traffictypediagnostic: DM4PR11MB5245: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7JgN/rNG0Aqw0KF1DPX41MxIPZTNHM7OBlwYZrZoGGSUjefa7uPScqG3+twNL69GwLjnFt7UCSk53xCEHchQ5RQ1zxrqwsdAAoT4C3vdms0qsf2MLDcQY2bMMrJItqDE49ZXQyFA0AZX6ZpFMeGM5ZE91GemZ5eL2bE1R7BaOV1PHixskpFGWsNzgeFUF5vCdkNOgDjWZVhOPDHkks3io7i1hIwxp+ok/SW+VE4EZ/1hkaPGw/pgBxgW8XfxiEphfYqXcYg7W9V8ZCOqPuGwHqKPW/cxE6vgb2y5jkgL8TTFhmDPGx2l4rFCsHZGgiFmA7SFAtKkmlr5jaONLDoRBfDEMjJimDvgahw6MBPkf12IqyhzgYAYSjgePcPkkDdL9bNMr3Hk656NQl6659vZcaC115hxmFZaj+ncX4gspAADd4ZzG2fQzjNee5BSJrpF4lZaguc08CGWztft8/gFQi/zzKKH3lnwpTMggte2wMb1Ib9HdqZ8QliWnzkpAUKolD9IDhiEBy47zjORx+befVTXdoIizJGNT5aVDK8JiHje7ul06tYFKf5m46SLIHZockZathDFdT4EcFR5BJUFdjuIQVka72p1sqL7CmHvJCBDvZSCfSJt2g0iYvb3bCvseNfCzehXsmAt7aTpoB/bqfVErh7V3Fjte5NWuAe5jGv9MylrBXfVKLSemwOoSBnG x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2796.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(396003)(39850400004)(136003)(376002)(346002)(5660300002)(8676002)(9686003)(6506007)(122000001)(66946007)(53546011)(110136005)(71200400001)(26005)(8936002)(66476007)(4326008)(478600001)(52536014)(83380400001)(966005)(38100700002)(186003)(316002)(66446008)(66556008)(33656002)(64756008)(55016002)(76116006)(86362001)(7696005)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?F/8RAd/uuVBq3PWy4QoOIW8hpi0pioRgtidAAoTh3jBLI2N9Mkb+9jdPTZJR?= =?us-ascii?Q?2VkQoBzinSoCa/Dln9V0uN3cE/RcsKRQY8qLTapjbwQffmbxRPovsytvL26U?= =?us-ascii?Q?rrN0fOMWiVt4TvFtFmXs5dX2+qOFzMlh2hBuo5YWZsA9gXpayo1fWEbPJp3B?= =?us-ascii?Q?jRgUiaO6vpz49ue5RuacNDGSl9UJ9NhNimbiTZ1CigFqdam+vdHp24YlVRjW?= =?us-ascii?Q?fqZLjrTsLxjugoIGuZSmWiqg4+DMos7INRy6QfRvUsvNkp5ylX5lm8NoyPWp?= =?us-ascii?Q?HCTD2AIDZgqcVEyy6efiHwKhYJoV0T0+dpKWHrJeEKDXQTAaTW2SiYrCfcG2?= =?us-ascii?Q?Rae8+DyNs8TyObPDnAVFl20V7TTrbOSuuvAKDUmv2z9AnjoMYNOmvnUoBHFV?= =?us-ascii?Q?EYp2rNgnUHDjTWhWZNOF53npU2OaRqMVVmvUCUmuy+6irfZRc4LcknS37n8W?= =?us-ascii?Q?JoKz83lWy8Q7uAn7gwRrUGB5tKawsG75QXF4JSnh5w8r0bhrUcdTCN9ag/n7?= =?us-ascii?Q?sO/CWpp0kag26k7oIh13+NxldvLKGfMciIt6eEZyc60bYB9CoTB2xRV5uZqS?= =?us-ascii?Q?3bMh/dxHMm125rvsxfBzLOx3WikPg847NnZSXbD10cHvSOjOuU9wpMWotKFH?= =?us-ascii?Q?+vYb8cYQJq5W5QdOaxK6qVngZ+8qfotqRRzJx8hg7f+xLa6yf6XDJygAzg1C?= =?us-ascii?Q?LKKJJlj3AjzDiMA8O/FnHmnjN6ve0qm6VMnnKWMZkJ+EBOJyrrFPjqEIp8L4?= =?us-ascii?Q?KocmCcZpI90ETllpfs7NBaT/kK6JdBZUy1k4dMZR3PHxog5Mcc8h45VZcoHI?= =?us-ascii?Q?oCGwcTWDNkNTv6gmXeGxEMv3GB3RACMCjnmCpwkGOMRn1r7y3sIeGocMIINl?= =?us-ascii?Q?OHiqsMSu8ldUjoAQnGEa80fiNISATSMjvYlWibU+fVh1N7K+0DeMKntsntX7?= =?us-ascii?Q?lquqfcQqcAIJOqJfYMWw1IYLmqxkyJZRAcDafD80GIiCv0MNlScplOTqXPlc?= =?us-ascii?Q?GtbrHszrc3XxHVCHBGEt6MvsYcvUMqRiiEQz266ry4dOWCf8DBEzfskhX/Hi?= =?us-ascii?Q?1Pr/74eE0Lvi0PvuAVYWXegblBqnSCnVo/1YTJ+0FZ84xCUsEpIEffaqudce?= =?us-ascii?Q?vTVb+rST6CShiX8AGntpyBpeuAd7tPNXmcZD+X9lH6VwJOvsa+taI5uexYWi?= =?us-ascii?Q?UIsMi79ixCU4T5BPgESE6+bebdIhwRrLvubk6FtJJgf761GdqBsEbUROyOiB?= =?us-ascii?Q?XQ/qHb+wurOv7zL8mi887XmMZ737jcWM4TGlIQcyPyFFzs8C7aFNa5ywCGly?= =?us-ascii?Q?2XQ=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2796.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b140fe48-903a-48ea-7ecf-08d904cd87d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 13:58:24.1748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1RgqaRnIyVe5hnHOkK8ftxxF3H/fGVvqjmFU1CyiqgqpbyG6l58upuS9AIOrK1AxD6SiPpKz0Wukhc2BIXHrDT/ACxp9roEUOcyu6L8wIx4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5245 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ali Alnubani > Sent: Wednesday, April 21, 2021 8:50 AM > To: NBU-Contact-Thomas Monjalon ; Dumitrescu, > Cristian ; Aaron Conole > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args >=20 > Hi, >=20 > > -----Original Message----- > > From: dev On Behalf Of Thomas Monjalon > > Sent: Tuesday, April 20, 2021 10:58 PM > > To: Cristian Dumitrescu > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > > action args > > > > 12/04/2021 01:23, Cristian Dumitrescu: > > > Each table entry is made up of match fields and action data, with the > > > latter made up of the action ID and the action arguments. The approac= h > > > of having the user specify explicitly the endianness of the action > > > arguments is difficult to be picked up by P4 compilers, as the P4 > > > compiler is generally unaware about this aspect. > > > > > > This commit introduces the auto-detection of the endianness of the > > > action arguments by examining the endianness of the their destination= : > > > network byte order (NBO) when they get copied to headers and host > byte > > > order (HBO) when they get copied to packet meta-data or mailboxes. > > > > > > The endianness specification of each action argument as part of the > > > rule specification, e.g. H(...) and N(...) is removed from the rule > > > file and auto-detected based on their destination. The DMA instructio= n > > > scope is made internal, so mov instructions need to be used. The > > > pattern of transferring complete headers from table entry action args > > > to headers is detected, and the associated set of mov instructions > > > plus header validate is internally detected and replaced with the > > > internal-only DMA instruction to preserve performance. > > > > > > Signed-off-by: Cristian Dumitrescu > > > > Series applied, thanks > > > > >=20 > I believe this patchset is causing the build failures in > https://bugs.dpdk.org/show_bug.cgi?id=3D683. >=20 > Regards, > Ali Hi Ali, I checked this issue and here are my findings: 1. The compiler warnings are NOT caused by this patch, all of them are trig= gered by older code. 2. Why were they not triggered before? Either this is the first time CentOS= 7 is run or the compiler has a mind of its own (my vote goes to the former= ). 3. These are all 100% fake issues that are probably triggered by the old GC= C version from CentOS 7. I just sent a patch now (you are copied on it) with some harmless local var= iable initializations in the hope it will stop these warnings on CentOS 7. = As I don't have access to a CentOS 7 machine, can you please confirm whethe= r the warnings are fixed? As the warnings are triggered selectively for just more occurrences of a co= mmon pattern as opposed to all occurrences, I am trying to fix all occurren= ces of this pattern in order to prevent the same warnings showing up again. Regards, Cristian